Re: [Suspend-devel] [PATCH] Cleanup terminal if abort was selected

2007-08-16 Thread Rafael J. Wysocki
On Thursday, 16 August 2007 05:38, Alon Bar-Lev wrote: On 8/15/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Saturday, 11 August 2007 21:08, Alon Bar-Lev wrote: Hello, Current implementation does not cleanup console settings if abort was selected by user. This should fix

Re: [Suspend-devel] [RFC] Modify switching into lzo compression

2007-08-16 Thread Rafael J. Wysocki
On Thursday, 16 August 2007 05:53, Alon Bar-Lev wrote: On 8/15/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: You can malloc as much as you wish at initialization directly into the pointers... I just don't understand what may go wrong if you do this... Nothing, really. I prefer

[Suspend-devel] [PATCH] Replace LZF with LZO

2007-08-16 Thread Rafael J. Wysocki
Hi, The appended patch makes s2disk and resume use LZO instead of LZF for compression. The new code seems to be a bit faster than the old one, but this may be my impression only. If anyone can please test it on i386, I'd be grateful. Greetings, Rafael --- Makefile |2 +- resume.c |

[Suspend-devel] [RFC/RFT][PATCH 1/7] s2disk: main() cleanup

2007-08-16 Thread Rafael J. Wysocki
Don't allocate to much memory if do_encrypt is not set. --- suspend.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) Index: suspend/suspend.c === --- suspend.orig/suspend.c 2007-08-16

[Suspend-devel] [RFC/RFT][PATCH 3/7] s2disk: suspend_system() cleanup

2007-08-16 Thread Rafael J. Wysocki
Reduce the number of indentation levels in suspend_system(). --- suspend.c | 70 ++ 1 file changed, 34 insertions(+), 36 deletions(-) Index: suspend/suspend.c === ---

[Suspend-devel] [RFC/RFT][PATCH 0/7] s2disk: Various code cleanups

2007-08-16 Thread Rafael J. Wysocki
Hi, I have seven patches indented to make the code in suspend.c a bit more readable (less levels of indentation, simpler loops etc.). I haven't tested them yet, so if anyone has the time and motivation, please do so. ;-) Comments welcome. Greetings, Rafael -- Premature optimization is the

[Suspend-devel] [RFC/RFT][PATCH 7/7] s2disk: Rename compress to do_compress

2007-08-16 Thread Rafael J. Wysocki
Rename the variable 'compress' to 'do_compress', in analogy with 'do_encrypt'. --- suspend.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) Index: suspend/suspend.c === --- suspend.orig/suspend.c

[Suspend-devel] [RFC/RFT][PATCH 6/7] s2disk: init_swap_writer() cleanup

2007-08-16 Thread Rafael J. Wysocki
Rearrange the code in init_swap_writer(). --- suspend.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) Index: suspend/suspend.c === --- suspend.orig/suspend.c 2007-08-16 15:39:58.0

[Suspend-devel] [RFC/RFT][PATCH 4/7] s2disk: write_image() cleanup

2007-08-16 Thread Rafael J. Wysocki
Rearrange the code in write_image(). --- suspend.c | 154 -- 1 file changed, 81 insertions(+), 73 deletions(-) Index: suspend/suspend.c === --- suspend.orig/suspend.c

[Suspend-devel] [RFC/RFT][PATCH 5/7] s2disk: save_image() cleanup

2007-08-16 Thread Rafael J. Wysocki
Reduce the number of indentation levels in save_image(). --- suspend.c | 54 -- 1 file changed, 28 insertions(+), 26 deletions(-) Index: suspend/suspend.c === ---

Re: [Suspend-devel] [PATCH] Speedup image writing

2007-08-15 Thread Rafael J. Wysocki
Hi, On Saturday, 11 August 2007 00:32, Couriousous wrote: Hello Here is an easy way to speed up the image writing. It simply tell the kernel to immediatly start writing the data to disk asynchronously and not to do the traditional buffering. Mesurement: System: pentium D820,

Re: [Suspend-devel] vt switch during image write

2007-08-15 Thread Rafael J. Wysocki
On Wednesday, 8 August 2007 21:30, Tim Dijkstra wrote: On Tue, 7 Aug 2007 01:50:12 +0300 Alon Bar-Lev [EMAIL PROTECTED] wrote: The question is: Why cannot I switch from one vt to another during image write? I guess some lock out somewhere at freeze something... I will be glad to be

Re: [Suspend-devel] [PATCH] Speedup image writing

2007-08-15 Thread Rafael J. Wysocki
On Wednesday, 15 August 2007 17:20, Couriousous wrote: Hello Le mercredi 15 août 2007, Rafael J. Wysocki a écrit : Hi, On Saturday, 11 August 2007 00:32, Couriousous wrote: Hello Here is an easy way to speed up the image writing. It simply tell the kernel to immediatly start

Re: [Suspend-devel] [PATCH] print_checksum fixup

2007-08-15 Thread Rafael J. Wysocki
On Monday, 6 August 2007 13:35, Rafael J. Wysocki wrote: On Monday, 6 August 2007 13:00, Alon Bar-Lev wrote: On 8/6/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: Yes, in this context you're right, but this was not clear from the original post. Moreover, the printf() is buggy

Re: [Suspend-devel] [PATCH 2/6] - autoconf/automake glue - scripts

2007-08-15 Thread Rafael J. Wysocki
On Monday, 6 August 2007 11:23, Alon Bar-Lev wrote: On Monday 06 August 2007, Pavel Machek wrote: @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/sh -x What is sh -x? Good catch! I had some issues with this script... -x allows debugging... Here is an update. Patch applied.

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-15 Thread Rafael J. Wysocki
On Monday, 6 August 2007 13:42, Alon Bar-Lev wrote: On Monday 06 August 2007, Alon Bar-Lev wrote: On 8/6/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: Second, what I didn't like is not the whole idea, but the context in which you used the word License. I think you just shouldn't say

Re: [Suspend-devel] [PATCH 4/6] - autoconf/automake glue - encrypt conflict

2007-08-15 Thread Rafael J. Wysocki
On Saturday, 4 August 2007 00:14, Rafael J. Wysocki wrote: On Friday, 3 August 2007 23:14, Alon Bar-Lev wrote: On Friday 03 August 2007, Rafael J. Wysocki wrote: On Friday, 3 August 2007 01:15, Alon Bar-Lev wrote: encrypt variable conflict with glibc::encrypt() Rename

Re: [Suspend-devel] [PATCH 6/6] - autoconf/automake glue - s2ram

2007-08-15 Thread Rafael J. Wysocki
On Sunday, 5 August 2007 19:48, Pavel Machek wrote: Hi! 1. Move main() out of s2ram.c into s2ram-main.c, this will enable s2ram.o to be included in both s2ram and s2both without recompilation. 2. Split whitelist.c into whitelist.h/whitelist.c as including .c is none

Re: [Suspend-devel] [rft] Kill junk from s2ram resume paths

2007-08-15 Thread Rafael J. Wysocki
On Tuesday, 31 July 2007 16:01, Pavel Machek wrote: Hi! # Running in *copy* of this code, somewhere in low 1MB. - movb$0xa1, %al ; outb %al, $0x80 Well, what was this for? Debugging leds on port 80. I still have that card somewhere :-).

Re: [Suspend-devel] [PATCH] Do not manually calculate config elements

2007-08-15 Thread Rafael J. Wysocki
On Saturday, 4 August 2007 14:51, Alon Bar-Lev wrote: This allows you to specify an array of config_par, ending it with NULL name, so that you don't have to calculate the number of entries manually. I have applied the patch. Greetings, Rafael

Re: [Suspend-devel] [PATCH] Speedup image writing

2007-08-15 Thread Rafael J. Wysocki
On Wednesday, 15 August 2007 18:43, Luca wrote: On 8/15/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Wednesday, 15 August 2007 17:20, Couriousous wrote: Hello Le mercredi 15 août 2007, Rafael J. Wysocki a écrit: Hi, On Saturday, 11 August 2007 00:32, Couriousous wrote

Re: [Suspend-devel] [PATCH] Enable splash setting via command-line

2007-08-15 Thread Rafael J. Wysocki
On Saturday, 4 August 2007 23:17, Alon Bar-Lev wrote: Hello, This patch adds --splash argument to s2both, s2disk, resume. It is required especially for resume when you want to disable splash in initramfs as result of kernel parameter, even if it usually turned on on suspend.conf you

Re: [Suspend-devel] [RFC] Modify switching into lzo compression

2007-08-15 Thread Rafael J. Wysocki
On Saturday, 4 August 2007 14:35, Alon Bar-Lev wrote: On Saturday 04 August 2007, Alon Bar-Lev wrote: Hello Rafael, This is *UNTESTED* suggestion for switching into lzo without the memcpy. Please see if I missed something as I the code combination of global variables, local

Re: [Suspend-devel] s2ram on: Sony Vaio sz340p

2007-08-14 Thread Rafael J. Wysocki
On Tuesday, 14 August 2007 17:43, Ilian wrote: This machine can be identified by: sys_vendor = Sony Corporation sys_product = VGN-SZ340P sys_version = R5283566 bios_version = R0096N0 This machiene is not in the whitelist. Suspend to RAM works - kind of. If I force

Re: [Suspend-devel] s2disk/s2ram not working with recent kernels on Acer Extensa 4100 WLMI

2007-08-09 Thread Rafael J. Wysocki
On Thursday, 9 August 2007 00:28, Felix Homann wrote: Hi again, now we're getting closer: With echo test /sys/power/disk it's just the same, but with echo shutdown ... the kernel will panic. The very last lines read like this: EIP: [c01127fd lapic_nmi_suspend+0x1d/0x30 ss:ESP

Re: [Suspend-devel] s2disk/s2ram not working with recent kernels on Acer Extensa 4100 WLMI

2007-08-08 Thread Rafael J. Wysocki
On Wednesday, 8 August 2007 21:17, Felix wrote: Rafael J. Wysocki wrote: Can you please do the following: * compile the kernel with CONFIG_DISABLE_CONSOLE_SUSPEND=y and the appended patch applied * boot the kernel with init=/bin/bash * run mount /sys mount /proc swapon

Re: [Suspend-devel] s2disk/s2ram not working with recent kernels on Acer Extensa 4100 WLMI

2007-08-08 Thread Rafael J. Wysocki
On Wednesday, 8 August 2007 22:27, Felix Homann wrote: Rafael J. Wysocki wrote: On Wednesday, 8 August 2007 21:17, Felix wrote: I don't think this is of any help, though... Yes, it is. At least we know that none of the device drivers that you use is totally broken wrt suspend

Re: [Suspend-devel] suspend to ram does not work with toshiba U305laptop

2007-08-07 Thread Rafael J. Wysocki
On Tuesday, 7 August 2007 16:03, Romano Giannetti wrote: On Fri, 2007-08-03 at 21:40 +0200, Romano Giannetti wrote: [basically, s2ram no working for me and ususpend ubuntu package busted] Well, I found a little error on ususpend 0.5 which stopped me to compile s2ram: in Makefile, you need

Re: [Suspend-devel] s2disk/s2ram not working with rece nt kernels on Acer Extensa 4100 WLMI

2007-08-07 Thread Rafael J. Wysocki
On Tuesday, 7 August 2007 21:59, Felix Homann wrote: On Monday 06 August 2007, Rafael J. Wysocki wrote: On Monday, 6 August 2007 20:22, Felix Homann Hi wrote: Please try 2.6.23-rc2, when it's out, in the minimal configuration (ie. boot with init=/bin/bash). Greetings, Rafael

Re: [Suspend-devel] s2disk/s2ram not working with recent kernels on Acer Extensa 4100 WLMI

2007-08-07 Thread Rafael J. Wysocki
On Tuesday, 7 August 2007 22:24, Felix wrote: Rafael J. Wysocki wrote: Can you please post the output of 'lspci -v'? It's in the attachement. Hmm, boxes with similar hardware configurations usually suspend with no problems. May I see your .config? Greetings, Rafael

Re: [Suspend-devel] s2disk/s2ram not working with recent kernels on Acer Extensa 4100 WLMI

2007-08-07 Thread Rafael J. Wysocki
On Tuesday, 7 August 2007 22:42, Felix wrote: Rafael J. Wysocki wrote: On Tuesday, 7 August 2007 22:24, Felix wrote: Hmm, boxes with similar hardware configurations usually suspend with no problems. May I see your .config? Sure, the config-2.6.18.1-jawaka

Re: [Suspend-devel] [PATCH] print_checksum fixup

2007-08-06 Thread Rafael J. Wysocki
On Monday, 6 August 2007 10:18, Alon Bar-Lev wrote: On 8/6/07, Frank Seidel [EMAIL PROTECTED] wrote: On Monday 06 August 2007 00:46:01 Alon Bar-Lev wrote: On 8/6/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Monday, 6 August 2007 00:05, Alon Bar-Lev wrote: Well... It never

Re: [Suspend-devel] Linux 2.6.23-rc2

2007-08-06 Thread Rafael J. Wysocki
On Monday, 6 August 2007 02:36, Jeff Chua wrote: On 8/6/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: What does 's2ram -i' say about your machine? This machine can be identified by: sys_vendor = LENOVO sys_product = 1702E7A sys_version = ThinkPad X60s bios_version

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-06 Thread Rafael J. Wysocki
On Monday, 6 August 2007 13:10, Alon Bar-Lev wrote: On 8/6/07, Pavel Machek [EMAIL PROTECTED] wrote: If you got radeontool from us, it is GPLed. You can get zlib-licensed version from Frederick. So please update the header of the file into dual license. Now (if you wish) we can add the

Re: [Suspend-devel] s2disk/s2ram not working with rece nt kernels on Acer Extensa 4100 WLMI

2007-08-06 Thread Rafael J. Wysocki
On Monday, 6 August 2007 20:22, Felix Homann Hi wrote: Hi again, On Friday, 27 Jul 2007 01:33:02 -0700, Rafael J. Wysocki wrote On Friday, 27 July 2007 10:15, Felix Homann wrote: Hi, with recent kernels I'm having several problems suspending with s2disk/s2ram. The last kernel

Re: [Suspend-devel] Linux 2.6.23-rc2

2007-08-05 Thread Rafael J. Wysocki
On Sunday, 5 August 2007 15:26, Jeff Chua wrote: On 8/5/07, Antonino A. Daplas [EMAIL PROTECTED] wrote: Can you try with the boot option acpi_sleep=s3_bios,s3_mode OR if using s2ram, use s2ram -f a3 Tried both, text-console still not restored. In fact, with s2ram -f a3, backlight

Re: [Suspend-devel] [PATCH 2/6] - autoconf/automake glue - scripts

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 01:12, Alon Bar-Lev wrote: Use sh and not bash. Support BOOT_DIR for install-resume.sh Looks OK, I'm going to apply it. --- diff -urNp suspend.org/scripts/create-resume-initrd.sh suspend-0.6_beta1/scripts/create-resume-initrd.sh ---

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-03 Thread Rafael J. Wysocki
+ + Copyright (C) 2005-2007 Rafael J. Wysocki [EMAIL PROTECTED] + Copyright (C) 2006-2007 Pavel Machek [EMAIL PROTECTED] + Copyright (C) 2006-2007 Stefan Seyfried [EMAIL PROTECTED] + Copyright 2006 Tim Dijkstra [EMAIL PROTECTED] + Copyright 2006 Luca Tettamanti [EMAIL

Re: [Suspend-devel] Autoconf/automake support

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 01:24, Alon Bar-Lev wrote: On 8/3/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: Please look at the code in prepare(), for example. In there, lzf_compress() is used to take page_size bytes of data from buf, compress them and place the result under the address

Re: [Suspend-devel] s2ram triggered by xbindkeys continually suspends

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 10:55, Warren Crossing wrote: I mapped the sleep key to s2ram with xbindkeys. It suspends, then the power button flashes, then it comes out of sleep, clicks the hdisk and sometimes blinks the last picture on the screen, and then goes back to sleep it does this until

Re: [Suspend-devel] [PATCH 5/6] - autoconf/automake glue - config.* rename

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 01:16, Alon Bar-Lev wrote: config.* conflicts with autoconf files. Rename the to configparser.*. After applying this patch, you should rename: config.h-configparser.h config.c-configparser.c OK I did not want to include the removal/addition in patch. Please

Re: [Suspend-devel] [PATCH 4/6] - autoconf/automake glue - encrypt conflict

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 01:15, Alon Bar-Lev wrote: encrypt variable conflict with glibc::encrypt() Rename it to encrypt_on I'd prefer do_encrypt. --- diff -urNp suspend.org/suspend.c suspend-0.6_beta1/suspend.c --- suspend.org/suspend.c 2007-07-29 21:30:27.0 +0300 +++

Re: [Suspend-devel] [PATCH3/6] - autoconf/automake glue - cflags

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 10:14, Alon Bar-Lev wrote: On 8/3/07, Frank Seidel [EMAIL PROTECTED] wrote: Hi, On Friday 03 August 2007 01:13:56 Alon Bar-Lev wrote: Can anyone please explain this usage? These flags should seldom be used. Why do you think so? _GNU_SOURCE activates various

Re: [Suspend-devel] [PATCH 6/6] - autoconf/automake glue - s2ram

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 01:18, Alon Bar-Lev wrote: 1. Move main() out of s2ram.c into s2ram-main.c, this will enable s2ram.o to be included in both s2ram and s2both without recompilation. 2. Split whitelist.c into whitelist.h/whitelist.c as including .c is none standard/unsupported.

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 18:27, Alon Bar-Lev wrote: On 8/3/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: +vbetool License + + Copyright Matthew Garrett [EMAIL PROTECTED], heavily based on + vbetest.c from the lrmi package and read-edid.c by John Fremlin And the license

Re: [Suspend-devel] [PATCH 4/6] - autoconf/automake glue - encrypt conflict

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 18:23, Alon Bar-Lev wrote: On 8/3/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Friday, 3 August 2007 01:15, Alon Bar-Lev wrote: encrypt variable conflict with glibc::encrypt() Rename it to encrypt_on I'd prefer do_encrypt. OK. Do you wish to sync

Re: [Suspend-devel] [PATCH 4/6] - autoconf/automake glue - encrypt conflict

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 23:14, Alon Bar-Lev wrote: On Friday 03 August 2007, Rafael J. Wysocki wrote: On Friday, 3 August 2007 01:15, Alon Bar-Lev wrote: encrypt variable conflict with glibc::encrypt() Rename it to encrypt_on I'd prefer do_encrypt. OK. Thanks. I'm going

Re: [Suspend-devel] [PATCH3/6] - autoconf/automake glue - cflags

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 18:22, Alon Bar-Lev wrote: On 8/3/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: Please dig in the list archives. I don't remember at the moment, but it's needed for something important. Alternatively, you can remove it and see what breaks. ;-) Greetings

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-03 Thread Rafael J. Wysocki
On Friday, 3 August 2007 23:58, Alon Bar-Lev wrote: On 8/4/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: Usually, only the package full license is shown here. For dependencies only short copyright signature is displayed. Do you wish to put the full license of each dependency as well

Re: [Suspend-devel] [PATCH 4/6] - autoconf/automake glue - encrypt conflict

2007-08-03 Thread Rafael J. Wysocki
On Saturday, 4 August 2007 00:03, Alon Bar-Lev wrote: On 8/4/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: OK. Do you wish to sync up compress-do_compress as well? No. I'd like to have a patch without this compress_ stuff (plain LZO instead I meant the compress flag... Ah, ok

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-03 Thread Rafael J. Wysocki
On Saturday, 4 August 2007 00:46, Alon Bar-Lev wrote: On 8/4/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: Hmm... You can help you know... Perhaps I'm doing something else, which I consider as more important, in parallel? We can always complete this in future. Also if you apply

Re: [Suspend-devel] Autoconf/automake support

2007-08-02 Thread Rafael J. Wysocki
On Friday, 3 August 2007 00:31, Alon Bar-Lev wrote: On Tuesday 31 July 2007, Rafael J. Wysocki wrote: IIRC noone was strongly against, so replacing lzf with lzo is the way to go...? Ultimately, I think it is. Rafael, Can you please apply the lzo support or tell me how to improve

Re: [Suspend-devel] Autoconf/automake support

2007-08-02 Thread Rafael J. Wysocki
On Friday, 3 August 2007 00:54, Alon Bar-Lev wrote: On 8/3/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: First, please just replace LZF with LZO. If LZF is unsupported, there's no reason to drag it all the way. OK. Second, you have added data copying in compress_compress(), which

Re: [Suspend-devel] [rft] Kill junk from s2ram resume paths

2007-07-31 Thread Rafael J. Wysocki
Hi, On Tuesday, 31 July 2007 15:18, Pavel Machek wrote: Hi! This removes some stale debugging infrastructure from s2ram paths. Also, there's no need to verify_cpu on x86-64 -- cpu can't change during s2ram, and removed #if 0-ed code. Some testing would be useful, perpahs it will

Re: [Suspend-devel] [rft] Kill junk from s2ram resume paths

2007-07-31 Thread Rafael J. Wysocki
On Tuesday, 31 July 2007 16:43, Stefan Seyfried wrote: On Tue, Jul 31, 2007 at 04:01:40PM +0200, Pavel Machek wrote: Hi! # Running in *copy* of this code, somewhere in low 1MB. - movb$0xa1, %al ; outb %al, $0x80 Well, what was this for?

Re: [Suspend-devel] Autoconf/automake support

2007-07-31 Thread Rafael J. Wysocki
On Tuesday, 31 July 2007 20:30, Pavel Machek wrote: Hi! Right... so do you have sourceforge login? I guess we could use you as a webmaster for suspend.sf.net project ;-). My sf login is alonbl. But I am far from being a web master... Or have the time to do this. But if you like I

Re: [Suspend-devel] [PATCH] Don't consume 100% CPU

2007-07-29 Thread Rafael J. Wysocki
On Saturday, 28 July 2007 20:02, Rafael J. Wysocki wrote: Hi, On Saturday, 28 July 2007 11:52, Alon Bar-Lev wrote: Hello, Just a minor issue, I know you should never reach there... But never consume 100% CPU. Thanks, I'm going to apply it. Applied

Re: [Suspend-devel] resume executable location

2007-07-29 Thread Rafael J. Wysocki
On Sunday, 29 July 2007 02:44, Stefan Seyfried wrote: On Fri, Jul 27, 2007 at 09:23:07PM +0200, Rafael J. Wysocki wrote: On Thursday, 19 July 2007 05:20, Alon Bar-Lev wrote: Please consider the following patch. So you can add new files as much as you like... I'm going to apply

Re: [Suspend-devel] [PATCH] Enable interactive reboot selection

2007-07-29 Thread Rafael J. Wysocki
On Saturday, 28 July 2007 20:14, Rafael J. Wysocki wrote: On Saturday, 28 July 2007 11:51, Alon Bar-Lev wrote: On Friday 27 July 2007, Alon Bar-Lev wrote: On Friday 27 July 2007, Rafael J. Wysocki wrote: Apart from this you should also clear the PLATFORM_SUSPEND flag in the image

Re: [Suspend-devel] suspend - libz dependency

2007-07-29 Thread Rafael J. Wysocki
On Sunday, 29 July 2007 20:01, Alon Bar-Lev wrote: On 7/29/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: It doesn't work on my system (openSUSE 10.2). What do you get? s2ram-x86.o: In function `s2ram_resume': s2ram-x86.c:(.text+0x31e): undefined reference to `pci_cleanup' s2ram-x86.o

Re: [Suspend-devel] suspend - libz dependency

2007-07-29 Thread Rafael J. Wysocki
On Sunday, 29 July 2007 21:17, Alon Bar-Lev wrote: On 7/29/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: Which version of pciutils do you have? pciutils-2.2.4-13 OK. pkg-config stuff was introduced in pciutils-2.2.6 I will fix this at autoconf/automake, but I need you to commit all

Re: [Suspend-devel] suspend - libz dependency

2007-07-29 Thread Rafael J. Wysocki
On Sunday, 29 July 2007 21:41, Alon Bar-Lev wrote: On 7/29/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Sunday, 29 July 2007 21:17, Alon Bar-Lev wrote: On 7/29/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: Which version of pciutils do you have? pciutils-2.2.4-13 OK

Re: [Suspend-devel] [PATCH] Don't consume 100% CPU

2007-07-28 Thread Rafael J. Wysocki
Hi, On Saturday, 28 July 2007 11:52, Alon Bar-Lev wrote: Hello, Just a minor issue, I know you should never reach there... But never consume 100% CPU. Thanks, I'm going to apply it. Greetings, Rafael -- Premature optimization is the root of all evil. - Donald Knuth

Re: [Suspend-devel] Autoconf/automake support

2007-07-28 Thread Rafael J. Wysocki
On Friday, 27 July 2007 22:28, Alon Bar-Lev wrote: On Friday 27 July 2007, Rafael J. Wysocki wrote: Well, in fact we're missing someone to take care of the project's web page, too. Hmmm... I cannot help you with web stuff... :( But I can help you with autoconf/automake... Well, I think

Re: [Suspend-devel] Autoconf/automake support

2007-07-28 Thread Rafael J. Wysocki
On Saturday, 28 July 2007 20:06, Alon Bar-Lev wrote: On 7/28/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: Well, I think that the majority of core developers of the suspend package do not know autoconf/automake very well, including me. That may be a problem if any changes to the Makefile

Re: [Suspend-devel] suspend framebuffers during s2ram

2007-07-27 Thread Rafael J. Wysocki
On Friday, 27 July 2007 18:33, Stefan Seyfried wrote: On Fri, Jul 27, 2007 at 05:18:45PM +0200, Rafael J. Wysocki wrote: (yes, i think i know what it does; writing 1 into the state of the framebuffer device just disables any drawing - and thus any access of possibly not really

Re: [Suspend-devel] suspend - libz dependency

2007-07-27 Thread Rafael J. Wysocki
On Monday, 23 July 2007 11:16, Pavel Machek wrote: Hi! AFAICS, recent versions of pciutils depend on it. Oh... You don't have to compile it with zlib... The configure script will automatically enable support for a compressed pci.ids if you have zlib installed. You can override

Re: [Suspend-devel] [PATCH] Enable interactive reboot selection

2007-07-27 Thread Rafael J. Wysocki
Hi, On Friday, 20 July 2007 17:54, Alon Bar-Lev wrote: Hello, This patch enables the user to press r during snapshot writing, in order to reboot and not shutdown. One more step toward suspend2 functionality... :) Best Regards, Alon Bar-Lev. diff -urNp suspend.org/splash.c

Re: [Suspend-devel] Autoconf/automake support

2007-07-25 Thread Rafael J. Wysocki
Hi, On Tuesday, 24 July 2007 19:51, Alon Bar-Lev wrote: Hello, I was afraid to ask this question... But given the options, dependencies and system configuration, it would be simpler (to users) an autoconf/automake build environment. If you don't have any religion thing against these

Re: [Suspend-devel] IBM ACPI suspend led is turned off during suspend

2007-07-23 Thread Rafael J. Wysocki
On Monday, 23 July 2007 19:10, Alon Bar-Lev wrote: On 7/23/07, Pavel Machek [EMAIL PROTECTED] wrote: We do ACPI calls (platform mode), and they manipulate LED status for us. We probably tell plaform to unsuspend at the end of snapshot. That's correct. Will you fix this? Well, I'd like to

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-23 Thread Rafael J. Wysocki
On Monday, 23 July 2007 22:04, Pavel Machek wrote: On Mon 2007-07-23 20:12:21, Alon Bar-Lev wrote: On 7/23/07, Pavel Machek [EMAIL PROTECTED] wrote: I guess it is easiest way for gentoo, but... I'd prefer not to switch compression algorithms too often, unless there's good reason to.

Re: [Suspend-devel] resume executable location

2007-07-18 Thread Rafael J. Wysocki
On Wednesday, 18 July 2007 20:01, Alon Bar-Lev wrote: Hello, I wounder why resume default location is at /usr/local/lib/suspend and not at /usr/local/sbin... The resume is a program which is executed directly, right? No, it's rather designed to be executed from an initrd/initramfs image.

Re: [Suspend-devel] suspend - libz dependency

2007-07-18 Thread Rafael J. Wysocki
On Wednesday, 18 July 2007 19:28, Alon Bar-Lev wrote: Hello, I wounder why the libz dependency is required, I did not see any reference to this library in the source. Do I miss something? It compiles find if I remove it: -S2RAM_LD_FLAGS += -lx86 -lpci -lz +S2RAM_LD_FLAGS += -lx86

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-18 Thread Rafael J. Wysocki
Hi, On Wednesday, 18 July 2007 19:25, Alon Bar-Lev wrote: Hello, Rafael I am the maintainer of gentoo hibernate-script, tuxonice (suspend2). I wish to add uswsup/suspend into portage. We do not currently maintain liblzf, as it seems upstream is not cooperative. I've created a patch so

Re: [Suspend-devel] Slightly change S3_BIOS|S3_MODE handling wrt. beeping patch

2007-07-17 Thread Rafael J. Wysocki
On Tuesday, 17 July 2007 22:39, Stefan Seyfried wrote: Hi, I am proposing two changes to s2ram-x86.c: - first, if no -a is given, reset acpi_video_flags to 0, which will override also the boot options. The reason i want to do this is that people (me included) are sometimes confused by

Re: [Suspend-devel] s2ram vs. bcm43xx

2007-07-13 Thread Rafael J. Wysocki
Hi, On Friday, 13 July 2007 18:13, Benedikt Nimmervoll wrote: Hi! I am using the uswsusp 0.3 on my Kubuntu Feisty driven nx6325 laptop (fglrx driver) with the command s2ram -f -p -s. I have changed from ndiswrapper to the most recent bcm43xx driver recently and have to un/reload the bcm43xx

Re: [Suspend-devel] [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-07-04 Thread Rafael J. Wysocki
On Wednesday, 4 July 2007 21:33, Pavel Machek wrote: Hi! What about this? (Only compile tested, but looks pretty obvious to me). Something like this should get us rid of ugly option, and still solve debugging problems... Hmmm?

Re: [Suspend-devel] [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-06-28 Thread Rafael J. Wysocki
On Thursday, 28 June 2007 19:25, Stefan Seyfried wrote: (CC'ing Linus, since disabling consoles during suspend was his idea IIRC) On Thu, Jun 28, 2007 at 05:34:54PM +0200, Rafael J. Wysocki wrote: Hi, On Thursday, 28 June 2007 15:51, Pavel Machek wrote: Hi! What about

Re: [Suspend-devel] s2ram on toshiba p15-s409

2007-06-27 Thread Rafael J. Wysocki
On Wednesday, 27 June 2007 18:24, Antonio Kanaan wrote: Hello, I sent the following message 10 days ago. I have seen no reply :-( This means that no one has any idea of what you can do next. Have you tried without the NVidia driver? Greetings, Rafael -- Premature optimization is the

Re: [Suspend-devel] Fw: Bug#392168: Resume device on external USB drive causes the boot process to stop

2007-06-19 Thread Rafael J. Wysocki
Hi, On Monday, 18 June 2007 22:55, Tim Dijkstra wrote: Hi, What do people think about this? [It's quite difficult to comment attached patches.] --- resume.c.dpkg 2007-06-10 22:49:25.0 -0400 +++ resume.c2007-06-11 23:02:33.0 -0400 @@ -731,6 +731,9 @@

Re: [Suspend-devel] [PATCH, 2nd try] make disable_console_suspend runtime configurable

2007-06-14 Thread Rafael J. Wysocki
On Thursday, 14 June 2007 00:23, Stefan Seyfried wrote: On Thu, Jun 14, 2007 at 12:08:00AM +0200, Pavel Machek wrote: Hi! I hate having to recompile the kernel, just to be able to debug suspend. Remove CONFIG_DISABLE_CONSOLE_SUSPEND, replace it by a tunable in

Re: [Suspend-devel] [PATCH, 3rd try] make disable_console_suspend runtime configurable

2007-06-14 Thread Rafael J. Wysocki
On Thursday, 14 June 2007 15:59, Frank Seidel wrote: From: Stefan Seyfried [EMAIL PROTECTED] I hate having to recompile the kernel, just to be able to debug suspend. Remove CONFIG_DISABLE_CONSOLE_SUSPEND, replace it by a tunable in /sys/power/disable_console_suspend. Signed-off-by:

Re: [Suspend-devel] [PATCH, 2nd try] make disable_console_suspend runtime configurable

2007-06-13 Thread Rafael J. Wysocki
On Wednesday, 13 June 2007 22:03, Stefan Seyfried wrote: I hate having to recompile the kernel, just to be able to debug suspend. Remove CONFIG_DISABLE_CONSOLE_SUSPEND, replace it by a tunable in /sys/power/disable_console_suspend. Signed-off-by: Stefan Seyfried [EMAIL PROTECTED]

Re: [Suspend-devel] [PATCH, 2nd try] make disable_console_suspend runtime configurable

2007-06-13 Thread Rafael J. Wysocki
On Thursday, 14 June 2007 00:23, Stefan Seyfried wrote: On Thu, Jun 14, 2007 at 12:08:00AM +0200, Pavel Machek wrote: Hi! I hate having to recompile the kernel, just to be able to debug suspend. Remove CONFIG_DISABLE_CONSOLE_SUSPEND, replace it by a tunable in

Re: [Suspend-devel] Update Whitelist

2007-06-01 Thread Rafael J. Wysocki
On Friday, 1 June 2007 09:30, Stefan Seyfried wrote: On Fri, Jun 01, 2007 at 08:38:59AM +0200, [EMAIL PROTECTED] wrote: On Thu, May 31, 2007 at 02:08:17PM +0200, Stefan Seyfried wrote: I have seen similar things on different machines, but usually it was reboot not rebooting but

Re: [Suspend-devel] willing to contribute - so laptops suspend better - but how?

2007-05-24 Thread Rafael J. Wysocki
On Thursday, 24 May 2007 20:49, Valent Turkovic wrote: On 5/24/07, Richard Hughes [EMAIL PROTECTED] wrote: On Thu, 2007-05-24 at 10:19 +0200, Valent Turkovic wrote: Hi, can you please look at the issue I'm having. I would like to help troubleshoot my laptop and then other 10 I have

Re: [Suspend-devel] s2ram broken for Linux 2.6.22, libx86 broken on x86-64

2007-05-20 Thread Rafael J. Wysocki
On Sunday, 20 May 2007 01:03, Rafael J. Wysocki wrote: On Saturday, 19 May 2007 21:31, Stefan Richter wrote: Hi, the last release of s2ram, the one in suspend-0.5, does not work with Linux 2.6.22-rc2: # s2ram -f -a3 Switching from vt7 to vt1 /proc/sys/kernel/acpi_video_flags

Re: [Suspend-devel] s2ram broken for Linux 2.6.22, libx86 broken on x86-64

2007-05-20 Thread Rafael J. Wysocki
On Sunday, 20 May 2007 20:31, Tim Dijkstra wrote: On Sun, 20 May 2007 15:27:18 +0200 Stefan Richter [EMAIL PROTECTED] wrote: Rafael wrote: Actually, on x86-64 you have to compile it with $ make BACKEND=x86emu Seife, perhaps we should add this information to README? It is

Re: [Suspend-devel] s2ram broken for Linux 2.6.22, libx86 broken on x86-64

2007-05-20 Thread Rafael J. Wysocki
On Sunday, 20 May 2007 22:45, Tim Dijkstra wrote: On Sun, 20 May 2007 21:02:23 +0200 Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Sunday, 20 May 2007 20:31, Tim Dijkstra wrote: On Sun, 20 May 2007 15:27:18 +0200 Stefan Richter [EMAIL PROTECTED] wrote: Rafael wrote

Re: [Suspend-devel] s2ram broken for Linux 2.6.22, libx86 broken on x86-64

2007-05-19 Thread Rafael J. Wysocki
On Saturday, 19 May 2007 21:31, Stefan Richter wrote: Hi, the last release of s2ram, the one in suspend-0.5, does not work with Linux 2.6.22-rc2: # s2ram -f -a3 Switching from vt7 to vt1 /proc/sys/kernel/acpi_video_flags does not exist; you need a kernel =2.6.16. switching back to vt7

Re: [Suspend-devel] s2ram works s2both doesn't

2007-05-17 Thread Rafael J. Wysocki
On Thursday, 17 May 2007 12:50, Tim Dijkstra wrote: On Thu, 17 May 2007 11:59:37 +0200 Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Thursday, 17 May 2007 00:14, Tim Dijkstra wrote: Hi, I've got an report of a laptop that works with s2ram --vbe_save --vbe_post

Re: [Suspend-devel] S2disk on Thinkpad R60 and suse 10.2

2007-05-13 Thread Rafael J. Wysocki
Hi, On Sunday, 13 May 2007 19:32, Michal Hlavac wrote: Hello, free command output is: total used free sharedbuffers cached Mem: 2075176 4415521633624 0 3512 115356 -/+ buffers/cache: 3226841752492 Swap:

Re: [Suspend-devel] Thank You

2007-05-12 Thread Rafael J. Wysocki
On Saturday, 12 May 2007 19:35, Ritesh Raj Sarraf wrote: Rafael J. Wysocki wrote: Can you please try if something like this works: # echo 5 /proc/sys/kernel/printk # echo platform /sys/power/disk # echo disk /sys/power/state (it should hibernate the system)? I tried

Re: [Suspend-devel] Thank You

2007-05-12 Thread Rafael J. Wysocki
On Saturday, 12 May 2007 21:52, Ritesh Raj Sarraf wrote: Rafael J. Wysocki wrote: Can you please send me the full output of dmesg from after the failing suspend? When the suspend fails, it hangs. There's no way I see to recover at that point. Only a reboot helps. Then after reboot when

Re: [Suspend-devel] Splashy features

2007-05-11 Thread Rafael J. Wysocki
On Friday, 11 May 2007 15:03, Tim Dijkstra wrote: On Thu, 10 May 2007 22:17:29 +0200 Rafael J. Wysocki [EMAIL PROTECTED] wrote: - } else if (!splashy_open()) { + } else if (!(error = splashy_open(mode))) { I'd prefer error = error = splashy_open(mode); if (error

Re: [Suspend-devel] Thank You

2007-05-11 Thread Rafael J. Wysocki
On Friday, 11 May 2007 22:55, Ritesh Raj Sarraf wrote: Ritesh Raj Sarraf wrote: I have a Dell XPS M1210 box with Core Duo 2 Ghz, 2G RAM and an nVIDIA GeForce Go 7400 GPU (and I'm using the proprietary nvidia modules) running on a Debian box. From the very beginning I'd never had

Re: [Suspend-devel] Splashy features

2007-05-10 Thread Rafael J. Wysocki
Hi, One small remark below. Apart from this looks OK. On Thursday, 10 May 2007 22:05, Tim Dijkstra wrote: Hi, libsplashy changed the ABI a bit, needed to change something. It also would want to know if we're suspend of resuming, it can then show a penguin going to bed or waking up.

Re: [Suspend-devel] [linux-pm] [RFC][PATCH -mm 1/2] swsusp: Remove platform callbacks from restore code

2007-05-09 Thread Rafael J. Wysocki
On Wednesday, 9 May 2007 08:58, Alexey Starikovskiy wrote: I expect http://bugzilla.kernel.org/show_bug.cgi?id=7887 this bug to pop again with this patch. Well, this change only reflects what's done in kernel/power/disk.c . Greetings, Rafael

Re: [Suspend-devel] [linux-pm] [RFC][PATCH -mm 1/2] swsusp: Remove platform callbacks from restore code

2007-05-09 Thread Rafael J. Wysocki
On Wednesday, 9 May 2007 13:59, Alexey Starikovskiy wrote: This patch will disable EC GPE, which seems to be major problem. Could you please explain to me why you think so? Greetings, Rafael - This SF.net email is

Re: [Suspend-devel] [linux-pm] [RFC][PATCH -mm 1/2] swsusp: Remove platform callbacks from restore code

2007-05-09 Thread Rafael J. Wysocki
the following code: status = acpi_hw_enable_all_runtime_gpes(); if (ACPI_FAILURE(status)) { return_ACPI_STATUS(status); } Greetings, Rafael On 5/9/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Wednesday, 9 May 2007 13:59, Alexey Starikovskiy wrote

  1   2   3   4   >