Re: svn commit: r287780 - in head: share/man/man9 sys/kern sys/sys

On Thu, Sep 17, 2015 at 12:20 AM, Hans Petter Selasky wrote: > On 09/17/15 00:05, Gleb Smirnoff wrote: >> >> Weren't you explicitly asked not to touch this system without a proper >> review and discussion? > > > Adding a new function is not touching code. > > --HPS > I tried to

Re: svn commit: r282250 - head/sys/sys

On Wed, Apr 29, 2015 at 3:30 PM, Mariusz Zaborski osho...@freebsd.org wrote: On 30 April 2015 at 00:28, Davide Italiano dav...@freebsd.org wrote: On Wed, Apr 29, 2015 at 3:00 PM, Mariusz Zaborski osho...@freebsd.org wrote: Author: oshogbo Date: Wed Apr 29 22:00:26 2015 New Revision

Re: svn commit: r282250 - head/sys/sys

On Wed, Apr 29, 2015 at 3:38 PM, Mariusz Zaborski osho...@freebsd.org wrote: I'm talking about sys/kern/subr_nvlist.c. Yes. lib/libnv is compiling sys/kern/subr_nvlist.c. This is the reason why we have nv_malloc. One nv_malloc is for kernel: #define nv_malloc(size)malloc((size),

Re: svn commit: r282250 - head/sys/sys

On Wed, Apr 29, 2015 at 3:00 PM, Mariusz Zaborski osho...@freebsd.org wrote: Author: oshogbo Date: Wed Apr 29 22:00:26 2015 New Revision: 282250 URL: https://svnweb.freebsd.org/changeset/base/282250 Log: Nvlist functionality is not used within interrupt context, so we should use

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

On Sat, Mar 28, 2015 at 12:04 PM, Randall Stewart r...@netflix.com wrote: Hmm does the KPI include the size of the callout structure (which is private)? It's KBI, not KPI. If so I suppose we could change the c_flags/c_iflags to ushort … I'm not familiar with your changes enough to

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

On Sat, Mar 28, 2015 at 5:50 AM, Randall Stewart r...@freebsd.org wrote: Author: rrs Date: Sat Mar 28 12:50:24 2015 New Revision: 280785 URL: https://svnweb.freebsd.org/changeset/base/280785 Log: Change the callout to supply -1 to indicate we are not changing CPU, also add protection

Re: svn commit: r279539 - head/sys/sys

On Mar 3, 2015 9:27 AM, John-Mark Gurney j...@funkthat.com wrote: Julian Elischer wrote this message on Tue, Mar 03, 2015 at 01:20 -0800: On 3/2/15 4:55 PM, Neel Natu wrote: Hi Davide, On Mon, Mar 2, 2015 at 12:26 PM, Davide Italiano dav...@freebsd.org wrote: On Mon, Mar 2, 2015

Re: svn commit: r279539 - head/sys/sys

On Mon, Mar 2, 2015 at 12:05 PM, John-Mark Gurney j...@freebsd.org wrote: Author: jmg Date: Mon Mar 2 20:05:16 2015 New Revision: 279539 URL: https://svnweb.freebsd.org/changeset/base/279539 Log: give others fair warning that _SPARE2 isn't just cxgb, but used by large number of other

svn commit: r278780 - head/sys/kern

Author: davide Date: Sat Feb 14 20:00:57 2015 New Revision: 278780 URL: https://svnweb.freebsd.org/changeset/base/278780 Log: Don't access sockbuf fields directly, use accessor functions instead. It is safe to move the call to socantsendmore_locked() after sbdrop_locked() as long as we hold

svn commit: r278306 - head/sys/conf

Author: davide Date: Fri Feb 6 03:49:31 2015 New Revision: 278306 URL: https://svnweb.freebsd.org/changeset/base/278306 Log: Always prefer double dashes for GNU LD long options. I discovered this while working on llvm/lld and realized export-dynamic only supported --. Although upstream

Re: svn commit: r278040 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

On Mon, Feb 2, 2015 at 1:17 AM, Steven Hartland s...@freebsd.org wrote: Author: smh Date: Mon Feb 2 00:17:36 2015 New Revision: 278040 URL: https://svnweb.freebsd.org/changeset/base/278040 Log: Prevent inlining txg_quiesce This allows dtrace to monitor the calls to txg_quiesce which

Re: svn commit: r277877 - head/lib/libc/mips/gen

On Thu, Jan 29, 2015 at 7:30 AM, Ed Maste ema...@freebsd.org wrote: Author: emaste Date: Thu Jan 29 15:30:04 2015 New Revision: 277877 URL: https://svnweb.freebsd.org/changeset/base/277877 Log: Use zero register instead of immediate 0x0 in MIPS assembly It seems GAS makes the

Re: svn commit: r277570 - head/usr.bin/vmstat

On Fri, Jan 23, 2015 at 8:18 AM, Will Andrews w...@freebsd.org wrote: Author: will Date: Fri Jan 23 16:18:39 2015 New Revision: 277570 URL: https://svnweb.freebsd.org/changeset/base/277570 Log: Use CLOCK_UPTIME to get the uptime instead of CLOCK_MONOTONIC. Submitted by: asomers MFC

Re: svn commit: r277570 - head/usr.bin/vmstat

On Fri, Jan 23, 2015 at 12:56 PM, Will Andrews w...@freebsd.org wrote: On Fri, Jan 23, 2015 at 11:23:57AM -0800, Davide Italiano wrote: What's the rationale behind this change? The rationale was to match the clock used to the name (and implied intent) of the variables used to store/manipulate

Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys

On Thu, Jan 15, 2015 at 7:32 AM, Hans Petter Selasky hsela...@freebsd.org wrote: Author: hselasky Date: Thu Jan 15 15:32:30 2015 New Revision: 277213 URL: https://svnweb.freebsd.org/changeset/base/277213 Log: Major callout subsystem cleanup and rewrite: I plan to review this as well --

svn commit: r274834 - head/sys/ufs/ufs

Author: davide Date: Sat Nov 22 00:37:37 2014 New Revision: 274834 URL: https://svnweb.freebsd.org/changeset/base/274834 Log: Make ufs_dirhashreclaimperc a percentage for real and rename it to ufs_dirhashreclaimpercent, as suggested by jhb@. As an added bonus this avoids divide-by-zero

svn commit: r274835 - head/sys/ufs/ufs

Author: davide Date: Sat Nov 22 00:42:30 2014 New Revision: 274835 URL: https://svnweb.freebsd.org/changeset/base/274835 Log: Use the correct variable name. Modified: head/sys/ufs/ufs/ufs_dirhash.c Modified: head/sys/ufs/ufs/ufs_dirhash.c

svn commit: r273234 - in head/sys: dev/cfe dev/nvram2env mips/beri mips/rmi mips/rt305x

Author: davide Date: Fri Oct 17 17:34:05 2014 New Revision: 273234 URL: https://svnweb.freebsd.org/changeset/base/273234 Log: Convert remaining {g,s}etenv-kern_{g,s}etenv left over from r273174. Reported by:bz Modified: head/sys/dev/cfe/cfe_env.c

svn commit: r273174 - in head/sys: amd64/amd64 amd64/vmm arm/arm cam/ata cddl/contrib/opensolaris/uts/common/dtrace dev/acpica dev/asmc dev/cfi dev/drm2 dev/hatm dev/mii dev/nfe dev/patm dev/pci de...

Author: davide Date: Thu Oct 16 18:04:43 2014 New Revision: 273174 URL: https://svnweb.freebsd.org/changeset/base/273174 Log: Follow up to r225617. In order to maximize the re-usability of kernel code in userland rename in-kernel getenv()/setenv() to kern_setenv()/kern_getenv(). This fixes

Re: svn commit: r273174 - in head/sys: amd64/amd64 amd64/vmm arm/arm cam/ata cddl/contrib/opensolaris/uts/common/dtrace dev/acpica dev/asmc dev/cfi dev/drm2 dev/hatm dev/mii dev/nfe dev/patm dev/pci d

On Thu, Oct 16, 2014 at 4:44 PM, Bjoern A. Zeeb b...@freebsd.org wrote: On 16 Oct 2014, at 18:04 , Davide Italiano dav...@freebsd.org wrote: Author: davide Date: Thu Oct 16 18:04:43 2014 New Revision: 273174 URL: https://svnweb.freebsd.org/changeset/base/273174 Log: Follow up to r225617

Re: svn commit: r273174 - in head/sys: amd64/amd64 amd64/vmm arm/arm cam/ata cddl/contrib/opensolaris/uts/common/dtrace dev/acpica dev/asmc dev/cfi dev/drm2 dev/hatm dev/mii dev/nfe dev/patm dev/pci d

On Thu, Oct 16, 2014 at 8:30 PM, Garrett Cooper yaneurab...@gmail.com wrote: BTW, it would be cool if universe will put logs of successful builds and logs of failed builds in different directories for easier inspection. If there's already something like this and you can point me to that, it

Re: svn commit: r272366 - head/sys/kern

On Wed, Oct 1, 2014 at 8:32 AM, Will Andrews w...@freebsd.org wrote: Author: will Date: Wed Oct 1 15:32:28 2014 New Revision: 272366 URL: https://svnweb.freebsd.org/changeset/base/272366 Log: In the syncer, drop the sync mutex while patting the watchdog. Some watchdog drivers (like

svn commit: r271736 - head/usr.sbin/makefs

Author: davide Date: Thu Sep 18 03:11:59 2014 New Revision: 271736 URL: http://svnweb.freebsd.org/changeset/base/271736 Log: r258695 introduces a sanity check for makefs in order to verify that the minimum image size specified is always less than the maximum image size. If makefs(1) is

Re: svn commit: r270261 - head/sys/sys

On Sun, Sep 7, 2014 at 1:14 PM, Rui Paulo rpa...@me.com wrote: On Aug 21, 2014, at 02:01, Davide Italiano dav...@freebsd.org wrote: Author: davide Date: Thu Aug 21 09:01:42 2014 New Revision: 270261 URL: http://svnweb.freebsd.org/changeset/base/270261 Log: Revert r270227. GCC doesn't

Re: svn commit: r270710 - in head/sys: contrib/rdma/krping dev/cxgb dev/cxgbe/iw_cxgbe modules/mlx4 modules/mlx4ib modules/mlxen ofed/drivers/infiniband/core ofed/drivers/infiniband/hw/mlx4 ofed/drive

On Wed, Aug 27, 2014 at 11:59 AM, Hans Petter Selasky h...@selasky.org wrote: Removing those files may make it more annoying to port some other linux code in the future, as some future linux driver code may include those files. On a (somewhat) related note, I would like to see sema(9)

svn commit: r270588 - head/sys/ufs/ufs

Author: davide Date: Mon Aug 25 17:06:18 2014 New Revision: 270588 URL: http://svnweb.freebsd.org/changeset/base/270588 Log: Rather than using an hardcoded reclaim age, rely on an LRU-like approach for dirhash cache, setting a target percent to reclaim (exposed via SYSCTL). This allows to

svn commit: r270261 - head/sys/sys

Author: davide Date: Thu Aug 21 09:01:42 2014 New Revision: 270261 URL: http://svnweb.freebsd.org/changeset/base/270261 Log: Revert r270227. GCC doesn't like the lack of LL suffix, so this makes powerpc build failing. Modified: head/sys/sys/time.h Modified: head/sys/sys/time.h

svn commit: r270221 - head/sys/security/audit

Author: davide Date: Wed Aug 20 16:04:30 2014 New Revision: 270221 URL: http://svnweb.freebsd.org/changeset/base/270221 Log: Replace dev_clone with cdevpriv(9) KPI in audit_pipe code. This is (yet another) step towards the removal of device cloning from our kernel. CR:

svn commit: r270227 - head/sys/sys

Author: davide Date: Wed Aug 20 16:32:02 2014 New Revision: 270227 URL: http://svnweb.freebsd.org/changeset/base/270227 Log: Make Bruce happy removing the LL abomination from time.h It's not necessary in all the three instances because they already have the correct type on all the supported

svn commit: r270233 - stable/10/sys/kern

Author: davide Date: Wed Aug 20 17:26:05 2014 New Revision: 270233 URL: http://svnweb.freebsd.org/changeset/base/270233 Log: MFC r269502: Fix an overflow in getsockopt(). optval isn't big enough to hold sbintime_t. Re-introduce r255030 behaviour capping socket timeouts to INT_32 if

Re: svn commit: r270227 - head/sys/sys

On Wed, Aug 20, 2014 at 9:32 AM, Davide Italiano dav...@freebsd.org wrote: Author: davide Date: Wed Aug 20 16:32:02 2014 New Revision: 270227 URL: http://svnweb.freebsd.org/changeset/base/270227 Log: Make Bruce happy removing the LL abomination from time.h It's not necessary in all

svn commit: r270240 - stable/10/sys/sys

Author: davide Date: Wed Aug 20 18:40:29 2014 New Revision: 270240 URL: http://svnweb.freebsd.org/changeset/base/270240 Log: Complete MFC of r270233, also unbreak the build. Reported by: grehan Modified: stable/10/sys/sys/time.h Modified: stable/10/sys/sys/time.h

Re: svn commit: r270227 - head/sys/sys

On Wed, Aug 20, 2014 at 12:42 PM, Xin Li delp...@delphij.net wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 08/20/14 09:32, Davide Italiano wrote: Author: davide Date: Wed Aug 20 16:32:02 2014 New Revision: 270227 URL: http://svnweb.freebsd.org/changeset/base/270227 Log: Make

svn commit: r269502 - head/sys/kern

Author: davide Date: Mon Aug 4 05:40:51 2014 New Revision: 269502 URL: http://svnweb.freebsd.org/changeset/base/269502 Log: Fix an overflow in getsockopt(). optval isn't big enough to hold sbintime_t. Re-introduce r255030 behaviour capping socket timeouts to INT_32 if they're too large.

svn commit: r267851 - in head/sys/cddl: contrib/opensolaris/uts/common/dtrace dev/dtrace

Author: davide Date: Wed Jun 25 03:54:02 2014 New Revision: 267851 URL: http://svnweb.freebsd.org/changeset/base/267851 Log: Continue the crusade towards a dev_clone()-free kernel, removing its usage from dtrace. The dtrace code already uses cdevpriv(9) since FreeBSD 8, so this change

svn commit: r267092 - head/sys/kern

Author: davide Date: Thu Jun 5 03:46:46 2014 New Revision: 267092 URL: http://svnweb.freebsd.org/changeset/base/267092 Log: Convert functions to the new-style format. Submitted by: Vijay Singh vijju.si...@gmail.com via -hackers Modified: head/sys/kern/kern_timeout.c Modified:

svn commit: r264388 - in head/sys: kern sys

Author: davide Date: Sat Apr 12 23:29:29 2014 New Revision: 264388 URL: http://svnweb.freebsd.org/changeset/base/264388 Log: Hide internal details of sbintime_t implementation wrapping INT64_MAX into SBT_MAX, to make it more robust in case internal type representation will change in the

svn commit: r264392 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Author: davide Date: Sun Apr 13 01:15:37 2014 New Revision: 264392 URL: http://svnweb.freebsd.org/changeset/base/264392 Log: Fix a panic in zfs_rename(). this is due to a wrong dereference of a vnode when it's not locked and can be (potentially) recycled. 'sdvp' cannot be locked on

Re: svn commit: r264392 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

On Sat, Apr 12, 2014 at 6:43 PM, Steven Hartland kill...@multiplay.co.uk wrote: Interesting, I'd be curious to know what the panic for this looks like? It's more like a 'trap 12: page fault while in kernel mode'. Post-mortem analysis with kgdb shows the vnode fields filled with garbage (e.g.

svn commit: r255877 - head/sys/kern

Author: davide Date: Thu Sep 26 10:06:50 2013 New Revision: 255877 URL: http://svnweb.freebsd.org/changeset/base/255877 Log: Make the callout arithmetic more robust adding checks for overflow. Without these, if the timeout value passed is large enough, the value of the sum of it and other

Re: svn commit: r255437 - in head: cddl/contrib/opensolaris/lib/libzpool/common cddl/contrib/opensolaris/lib/libzpool/common/sys sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opensolaris/uts/common

On Mon, Sep 23, 2013 at 9:14 AM, Andriy Gapon a...@freebsd.org wrote: on 10/09/2013 15:03 Davide Italiano said the following: The Illumos cv_timedwait_hires() doesn't use 'res' argument so if you want to be consistent with their behaviour you should pass '0' as precision argument

svn commit: r255788 - head/sys/kern

Author: davide Date: Sun Sep 22 14:09:07 2013 New Revision: 255788 URL: http://svnweb.freebsd.org/changeset/base/255788 Log: Consistently use the same value to indicate exclusively-held and shared-held locks for all the primitives in lc_lock/lc_unlock routines. This fixes the problems

svn commit: r255745 - in head/sys: dev/hwpmc kern sys

Author: davide Date: Fri Sep 20 23:06:21 2013 New Revision: 255745 URL: http://svnweb.freebsd.org/changeset/base/255745 Log: Fix lc_lock/lc_unlock() support for rmlocks held in shared mode. With current lock classes KPI it was really difficult because there was no way to pass an rmtracker

svn commit: r255746 - head/sys/dev/hwpmc

Author: davide Date: Fri Sep 20 23:10:52 2013 New Revision: 255746 URL: http://svnweb.freebsd.org/changeset/base/255746 Log: Remove local change leftover, this should never have been part of r255745. Pointy-hat to:davide Approved by: re (implicit) Modified:

svn commit: r255747 - head/sys/kern

Author: davide Date: Fri Sep 20 23:16:15 2013 New Revision: 255747 URL: http://svnweb.freebsd.org/changeset/base/255747 Log: Fix callout_init_rm() in the shared case, allocating storage for 'struct rm_priotracker' directly in the softclock thread. Now consumers can pass CALLOUT_SHAREDLOCK

svn commit: r255748 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Author: davide Date: Fri Sep 20 23:22:00 2013 New Revision: 255748 URL: http://svnweb.freebsd.org/changeset/base/255748 Log: Fixup cross-device rename checks in ZFS. Add a check for the case where 'fdvp' is a directory, 'tvp' is an already existing directory and they have different mount

Re: svn commit: r254703 - in head: share/man/man9 sys/sys

On Thu, Sep 12, 2013 at 4:08 PM, John Baldwin j...@freebsd.org wrote: Hmm, I think I had envisioned something a bit simpler. Namely, I would change lc_lock/lc_unlock to return a uintptr_t instead of an int, and I would then change lc_unlock for an rm lock to return a pointer to the current

Re: svn commit: r254703 - in head: share/man/man9 sys/sys

[snip] Well, I've thought about changing lc_lock/unlock to return a uintptr_t or void * instead of an int and then I could make rm_sleep work fine. However, that still doesn't solve the callout case. The callout case can't be fixed easily without explicitly allocating storage in the

Re: svn commit: r255437 - in head: cddl/contrib/opensolaris/lib/libzpool/common cddl/contrib/opensolaris/lib/libzpool/common/sys sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opensolaris/uts/common

On Tue, Sep 10, 2013 at 3:46 AM, Xin LI delp...@freebsd.org wrote: [snip] +static clock_t +cv_timedwait_hires(kcondvar_t *cvp, kmutex_t *mp, hrtime_t tim, hrtime_t res, +int flag) +{ + sbintime_t sbt; + sbintime_t pr; + + sbt = tim * SBT_1NS; + pr = res *

Re: svn commit: r255067 - head/sys/kern

== --- head/sys/kern/kern_synch.c Fri Aug 30 10:10:22 2013(r255066) +++ head/sys/kern/kern_synch.c Fri Aug 30 10:39:56 2013(r255067) @@ -356,10 +356,7 @@ msleep_spin_sbt(void *ident, struct mtx int

Re: svn commit: r255067 - head/sys/kern

On Tue, Sep 10, 2013 at 11:16 PM, Davide Italiano dav...@freebsd.org wrote: == --- head/sys/kern/kern_synch.c Fri Aug 30 10:10:22 2013(r255066) +++ head/sys/kern/kern_synch.c Fri Aug 30 10:39:56 2013

Re: svn commit: r255359 - in head/sys: cddl/dev/dtrace dev/firewire dev/vkbd security/audit

On Sun, Sep 8, 2013 at 6:24 PM, Ed Schouten e...@80386.nl wrote: 2013/9/7 Davide Italiano dav...@freebsd.org: Log: - Use make_dev_credf(MAKEDEV_REF) instead of the race-prone make_dev()+ dev_ref() in the clone handlers that still use it. - Don't set SI_CHEAPCLONE flag, it's not used

Re: svn commit: r255360 - head/sys/net

On Sun, Sep 8, 2013 at 6:26 PM, Ed Schouten e...@80386.nl wrote: 2013/9/7 Davide Italiano dav...@freebsd.org: Log: Don't clear the unused SI_CHEAPCLONE flag in tap_create()/tuncreate(). Both the tun and the tap driver still use clonelists, right? I'm not sure this fix is all right

svn commit: r255359 - in head/sys: cddl/dev/dtrace dev/firewire dev/vkbd security/audit

Author: davide Date: Sat Sep 7 13:45:44 2013 New Revision: 255359 URL: http://svnweb.freebsd.org/changeset/base/255359 Log: - Use make_dev_credf(MAKEDEV_REF) instead of the race-prone make_dev()+ dev_ref() in the clone handlers that still use it. - Don't set SI_CHEAPCLONE flag, it's not

svn commit: r255360 - head/sys/net

Author: davide Date: Sat Sep 7 13:50:13 2013 New Revision: 255360 URL: http://svnweb.freebsd.org/changeset/base/255360 Log: Don't clear the unused SI_CHEAPCLONE flag in tap_create()/tuncreate(). Reviewed by: kib Modified: head/sys/net/if_tap.c head/sys/net/if_tun.c Modified:

svn commit: r255329 - head/sys/net

Author: davide Date: Fri Sep 6 21:02:43 2013 New Revision: 255329 URL: http://svnweb.freebsd.org/changeset/base/255329 Log: Retire netisr.netisr_direct and netisr.netisr_direct_force sysctls. These were used to control/export dispatch policy but they're not anymore. This commit cannot be

Re: svn commit: r255329 - head/sys/net

On Fri, Sep 6, 2013 at 11:02 PM, Davide Italiano dav...@freebsd.org wrote: Author: davide Date: Fri Sep 6 21:02:43 2013 New Revision: 255329 URL: http://svnweb.freebsd.org/changeset/base/255329 Log: Retire netisr.netisr_direct and netisr.netisr_direct_force sysctls. These were used

svn commit: r255133 - head/sys/dev/hwpmc

Author: davide Date: Sun Sep 1 21:44:43 2013 New Revision: 255133 URL: http://svnweb.freebsd.org/changeset/base/255133 Log: Complete r250105. Do not zero fields if M_ZERO flag is specified to malloc(9). Reported by: pluknet, glebius Modified: head/sys/dev/hwpmc/hwpmc_mod.c

svn commit: r255135 - head/sys/sys

Author: davide Date: Sun Sep 1 22:30:24 2013 New Revision: 255135 URL: http://svnweb.freebsd.org/changeset/base/255135 Log: Use single underscore for all parameters name and local variables in bintime_* related functions. This commit completes what was already done by theraven@ for

Re: svn commit: r255135 - head/sys/sys

On Mon, Sep 2, 2013 at 12:30 AM, Davide Italiano dav...@freebsd.org wrote: Author: davide Date: Sun Sep 1 22:30:24 2013 New Revision: 255135 URL: http://svnweb.freebsd.org/changeset/base/255135 Log: Use single underscore for all parameters name and local variables in bintime_* related

svn commit: r255138 - in head/sys: kern sys

Author: davide Date: Sun Sep 1 23:34:53 2013 New Revision: 255138 URL: http://svnweb.freebsd.org/changeset/base/255138 Log: Fix socket buffer timeouts precision using the new sbintime_t KPI instead of relying on the tvtohz() workaround. The latter has been introduced lately by jhb@

Re: svn commit: r254585 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

On Wed, Aug 28, 2013 at 3:02 AM, Xin Li delp...@delphij.net wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 [snip] On 08/27/13 01:59, Davide Italiano wrote: I've written a patch that attempts to fix the second problem. http://people.freebsd.org/~davide/review/zfsrename_recycle.diff

Re: svn commit: r254986 - head/sys/ufs/ufs

On Wed, Aug 28, 2013 at 12:06 PM, Ivan Voras ivo...@freebsd.org wrote: Author: ivoras Date: Wed Aug 28 10:06:20 2013 New Revision: 254986 URL: http://svnweb.freebsd.org/changeset/base/254986 Log: Take a very small step toward the Century of the Anchovy by increasing the time dirhash

Re: svn commit: r254986 - head/sys/ufs/ufs

On Wed, Aug 28, 2013 at 12:31 PM, Ivan Voras ivo...@freebsd.org wrote: On 28 August 2013 12:25, Davide Italiano dav...@freebsd.org wrote: do you have any evidence that this change impacts positively (or negatively) performances for some workloads? If yes, can you share? Yes, observation

Re: svn commit: r254986 - head/sys/ufs/ufs

On Wed, Aug 28, 2013 at 12:53 PM, Ivan Voras ivo...@freebsd.org wrote: On 28 August 2013 12:44, Davide Italiano dav...@freebsd.org wrote: Do you realize that this is a driven by commit change, right? And there's no technical motivatiion about this or experimental data that confirms you've

Re: svn commit: r254585 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

instead of just ifdef'ing the code out -- maybe to prevent unwanted conflict with upstream? These two VOP's are the only consumers of VOP_REALVP in tree. Yes. Personally I would just ifdef out the calls. Another unrelated problem that existed before this change and has been noted by Davide

Re: svn commit: r254703 - in head: share/man/man9 sys/sys

On Fri, Aug 23, 2013 at 9:58 AM, John Baldwin j...@freebsd.org wrote: On Friday, August 23, 2013 11:29:45 am Davide Italiano wrote: On Fri, Aug 23, 2013 at 4:51 PM, John Baldwin j...@freebsd.org wrote: On Friday, August 23, 2013 10:12:39 am Davide Italiano wrote: Author: davide Date: Fri

svn commit: r254703 - in head: share/man/man9 sys/sys

Author: davide Date: Fri Aug 23 14:12:39 2013 New Revision: 254703 URL: http://svnweb.freebsd.org/changeset/base/254703 Log: Introduce callout_init_rm() so that callouts can be used in conjunction with rmlocks. This works only with non-sleepable rm because handlers run in SWI context. While

svn commit: r254710 - head/share/man/man9

Author: davide Date: Fri Aug 23 14:33:56 2013 New Revision: 254710 URL: http://svnweb.freebsd.org/changeset/base/254710 Log: - Bump date. - Small mdoc fix. Submitted by: pluknet Modified: head/share/man/man9/timeout.9 Modified: head/share/man/man9/timeout.9

svn commit: r254712 - head/sys/sys

Author: davide Date: Fri Aug 23 14:40:17 2013 New Revision: 254712 URL: http://svnweb.freebsd.org/changeset/base/254712 Log: Fix the build and fix style. Pointy-hat to:davide Modified: head/sys/sys/callout.h Modified: head/sys/sys/callout.h

Re: svn commit: r254703 - in head: share/man/man9 sys/sys

On Fri, Aug 23, 2013 at 4:51 PM, John Baldwin j...@freebsd.org wrote: On Friday, August 23, 2013 10:12:39 am Davide Italiano wrote: Author: davide Date: Fri Aug 23 14:12:39 2013 New Revision: 254703 URL: http://svnweb.freebsd.org/changeset/base/254703 Log: Introduce callout_init_rm() so

Re: svn commit: r254524 - head/sys/sys

On Wed, Aug 21, 2013 at 6:18 PM, Andre Oppermann an...@freebsd.org wrote: On 21.08.2013 17:59, Davide Italiano wrote: On Wed, Aug 21, 2013 at 5:30 PM, Andre Oppermann an...@freebsd.org wrote: On 20.08.2013 20:13, Davide Italiano wrote: On Tue, Aug 20, 2013 at 7:42 PM, Andre Oppermann

Re: svn commit: r254616 - head/sys/dev/hwpmc

On Wed, Aug 21, 2013 at 2:47 PM, Adrian Chadd adr...@freebsd.org wrote: Author: adrian Date: Wed Aug 21 21:47:56 2013 New Revision: 254616 URL: http://svnweb.freebsd.org/changeset/base/254616 Log: Change the name of this particular event to reflect the name used in Linux and Intel

Re: svn commit: r254616 - head/sys/dev/hwpmc

On Wed, Aug 21, 2013 at 2:52 PM, Davide Italiano dav...@freebsd.org wrote: On Wed, Aug 21, 2013 at 2:47 PM, Adrian Chadd adr...@freebsd.org wrote: Author: adrian Date: Wed Aug 21 21:47:56 2013 New Revision: 254616 URL: http://svnweb.freebsd.org/changeset/base/254616 Log: Change the name

Re: svn commit: r254524 - head/sys/sys

On Tue, Aug 20, 2013 at 7:42 PM, Andre Oppermann an...@freebsd.org wrote: On 19.08.2013 19:37, Navdeep Parhar wrote: On 08/19/13 06:56, Andre Oppermann wrote: Author: andre Date: Mon Aug 19 13:56:14 2013 New Revision: 254524 URL: http://svnweb.freebsd.org/changeset/base/254524 Log:

Re: svn commit: r254520 - in head/sys: kern sys

On Mon, Aug 19, 2013 at 1:16 PM, Andre Oppermann an...@freebsd.org wrote: Author: andre Date: Mon Aug 19 11:16:53 2013 New Revision: 254520 URL: http://svnweb.freebsd.org/changeset/base/254520 Log: Remove the unused M_NOFREE mbuf flag. It didn't have any in-tree users for a very long

Re: svn commit: r254309 - in head: share/man/man9 sys/cddl/contrib/opensolaris/uts/common/dtrace sys/cddl/dev/dtrace sys/cddl/dev/sdt sys/kern sys/sys

[trim old mails] diff --git a/sys/sys/pmckern.h b/sys/sys/pmckern.h index e3e18a6..90585de 100644 --- a/sys/sys/pmckern.h +++ b/sys/sys/pmckern.h @@ -51,13 +51,11 @@ #definePMC_FN_CSW_IN 2 #definePMC_FN_CSW_OUT 3 #define

svn commit: r252558 - head/sys/fs/smbfs

Author: davide Date: Wed Jul 3 10:31:45 2013 New Revision: 252558 URL: http://svnweb.freebsd.org/changeset/base/252558 Log: - Fix double frees/user after free. - Allocate using smb_rq_alloc() instead of inlining it. Reported by: uqs Found with: Coverity Scan Modified:

Re: svn commit: r252356 - in head: contrib/smbfs/mount_smbfs etc/defaults etc/mtree include lib lib/libprocstat rescue/rescue sbin/mount share/examples share/examples/etc share/mk sys/conf sys/kern sy

On Wed, Jul 3, 2013 at 11:28 AM, Ulrich Spörlein u...@freebsd.org wrote: On Fri, 2013-06-28 at 21:00:08 +, Davide Italiano wrote: Author: davide Date: Fri Jun 28 21:00:08 2013 New Revision: 252356 URL: http://svnweb.freebsd.org/changeset/base/252356 Log: - Trim an unused and bogus

svn commit: r252352 - head/sys/fs/smbfs

Author: davide Date: Fri Jun 28 20:07:24 2013 New Revision: 252352 URL: http://svnweb.freebsd.org/changeset/base/252352 Log: Plug a couple of leakages in smbfs_lookup(). Modified: head/sys/fs/smbfs/smbfs_vnops.c Modified: head/sys/fs/smbfs/smbfs_vnops.c

svn commit: r252353 - head/sys/fs/smbfs

Author: davide Date: Fri Jun 28 20:14:30 2013 New Revision: 252353 URL: http://svnweb.freebsd.org/changeset/base/252353 Log: Garbage collect an useless check. smp should be never NULL. Modified: head/sys/fs/smbfs/smbfs_vfsops.c Modified: head/sys/fs/smbfs/smbfs_vfsops.c

svn commit: r252354 - head/sys/netsmb

Author: davide Date: Fri Jun 28 20:21:13 2013 New Revision: 252354 URL: http://svnweb.freebsd.org/changeset/base/252354 Log: Remove a reference to LK_DRAIN now that lockmgr(9) is gone from this piece of code. Reported by: attilio Modified: head/sys/netsmb/smb_conn.c Modified:

svn commit: r252355 - head/sys/fs/smbfs

Author: davide Date: Fri Jun 28 20:32:48 2013 New Revision: 252355 URL: http://svnweb.freebsd.org/changeset/base/252355 Log: Properly use v_data field. This magically worked (even if wrong) until now because v_data is the first field of the structure, but it's not something we should rely

svn commit: r252356 - in head: contrib/smbfs/mount_smbfs etc/defaults etc/mtree include lib lib/libprocstat rescue/rescue sbin/mount share/examples share/examples/etc share/mk sys/conf sys/kern sys...

Author: davide Date: Fri Jun 28 21:00:08 2013 New Revision: 252356 URL: http://svnweb.freebsd.org/changeset/base/252356 Log: - Trim an unused and bogus Makefile for mount_smbfs. - Reconnect with some minor modifications, in particular now selsocket() internals are adapted to use sbintime

svn commit: r252357 - head/sys/kern

Author: davide Date: Fri Jun 28 21:04:15 2013 New Revision: 252357 URL: http://svnweb.freebsd.org/changeset/base/252357 Log: Correct the comment above _sleep() function which still mentions 'timo' instead of 'sbintime_t'. Reported by: kan Modified: head/sys/kern/kern_synch.c

svn commit: r252358 - head/sys/vm

Author: davide Date: Fri Jun 28 21:13:19 2013 New Revision: 252358 URL: http://svnweb.freebsd.org/changeset/base/252358 Log: Remove a spurious keg lock acquisition. Modified: head/sys/vm/uma_core.c Modified: head/sys/vm/uma_core.c

svn commit: r250236 - in head: contrib/smbfs/lib/smb contrib/smbfs/mount_smbfs sys/fs/smbfs sys/netsmb

Author: davide Date: Sat May 4 14:03:18 2013 New Revision: 250236 URL: http://svnweb.freebsd.org/changeset/base/250236 Log: Completely rewrite the interface to smbdev switching from dev_clone to cdevpriv(9). This commit changes the semantic of mount_smbfs in userland as well, which now

svn commit: r250237 - in head/sys: fs/smbfs netsmb

Author: davide Date: Sat May 4 14:18:10 2013 New Revision: 250237 URL: http://svnweb.freebsd.org/changeset/base/250237 Log: Overhaul locking in netsmb, getting rid of the obsolete lockmgr() primitive. This solves a long standing LOR between smb_conn and smb_vc. Tested by:martymac,

svn commit: r250238 - head/sys/fs/smbfs

Author: davide Date: Sat May 4 14:27:28 2013 New Revision: 250238 URL: http://svnweb.freebsd.org/changeset/base/250238 Log: Change VM_OBJECT_LOCK/UNLOCK() - VM_OBJECT_WLOCK/WUNLOCK() to reflect the recent switch of the vm object lock to a rwlock. Reported by: attilio Modified:

svn commit: r250243 - head/sys/netsmb

Author: davide Date: Sat May 4 16:55:48 2013 New Revision: 250243 URL: http://svnweb.freebsd.org/changeset/base/250243 Log: If the kernel is compiled with VMIMAGE support, the first attempt of mounting smbfs share will cause a panic. Fix setting setting/restoring vnet context when needed.

svn commit: r250182 - head/sys/dev/hwpmc

Author: davide Date: Thu May 2 14:55:21 2013 New Revision: 250182 URL: http://svnweb.freebsd.org/changeset/base/250182 Log: Suppress a GCC warning. This warning is actually bogus and newer GCC versions than the one in base (dim@ mentioned he tried on 4.7.3 and 4.8.1) do not whine about it,

svn commit: r250149 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Author: davide Date: Wed May 1 17:34:44 2013 New Revision: 250149 URL: http://svnweb.freebsd.org/changeset/base/250149 Log: In case ZFS doesn't use UMA for buffers there's no need to waste memory creating zones that will remain empty. Reviewed by: pjd Modified:

svn commit: r250096 - head/sys/dev/hwpmc

Author: davide Date: Tue Apr 30 08:18:08 2013 New Revision: 250096 URL: http://svnweb.freebsd.org/changeset/base/250096 Log: Fixup Westmere hwpmc(4) support: add missing CPU flag so that intrucion-retired, llc-misses and llc-reference events can now be allocated. Reviewed by:

svn commit: r250097 - head/sys/dev/hwpmc

Author: davide Date: Tue Apr 30 08:33:38 2013 New Revision: 250097 URL: http://svnweb.freebsd.org/changeset/base/250097 Log: When hwpmc(4) module is unloaded it reports a double leakage. This happens at least if FreeBSD is ran under VirtualBox. In order to avoid the leakage, properly

svn commit: r250101 - head/sys/dev/hwpmc

Author: davide Date: Tue Apr 30 14:56:41 2013 New Revision: 250101 URL: http://svnweb.freebsd.org/changeset/base/250101 Log: Complete r250097: Do not change the initialization order in pmc_intel_initialize(). Modified: head/sys/dev/hwpmc/hwpmc_intel.c Modified:

svn commit: r250103 - head/sys/dev/hwpmc

Author: davide Date: Tue Apr 30 15:31:45 2013 New Revision: 250103 URL: http://svnweb.freebsd.org/changeset/base/250103 Log: The Intel PMC architectural events have encodings which are identical to those of some non-architectural core events. This is not a problem in the general case as

svn commit: r250105 - head/sys/dev/hwpmc

Author: davide Date: Tue Apr 30 15:59:22 2013 New Revision: 250105 URL: http://svnweb.freebsd.org/changeset/base/250105 Log: malloc(9) cannot return NULL if M_WAITOK flag is specified. Modified: head/sys/dev/hwpmc/hwpmc_mod.c head/sys/dev/hwpmc/hwpmc_soft.c Modified:

svn commit: r248699 - head/sys/kern

Author: davide Date: Mon Mar 25 09:43:50 2013 New Revision: 248699 URL: http://svnweb.freebsd.org/changeset/base/248699 Log: Cache the callout precision argument as part of the informations required for migrating callouts to new CPU. This value is passed to callout_cc_add() in order to

svn commit: r248099 - head/sys/fs/smbfs

Author: davide Date: Sat Mar 9 13:05:21 2013 New Revision: 248099 URL: http://svnweb.freebsd.org/changeset/base/248099 Log: - Initialize variable in smbfs_rename() to silent compiler warning - Fix smbfs_mkdir() return value (in case of error). Reported by: pho Modified:

svn commit: r248101 - head/sys/fs/smbfs

Author: davide Date: Sat Mar 9 13:25:45 2013 New Revision: 248101 URL: http://svnweb.freebsd.org/changeset/base/248101 Log: smbfs_lookup() in the DOTDOT case operates on dvp-n_parent without proper locking. This doesn't prevent in any case reclaim of the vnode. Avoid this not going

  1   2   >