Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-07 Thread Hans Petter Selasky
On Thursday 06 August 2009 21:47:16 Navdeep Parhar wrote: See attached patch. Please test and report back. This patch fixes my problem. The machine is remote and I'm unable to test whether the USB keyboard and keystroke repetition works, but core dumps to a SATA disk are now as fast as

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-07 Thread M. Warner Losh
In message: 200908070830.47894.hsela...@c2i.net Hans Petter Selasky hsela...@c2i.net writes: : On Thursday 06 August 2009 21:47:16 Navdeep Parhar wrote: : See attached patch. Please test and report back. : : This patch fixes my problem. The machine is remote and I'm unable :

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-07 Thread Navdeep Parhar
On Fri, Aug 07, 2009 at 08:30:45AM +0200, Hans Petter Selasky wrote: On Thursday 06 August 2009 21:47:16 Navdeep Parhar wrote: See attached patch. Please test and report back. This patch fixes my problem. The machine is remote and I'm unable to test whether the USB keyboard and

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-07 Thread Hans Petter Selasky
On Friday 07 August 2009 08:57:44 Navdeep Parhar wrote: ok. And my question, just like with the previous problem, is: Can something be done about it or are we expected to learn to live with this I will make a fix for this. --HPS ___

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-07 Thread Hans Petter Selasky
On Friday 07 August 2009 08:54:00 M. Warner Losh wrote: In message: 200908070830.47894.hsela...@c2i.net Hans Petter Selasky hsela...@c2i.net writes: : On Thursday 06 August 2009 21:47:16 Navdeep Parhar wrote: : See attached patch. Please test and report back. : : This

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-07 Thread Bruce Evans
On Fri, 7 Aug 2009, M. Warner Losh wrote: In message: 200908070830.47894.hsela...@c2i.net Hans Petter Selasky hsela...@c2i.net writes: : On Thursday 06 August 2009 21:47:16 Navdeep Parhar wrote: : ... : Simple sequence of steps to reproduce problem: : ctrl-alt-esc on the USB

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-07 Thread Dag-Erling Smørgrav
Sam Leffler s...@errno.com writes: I think we are losing sight of the goal here. We are in a release schedule and trying to find a minimal set of changes that resolves our immediate need. Keyboard repeat is not required and unless there is an obvious and immediate solution it should be

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-07 Thread M. Warner Losh
In message: 8663d463d7@ds4.des.no Dag-Erling_Smørgrav d...@des.no writes: : Sam Leffler s...@errno.com writes: : I think we are losing sight of the goal here. We are in a release : schedule and trying to find a minimal set of changes that resolves our : immediate need.

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-07 Thread Dag-Erling Smørgrav
M. Warner Losh i...@bsdimp.com writes: Does the patch that Hans posted fit the bill? To my eye I think it does, but I've not tested to see if it works... My point (and Sam's, I think) is simply: drop keyboard repeat support. DES -- Dag-Erling Smørgrav - d...@des.no

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-07 Thread M. Warner Losh
In message: 86skg84o8i@ds4.des.no Dag-Erling_Smørgrav d...@des.no writes: : M. Warner Losh i...@bsdimp.com writes: : Does the patch that Hans posted fit the bill? To my eye I think it : does, but I've not tested to see if it works... : : My point (and Sam's, I think) is simply:

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-06 Thread Navdeep Parhar
See attached patch. Please test and report back. This patch fixes my problem.  The machine is remote and I'm unable to test whether the USB keyboard and keystroke repetition works, but core dumps to a SATA disk are now as fast as they were before r195960.  Thanks. I finally got a chance to

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-04 Thread Bruce Evans
On Mon, 3 Aug 2009, Hans Petter Selasky wrote: On Monday 03 August 2009 19:46:16 Bruce Evans wrote: On Mon, 3 Aug 2009, M. Warner Losh wrote: In message: 200908030827.21108.hsela...@c2i.net : I see two solutions: : : 1) Disable the timekeeping if no keys are pressed. : : 2) Second option is

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input (regression patch)

2009-08-03 Thread Hans Petter Selasky
Hi, Here is a patch to address the problem. Please test and report back. Works fine over here. http://perforce.freebsd.org/chv.cgi?CH=166957 MD5 (ukbd.c.diff) = 1e3c143942593b0ed4617d306a9d2ee2 cd /usr/src/sys/dev/usb/input/ cat ukbd.c.diff | patch --HPS --- ukbd.c 2009-08-02

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-03 Thread M. Warner Losh
In message: 200908030827.21108.hsela...@c2i.net Hans Petter Selasky hsela...@c2i.net writes: : On Sunday 02 August 2009 21:58:14 Robert N. M. Watson wrote: : On 2 Aug 2009, at 20:29, Alfred Perlstein wrote: : * Robert Watson rwat...@freebsd.org [090801 15:15] wrote: : On Sat, 1

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-03 Thread Hans Petter Selasky
On Sunday 02 August 2009 21:58:14 Robert N. M. Watson wrote: On 2 Aug 2009, at 20:29, Alfred Perlstein wrote: * Robert Watson rwat...@freebsd.org [090801 15:15] wrote: On Sat, 1 Aug 2009, Hans Petter Selasky wrote: This has slowed down core dumps very significantly. What used to take

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input (regression patch)

2009-08-03 Thread Robert Watson
On Mon, 3 Aug 2009, Hans Petter Selasky wrote: Here is a patch to address the problem. Please test and report back. Works fine over here. http://perforce.freebsd.org/chv.cgi?CH=166957 MD5 (ukbd.c.diff) = 1e3c143942593b0ed4617d306a9d2ee2 cd /usr/src/sys/dev/usb/input/ cat ukbd.c.diff |

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input (regression patch)

2009-08-03 Thread Ed Schouten
* Robert Watson rwat...@freebsd.org wrote: I'm a bit surprised the timed key repeat in this patch would work properly in DDB, as microtime(9) relies on interrupts firing for updated timestamps. The availability of interrupts for polled input consumers varies, but in general this is not true

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input (regression patch)

2009-08-03 Thread Hans Petter Selasky
On Monday 03 August 2009 10:28:38 Ed Schouten wrote: * Robert Watson rwat...@freebsd.org wrote: I'm a bit surprised the timed key repeat in this patch would work properly in DDB, as microtime(9) relies on interrupts firing for updated timestamps. The availability of interrupts for polled

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input (regression patch)

2009-08-03 Thread Robert Watson
On Mon, 3 Aug 2009, Hans Petter Selasky wrote: On Monday 03 August 2009 10:28:38 Ed Schouten wrote: * Robert Watson rwat...@freebsd.org wrote: I'm a bit surprised the timed key repeat in this patch would work properly in DDB, as microtime(9) relies on interrupts firing for updated

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-03 Thread Bruce Evans
On Mon, 3 Aug 2009, M. Warner Losh wrote: In message: 200908030827.21108.hsela...@c2i.net : I see two solutions: : : 1) Disable the timekeeping if no keys are pressed. : : 2) Second option is to use getmicrotime. Actually what I need is just a : millisecond time reference so I know when to

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input (regression patch)

2009-08-03 Thread Bruce Evans
On Mon, 3 Aug 2009, Robert Watson wrote: On Mon, 3 Aug 2009, Hans Petter Selasky wrote: I think getmicrotime relies on interrupts, while microtime doesn't. See man microtime. You're right, but that doesn't make things better :-). Some of the tc_get_timecount() calls are safe in the DDB

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-03 Thread Hans Petter Selasky
On Monday 03 August 2009 19:46:16 Bruce Evans wrote: On Mon, 3 Aug 2009, M. Warner Losh wrote: In message: 200908030827.21108.hsela...@c2i.net : I see two solutions: : : 1) Disable the timekeeping if no keys are pressed. : : 2) Second option is to use getmicrotime. Actually what I

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-03 Thread Nathan Whitehorn
Hans Petter Selasky wrote: On Monday 03 August 2009 19:46:16 Bruce Evans wrote: On Mon, 3 Aug 2009, M. Warner Losh wrote: In message: 200908030827.21108.hsela...@c2i.net : I see two solutions: : : 1) Disable the timekeeping if no keys are pressed. : : 2) Second option is to use

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-03 Thread Sam Leffler
Robert Watson wrote: On Mon, 3 Aug 2009, Hans Petter Selasky wrote: On Monday 03 August 2009 19:46:16 Bruce Evans wrote: On Mon, 3 Aug 2009, M. Warner Losh wrote: In message: 200908030827.21108.hsela...@c2i.net : I see two solutions: : : 1) Disable the timekeeping if no keys are pressed. :

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-02 Thread Alfred Perlstein
* Robert Watson rwat...@freebsd.org [090801 15:15] wrote: On Sat, 1 Aug 2009, Hans Petter Selasky wrote: This has slowed down core dumps very significantly. What used to take 10-15s on my system now takes around 3 minutes. A simple test is to break into ddb and call doadump with or

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-02 Thread Robert N. M. Watson
On 2 Aug 2009, at 20:29, Alfred Perlstein wrote: * Robert Watson rwat...@freebsd.org [090801 15:15] wrote: On Sat, 1 Aug 2009, Hans Petter Selasky wrote: This has slowed down core dumps very significantly. What used to take 10-15s on my system now takes around 3 minutes. A simple test

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-01 Thread Alfred Perlstein
* Navdeep Parhar npar...@gmail.com [090731 21:55] wrote: On Sat, Aug 01, 2009 at 06:15:01AM +0200, Hans Petter Selasky wrote: On Friday 31 July 2009 23:21:40 Alfred Perlstein wrote: Hans, can you please look into this issue? * Navdeep Parhar npar...@gmail.com [090731 00:45] wrote:

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-08-01 Thread Robert Watson
On Sat, 1 Aug 2009, Hans Petter Selasky wrote: This has slowed down core dumps very significantly. What used to take 10-15s on my system now takes around 3 minutes. A simple test is to break into ddb and call doadump with or without this rev. I have a serial console on this machine and so

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-07-31 Thread Navdeep Parhar
On Wed, Jul 29, 2009 at 5:14 PM, Alfred Perlsteinalf...@freebsd.org wrote: Author: alfred Date: Thu Jul 30 00:14:34 2009 New Revision: 195960 URL: http://svn.freebsd.org/changeset/base/195960 Log:  USB CORE:  - Add minimum polling support to drive UMASS    and UKBD in case of panic.  -

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-07-31 Thread Dmitry Marakasov
* Navdeep Parhar (npar...@gmail.com) wrote: This has slowed down core dumps very significantly. What used to take 10-15s on my system now takes around 3 minutes. Same here. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amd...@amdmi3.ru ..: jabber:

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-07-31 Thread Scott Long
Dmitry Marakasov wrote: * Navdeep Parhar (npar...@gmail.com) wrote: This has slowed down core dumps very significantly. What used to take 10-15s on my system now takes around 3 minutes. Same here. Likely because prior to polling being implemented, each i/o was done blindly and completed

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-07-31 Thread Navdeep Parhar
On Sat, Aug 01, 2009 at 06:15:01AM +0200, Hans Petter Selasky wrote: On Friday 31 July 2009 23:21:40 Alfred Perlstein wrote: Hans, can you please look into this issue? * Navdeep Parhar npar...@gmail.com [090731 00:45] wrote: This has slowed down core dumps very significantly. What used

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-07-31 Thread Navdeep Parhar
On Fri, Jul 31, 2009 at 08:58:47PM -0600, Scott Long wrote: Dmitry Marakasov wrote: * Navdeep Parhar (npar...@gmail.com) wrote: This has slowed down core dumps very significantly. What used to take 10-15s on my system now takes around 3 minutes. Same here. Likely because prior to

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-07-31 Thread Scott Long
Navdeep Parhar wrote: On Fri, Jul 31, 2009 at 08:58:47PM -0600, Scott Long wrote: Dmitry Marakasov wrote: * Navdeep Parhar (npar...@gmail.com) wrote: This has slowed down core dumps very significantly. What used to take 10-15s on my system now takes around 3 minutes. Same here. Likely

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-07-31 Thread Hans Petter Selasky
On Friday 31 July 2009 23:21:40 Alfred Perlstein wrote: Hans, can you please look into this issue? * Navdeep Parhar npar...@gmail.com [090731 00:45] wrote: On Wed, Jul 29, 2009 at 5:14 PM, Alfred Perlsteinalf...@freebsd.org wrote: Author: alfred Date: Thu Jul 30 00:14:34 2009 New

Re: svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-07-31 Thread Navdeep Parhar
On Fri, Jul 31, 2009 at 11:11:26PM -0600, Scott Long wrote: Navdeep Parhar wrote: On Fri, Jul 31, 2009 at 08:58:47PM -0600, Scott Long wrote: Dmitry Marakasov wrote: * Navdeep Parhar (npar...@gmail.com) wrote: This has slowed down core dumps very significantly. What used to take 10-15s

svn commit: r195960 - in head/sys/dev/usb: . controller input

2009-07-29 Thread Alfred Perlstein
Author: alfred Date: Thu Jul 30 00:14:34 2009 New Revision: 195960 URL: http://svn.freebsd.org/changeset/base/195960 Log: USB CORE: - Add minimum polling support to drive UMASS and UKBD in case of panic. - Add extra check to ukbd probe to fix problem about mouse devices attaching