Re: svn commit: r209358 - head/cddl/contrib/opensolaris/lib/libdtrace/common

2010-06-21 Thread Bruce Evans
On Sun, 20 Jun 2010, Marcel Moolenaar wrote: Log: Unbreak platforms with char unsigned by default. Oddly enough, GCC isn't satisfied with a simple cast to int in the check against EOF, so the fix is a bit involved by actually having to go through a temporary variable. Perhaps that is

Re: svn commit: r209358 - head/cddl/contrib/opensolaris/lib/libdtrace/common

2010-06-21 Thread Alexander Kabaev
On Tue, 22 Jun 2010 03:22:40 +1000 (EST) Bruce Evans b...@optusnet.com.au wrote: On Sun, 20 Jun 2010, Marcel Moolenaar wrote: Log: Unbreak platforms with char unsigned by default. Oddly enough, GCC isn't satisfied with a simple cast to int in the check against EOF, so the fix is a bit

Re: svn commit: r209358 - head/cddl/contrib/opensolaris/lib/libdtrace/common

2010-06-21 Thread Marcel Moolenaar
On Jun 21, 2010, at 10:22 AM, Bruce Evans wrote: On Sun, 20 Jun 2010, Marcel Moolenaar wrote: Log: Unbreak platforms with char unsigned by default. Oddly enough, GCC isn't satisfied with a simple cast to int in the check against EOF, so the fix is a bit involved by actually having to go

Re: svn commit: r209358 - head/cddl/contrib/opensolaris/lib/libdtrace/common

2010-06-21 Thread Bruce Evans
On Mon, 21 Jun 2010, Alexander Kabaev wrote: On Tue, 22 Jun 2010 03:22:40 +1000 (EST) Bruce Evans b...@optusnet.com.au wrote: On Sun, 20 Jun 2010, Marcel Moolenaar wrote: ... #undef unput -#define unput(c) \ - if (c != EOF) yyunput( c, yytext_ptr ) +#define unput(c)

Re: svn commit: r209358 - head/cddl/contrib/opensolaris/lib/libdtrace/common

2010-06-21 Thread Alexander Kabaev
On Tue, 22 Jun 2010 04:30:12 +1000 (EST) Bruce Evans b...@optusnet.com.au wrote: On Mon, 21 Jun 2010, Alexander Kabaev wrote: On Tue, 22 Jun 2010 03:22:40 +1000 (EST) Bruce Evans b...@optusnet.com.au wrote: SKIP DTrace _does_ try to unput EOF though and apparently gets away with it

svn commit: r209358 - head/cddl/contrib/opensolaris/lib/libdtrace/common

2010-06-19 Thread Marcel Moolenaar
Author: marcel Date: Sun Jun 20 00:34:06 2010 New Revision: 209358 URL: http://svn.freebsd.org/changeset/base/209358 Log: Unbreak platforms with char unsigned by default. Oddly enough, GCC isn't satisfied with a simple cast to int in the check against EOF, so the fix is a bit involved by

Re: svn commit: r209358 - head/cddl/contrib/opensolaris/lib/libdtrace/common

2010-06-19 Thread Alexander Kabaev
On Sun, 20 Jun 2010 00:34:06 + (UTC) Marcel Moolenaar mar...@freebsd.org wrote: Author: marcel Date: Sun Jun 20 00:34:06 2010 New Revision: 209358 URL: http://svn.freebsd.org/changeset/base/209358 Log: Unbreak platforms with char unsigned by default. Oddly enough, GCC isn't