Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

That being said, is there any other socket option value in there implemented as enum? I don't see anything obvious, so that I am curious if it would stick out as an odd one in there. What do you think? -Max On Tue, Jan 17, 2017 at 6:22 AM, Maxim Sobolev wrote: > Of course

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

In my experience, enums are a superior way to define integer constants (compared to #define), but they are pure poison as variable types in APIs and structures because their size is a compiler implementation choice. -- Ian On Tue, 2017-01-17 at 08:40 -0800, Maxim Sobolev wrote: > That being

Re: svn commit: r312205 - in head/sys: kern net

On 01/17/17 16:04, John Baldwin wrote: Then it gives a much slower boot by hanging for almost a minute waiting for USB or something. Hi, This might be related to a bug in the timer init which I've observed too. Can you show output from: vmstat -i When the booting is slow? --HPS

svn commit: r312348 - head/sys/cam/ctl

Author: mav Date: Tue Jan 17 18:32:47 2017 New Revision: 312348 URL: https://svnweb.freebsd.org/changeset/base/312348 Log: Remove writing 'residual' field of struct ctl_scsiio. This field has no practical use and never readed. Initiators already receive respective residual size from

svn commit: r312346 - head/sys/dev/sdhci

Author: loos Date: Tue Jan 17 17:41:14 2017 New Revision: 312346 URL: https://svnweb.freebsd.org/changeset/base/312346 Log: Set the the wp_disabled flag when asked to. While here, add the missing new line. MFC after:3 days Sponsored by: Rubicon Communications, LLC (Netgate)

svn commit: r312349 - in stable/11/sys/boot/efi: . loader/arch/arm

Author: gonzo Date: Tue Jan 17 19:19:29 2017 New Revision: 312349 URL: https://svnweb.freebsd.org/changeset/base/312349 Log: MFC r311888, r311890-r311891 r311888: [efi] Fix off-by-one error in ARM .bss zeroing code in loader's _start __bss_end should not be included in .bss zeroing

svn commit: r312347 - head/sys/boot/fdt/dts/arm

Author: loos Date: Tue Jan 17 18:04:13 2017 New Revision: 312347 URL: https://svnweb.freebsd.org/changeset/base/312347 Log: The write-protect is not wired on uFW, disable it to allow writes to SD card. Sponsored by: Rubicon Communications, LLC (Netgate) Modified:

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

On 01/17/2017 11:48, Benjamin Kaduk wrote: > On Tue, Jan 17, 2017 at 10:57 AM, Ian Lepore > wrote: > > In my experience, enums are a superior way to define integer constants > (compared to #define), but they are pure poison as variable types in

Re: svn commit: r312236 - head/sys/net80211

On 15/01/2017 22:43, Adrian Chadd wrote: > On 15 January 2017 at 11:56, Ian Lepore wrote: > >> >> What is the point of the !! in these macros? The expressions already >> have boolean type (even in C++ where it matters) due to the ==. >> Removing the !! would also make one

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

Ian's potential objection has been met by Ben Kaduk and Eric van Gyzen's responses. It seems like an enum is just fine. And I agree with Gleb that it is preferable. Conrad On Tue, Jan 17, 2017 at 1:34 PM, Maxim Sobolev wrote: > Well as other pointed out there are some

Re: svn commit: r312205 - in head/sys: kern net

On Tuesday, January 17, 2017 12:02:49 PM Bruce Evans wrote: > On Mon, 16 Jan 2017, John Baldwin wrote: > > > On Sunday, January 15, 2017 12:50:10 AM Sean Bruno wrote: > >> ... > >> Log: > >> Fix hangs in a uniprocessor configuration (qemu, virtualbox, real hw). > >> > >> sys/net/iflib.c: > >>

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

On Tue, Jan 17, 2017 at 10:57 AM, Ian Lepore wrote: > In my experience, enums are a superior way to define integer constants > (compared to #define), but they are pure poison as variable types in > APIs and structures because their size is a compiler implementation > choice. >

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

I actually don't agree that it's all good, but I also don't have the time to prove it's not (or prove myself wrong, which could certainly be the case). -- Ian On Tue, 2017-01-17 at 15:21 -0800, Conrad Meyer wrote: > Ian's potential objection has been met by Ben Kaduk and Eric van > Gyzen's

svn commit: r312357 - in stable/10/sys: cam/scsi modules/cam

Author: ngie Date: Tue Jan 17 23:55:10 2017 New Revision: 312357 URL: https://svnweb.freebsd.org/changeset/base/312357 Log: MFC r299864,r303166: r299864 (by markj): opt_kdtrace.h is not needed for SDT probes as of r258541. r303166 (by imp): Add opt_ddb.h. Modified:

Re: svn commit: r312356 - stable/11/sys/modules/cam

> On Jan 17, 2017, at 15:47, Ngie Cooper wrote: > > Author: ngie > Date: Tue Jan 17 23:47:37 2017 > New Revision: 312356 > URL: https://svnweb.freebsd.org/changeset/base/312356 > > Log: > MFC r303166: > r303166 (by imp): > > Add opt_ddb.h. This MFC fixes bug 213535 as

Re: svn commit: r312357 - in stable/10/sys: cam/scsi modules/cam

> On Jan 17, 2017, at 15:55, Ngie Cooper wrote: > > Author: ngie > Date: Tue Jan 17 23:55:10 2017 > New Revision: 312357 > URL: https://svnweb.freebsd.org/changeset/base/312357 > > Log: > MFC r299864,r303166: > > r299864 (by markj): > > opt_kdtrace.h is not needed for

svn commit: r312350 - head/sys/conf

Author: bdrewery Date: Tue Jan 17 21:12:21 2017 New Revision: 312350 URL: https://svnweb.freebsd.org/changeset/base/312350 Log: Don't compute MPATH during install. This saves time when building over NFS. Nothing should be building during this phase anyhow. Sponsored by: Dell EMC

svn commit: r312354 - in head/sys/compat: cloudabi32 cloudabi64

Author: ed Date: Tue Jan 17 22:05:01 2017 New Revision: 312354 URL: https://svnweb.freebsd.org/changeset/base/312354 Log: Regenerate sources based on the system call tables. Modified: head/sys/compat/cloudabi32/cloudabi32_proto.h head/sys/compat/cloudabi32/cloudabi32_syscall.h

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

On Tue, Jan 17, 2017 at 08:40:50AM -0800, Maxim Sobolev wrote: M> That being said, is there any other socket option value in there M> implemented as enum? I don't see anything obvious, so that I am curious if M> it would stick out as an odd one in there. What do you think? Simply because 30 years

svn commit: r312351 - stable/11/sys/dev/kbd

Author: lifanov (ports committer) Date: Tue Jan 17 22:01:33 2017 New Revision: 312351 URL: https://svnweb.freebsd.org/changeset/base/312351 Log: MFC r311650 Restore priority value for OGIO_KEYMAP PR: 206678 Submitted by: ect...@gmail.com Reviewed by: cem Approved by:

svn commit: r312355 - in head/sys: amd64/cloudabi32 amd64/cloudabi64 arm/cloudabi32 arm64/cloudabi64 compat/cloudabi compat/cloudabi32 compat/cloudabi64 i386/cloudabi32

Author: ed Date: Tue Jan 17 22:05:52 2017 New Revision: 312355 URL: https://svnweb.freebsd.org/changeset/base/312355 Log: Catch up with changes to structure member names. Pointer/length pairs are now always named ${name} and ${name}_len. Modified:

svn commit: r312352 - stable/10/sys/dev/kbd

Author: lifanov (ports committer) Date: Tue Jan 17 22:02:22 2017 New Revision: 312352 URL: https://svnweb.freebsd.org/changeset/base/312352 Log: MFC r311650 Restore priority value for OGIO_KEYMAP PR: 206678 Submitted by: ect...@gmail.com Reviewed by: cem Approved by:

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

Well as other pointed out there are some concerns with using enums from C++ and ABI prospective. So it looks to me that there is no general consensus on that direction. -Max On Tue, Jan 17, 2017 at 1:27 PM, Gleb Smirnoff wrote: > On Tue, Jan 17, 2017 at 08:40:50AM -0800,

svn commit: r312353 - head/sys/contrib/cloudabi

Author: ed Date: Tue Jan 17 22:03:08 2017 New Revision: 312353 URL: https://svnweb.freebsd.org/changeset/base/312353 Log: Sync in the latest CloudABI generated source files. Languages like C++17 and Go provide direct support for slice types: pointer/length pairs. The CloudABI generator

svn commit: r312368 - head/sys/dev/cxgbe/tom

Author: np Date: Wed Jan 18 03:35:42 2017 New Revision: 312368 URL: https://svnweb.freebsd.org/changeset/base/312368 Log: cxgbe/tom: Fix a case where do_pass_accept_req wasn't properly restoring the VNET. This should have been in r311949. MFC after:2 days Modified:

svn commit: r312369 - head/sys/powerpc/aim

Author: jhibbits Date: Wed Jan 18 03:42:21 2017 New Revision: 312369 URL: https://svnweb.freebsd.org/changeset/base/312369 Log: Use the explicit expanded form of cmp. Clang apparently requires the explicit form of this instruction, and rejects uses which ignore the optional cmpD

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

OK, guys, with all due respect I think I've heard enough to say that if somebody feels like this has to be enum feel free to jump in and tweak it out. As far as I understand there should be no user-visible differences either way, so it's not like we are going to be locked with this way forever.

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

On Tue, 17 Jan 2017, Maxim Sobolev wrote: Also there is at least one thing that makes enum less desirable from the point of view of application developer. Particularly it makes it impossible to use preprocessor to do a conditional compilation, which is especially important for the

svn commit: r312358 - in stable/11/sys/dev: alc pci

Author: yongari Date: Wed Jan 18 01:52:04 2017 New Revision: 312358 URL: https://svnweb.freebsd.org/changeset/base/312358 Log: MFC r304574-304575,304584: r304574: Correct DMA channel number selection on AR816x family of controllers. For Gigabit Ethernet version of AR816x,

svn commit: r312362 - in stable/10/sys/dev: age alc ale jme msk stge vte

Author: yongari Date: Wed Jan 18 02:16:17 2017 New Revision: 312362 URL: https://svnweb.freebsd.org/changeset/base/312362 Log: MFC r295735: Fix variable assignment. Modified: stable/10/sys/dev/age/if_age.c stable/10/sys/dev/alc/if_alc.c stable/10/sys/dev/ale/if_ale.c

svn commit: r312363 - stable/10/sys/dev/rl

Author: yongari Date: Wed Jan 18 02:22:07 2017 New Revision: 312363 URL: https://svnweb.freebsd.org/changeset/base/312363 Log: MFC r295736,295738: r295736: Remove duplicated check. r295738: Fix a bug introduced in r295736 TX descriptor address should be updated for valid

svn commit: r312365 - stable/10/share/man/man9

Author: yongari Date: Wed Jan 18 02:41:13 2017 New Revision: 312365 URL: https://svnweb.freebsd.org/changeset/base/312365 Log: MFC r302548: Belatedly remove CSUM_IP_FRAGS and CSUM_FRAGMENT offloading capabilities. It was removed in r243624 and r254804/r271006 respectively. This

svn commit: r312364 - stable/11/share/man/man9

Author: yongari Date: Wed Jan 18 02:40:18 2017 New Revision: 312364 URL: https://svnweb.freebsd.org/changeset/base/312364 Log: MFC r302548: Belatedly remove CSUM_IP_FRAGS and CSUM_FRAGMENT offloading capabilities. It was removed in r243624 and r254804/r271006 respectively. This

svn commit: r312366 - stable/11/sys/dev/sound/pci/hda

Author: yongari Date: Wed Jan 18 02:56:24 2017 New Revision: 312366 URL: https://svnweb.freebsd.org/changeset/base/312366 Log: MFC r309527-309528: r309527: Recognize RealTek ALC1150 7.1 channel HD audio codec. r309528: Fix too low volume on MSI H170 GAMING M3 board by poking

svn commit: r312367 - stable/10/sys/dev/sound/pci/hda

Author: yongari Date: Wed Jan 18 02:57:22 2017 New Revision: 312367 URL: https://svnweb.freebsd.org/changeset/base/312367 Log: MFC r309527-309528: r309527: Recognize RealTek ALC1150 7.1 channel HD audio codec. r309528: Fix too low volume on MSI H170 GAMING M3 board by poking

svn commit: r312359 - in stable/10/sys/dev: alc pci

Author: yongari Date: Wed Jan 18 01:53:07 2017 New Revision: 312359 URL: https://svnweb.freebsd.org/changeset/base/312359 Log: MFC r304574-304575,304584: r304574: Correct DMA channel number selection on AR816x family of controllers. For Gigabit Ethernet version of AR816x,

svn commit: r312360 - stable/11/share/man/man4

Author: yongari Date: Wed Jan 18 01:57:13 2017 New Revision: 312360 URL: https://svnweb.freebsd.org/changeset/base/312360 Log: MFC r304576: Add Killer E2400 to the supported hardware list. Modified: stable/11/share/man/man4/alc.4 Directory Properties: stable/11/ (props changed)

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

> On Jan 17, 2017, at 17:42, Daniel Eischen wrote: > > On Tue, 17 Jan 2017, Maxim Sobolev wrote: > >> Also there is at least one thing that makes enum less desirable from the >> point of view of application developer. Particularly it makes it impossible >> to use

svn commit: r312361 - stable/10/share/man/man4

Author: yongari Date: Wed Jan 18 01:58:33 2017 New Revision: 312361 URL: https://svnweb.freebsd.org/changeset/base/312361 Log: MFC r304576: Add Killer E2400 to the supported hardware list. Modified: stable/10/share/man/man4/alc.4 Directory Properties: stable/10/ (props changed)

svn commit: r312356 - stable/11/sys/modules/cam

Author: ngie Date: Tue Jan 17 23:47:37 2017 New Revision: 312356 URL: https://svnweb.freebsd.org/changeset/base/312356 Log: MFC r303166: r303166 (by imp): Add opt_ddb.h. Modified: stable/11/sys/modules/cam/Makefile Directory Properties: stable/11/ (props changed) Modified:

svn commit: r312338 - in head: share/man/man4 sys/dev/sound/usb sys/dev/usb sys/dev/usb/quirk

Author: hselasky Date: Tue Jan 17 08:15:10 2017 New Revision: 312338 URL: https://svnweb.freebsd.org/changeset/base/312338 Log: Add USB audio support for S/PDIF output with C-Media CM6206 devices. Submitted by: Julien Nadeau PR: 216131

Re: svn commit: r311952 - head/sys/ddb

On Mon, 16 Jan 2017, Julian Elischer wrote: On 16/01/2017 11:53 AM, Bruce Evans wrote: On Sun, 15 Jan 2017, Adrian Chadd wrote: hah, i took this, then life got in the way. :) Bruce - what do you think of https://bz-attachments.freebsd.org/attachment.cgi?id=138881 ? Also

svn commit: r312339 - stable/11/libexec/rtld-elf

Author: kib Date: Tue Jan 17 10:32:27 2017 New Revision: 312339 URL: https://svnweb.freebsd.org/changeset/base/312339 Log: MFC r311879: Use ANSI C definitions, update comment. Modified: stable/11/libexec/rtld-elf/rtld_lock.c Directory Properties: stable/11/ (props changed) Modified:

svn commit: r312341 - head/sys/netpfil/ipfw

Author: ae Date: Tue Jan 17 10:50:28 2017 New Revision: 312341 URL: https://svnweb.freebsd.org/changeset/base/312341 Log: Initialize IPFW static rules rmlock with RM_RECURSE flag. This lock was replaced from rwlock in r272840. But unlike rwlock, rmlock doesn't allow recursion on

Re: svn commit: r312322 - stable/11/tests/sys/file

> Author: ngie > Date: Tue Jan 17 01:56:44 2017 > New Revision: 312322 > URL: https://svnweb.freebsd.org/changeset/base/312322 > > Log: > MFC r312111: > > Remove unused vars to fix -Wunused issues The actual mistake here is that these are unused, a main() should do at least a check on

svn commit: r312340 - stable/10/libexec/rtld-elf

Author: kib Date: Tue Jan 17 10:34:31 2017 New Revision: 312340 URL: https://svnweb.freebsd.org/changeset/base/312340 Log: MFC r311879: Use ANSI C definitions, update comment. Modified: stable/10/libexec/rtld-elf/rtld_lock.c Directory Properties: stable/10/ (props changed) Modified:

svn commit: r312343 - head/sys/cam/ctl

Author: mav Date: Tue Jan 17 14:13:14 2017 New Revision: 312343 URL: https://svnweb.freebsd.org/changeset/base/312343 Log: Improve error message on duplicate iSCSI port. MFC after:2 weeks Modified: head/sys/cam/ctl/ctl_frontend_iscsi.c Modified:

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

Of course it's possible. Do you guys want me to amend that patch? -Max On Mon, Jan 16, 2017 at 10:52 PM, Gleb Smirnoff wrote: > Hi! > > On Mon, Jan 16, 2017 at 05:46:38PM +, Maxim Sobolev wrote: > M> Author: sobomax > M> Date: Mon Jan 16 17:46:38 2017 > M> New

svn commit: r312344 - in head/sys/cam: ata scsi

Author: sbruno Date: Tue Jan 17 14:52:48 2017 New Revision: 312344 URL: https://svnweb.freebsd.org/changeset/base/312344 Log: Add 4k quirk for Micron 5100 and Intel S3610 SSDs Submitted by: Jason Wolfe MFH: 1 week Sponsored by: Limelight Networks

svn commit: r312370 - in vendor/NetBSD/tests/dist: kernel/arch/amd64 lib/libpthread

Author: ngie Date: Wed Jan 18 05:32:50 2017 New Revision: 312370 URL: https://svnweb.freebsd.org/changeset/base/312370 Log: More test updates from upstream Nothing much to note -- this looks like a good place to stop Modified: vendor/NetBSD/tests/dist/kernel/arch/amd64/t_ptrace_wait.c

svn commit: r312371 - vendor/NetBSD/tests/01.17.2017_21.34

Author: ngie Date: Wed Jan 18 05:35:34 2017 New Revision: 312371 URL: https://svnweb.freebsd.org/changeset/base/312371 Log: Tag the "01.17.2017_21.34" snapshot of ^/vendor/NetBSD/tests Added: vendor/NetBSD/tests/01.17.2017_21.34/ - copied from r312370, vendor/NetBSD/tests/dist/