[Swan-dev] testing/utils/kvmresults.py has a problem

2020-08-31 Thread D. Hugh Redelmeier
After each run of the test suite, I use kvmresults.py to create a useful summary of how each test did. Recently it has crashed when I run it, but only after producing the results I want. So this isn't a big problem. Here's the most recent traceback: Traceback (most recent call last): File

Re: [Swan-dev] a few test are broken because reference logs need updating

2020-08-31 Thread D. Hugh Redelmeier
| From: Antony Antony | | oh, that was me. I added new tests and sanitizer line when I noticed new | test need it. I did not realize it would affet existing tests. Let me push | the two tests. Thanks. I was worried that this intermediate state had been intentional. I certainly accidentally

[Swan-dev] code for impossible situations

2020-08-31 Thread D. Hugh Redelmeier
If a case is impossible, but you feel unsure about it, use passert. Then you'll know. Actually handling an impossible case requires or suggests that all related code should handle it too. And that multiplies complexity and the chance for bugs. This code will never be exercised by our test

Re: [Swan-dev] a few test are broken because reference logs need updating

2020-08-31 Thread Antony Antony
oh, that was me. I added new tests and sanitizer line when I noticed new test need it. I did not realize it would affet existing tests. Let me push the two tests. Thanks Hugh for spotting them. On Mon, Aug 31, 2020 at 09:28:04AM -0400, D. Hugh Redelmeier wrote: > It looks like a new filter was

Re: [Swan-dev] pexpect() and passert() from a thread

2020-08-31 Thread Andrew Cagney
On Fri, 21 Aug 2020 at 13:10, Andrew Cagney wrote: > > FYI, > Currently if there's a pexpect() or passert() in a helper thread > there's no context (state prefix) so it's not easy to proportion > blame. Going forward (when cur_* are deleted) the main thread will > have the same problem. >

[Swan-dev] a few test are broken because reference logs need updating

2020-08-31 Thread D. Hugh Redelmeier
It looks like a new filter was added. If your changes are going to require reference file changes, please push both sets of changes at the same time. > testing/pluto/interop-ikev2-strongswan-29-rekey failed west:output-different