Re: [Swan-dev] On re-applying "pluto: warn if loaded connection ended up unoriented" et.al.

2024-01-23 Thread Andrew Cagney
On Tue, 23 Jan 2024 at 10:44, Paul Wouters wrote: > > On Mon, 22 Jan 2024, Andrew Cagney wrote: > > >> Also, please use separate commits for code and test cases in the future. > > > > Except this wasn't my mess. > > > > I was dealing with a commit that, once it became clear was broken, > > should

Re: [Swan-dev] On re-applying "pluto: warn if loaded connection ended up unoriented" et.al.

2024-01-23 Thread Paul Wouters
On Mon, 22 Jan 2024, Andrew Cagney wrote: Also, please use separate commits for code and test cases in the future. Except this wasn't my mess. I was dealing with a commit that, once it became clear was broken, should have been quickly reverted, followed by an incomplete trickle of test

Re: [Swan-dev] On re-applying "pluto: warn if loaded connection ended up unoriented" et.al.

2024-01-22 Thread Andrew Cagney
On Mon, 22 Jan 2024 at 19:40, Paul Wouters wrote: > > On Mon, 22 Jan 2024, Andrew Cagney wrote: > > > commit b575e15e80bcf0924bc96e3e7420092becedc42a > > Author: Andrew Cagney > > Date: Mon Jan 22 13:32:01 2024 -0500 > > > >Reapply "pluto: warn if loaded connection ended up unoriented"

Re: [Swan-dev] On re-applying "pluto: warn if loaded connection ended up unoriented" et.al.

2024-01-22 Thread Andrew Cagney
On Mon, 22 Jan 2024 at 19:40, Paul Wouters wrote: > > On Mon, 22 Jan 2024, Andrew Cagney wrote: > > > commit b575e15e80bcf0924bc96e3e7420092becedc42a > > Author: Andrew Cagney > > Date: Mon Jan 22 13:32:01 2024 -0500 > > > >Reapply "pluto: warn if loaded connection ended up unoriented"

[Swan-dev] On re-applying "pluto: warn if loaded connection ended up unoriented" et.al.

2024-01-22 Thread Paul Wouters
On Mon, 22 Jan 2024, Andrew Cagney wrote: commit b575e15e80bcf0924bc96e3e7420092becedc42a Author: Andrew Cagney Date: Mon Jan 22 13:32:01 2024 -0500 Reapply "pluto: warn if loaded connection ended up unoriented" et.al. Log failed orient() during connection load using RC_LOG and not