Re: [Swan-dev] WIP: supporting xfrm SA expire

2022-07-04 Thread Paul Wouters
On Mon, 4 Jul 2022, Antony Antony wrote: I worked a bit more on sa-expire branch and rebaseed it to the latest main. The github PR is updated. Are there any other feedback? Looking at the branch now, it shows many commits from 10 hours ago and not additional commits to the previous state.

Re: [Swan-dev] WIP: supporting xfrm SA expire

2022-07-04 Thread Antony Antony
I worked a bit more on sa-expire branch and rebaseed it to the latest main. The github PR is updated. Last two commits on the lateset PR are for pluto to use re-factored function to calculate IKEv1 and IKEv2 margins. Added more robust fping when a kernel SA hard expire SA and reconnect

Re: [Swan-dev] WIP: supporting xfrm SA expire

2022-06-26 Thread Paul Wouters
On Jun 26, 2022, at 18:35, Antony Antony wrote: > > On Fri, Jun 24, 2022 at 02:22:14PM -0400, Paul Wouters wrote: >>> On Tue, 21 Jun 2022, Antony Antony wrote: >>> >>> Hi Paul, >>> Here is a new iteration sa-expire branch. I cherry picked changes from >>>

Re: [Swan-dev] WIP: supporting xfrm SA expire

2022-06-26 Thread Antony Antony
On Fri, Jun 24, 2022 at 02:22:14PM -0400, Paul Wouters wrote: > On Tue, 21 Jun 2022, Antony Antony wrote: > > > Hi Paul, > > Here is a new iteration sa-expire branch. I cherry picked changes from > > https://github.com/paulwouters/libreswan/tree/sa-expire-2022-01-06 > > > > and rebased to

Re: [Swan-dev] WIP: supporting xfrm SA expire

2022-06-24 Thread Paul Wouters
On Tue, 21 Jun 2022, Antony Antony wrote: Hi Paul, Here is a new iteration sa-expire branch. I cherry picked changes from https://github.com/paulwouters/libreswan/tree/sa-expire-2022-01-06 and rebased to origin/main. I have created a PR to make it easy to review my branch.

Re: [Swan-dev] WIP: supporting xfrm SA expire

2022-06-21 Thread Antony Antony
Hi Paul, Here is a new iteration sa-expire branch. I cherry picked changes from https://github.com/paulwouters/libreswan/tree/sa-expire-2022-01-06 and rebased to origin/main. I have created a PR to make it easy to review my branch. https://github.com/libreswan/libreswan/pull/777 I ignored ""

Re: [Swan-dev] WIP: supporting xfrm SA expire

2021-12-07 Thread Antony Antony
I have rebased the branches a couple days ago. minor fixes to ignore acquire SA expire. GiB...EiB support. On Sun, Nov 28, 2021 at 05:21:36PM -0500, Paul Wouters wrote: > On Nov 27, 2021, at 14:03, Antony Antony wrote: > > > > Hi, > > I rebased this branch and improved expire handling. > > >

Re: [Swan-dev] WIP: supporting xfrm SA expire

2021-12-01 Thread Andrew Cagney
On Wed, 1 Dec 2021 at 14:49, Antony Antony wrote: > On Sat, Nov 27, 2021 at 07:23:00PM -0500, Andrew Cagney wrote: > > > > > > One thing decide as group is how to represent big number (2^64) > bytes > > and > > packets, especially the default 2^64 will appear in "ipsec >

Re: [Swan-dev] WIP: supporting xfrm SA expire

2021-12-01 Thread Antony Antony
On Sat, Nov 27, 2021 at 07:23:00PM -0500, Andrew Cagney wrote: > > > One thing decide as group is how to represent big number (2^64) bytes > and > packets, especially the default 2^64  will appear in "ipsec status:  > output. >  18446744073709551615 look

Re: [Swan-dev] WIP: supporting xfrm SA expire

2021-11-28 Thread Paul Wouters
On Nov 27, 2021, at 14:03, Antony Antony wrote: > > Hi, > I rebased this branch and improved expire handling. > > #sa-expire or #sa-expire-20211127 > https://github.com/antonyantony/libreswan/tree/sa-expire Awesome. I will have a look. > I renamed keywords to salifebytes= salifepackets=

Re: [Swan-dev] WIP: supporting xfrm SA expire

2021-11-27 Thread Andrew Cagney
> > >> >> One thing decide as group is how to represent big number (2^64) bytes and >> packets, especially the default 2^64 will appear in "ipsec status: >> output. >> 18446744073709551615 look ugly:) > > > There's readable_humber() but that would need work. > Conversely is there something to

Re: [Swan-dev] WIP: supporting xfrm SA expire

2021-11-27 Thread Andrew Cagney
On Sat, 27 Nov 2021 at 14:04, Antony Antony wrote: > Hi, > I rebased this branch and improved expire handling. > > #sa-expire or #sa-expire-20211127 > https://github.com/antonyantony/libreswan/tree/sa-expire > > I renamed keywords to salifebytes= salifepackets= > > added few basic checks to

Re: [Swan-dev] WIP: supporting xfrm SA expire

2021-11-27 Thread Antony Antony
Hi, I rebased this branch and improved expire handling. #sa-expire or #sa-expire-20211127 https://github.com/antonyantony/libreswan/tree/sa-expire I renamed keywords to salifebytes= salifepackets= added few basic checks to avoid corner cases those netlink calls will return error: - do not

Re: [Swan-dev] WIP: supporting xfrm SA expire

2021-04-06 Thread Paul Wouters
On Tue, 6 Apr 2021, Antony Antony wrote: I noticed you used salifebytes= and salifepackets=. I think it would be more intuitive to call these maxbytes= and maxpackets. Or limit-bytes= or bytelimit= and packet-limit= ? given that we have "salifetime" for IPsec and "lifetime" from IKE I feel

Re: [Swan-dev] WIP: supporting xfrm SA expire

2021-04-06 Thread Andrew Cagney
On Tue, 6 Apr 2021 at 11:51, Antony Antony wrote: > On Mon, Apr 05, 2021 at 01:22:39PM -0400, Paul Wouters wrote: > > On Mon, 5 Apr 2021, Antony Antony wrote: > > > > > Here is my sa expire branch rebased to main. > > > > > > #sa-expire > > >

Re: [Swan-dev] WIP: supporting xfrm SA expire

2021-04-06 Thread Antony Antony
On Mon, Apr 05, 2021 at 01:22:39PM -0400, Paul Wouters wrote: > On Mon, 5 Apr 2021, Antony Antony wrote: > > > Here is my sa expire branch rebased to main. > > > > #sa-expire > > https://github.com/antonyantony/libreswan/tree/sa-expire > > Thanks! I had a look and I think it looks pretty good.

Re: [Swan-dev] WIP: supporting xfrm SA expire

2021-04-05 Thread Paul Wouters
On Mon, 5 Apr 2021, Paul Wouters wrote: I noticed you used salifebytes= and salifepackets=. I'm still working with these for now. Since I'm adding code for deleting an IPsec SA when hard timer hits, I also have a need to ignore a hard timer when testing, so I created two new impair values

Re: [Swan-dev] WIP: supporting xfrm SA expire

2021-04-05 Thread Paul Wouters
On Mon, 5 Apr 2021, Antony Antony wrote: Here is my sa expire branch rebased to main. #sa-expire https://github.com/antonyantony/libreswan/tree/sa-expire Thanks! I had a look and I think it looks pretty good. It need a bit more work to merge to main. I look the code again and fix "FIXME".

[Swan-dev] WIP: supporting xfrm SA expire

2021-04-04 Thread Antony Antony
Hi Paul, Here is my sa expire branch rebased to main. #sa-expire https://github.com/antonyantony/libreswan/tree/sa-expire It need a bit more work to merge to main. I look the code again and fix "FIXME". It also need more tests. If you feel like helping add more tests. This would help to get