Re: [Swan-dev] libswan/ttoaddress.c: use getaddrinfo(3) instead of gethostbyname2(3)

2021-05-04 Thread Andrew Cagney
Just found another gotya. From the linux page: If service is NULL [which it is], then the port number of the returned socket addresses will be left uninitialized. so it might be prudent to have the sockaddr_to_address_port() function accept and ignore the port when it is NULL. (posix says a

Re: [Swan-dev] libswan/ttoaddress.c: use getaddrinfo(3) instead of gethostbyname2(3)

2021-05-04 Thread Andrew Cagney
On Tue, 4 May 2021 at 07:47, Andrew Cagney wrote: > Looking at the results that came in overnight > https://testing.libreswan.org/ > The core seems to be fixed. However, the results are still taking a > sizable hit; how does that compare to your local results? > It looks like there's more

Re: [Swan-dev] libswan/ttoaddress.c: use getaddrinfo(3) instead of gethostbyname2(3)

2021-05-04 Thread Andrew Cagney
Looking at the results that came in overnight https://testing.libreswan.org/ The core seems to be fixed. However, the results are still taking a sizable hit; how does that compare to your local results? Any ideas on fixing that function's portability? On Tue, 4 May 2021 at 00:23, D. Hugh

Re: [Swan-dev] libswan/ttoaddress.c: use getaddrinfo(3) instead of gethostbyname2(3)

2021-05-03 Thread D. Hugh Redelmeier
| From: Andrew Cagney | FYI, | https://testing.libreswan.org/v4.4-73-g379929c054-main/ikev2-ddns-03/OUTPUT/west.console.diff Thanks. Could you see if my latest commit fixes the problem. ___ Swan-dev mailing list Swan-dev@lists.libreswan.org

Re: [Swan-dev] libswan/ttoaddress.c: use getaddrinfo(3) instead of gethostbyname2(3)

2021-05-03 Thread Andrew Cagney
FYI, https://testing.libreswan.org/v4.4-73-g379929c054-main/ikev2-ddns-03/OUTPUT/west.console.diff On Mon, 3 May 2021 at 16:27, Andrew Cagney wrote: > > > On Mon, 3 May 2021 at 15:42, D. Hugh Redelmeier wrote: > >> | From: Andrew Cagney >> >> | On Mon, 3 May 2021 at 13:54, D. Hugh Redelmeier

Re: [Swan-dev] libswan/ttoaddress.c: use getaddrinfo(3) instead of gethostbyname2(3)

2021-05-03 Thread Andrew Cagney
On Mon, 3 May 2021 at 15:42, D. Hugh Redelmeier wrote: > | From: Andrew Cagney > > | On Mon, 3 May 2021 at 13:54, D. Hugh Redelmeier > > | wrote: > | > | > commit 379929c054bbe6022abbc456f5c1fd9bd453470d > > | > We always accept the first result from getaddrinfo(3). This may > | >

Re: [Swan-dev] libswan/ttoaddress.c: use getaddrinfo(3) instead of gethostbyname2(3)

2021-05-03 Thread D. Hugh Redelmeier
| From: Andrew Cagney | On Mon, 3 May 2021 at 13:54, D. Hugh Redelmeier | wrote: | | > commit 379929c054bbe6022abbc456f5c1fd9bd453470d | > We always accept the first result from getaddrinfo(3). This may | > change prioritization of IPv4 vs IPv6, but at least it matches RFC | >

[Swan-dev] libswan/ttoaddress.c: use getaddrinfo(3) instead of gethostbyname2(3)

2021-05-03 Thread Andrew Cagney
On Mon, 3 May 2021 at 13:54, D. Hugh Redelmeier wrote: > New commits: > commit 379929c054bbe6022abbc456f5c1fd9bd453470d > Author: D. Hugh Redelmeier > Date: Mon May 3 12:37:40 2021 -0400 > > libswan/ttoaddress.c: use getaddrinfo(3) instead of gethostbyname2(3) > > Modernization. Much