Re: [Swan-dev] puzzled by TS code Coverity flagged

2022-12-21 Thread Andrew Cagney
On Wed, 21 Dec 2022 at 03:26, D. Hugh Redelmeier wrote: > > Coverity flags an uninitialized scalar value in ikev2_ts.c. > > The scalar in question is verify_rekey_child_request_ts()'s "best". > > Part of best seems to be initialized by calls to fit_tsp_to_end > but only some paths through the

[Swan-dev] puzzled by TS code Coverity flagged

2022-12-21 Thread D. Hugh Redelmeier
Coverity flags an uninitialized scalar value in ikev2_ts.c. The scalar in question is verify_rekey_child_request_ts()'s "best". Part of best seems to be initialized by calls to fit_tsp_to_end but only some paths through the function initialize. The bool result returned does not actually