Re: [Swan-dev] why I added a consistency check to pbs_in_struct

2021-05-08 Thread Andrew Cagney
On Sat, 8 May 2021 at 15:33, D. Hugh Redelmeier wrote: > | From: Andrew Cagney > > | The old behavior was that a NULL implied that the nested struct, if any, > | could be ignored. I'd call that obvious behaviour. > | (passing a pbs when not needed was benign). > > That's not what the contract

Re: [Swan-dev] why I added a consistency check to pbs_in_struct

2021-05-08 Thread D. Hugh Redelmeier
| From: Andrew Cagney | The old behavior was that a NULL implied that the nested struct, if any, | could be ignored. I'd call that obvious behaviour. | (passing a pbs when not needed was benign). That's not what the contract said. Ever. | Now, if this is done wrong, and on a rarely executed

Re: [Swan-dev] why I added a consistency check to pbs_in_struct

2021-05-08 Thread Andrew Cagney
On Sat, 8 May 2021 at 12:27, D. Hugh Redelmeier wrote: > | commit 9945236619b17fa13dfd1cfbe60359dcbf3fcd21 > | Author: D. Hugh Redelmeier > | Date: Fri May 7 23:58:52 2021 -0400 > | > | pluto: packet.c: add consistency check to pbs_in_struct > | > | pbs_in_struct now requires that if

[Swan-dev] why I added a consistency check to pbs_in_struct

2021-05-08 Thread D. Hugh Redelmeier
| commit 9945236619b17fa13dfd1cfbe60359dcbf3fcd21 | Author: D. Hugh Redelmeier | Date: Fri May 7 23:58:52 2021 -0400 | | pluto: packet.c: add consistency check to pbs_in_struct | | pbs_in_struct now requires that if and only if the structure has a | length field then the