[systemd-devel] [bug] (char*)NULL should be used in variadic functions

2013-01-30 Thread Vasily Kulikov
Hi, systemd uses plain NULL as an argument of variadic functions, which is a UB in C. (char*)NULL should be used instead. Plain NULL may be defined as 0 or smth. From C99: 6.3.2.3 Pointers ... 3 An integer constant expression with the value 0, or such an expression cast to type void *, is

Re: [systemd-devel] [bug] (char*)NULL should be used in variadic functions

2013-01-30 Thread Jan Engelhardt
On Wednesday 2013-01-30 08:07, Vasily Kulikov wrote: Hi, systemd uses plain NULL as an argument of variadic functions, which is a UB in C. The mere use of NULL in variadic functions is not UB. If anything, calling va_arg(argp, char *) for something that is actually not a char * might, though.

Re: [systemd-devel] Simple question.

2013-01-30 Thread Daniel J Walsh
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/26/2013 08:07 PM, David Strauss wrote: On Fri, Jan 25, 2013 at 12:42 PM, Mantas Mikulėnas graw...@gmail.com wrote: That some users may want to take advantage of modern Linux features and run httpd without *ever* giving it full root

[systemd-devel] build failures in latest master from d848b9cbfa0ba72381363accce481600169df2eb

2013-01-30 Thread Colin Walters
In gnome-ostree (tracking systemd git master), the first failure is the recent commit: commit d848b9cbfa0ba72381363accce481600169df2eb Author: Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl Date: Sun Jan 27 19:44:52 2013 -0500 Move generic specifier functions to shared No

Re: [systemd-devel] build failures in latest master from d848b9cbfa0ba72381363accce481600169df2eb

2013-01-30 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 30, 2013 at 04:30:39PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Jan 30, 2013 at 08:50:09AM -0500, Colin Walters wrote: In gnome-ostree (tracking systemd git master), the first failure is the recent commit: commit d848b9cbfa0ba72381363accce481600169df2eb Author:

Re: [systemd-devel] InaccessibleDirectories and non-existing dirs

2013-01-30 Thread Colin Guthrie
'Twas brillig, and Reindl Harald at 30/01/13 15:34 did gyre and gimble: systemd-197-1.fc18.2.x86_64 i try to make a generic list with folders which are never supposed to be access from httpd - but if you list here a non-existing directory httpd.service fails completly to start - as i can

Re: [systemd-devel] [PATCH] systemctl: Fix wrong assertion test

2013-01-30 Thread Dave Reisner
On Wed, Jan 30, 2013 at 04:55:24PM -0200, Mauro Dreissig wrote: --- src/systemctl/systemctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 408a4f0..5deacbf 100644 --- a/src/systemctl/systemctl.c +++

Re: [systemd-devel] [PATCH] systemctl: Fix wrong assertion test

2013-01-30 Thread Mauro Dreissig
On 01/30/2013 05:06 PM, Dave Reisner wrote: On Wed, Jan 30, 2013 at 04:55:24PM -0200, Mauro Dreissig wrote: --- src/systemctl/systemctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 408a4f0..5deacbf 100644

[systemd-devel] tests

2013-01-30 Thread Daniel Buch
I did some improvements on strv-test.c and added additional test, more is on its way. Patch files is attached. What do you think? 0001-test-strv.c-Split-tests-into-seperate-functions.patch Description: Binary data 0002-test-strv.c-test-strv_join-added.patch Description: Binary data

Re: [systemd-devel] tests

2013-01-30 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 30, 2013 at 10:18:46PM +0100, Daniel Buch wrote: I did some improvements on strv-test.c and added additional test, more is on its way. Patch files is attached. What do you think? Hi, more tests are usually good ;) Applied. In the future, try using _cleanup_free_, and please