Re: [systemd-devel] [PATCH 6/8] add GOP mode setting and splash drawing support

2013-12-10 Thread Joonas Lahtinen
On 10.12.2013 10:03, Greg KH wrote: On Tue, Dec 10, 2013 at 09:50:58AM +0200, Joonas Lahtinen wrote: Add support for two new configuration directives gfxmode and splash which respectively allow setting the screen graphics mode and drawing splash image during gummiboot execution. See README.gop

[systemd-devel] [PATCH] man: improve wording and comma usage in systemd.journal-fields(7)

2013-12-10 Thread Jason St. John
Improve wording under Description and _KERNEL_DEVICE= Signed-off-by: Jason St. John jstj...@purdue.edu --- man/systemd.journal-fields.xml | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/man/systemd.journal-fields.xml b/man/systemd.journal-fields.xml index

Re: [systemd-devel] [PATCH] libsystemd-bus: Clean up code

2013-12-10 Thread Lukasz Skalski
On 12/10/2013 05:24 AM, Zbigniew Jędrzejewski-Szmek wrote: On Mon, Dec 09, 2013 at 09:22:43PM +0100, Thomas H.P. Andersen wrote: If I understood correctly then the assert_return was meant to be used only on the public library functions. I can't seem to find the reference to it so maybe I am

[systemd-devel] [PATCH v2 0/8] GOP display initialization and splash screen drawing

2013-12-10 Thread Joonas Lahtinen
Hi, This set of patches is meant to replace the previous one that got broken due to Thunderbird mangling. No other changes. Sorry for the unnecessary traffic. Regards, Joonas -- Joonas Lahtinen (8): add source format modeline Makefile.am: be consistent defining sources add atoi function

[systemd-devel] [PATCH v2 3/8] add atoi function

2013-12-10 Thread Joonas Lahtinen
Add generic purpose number parsing function to be used by modeline parsing. Signed-off-by: Joonas Lahtinen joonas.lahti...@linux.intel.com Reviewed-by: Darren Hart dvh...@linux.intel.com Reviewed-by: Mikko Ylinen mikko.yli...@intel.com --- src/efi/gummiboot.c | 26 ++ 1

[systemd-devel] [PATCH v2 4/8] make file_read callable outside compilation unit

2013-12-10 Thread Joonas Lahtinen
Make file_read usable from other compilation units allowing reuse of code when splitting functionality to multiple files. Signed-off-by: Joonas Lahtinen joonas.lahti...@linux.intel.com Reviewed-by: Darren Hart dvh...@linux.intel.com Reviewed-by: Mikko Ylinen mikko.yli...@intel.com ---

[systemd-devel] [PATCH v2 2/8] Makefile.am: be consistent defining sources

2013-12-10 Thread Joonas Lahtinen
Be consistent with other source file definitions. Signed-off-by: Joonas Lahtinen joonas.lahti...@linux.intel.com Reviewed-by: Mikko Ylinen mikko.yli...@intel.com Acked-by: Darren Hart dvh...@linux.intel.com --- Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[systemd-devel] [PATCH v2 1/8] add source format modeline

2013-12-10 Thread Joonas Lahtinen
For easier editing, add source format modeline similar to other files. Signed-off-by: Joonas Lahtinen joonas.lahti...@linux.intel.com Reviewed-by: Mikko Ylinen mikko.yli...@intel.com Acked-by: Darren Hart dvh...@linux.intel.com --- src/efi/gummiboot.c | 2 ++ 1 file changed, 2 insertions(+)

[systemd-devel] [PATCH v2 6/8] add GOP mode setting and splash drawing support

2013-12-10 Thread Joonas Lahtinen
Add support for two new configuration directives gfxmode and splash which respectively allow setting the screen graphics mode and drawing splash image during gummiboot execution. See README.gop for more details. Signed-off-by: Joonas Lahtinen joonas.lahti...@linux.intel.com Reviewed-by: Mikko

[systemd-devel] [PATCH v2 5/8] make console_text_mode into more generic function

2013-12-10 Thread Joonas Lahtinen
Convert console_text_mode function into console_mode function which is able to switch back and forth between graphics and text mode. Signed-off-by: Joonas Lahtinen joonas.lahti...@linux.intel.com Reviewed-by: Darren Hart dvh...@linux.intel.com Reviewed-by: Mikko Ylinen mikko.yli...@intel.com ---

[systemd-devel] [PATCH v2 7/8] add ppm2bgrx utility

2013-12-10 Thread Joonas Lahtinen
Add utility to convert 8-bit PPM files into UEFI GOP supported BGRX files to be used as splash screens. Signed-off-by: Joonas Lahtinen joonas.lahti...@linux.intel.com Reviewed-by: Mikko Ylinen mikko.yli...@intel.com Acked-by: Darren Hart dvh...@linux.intel.com --- .gitignore | 1 +

Re: [systemd-devel] [PATCH] man: improve wording and comma usage in systemd.journal-fields(7)

2013-12-10 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 10, 2013 at 12:10:03AM -0500, Jason St. John wrote: Improve wording under Description and _KERNEL_DEVICE= Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

[systemd-devel] Logging in an enterprise environment

2013-12-10 Thread Cecil Westerhof
After giving a presentation about systemd/journald I am seen as the expert, so they come to me with the challenges they see. As I understand it, journald is mend to log locally. Two methods to log centrally are, if I have understand it correctly: - mounting and merging through NFS -

Re: [systemd-devel] [PATCH v3 01/26] dhcp: Add DHCP protocol structures and initial defines

2013-12-10 Thread Patrik Flykt
On Tue, 2013-12-10 at 02:46 +0100, Lennart Poettering wrote: +uint32_t ciaddr; +uint32_t yiaddr; +uint32_t siaddr; +uint32_t giaddr; Hmmm, why uin32_t? Shouldn't this be32_t? THis is network byte order, right? which is just synoymous to big endian...

Re: [systemd-devel] [PATCH 1/2] Use heap allocation for stdout journald buffer

2013-12-10 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Dec 08, 2013 at 11:32:33AM -0600, Dan McGee wrote: -l = read(s-fd, s-buffer+s-length, sizeof(s-buffer)-1-s-length); +l = read(s-fd, s-buffer+s-length, s-size-1-s-length); Please add some spaces here around + and - operators. if (l 0) {

Re: [systemd-devel] Logging in an enterprise environment

2013-12-10 Thread Holger Winkelmann [TP]
Hi Cecil, - Original Message - After giving a presentation about systemd/journald I am seen as the expert, so they come to me with the challenges they see. As I understand it, journald is mend to log locally. Two methods to log centrally are, if I have understand it correctly: -

Re: [systemd-devel] [PATCH] update README to not suggest that systemd works without procfs

2013-12-10 Thread Zbigniew Jędrzejewski-Szmek
Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] Ensure unit is journaled for short-lived or oneshot processes

2013-12-10 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Dec 08, 2013 at 11:46:09AM -0800, David Timothy Strauss wrote: How reliable is the unit_id data this falls back to? If it's going into an underscore-prefixed field in the journal, we need confidence that it's not forgeable. It is only trusted if it is comming from uid=0 process. We

Re: [systemd-devel] [PATCH] Bring bootchart code in line with CODING_STYLE

2013-12-10 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Dec 08, 2013 at 11:27:06AM -0600, Dan McGee wrote: Use double and not float, as there is little to no benefit. True. Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

Re: [systemd-devel] [PATCH] fix scan-build issues

2013-12-10 Thread Thomas H.P. Andersen
On Tue, Dec 10, 2013 at 5:37 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Mon, Dec 09, 2013 at 09:01:08PM +0100, Thomas H.P. Andersen wrote: From: Thomas Hindoe Paaboel Andersen pho...@gmail.com The static analyzer scan-build had a few issues with analysing parts of systemd.

Re: [systemd-devel] [PATCH] test: rework run_qemu

2013-12-10 Thread Zbigniew Jędrzejewski-Szmek
Applied. On Tue, Dec 10, 2013 at 08:23:50AM +0530, Tom Gundersen wrote: On 10 Dec 2013 02:44, Ronny Chevalier chevalier.ro...@gmail.com wrote: Do we really want to add a compat for several distributions ? Because why not Archlinux, Ubuntu,... too ? Maybe just use the path created by our

Re: [systemd-devel] [PATCH] fix scan-build issues

2013-12-10 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 10, 2013 at 01:44:02PM +0100, Thomas H.P. Andersen wrote: Makefile.am: Moved some -D's from CFLAGS to CPPFLAGS. I also simplified them a bit and got rid of a left over DBUS_CFLAGS. I think that this breaks compilation if the directory has spaces in the name. Not a big deal,

Re: [systemd-devel] [PATCH] test: fix TEST-02-CRYPTSETUP

2013-12-10 Thread Zbigniew Jędrzejewski-Szmek
Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH v3 01/26] dhcp: Add DHCP protocol structures and initial defines

2013-12-10 Thread Tom Gundersen
On 10 Dec 2013 17:45, Patrik Flykt patrik.fl...@linux.intel.com wrote: On Tue, 2013-12-10 at 02:46 +0100, Lennart Poettering wrote: +uint32_t ciaddr; +uint32_t yiaddr; +uint32_t siaddr; +uint32_t giaddr; Hmmm, why uin32_t? Shouldn't this be32_t?

Re: [systemd-devel] [PATCH v3 01/26] dhcp: Add DHCP protocol structures and initial defines

2013-12-10 Thread Lennart Poettering
On Tue, 10.12.13 14:15, Patrik Flykt (patrik.fl...@linux.intel.com) wrote: On Tue, 2013-12-10 at 02:46 +0100, Lennart Poettering wrote: +uint32_t ciaddr; +uint32_t yiaddr; +uint32_t siaddr; +uint32_t giaddr; Hmmm, why uin32_t? Shouldn't this

Re: [systemd-devel] [PATCH v3 01/26] dhcp: Add DHCP protocol structures and initial defines

2013-12-10 Thread Marcel Holtmann
Hi Lennart, +uint32_t ciaddr; +uint32_t yiaddr; +uint32_t siaddr; +uint32_t giaddr; Hmmm, why uin32_t? Shouldn't this be32_t? THis is network byte order, right? which is just synoymous to big endian... Or even, if you now use struct in_addr elsewhere

Re: [systemd-devel] Setting low-level cgroups attributes in systemd

2013-12-10 Thread Lennart Poettering
On Mon, 09.12.13 10:31, Joe Miller (jo...@joeym.net) wrote: It appears that the .slice changed described here[1] removed all ability to set low-level cgroups settings, is that correct? Yes, that is correct. With the new code only attributes that systemd understands can be set, nothing else.

[systemd-devel] [PATCH] core/manager: remove infinite loop

2013-12-10 Thread Shawn Landden
--- src/core/manager.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/core/manager.c b/src/core/manager.c index f06df54..c25343f 100644 --- a/src/core/manager.c +++ b/src/core/manager.c @@ -2211,10 +2211,8 @@ int manager_deserialize(Manager *m, FILE *f, FDSet *fds) {

Re: [systemd-devel] [PATCH v3 01/26] dhcp: Add DHCP protocol structures and initial defines

2013-12-10 Thread Lennart Poettering
On Tue, 10.12.13 18:12, Marcel Holtmann (mar...@holtmann.org) wrote: Hi Lennart, +uint32_t ciaddr; +uint32_t yiaddr; +uint32_t siaddr; +uint32_t giaddr; Hmmm, why uin32_t? Shouldn't this be32_t? THis is network byte order, right? which is just

Re: [systemd-devel] systemd session mode

2013-12-10 Thread Kok, Auke-jan H
On Sun, Dec 1, 2013 at 12:33 PM, Kay Sievers k...@vrfy.org wrote: On Sun, Dec 1, 2013 at 8:25 PM, Hristo Venev hri...@venev.name wrote: I've implemented session mode for systemd. I am currently using it and it works pretty okay. I just had to generate D-Bus user services for D-Bus activation

Re: [systemd-devel] Re:Re: How to use systemctl preset ?

2013-12-10 Thread Lennart Poettering
On Mon, 09.12.13 03:21, Tony Seo (tonys...@gmail.com) wrote: Thanks your answer, Andrey. But what is remove policy, I can't understand what you mean. Would you plz explain more abou it? I already added all units which I'd like to disable in 00-first.preset file. 00-first.preset

Re: [systemd-devel] Setting low-level cgroups attributes in systemd

2013-12-10 Thread Joe Miller
Understood. Thank you for the explanation. I'm not familiar with the cgroup rework being done so I don't have any ideas or opinion on that at the moment. I was not aware of %c. It sounds like that might be a reasonable and simple workaround for now. thanks On Tue, Dec 10, 2013 at 9:24 AM,

Re: [systemd-devel] [PATCH] core/manager: remove infinite loop

2013-12-10 Thread Lennart Poettering
On Tue, 10.12.13 09:28, Shawn Landden (sh...@churchofgit.com) wrote: Ouch! Thanks! Applied! --- src/core/manager.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/core/manager.c b/src/core/manager.c index f06df54..c25343f 100644 --- a/src/core/manager.c +++

Re: [systemd-devel] Logging in an enterprise environment

2013-12-10 Thread Lennart Poettering
On Tue, 10.12.13 12:16, Cecil Westerhof (cecil.wester...@snow.nl) wrote: After giving a presentation about systemd/journald I am seen as the expert, so they come to me with the challenges they see. As I understand it, journald is mend to log locally. Two methods to log centrally are, if I

Re: [systemd-devel] user@.service doesn't stop on logout

2013-12-10 Thread Lennart Poettering
On Mon, 09.12.13 20:56, Thomas Bächler (tho...@archlinux.org) wrote: In systemd 208 and latest systemd git, every user gets a new user@.service instance when they login. However, when their last session exits, that service is not terminated. After a few weeks of uptime on one of my servers,

Re: [systemd-devel] [PATCH 2/2] journald: when buffering stdout, allow buffer to grow if needed

2013-12-10 Thread Lennart Poettering
On Tue, 10.12.13 13:22, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: Here is a brief test script that stresses the stdout capture. Run it through systemd-run and watch the CPU usage of the systemd-journal process before and after. #!/usr/bin/env python2 data = []

Re: [systemd-devel] udevadm settle takes too long to finish

2013-12-10 Thread Thomas Bächler
Am 10.12.2013 18:37, schrieb Lennart Poettering: What's the distribution you are using? Using udevadm settle for lvm is a waste of boot time and isn't even guaranteed to work (ask Lennart, Kay or Greg K-H for the full speech). It's a hackish workaround for LVM's inability to activate volumes

Re: [systemd-devel] user@.service doesn't stop on logout

2013-12-10 Thread Thomas Bächler
Am 10.12.2013 19:19, schrieb Lennart Poettering: That service should be reference counted by the sessions of the users logging in. I should hence go away if the users successfully log out from their last session. That sounds like the behaviour I would expect. Your screenshot shows the user

Re: [systemd-devel] File system gets remounted read-only after using nspawn

2013-12-10 Thread Lennart Poettering
On Thu, 05.12.13 17:26, Canek Peláez Valdés (can...@gmail.com) wrote: Hi; I've been playing with systemd-nspawn with Gentoo. I'm running systemd 208, and the normal Gentoo stage3 image [1], installing systemd 204 inside it. Everything works great, but for some reason after powering off the

Re: [systemd-devel] File system gets remounted read-only after using nspawn

2013-12-10 Thread Lennart Poettering
On Sat, 07.12.13 23:56, Colin Guthrie (gm...@colin.guthr.ie) wrote: 'Twas brillig, and Canek Peláez Valdés at 05/12/13 23:26 did gyre and gimble: Hi; I've been playing with systemd-nspawn with Gentoo. I'm running systemd 208, and the normal Gentoo stage3 image [1], installing systemd 204

[systemd-devel] reexec fails in latest git

2013-12-10 Thread Dave Reisner
'systemctl daemon-reexec' fails on recent builds at HEAD. A second reexec successfully reconnects to the bus. Relevant bits from the journal: first reexec Dec 10 12:01:04 rampage systemd[1]: Reexecuting. Dec 10 12:01:04 rampage systemd[1]: systemd 208 running in system mode Dec 10

Re: [systemd-devel] [PATCH] systemd: always start jobs for units in SYSTEMD_WANTS=

2013-12-10 Thread Lennart Poettering
On Mon, 09.12.13 00:33, Lennart Poettering (lenn...@poettering.net) wrote: On Sat, 07.12.13 00:35, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: Before they would only be started when the unit transitioned from inactive to active state. Now, they will be started also on other

Re: [systemd-devel] user@.service doesn't stop on logout

2013-12-10 Thread Lennart Poettering
On Tue, 10.12.13 19:30, Thomas Bächler (tho...@archlinux.org) wrote: Am 10.12.2013 19:19, schrieb Lennart Poettering: That service should be reference counted by the sessions of the users logging in. I should hence go away if the users successfully log out from their last session. That

Re: [systemd-devel] systemd unit review requested

2013-12-10 Thread Lennart Poettering
On Mon, 09.12.13 12:18, Peter Hutterer (peter.hutte...@who-t.net) wrote: On Fri, Dec 06, 2013 at 04:10:02PM +0100, Kay Sievers wrote: On Fri, Dec 6, 2013 at 7:20 AM, Peter Hutterer peter.hutte...@who-t.net wrote: It also depends on the wacom_w8001 and how it reacts when it's loaded

Re: [systemd-devel] [PATCH] libsystemd-bus: Add return error msg for unicast signals when well-known name is not available

2013-12-10 Thread Lennart Poettering
On Wed, 04.12.13 14:44, Lukasz Skalski (l.skal...@partner.samsung.com) wrote: ENXIO, ESRCH and EADDRNOTAVAIL are also returned by ioctl(KDBUS_CMD_MSG_SEND) when we have unicast signal messages (signals with a DESTINATION field). Well, but you cannot respond to signals. They are supposed to be

Re: [systemd-devel] udevadm settle takes too long to finish

2013-12-10 Thread Chris Murphy
On Dec 9, 2013, at 11:47 PM, Andrey Borzenkov arvidj...@gmail.com wrote: В Mon, 9 Dec 2013 12:42:21 -0700 Chris Murphy li...@colorremedies.com пишет: On Dec 9, 2013, at 3:33 AM, Thomas Bächler tho...@archlinux.org wrote: I'm finding that plymouth-start.service uses ExecStartPost= to

Re: [systemd-devel] [PATCH] libsystemd-bus: Clean up code

2013-12-10 Thread Lennart Poettering
On Tue, 10.12.13 18:33, Lennart Poettering (lenn...@poettering.net) wrote: On Tue, 10.12.13 05:24, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Mon, Dec 09, 2013 at 09:22:43PM +0100, Thomas H.P. Andersen wrote: If I understood correctly then the assert_return was meant to be

[systemd-devel] [PATCH] hashmap: Remove unused auxv variable

2013-12-10 Thread Marcel Holtmann
CC src/shared/hashmap.lo src/shared/hashmap.c: In function 'hashmap_new': src/shared/hashmap.c:188:15: warning: unused variable 'auxv' [-Wunused-variable] void *auxv; ^ --- src/shared/hashmap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/shared/hashmap.c

Re: [systemd-devel] [PATCH] hashmap: Remove unused auxv variable

2013-12-10 Thread Lennart Poettering
On Tue, 10.12.13 11:47, Marcel Holtmann (mar...@holtmann.org) wrote: CC src/shared/hashmap.lo src/shared/hashmap.c: In function 'hashmap_new': src/shared/hashmap.c:188:15: warning: unused variable 'auxv' [-Wunused-variable] void *auxv; ^ ---

Re: [systemd-devel] [PATCH] libsystemd-bus: trivial macro KDBUS_PART_HEADER_SIZE replace

2013-12-10 Thread Lennart Poettering
On Wed, 04.12.13 15:28, Yin Kangkai (kangkai@intel.com) wrote: It's a little bit cleaner(?) to replace offsetof(struct kdbus_item, data) with KDBUS_PART_HEADER_SIZE. Hmm, is this really cleaner? I kinda like using offsetof() for this, since it explains less opaquely what we are putting

Re: [systemd-devel] [PATCH 2/7] Give the user permissions to their session's cgroup

2013-12-10 Thread Lennart Poettering
On Sun, 01.12.13 23:15, Hristo Venev (hri...@venev.name) wrote: See systemd src/core/execute.c:1299-1312, especially lines 1300 and 1307. Kay is wrong here. You are right. We do delegate access to the cgroup tree to user instances of systemd, as well as to systemd instances in containers.

Re: [systemd-devel] [PATCH] libsystemd-bus: Add return error msg for unicast signals when well-known name is not available

2013-12-10 Thread Lukasz Skalski
On 12/10/2013 08:24 PM, Lennart Poettering wrote: On Wed, 04.12.13 14:44, Lukasz Skalski (l.skal...@partner.samsung.com) wrote: ENXIO, ESRCH and EADDRNOTAVAIL are also returned by ioctl(KDBUS_CMD_MSG_SEND) when we have unicast signal messages (signals with a DESTINATION field). Well, but you

Re: [systemd-devel] [PATCH 2/2] tests: Add test-bus-kernel-monitor

2013-12-10 Thread Lennart Poettering
On Tue, 03.12.13 15:17, Lukasz Skalski (l.skal...@partner.samsung.com) wrote: test-bus-kernel-monitor is very simple program used to monitor all messages/signals going through a kdbus message bus. It allows monitor an arbitrary kernel bus given at --bus_path parameter and also monitor system

Re: [systemd-devel] [PATCH] libsystemd-bus: Add return error msg for unicast signals when well-known name is not available

2013-12-10 Thread Lennart Poettering
On Tue, 10.12.13 21:27, Lukasz Skalski (lukasz.skal...@op.pl) wrote: On 12/10/2013 08:24 PM, Lennart Poettering wrote: On Wed, 04.12.13 14:44, Lukasz Skalski (l.skal...@partner.samsung.com) wrote: ENXIO, ESRCH and EADDRNOTAVAIL are also returned by ioctl(KDBUS_CMD_MSG_SEND) when we have

Re: [systemd-devel] [PATCH 2/7] Give the user permissions to their session's cgroup

2013-12-10 Thread Lennart Poettering
On Sun, 01.12.13 21:25, Hristo Venev (hri...@venev.name) wrote: User is given permissions to their user@*.service cgroup so that user mode systemd can run. session-*.scope cgroup permissions are required for session mode. Passing ownership to the cgroup tree is explicitly something that we

Re: [systemd-devel] Logging in an enterprise environment

2013-12-10 Thread David Timothy Strauss
We currently use journal2gelf [1], which we also have a rewrite of that uses the native Python bindings to the journal. We're probably dumping our rewrite and adding journal integration to Beaver [2]. [1] https://github.com/systemd/journal2gelf [2] https://github.com/clifton/beaver

Re: [systemd-devel] script assigned via Unit's ExecStartPre= only partially executes, fails to complete ?

2013-12-10 Thread Lennart Poettering
On Sun, 01.12.13 00:10, jen...@promessage.com (jen...@promessage.com) wrote: I'm using an openvpn unit, cat openvpn.service [Unit] Description=OpenVPN After=syslog.target network.target Before=openvpn.target

Re: [systemd-devel] script assigned via Unit's ExecStartPre= only partially executes, fails to complete ?

2013-12-10 Thread jen142
I am not sure what thos openvpn calls do. If they fork something in the background, please be aware that systemd will kill that before proceeding. Simply (re)create the tunnel device Maybe there's a race bewteen the openvpn and iptables commands in that the interfaces are not finished

Re: [systemd-devel] [PATCH] libsystemd-bus: Add return error msg for unicast signals when well-known name is not available

2013-12-10 Thread Lukasz Skalski
On 12/10/2013 09:42 PM, Lennart Poettering wrote: On Tue, 10.12.13 21:27, Lukasz Skalski (lukasz.skal...@op.pl) wrote: On 12/10/2013 08:24 PM, Lennart Poettering wrote: On Wed, 04.12.13 14:44, Lukasz Skalski (l.skal...@partner.samsung.com) wrote: ENXIO, ESRCH and EADDRNOTAVAIL are also

Re: [systemd-devel] user@.service doesn't stop on logout

2013-12-10 Thread Thomas Bächler
Am 10.12.2013 20:07, schrieb Lennart Poettering: The screenshot actually has the full output of 'loginctl user-status $user', which includes all open sessions of the user (in this case, none). I also verified with 'ps' that all processes by that user are gone, except the (sd-pam) and systemd

Re: [systemd-devel] Problem with LXC and systemd-gpt-auto-generator

2013-12-10 Thread Lennart Poettering
On Tue, 10.12.13 20:53, John Lane (syst...@jelmail.com) wrote: Good evening. I have noticed a problem on systemd 208. I get an odd error when trying to enable/disable: This should have been fixed with 9a5cb1371b6d8b0a04bd08665bcf9b06cb40c64c. That patch was commited after 208. Lennart --

Re: [systemd-devel] [PATCH 7/7] run: Support KillMode via --kill-mode=... flag

2013-12-10 Thread Lennart Poettering
On Sun, 01.12.13 21:25, Hristo Venev (hri...@venev.name) wrote: This sounds useful. Hmm, I wonder though whether we really should add more --foobar options for all the settings one can make in unit files. I think the more exotic it gets we should instead have a catch-all -o or so, which allows

Re: [systemd-devel] [PATCH 1/2] nspawn: --populate to run static binaries on empty target directory

2013-12-10 Thread Lennart Poettering
On Mon, 02.12.13 09:41, Shawn Landden (sh...@churchofgit.com) wrote: On Mon, Dec 2, 2013 at 8:27 AM, Lennart Poettering lenn...@poettering.net wrote: On Sat, 30.11.13 10:20, Shawn Landden (sh...@churchofgit.com) wrote: nspawn has been called chroot on steroids. Continue that

Re: [systemd-devel] [PATCH 1/2] core: support Distribute=n to distribute to n workers

2013-12-10 Thread Lennart Poettering
On Mon, 09.12.13 14:08, Shawn Landden (sh...@churchofgit.com) wrote: Until there are some use cases for Distribute= w/o SO_REUSEPORT make it imply that. Otherwise we need a new config_parse_distribute in load-fragment.c and gain the same issues of config_parse_syscall, where NoNewPrivs can

Re: [systemd-devel] [PATCH 2/2] epoll and signalfd has been moved into sd event loop

2013-12-10 Thread Lennart Poettering
On Mon, 09.12.13 14:08, Shawn Landden (sh...@churchofgit.com) wrote: Looks good. Committed! Thanks! --- src/core/manager.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/core/manager.c b/src/core/manager.c index f06df54..56c10cf 100644 --- a/src/core/manager.c +++

Re: [systemd-devel] udev rule not applied after resume from sleep

2013-12-10 Thread Kay Sievers
On Tue, Dec 10, 2013 at 11:59 PM, Jason A. Donenfeld ja...@zx2c4.com wrote: I hope this is the right list to ask about udev. I've got a lenovo usb keyboard with a trackpoint on it -- essentially an external replica of the classic thinkpad keyboard. The trackpoint by default isn't very

Re: [systemd-devel] udev rule not applied after resume from sleep

2013-12-10 Thread Lennart Poettering
On Tue, 10.12.13 23:59, Jason A. Donenfeld (ja...@zx2c4.com) wrote: Hi folks, I hope this is the right list to ask about udev. I've got a lenovo usb keyboard with a trackpoint on it -- essentially an external replica of the classic thinkpad keyboard. The trackpoint by default isn't very

Re: [systemd-devel] [HACK/RFC/PATCH] systemd-su: su on steroids

2013-12-10 Thread Lennart Poettering
On Mon, 02.12.13 21:47, David Herrmann (dh.herrm...@gmail.com) wrote: 4h later, I present systemd-su: If you want to give it a try, run: systemd-su -u david /bin/sh It requires the systemd-suexec helper internally, so if you didn't install it, use something like this:

Re: [systemd-devel] Question regarding the NotifyAccess parameter

2013-12-10 Thread Lennart Poettering
On Mon, 09.12.13 09:47, salil GK (gksa...@gmail.com) wrote: Hello did any body get a chance to look into this. I am a kind of stuck on this. I can work around using ExecStartPre script where I can kill the previous instances. But if systemd is capable to do it by itself, that would be

Re: [systemd-devel] [PATCH] core: fix Unit.SetProperties argument parsing

2013-12-10 Thread Lennart Poettering
On Mon, 02.12.13 23:26, David Herrmann (dh.herrm...@gmail.com) wrote: SetProperties has signature ba(sv), but the bus_unit_set_properties() helper already does a enter_container('a', sv) so we have to skip it in bus_unit_method_set_properties(). Indeed! Thanks for the pointer! Applied! ---

Re: [systemd-devel] [RFC] logind: introduce session positions

2013-12-10 Thread Lennart Poettering
On Sun, 01.12.13 12:43, David Herrmann (dh.herrm...@gmail.com) wrote: +static int method_switch_to(sd_bus *bus, sd_bus_message *message, void *userdata, sd_bus_error *error) { +Seat *s = userdata; +unsigned int to; +int r; + +assert(bus); +

Re: [systemd-devel] [RFC] logind: introduce session positions

2013-12-10 Thread Lennart Poettering
On Mon, 02.12.13 14:07, David Herrmann (dh.herrm...@gmail.com) wrote: Hi On Mon, Dec 2, 2013 at 10:57 AM, Colin Guthrie gm...@colin.guthr.ie wrote: 'Twas brillig, and David Herrmann at 01/12/13 11:43 did gyre and gimble: During session_load() or if two sessions have the same VTnr, we

Re: [systemd-devel] [RFC] logind: introduce session positions

2013-12-10 Thread Lennart Poettering
On Mon, 02.12.13 13:51, David Herrmann (dh.herrm...@gmail.com) wrote: This obviously isn't true for seats with VTs. There you can start multiple sessions on the same VT. However, this is strongly discouraged as systemd randomly chooses one session to be active then. I'd really prefer to have

Re: [systemd-devel] syslog makes impossible to enter emergency mode

2013-12-10 Thread Lennart Poettering
On Sat, 30.11.13 10:27, Andrey Borzenkov (arvidj...@gmail.com) wrote: В Tue, 26 Nov 2013 02:27:00 +0100 Lennart Poettering lenn...@poettering.net пишет: On Tue, 26.11.13 01:00, Lennart Poettering (lenn...@poettering.net) wrote: On Sun, 24.11.13 22:36, Andrey Borzenkov

Re: [systemd-devel] udev rule not applied after resume from sleep

2013-12-10 Thread Kay Sievers
On Wed, Dec 11, 2013 at 12:05 AM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 10.12.13 23:59, Jason A. Donenfeld (ja...@zx2c4.com) wrote: Hi folks, I hope this is the right list to ask about udev. I've got a lenovo usb keyboard with a trackpoint on it -- essentially an external

Re: [systemd-devel] Optionally save core dumps as plain files

2013-12-10 Thread Lennart Poettering
On Thu, 28.11.13 16:44, Umut Tezduyar Lindskog (umut.tezdu...@axis.com) wrote: Hi, I can’t find the last word on Oleksii’s coredump patch http://lists.freedesktop.org/archives/systemd-devel/2013-May/010991.html. Was there a decision about not taking it in? The patch is still in my queue of

Re: [systemd-devel] [RFC 00/12] Bugfixes for CONFIG_VT=n

2013-12-10 Thread Lennart Poettering
On Thu, 28.11.13 09:08, David Herrmann (dh.herrm...@gmail.com) wrote: A few comments beforehand: - regarding logging in libraries: I *want* verbose errors/warnings in sd-gfx. Especially if modesetting, keymap-compilation or bus-requests fail, I want some rather verbose messages in the log.

Re: [systemd-devel] udev rule not applied after resume from sleep

2013-12-10 Thread Cristian Rodríguez
El 10/12/13 19:59, Jason A. Donenfeld escribió: Is this by design, No, It is clearly a kernel bug. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [RFC 02/12] ring: add basic ring-buffer helper

2013-12-10 Thread Lennart Poettering
On Thu, 28.11.13 09:19, David Herrmann (dh.herrm...@gmail.com) wrote: Hmm, so if end and start match the buffer is empty? So you can never fill it entirely? Or am I missing something? I'd always maintain start index + fill level instead of a start index + end index, to avoid the

Re: [systemd-devel] [RFC 03/12] bus: add two new bus_*_map_*_properties() helpers

2013-12-10 Thread Lennart Poettering
On Thu, 28.11.13 09:21, David Herrmann (dh.herrm...@gmail.com) wrote: Hi On Wed, Nov 27, 2013 at 10:58 PM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 27.11.13 19:48, David Herrmann (dh.herrm...@gmail.com) wrote: +/* skip interface, but allow callers to do that

Re: [systemd-devel] [RFC 05/12] gfx: add sd-gfx library with unifont section

2013-12-10 Thread Lennart Poettering
On Thu, 28.11.13 09:32, David Herrmann (dh.herrm...@gmail.com) wrote: +sd_gfx_font *font; +int r; + +ppi = CLAMP(ppi, 10U, 1000U); + +font = calloc(1, sizeof(*font)); font = new0(sd_gfx_font, 1); I actually dislike new0() to require the type. I'd

Re: [systemd-devel] [RFC 06/12] gfx: add keyboard layer

2013-12-10 Thread Lennart Poettering
On Thu, 28.11.13 09:36, David Herrmann (dh.herrm...@gmail.com) wrote: Hi On Wed, Nov 27, 2013 at 11:17 PM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 27.11.13 19:48, David Herrmann (dh.herrm...@gmail.com) wrote: + +enum { +SD_GFX__LED_NUML, +

Re: [systemd-devel] Question regarding the NotifyAccess parameter

2013-12-10 Thread salil GK
Thanks Lennart for the reply. The issue that I am facing is with the restart feature of systemd. I have configured my unit file as Restart=on-failure when the service fail to send watchdog signal the expectation is - systemd will restart the service. what I observed is - systemd started one

Re: [systemd-devel] [RFC 07/12] gfx: add graphics layer

2013-12-10 Thread Lennart Poettering
On Thu, 28.11.13 09:39, David Herrmann (dh.herrm...@gmail.com) wrote: For the types that actually feel like primitive types (in contrast to objects), we usually appended a libc style _t to our names. Ouh, libudev uses udev_log_fn so I followed that style. I thought that's what we use for

Re: [systemd-devel] [RFC 00/12] Bugfixes for CONFIG_VT=n

2013-12-10 Thread Kay Sievers
On Wed, Dec 11, 2013 at 1:35 AM, Lennart Poettering lenn...@poettering.net wrote: On Thu, 28.11.13 09:08, David Herrmann (dh.herrm...@gmail.com) wrote: A few comments beforehand: - regarding logging in libraries: I *want* verbose errors/warnings in sd-gfx. Especially if modesetting,

Re: [systemd-devel] [RFC 05/12] gfx: add sd-gfx library with unifont section

2013-12-10 Thread Lennart Poettering
On Sun, 01.12.13 06:28, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Wed, Nov 27, 2013 at 07:48:40PM +0100, David Herrmann wrote: As a first step, we add the required header+build-chain and add the font-handling. To avoid heavy font-pipelines in systemd, we only provide a

Re: [systemd-devel] [RFC 05/12] gfx: add sd-gfx library with unifont section

2013-12-10 Thread Lennart Poettering
On Sun, 01.12.13 10:05, David Herrmann (dh.herrm...@gmail.com) wrote: I'm fine with installing the file into the system, but I doubt we win much. It's meant as fallback for early-boot, initrd and so on. If we keep it separate, we must make sure to include it in any systems we build (initrd,

Re: [systemd-devel] [PATCH 2/2] ptyfwd: Don't set the output prop of stdin, nor the input props of stdout.

2013-12-10 Thread Lennart Poettering
On Sat, 23.11.13 04:57, Luke Shumaker (luke...@sbcglobal.net) wrote: It was calling cfmakeraw(3) on the properties for STDIN_FILENO; cfmakeraw sets both input and output properties. If (and only if) stdin and stdout are the same device is this correct. Otherwise, we must change only the

Re: [systemd-devel] [RFC 07/12] gfx: add graphics layer

2013-12-10 Thread Kay Sievers
On Wed, Dec 11, 2013 at 1:47 AM, Lennart Poettering lenn...@poettering.net wrote: On Thu, 28.11.13 09:39, David Herrmann (dh.herrm...@gmail.com) wrote: For the types that actually feel like primitive types (in contrast to objects), we usually appended a libc style _t to our names. Ouh,

[systemd-devel] [RFC] Initial work for asyncns push

2013-12-10 Thread Daniel Buch
Hi, So i layed the foundation of this libary to fit systemd But what is actually desired? C99 or C89? Do we want it to be public or private? Is modernization desired? Daniel Buch (1): Initial libsystemd-asyncns commit Makefile.am | 23 +

Re: [systemd-devel] [RFC 05/12] gfx: add sd-gfx library with unifont section

2013-12-10 Thread Kay Sievers
On Wed, Dec 11, 2013 at 1:56 AM, Lennart Poettering lenn...@poettering.net wrote: On Sun, 01.12.13 10:05, David Herrmann (dh.herrm...@gmail.com) wrote: I'm fine with installing the file into the system, but I doubt we win much. It's meant as fallback for early-boot, initrd and so on. If we

Re: [systemd-devel] Question regarding the NotifyAccess parameter

2013-12-10 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 11, 2013 at 06:15:02AM +0530, salil GK wrote: Thanks Lennart for the reply. The issue that I am facing is with the restart feature of systemd. I have configured my unit file as Restart=on-failure when the service fail to send watchdog signal the expectation is - systemd

Re: [systemd-devel] [RFC 05/12] gfx: add sd-gfx library with unifont section

2013-12-10 Thread Lennart Poettering
On Wed, 11.12.13 02:14, Kay Sievers (k...@vrfy.org) wrote: On Wed, Dec 11, 2013 at 1:56 AM, Lennart Poettering lenn...@poettering.net wrote: On Sun, 01.12.13 10:05, David Herrmann (dh.herrm...@gmail.com) wrote: I'm fine with installing the file into the system, but I doubt we win

Re: [systemd-devel] [RFC] Initial work for asyncns push

2013-12-10 Thread Lennart Poettering
On Wed, 11.12.13 02:18, Lennart Poettering (lenn...@poettering.net) wrote: C99 or C89? Do we want it to be public or private? Internally we use C99 and a lot of gcc extensions. Externally we limit ourselves to C89. One effect of this is that internally we use the C99 bool type for

Re: [systemd-devel] [RFC] Initial work for asyncns push

2013-12-10 Thread Daniel Buch
Cool, thanks you for the very decent reply.. I will work on this the next few days, you can then expect some new RFC's :) 2013/12/11 Lennart Poettering lenn...@poettering.net On Wed, 11.12.13 02:18, Lennart Poettering (lenn...@poettering.net) wrote: C99 or C89? Do we want it to be public

Re: [systemd-devel] [RFC] Initial libsystemd-asyncns commit

2013-12-10 Thread Marcel Holtmann
Hi Daniel, Reindentation is done to fit systemd --- Makefile.am | 23 + src/libsystemd-asyncns/asyncns.c | 1513 + src/libsystemd-asyncns/asyncns.h | 163 src/libsystemd-asyncns/test-asyncns.c | 178 4 files

Re: [systemd-devel] [RFC] Initial libsystemd-asyncns commit

2013-12-10 Thread Lennart Poettering
On Wed, 11.12.13 02:13, Daniel Buch (boogiewasth...@gmail.com) wrote: Heya, Hmm, so thinking about it I have the suspicion this should probably be linked into libsystemd-bus, and thus live in src/libsystemd-bus/. The reason for this is cyclic deps: libsystemd-bus really should make use of this

Re: [systemd-devel] [PATCH] libsystemd-bus: trivial macro KDBUS_PART_HEADER_SIZE replace

2013-12-10 Thread Yin Kangkai
On 2013-12-10, 20:56 +0100, Lennart Poettering wrote: On Wed, 04.12.13 15:28, Yin Kangkai (kangkai@intel.com) wrote: It's a little bit cleaner(?) to replace offsetof(struct kdbus_item, data) with KDBUS_PART_HEADER_SIZE. Hmm, is this really cleaner? I kinda like using offsetof()

Re: [systemd-devel] [RFC] Initial libsystemd-asyncns commit

2013-12-10 Thread Lennart Poettering
On Wed, 11.12.13 02:36, Marcel Holtmann (mar...@holtmann.org) wrote: why do we have to spawn threads or do forks for DNS. This looks all pretty expensive. In ConnMan for example we just wrote our own async DNS using a mainloop. Works perfectly fine and is dirt cheap. Well, we don't fork

Re: [systemd-devel] [PATCH 1/3] tmpfiles: skip the path entirely if configured as type x

2013-12-10 Thread Lennart Poettering
On Fri, 08.11.13 07:32, Michal Sekletar (msekl...@redhat.com) wrote: On Thu, Nov 07, 2013 at 10:39:19PM +0100, Lennart Poettering wrote: On Wed, 06.11.13 11:18, Michal Sekletar (msekl...@redhat.com) wrote: Type x in tmpfiles configuration accepts shell style globs instead of normal

  1   2   >