Re: [systemd-devel] [PATCH 3/4] bus: driverd: don't attempt to remove from empty list

2014-01-04 Thread Marc-Antoine Perennou
On 28 December 2013 13:54, Marc-Antoine Perennou marc-anto...@perennou.com wrote: --- src/bus-driverd/bus-driverd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bus-driverd/bus-driverd.c b/src/bus-driverd/bus-driverd.c index b423420..1fdea7e 100644 ---

Re: [systemd-devel] [PATCH v2] systemctl: improve readability on failed commands

2014-01-04 Thread Thomas H.P. Andersen
On Sat, Jan 4, 2014 at 12:39 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Fri, Jan 03, 2014 at 11:59:08PM +0100, Thomas H.P. Andersen wrote: From: Thomas Hindoe Paaboel Andersen pho...@gmail.com Not long ago a failed command would print: Failed to start something.service: ...

[systemd-devel] [PATCH] bus: open user, not system, bus in bus_open_user_systemd()

2014-01-04 Thread Mantas Mikulėnas
--- src/libsystemd-bus/bus-util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libsystemd-bus/bus-util.c b/src/libsystemd-bus/bus-util.c index 425f63a..a468bca 100644 --- a/src/libsystemd-bus/bus-util.c +++ b/src/libsystemd-bus/bus-util.c @@ -553,7 +553,7 @@ int

[systemd-devel] [RFC][PATCH] net: set default DEVTYPE for all ethernet based devices

2014-01-04 Thread Tom Gundersen
In systemd's networkd and udevd, we would like to give the administrator a simple way to filter ethernet devices by their DEVTYPE. In order to avoid having a special treatment of the case where DEVTYPE=(null), initialize it to a default value, ethernet, in the kernel. Signed-off-by: Tom Gundersen

Re: [systemd-devel] [RFC][PATCH] net: set default DEVTYPE for all ethernet based devices

2014-01-04 Thread Marcel Holtmann
Hi Tom, In systemd's networkd and udevd, we would like to give the administrator a simple way to filter ethernet devices by their DEVTYPE. In order to avoid having a special treatment of the case where DEVTYPE=(null), initialize it to a default value, ethernet, in the kernel.

Re: [systemd-devel] [RFC][PATCH] net: set default DEVTYPE for all ethernet based devices

2014-01-04 Thread Tom Gundersen
On Sun, Jan 5, 2014 at 3:14 AM, Marcel Holtmann mar...@holtmann.org wrote: Hi Tom, In systemd's networkd and udevd, we would like to give the administrator a simple way to filter ethernet devices by their DEVTYPE. In order to avoid having a special treatment of the case where DEVTYPE=(null),

Re: [systemd-devel] [RFC][PATCH] net: set default DEVTYPE for all ethernet based devices

2014-01-04 Thread Marcel Holtmann
Hi Tom, In systemd's networkd and udevd, we would like to give the administrator a simple way to filter ethernet devices by their DEVTYPE. In order to avoid having a special treatment of the case where DEVTYPE=(null), initialize it to a default value, ethernet, in the kernel.

Re: [systemd-devel] [PATCH 2/2] Update .mailmap file

2014-01-04 Thread Zbigniew Jędrzejewski-Szmek
Applied both. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 1/5] shared: procfs_file_alloca: handle pid==0

2014-01-04 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Jan 04, 2014 at 02:35:23AM +0100, Simon Peeters wrote: when pid is set to 0 use /proc/self Nice. Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 4/5] util.c: use read_one_line_file where possible

2014-01-04 Thread Zbigniew Jędrzejewski-Szmek
Nice cleanup. Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 5/5] strv: multiple cleanups

2014-01-04 Thread Zbigniew Jędrzejewski-Szmek
Looks great, except for one issue: On Sat, Jan 04, 2014 at 02:35:27AM +0100, Simon Peeters wrote: @@ -1865,14 +1863,11 @@ finish: watchdog_close(false); /* Tell the binary how often to ping */ -snprintf(e, sizeof(e),

Re: [systemd-devel] [PATCH] bus: open user, not system, bus in bus_open_user_systemd()

2014-01-04 Thread Kay Sievers
On Sun, Jan 5, 2014 at 3:57 AM, Mantas Mikulėnas graw...@gmail.com wrote: --- src/libsystemd-bus/bus-util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Applied. Thanks, Kay ___ systemd-devel mailing list

Re: [systemd-devel] [PATCH 3/4] bus: driverd: don't attempt to remove from empty list

2014-01-04 Thread Kay Sievers
On Sat, Dec 28, 2013 at 8:54 AM, Marc-Antoine Perennou marc-anto...@perennou.com wrote: --- src/bus-driverd/bus-driverd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Applied. Thanks, Kay ___ systemd-devel mailing list