Re: [systemd-devel] [PATCH 2/2] Add AppArmor profile switching

2014-02-14 Thread Michael Scherer
Le vendredi 14 février 2014 à 01:24 +0100, Lennart Poettering a écrit : On Fri, 03.01.14 17:22, m...@zarb.org (m...@zarb.org) wrote: Heya! This patch appears to be unmerged still. Unfortunately it doesn't apply anymore, but looks good otherwiese! Could you please rebase? I'll merge it

Re: [systemd-devel] [PATCH] core/service: check if mainpid matches only if it set

2014-02-14 Thread Tomasz Torcz
On Mon, Dec 30, 2013 at 05:26:19PM +0100, Zbigniew Jędrzejewski-Szmek wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1047304 -if (s-notify_access == NOTIFY_MAIN pid != s-main_pid) { +if (s-notify_access == NOTIFY_MAIN s-main_pid != 0 pid != s-main_pid) { I don't

Re: [systemd-devel] recipe for target 'dbus1-generator-install-hook' failed

2014-02-14 Thread Peeters Simon
2014-02-14 1:56 GMT+01:00 Lennart Poettering lenn...@poettering.net: On Thu, 13.02.14 22:26, Simon Peeters (peeters.si...@gmail.com) wrote: Thanks! Applied! thanks Please always send these things are proper git patches (and not linebroken, please!), so that I can immediately apply them!

[systemd-devel] [PATCH] match: kdbus_match_entry_free fixed

2014-02-14 Thread Radoslaw Pajak
Signed-off-by: Radoslaw Pajak r.pa...@samsung.com --- match.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/match.c b/match.c index d619bef..4c51327 100644 --- a/match.c +++ b/match.c @@ -121,6 +121,9 @@ static void kdbus_match_entry_free(struct kdbus_match_entry *entry)

Re: [systemd-devel] [PATCH] core/service: check if mainpid matches only if it set

2014-02-14 Thread Lennart Poettering
On Fri, 14.02.14 10:15, Tomasz Torcz (to...@pipebreaker.pl) wrote: On Mon, Dec 30, 2013 at 05:26:19PM +0100, Zbigniew Jędrzejewski-Szmek wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1047304 -if (s-notify_access == NOTIFY_MAIN pid != s-main_pid) { +if

Re: [systemd-devel] [PATCH RFC] namespace: make sure ReadWriteDirectories are actually writable

2014-02-14 Thread Lennart Poettering
On Fri, 27.12.13 10:18, Michael Olbrich (m.olbr...@pengutronix.de) wrote: Currently adding directories to ReadWriteDirectories= only restores the original mount flags. So e.g. setting ReadOnlyDirectories=/usr and ReadWriteDirectories=/usr/local works as expected if the underlying file system

Re: [systemd-devel] journal on btrfs subvolume, failed unmounting /var/log/journal

2014-02-14 Thread Lennart Poettering
On Tue, 11.02.14 21:02, Chris Murphy (li...@colorremedies.com) wrote: It looks like var-log-journal.mount is called before systemd-journald is finished using it. Is the failure message merely cosmetic? The file system comes up clean on reboot so I'm pretty sure it's being cleanly unmounted

[systemd-devel] Apparmor profile switching support, v2

2014-02-14 Thread Michael Scherer
This patch implement a option AppArmorProfile to load a specific profile for a service, following the previous SELinux patch for SELinuxProfile configuration. It also follow the same convention of being non-fatal if prefixed by -. I tested it on Opensuse only for now, and the profile still need

[systemd-devel] [PATCH] Add AppArmor profile switching

2014-02-14 Thread Michael Scherer
This permit to switch to a specific apparmor profile when starting a daemon. This will result in a non operation if apparmor is disabled. It also add a new build requirement on libapparmor for using this feature. --- Makefile.am | 7 +++ configure.ac

Re: [systemd-devel] [PATCH] Add AppArmor profile switching

2014-02-14 Thread Lennart Poettering
On Fri, 14.02.14 12:21, Michael Scherer (m...@zarb.org) wrote: This permit to switch to a specific apparmor profile when starting a daemon. This will result in a non operation if apparmor is disabled. It also add a new build requirement on libapparmor for using this feature. ---

Re: [systemd-devel] [PATCH] man: grammar and wording improvements

2014-02-14 Thread Lennart Poettering
On Fri, 20.12.13 03:03, Jan Engelhardt (jeng...@inai.de) wrote: This is a recurring submission and includes corrections to various issue spotted: comma setting, missing words/preposition choice. Of note is the change of /lib to /usr/lib, because that is what most distros are using as the

Re: [systemd-devel] libcap .pc file

2014-02-14 Thread Lennart Poettering
On Fri, 27.12.13 23:12, Thomas H.P. Andersen (pho...@gmail.com) wrote: Hi, Just a heads up that libcap now includes a pc file in version 2.23. https://git.kernel.org/cgit/linux/kernel/git/morgan/libcap.git/commit/?id=dfea7eba31e6d15e8a63f818bb4438340b70a8c9 (The commit message gives me way

Re: [systemd-devel] How to control socket activation when it run respawn infinitely.

2014-02-14 Thread Lennart Poettering
On Thu, 19.12.13 03:02, Tony Seo (tonys...@gmail.com) wrote: I already knew that a process executed by socket activation would be respawn. But, what the important thing is that I don't know how to control the number of respawn. When a service fails too rapidly systemd will stop restarting it

Re: [systemd-devel] [PATCH] Add AppArmor profile switching

2014-02-14 Thread Michael Scherer
Le vendredi 14 février 2014 à 12:31 +0100, Lennart Poettering a écrit : On Fri, 14.02.14 12:21, Michael Scherer (m...@zarb.org) wrote: This permit to switch to a specific apparmor profile when starting a daemon. This will result in a non operation if apparmor is disabled. It also add a

Re: [systemd-devel] [PATCH] Add AppArmor profile switching

2014-02-14 Thread Michael Scherer
Le vendredi 14 février 2014 à 14:05 +0100, Michael Scherer a écrit : Le vendredi 14 février 2014 à 12:31 +0100, Lennart Poettering a écrit : On Fri, 14.02.14 12:21, Michael Scherer (m...@zarb.org) wrote: SD_BUS_PROPERTY(SELinuxContext, s, NULL, offsetof(ExecContext,

Re: [systemd-devel] [PATCH] man: grammar and wording improvements

2014-02-14 Thread Jan Engelhardt
On Friday 2014-02-14 12:44, Lennart Poettering wrote: On Fri, 20.12.13 03:03, Jan Engelhardt (jeng...@inai.de) wrote: This is a recurring submission and includes corrections to various issue spotted: comma setting, missing words/preposition choice. Of note is the change of /lib to /usr/lib,

Re: [systemd-devel] [PATCH] Add AppArmor profile switching

2014-02-14 Thread Lennart Poettering
On Fri, 14.02.14 14:05, Michael Scherer (m...@zarb.org) wrote: SD_BUS_PROPERTY(SELinuxContext, s, NULL, offsetof(ExecContext, selinux_context), SD_BUS_VTABLE_PROPERTY_CONST), +SD_BUS_PROPERTY(AppArmorProfile, s, NULL, offsetof(ExecContext, apparmor_profile),

Re: [systemd-devel] [PATCH] match: kdbus_match_entry_free fixed

2014-02-14 Thread Daniel Mack
On 02/14/2014 10:47 AM, Radoslaw Pajak wrote: Signed-off-by: Radoslaw Pajak r.pa...@samsung.com --- match.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/match.c b/match.c index d619bef..4c51327 100644 --- a/match.c +++ b/match.c @@ -121,6 +121,9 @@ static void

[systemd-devel] Problems with systemd master

2014-02-14 Thread Richard Purdie
Hi, I work on the Yocto Project and we've been having some stability issues with systemd based images on our automated testing infrastructure. We default to the last released version but it appears there have been a lot of changes in master so I tried the latest git master in the hope that this

Re: [systemd-devel] Problems with systemd master

2014-02-14 Thread Kay Sievers
On Fri, Feb 14, 2014 at 4:23 PM, Richard Purdie richard.pur...@linuxfoundation.org wrote: systemd[1]: Expecting device dev-ttyS0.device... Expecting device dev-ttyS0.device... systemd[1]: job_get_timeout dev-ttyS0.device 1/96903843 0/18446744073709551615 - 1/96903843 [* ] A

[systemd-devel] [PATCH] Ship new udev rules file to create per-seat symlinks for input devices

2014-02-14 Thread Laércio de Sousa
This rules file tells udev to create symlinks for input devices (keyboard and mouse, at this moment) separated by seat, so it could be easier for one to get quickly the devpath of a given input device attached to a given seat. Example: the keyboard attached to seat-foo will receive a symlink with

Re: [systemd-devel] [PATCH] Ship new udev rules file to create per-seat symlinks for input devices

2014-02-14 Thread Lennart Poettering
On Fri, 14.02.14 13:52, Laércio de Sousa (lbsous...@gmail.com) wrote: This rules file tells udev to create symlinks for input devices (keyboard and mouse, at this moment) separated by seat, so it could be easier for one to get quickly the devpath of a given input device attached to a given

[systemd-devel] [PATCH] export SELinuxContext on the bus as a structure

2014-02-14 Thread Michael Scherer
This permit to hide the logic of prefixing by '-' from the consumer of the DBus API, by presenting a boolean and a string rather than just a raw string, with specific magic value. See http://lists.freedesktop.org/archives/systemd-devel/2014-February/016918.html --- src/core/dbus-execute.c | 21

[systemd-devel] [PATCH v3 1/2] test: add basic seccomp tests

2014-02-14 Thread Ronny Chevalier
--- test/TEST-04-SECCOMP/Makefile | 1 + test/TEST-04-SECCOMP/test-seccomp.sh| 13 + test/TEST-04-SECCOMP/test.sh| 79 + test/TEST-04-SECCOMP/will-fail.service | 8 +++ test/TEST-04-SECCOMP/will-fail2.service | 6

Re: [systemd-devel] [PATCH] Ship new udev rules file to create per-seat symlinks for input devices

2014-02-14 Thread Laércio de Sousa
Good point. I used to append a $env{MINOR} to symlink names to avoid such ambiguities. A side effect of this approach is that symlink names would change every time the device is plugged in a different USB port, for example. Would it be enough for you? CANTATE DOMINO CANTICUM NOVUM QUIA

Re: [systemd-devel] Problems with systemd master

2014-02-14 Thread Richard Purdie
On Fri, 2014-02-14 at 16:47 +0100, Kay Sievers wrote: On Fri, Feb 14, 2014 at 4:23 PM, Richard Purdie richard.pur...@linuxfoundation.org wrote: systemd[1]: Expecting device dev-ttyS0.device... Expecting device dev-ttyS0.device... systemd[1]: job_get_timeout dev-ttyS0.device

Re: [systemd-devel] [PATCH] Ship new udev rules file to create per-seat symlinks for input devices

2014-02-14 Thread Kay Sievers
On Fri, Feb 14, 2014 at 5:25 PM, Laércio de Sousa lbsous...@gmail.com wrote: Good point. I used to append a $env{MINOR} to symlink names to avoid such ambiguities. A side effect of this approach is that symlink names would change every time the device is plugged in a different USB port, for

Re: [systemd-devel] Problems with systemd master

2014-02-14 Thread Cristian Rodríguez
El 14/02/14 13:32, Richard Purdie escribió: Both conditions are checked, can you find out why the second seems to fail too, it shouldn't? CONFIG_FHANDLE is in your kernel? No, it wasn't. I enabled that and that image started working better, thanks! I believe we should throw a big fat

Re: [systemd-devel] Problems with systemd master

2014-02-14 Thread Greg KH
On Fri, Feb 14, 2014 at 02:30:00PM -0300, Cristian Rodríguez wrote: El 14/02/14 13:32, Richard Purdie escribió: Both conditions are checked, can you find out why the second seems to fail too, it shouldn't? CONFIG_FHANDLE is in your kernel? No, it wasn't. I enabled that and that image

[systemd-devel] [PATCH] core: fix detection of dead process.

2014-02-14 Thread Yuxuan Shui
Commit 5ba6985b moves the UNIT_VTABLE(u)-sigchld_event before systemd actually reap the zombie. Which leads to service_load_pid_file accept zombie as a valid pid. --- src/core/service.c | 3 +++ src/shared/util.c | 24 src/shared/util.h | 1 + 3 files changed, 28

Re: [systemd-devel] [PATCH] core: fix detection of dead process.

2014-02-14 Thread Yuxuan Shui
Sorry, I sent the wrong patch 2014-2-15 上午2:34于 Yuxuan Shui yshu...@gmail.com写道: Commit 5ba6985b moves the UNIT_VTABLE(u)-sigchld_event before systemd actually reap the zombie. Which leads to service_load_pid_file accept zombie as a valid pid. --- src/core/service.c | 3 +++

[systemd-devel] [PATCH] core: fix detection of dead process v2.

2014-02-14 Thread Yuxuan Shui
Commit 5ba6985b moves the UNIT_VTABLE(u)-sigchld_event before systemd actually reap the zombie. Which leads to service_load_pid_file accept zombie as a valid pid. v2: I sent the wrong patch. --- src/core/service.c | 3 +++ src/shared/util.c | 25 + src/shared/util.h |

Re: [systemd-devel] journal on btrfs subvolume, failed unmounting /var/log/journal

2014-02-14 Thread Chris Murphy
On Feb 14, 2014, at 4:19 AM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 11.02.14 21:02, Chris Murphy (li...@colorremedies.com) wrote: It looks like var-log-journal.mount is called before systemd-journald is finished using it. Is the failure message merely cosmetic? The file

Re: [systemd-devel] [PATCH] Ship new udev rules file to create per-seat symlinks for input devices

2014-02-14 Thread Peter Hutterer
On 15/02/2014 01:52 , Laércio de Sousa wrote: This rules file tells udev to create symlinks for input devices (keyboard and mouse, at this moment) separated by seat, so it could be easier for one to get quickly the devpath of a given input device attached to a given seat. Example: the keyboard

Re: [systemd-devel] [PATCH v3 1/2] test: add basic seccomp tests

2014-02-14 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 14, 2014 at 05:21:41PM +0100, Ronny Chevalier wrote: --- test/TEST-04-SECCOMP/Makefile | 1 + test/TEST-04-SECCOMP/test-seccomp.sh| 13 + test/TEST-04-SECCOMP/test.sh| 79 +

Re: [systemd-devel] [PATCH] core: fix detection of dead process v2.

2014-02-14 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Feb 15, 2014 at 02:38:50AM +0800, Yuxuan Shui wrote: Commit 5ba6985b moves the UNIT_VTABLE(u)-sigchld_event before systemd actually reap the zombie. Which leads to service_load_pid_file accept zombie as a valid pid. v2: I sent the wrong patch. Applied, with some tweaks: - a message

Re: [systemd-devel] [PATCH 2/2] man: use spaces instead of tabs

2014-02-14 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Feb 13, 2014 at 08:25:24PM -0500, Jason St. John wrote: * standardize capitalization of STDIN, STDOUT, and STDERR * reword some sentences for clarity * reflow some very long lines to be shorter than ~80 characters * add some missing literal, constant, varname, option, and filename

Re: [systemd-devel] [PATCH 2/2] man: use spaces instead of tabs

2014-02-14 Thread Jason St. John
On Fri, Feb 14, 2014 at 10:11 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Thu, Feb 13, 2014 at 08:25:24PM -0500, Jason St. John wrote: * standardize capitalization of STDIN, STDOUT, and STDERR * reword some sentences for clarity * reflow some very long lines to be shorter than

Re: [systemd-devel] [systemd-commits] src/shared

2014-02-14 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 14, 2014 at 07:31:33PM -0800, Kay Sievers wrote: src/shared/util.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ecea04731c30e351c9eb3176d89af4a329ba784a Author: Kay Sievers k...@vrfy.org Date: Sat Feb 15 04:30:27 2014 +0100 util: fix

Re: [systemd-devel] [systemd-commits] src/shared

2014-02-14 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Feb 15, 2014 at 05:06:13AM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Fri, Feb 14, 2014 at 07:31:33PM -0800, Kay Sievers wrote: src/shared/util.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ecea04731c30e351c9eb3176d89af4a329ba784a Author:

[systemd-devel] [PATCH] core: small fixes for commit e10c9985bb.

2014-02-14 Thread Yuxuan Shui
Fix function prototype and check for return value. --- src/core/service.c | 10 +- src/shared/util.h | 2 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/core/service.c b/src/core/service.c index 3a2ef01..efccdbf 100644 --- a/src/core/service.c +++