[systemd-devel] [212] systemd-networkd crashes with simple network config

2014-03-30 Thread Kai Krakow
Hello list! I've tried switching from NetworkManager to systemd-networkd on Gentoo. These were the steps I did: # systemctl enable systemd-networkd.service # cat /etc/systemd/network/80-dhcp.network [Match] Name=en* [Network] DHCP=yes After starting systemd-networkd.service, it crashes with

Re: [systemd-devel] [212] systemd-networkd crashes with simple network config

2014-03-30 Thread Dave Reisner
On Sun, Mar 30, 2014 at 04:47:22PM +0200, Kai Krakow wrote: Hello list! I've tried switching from NetworkManager to systemd-networkd on Gentoo. These were the steps I did: # systemctl enable systemd-networkd.service # cat /etc/systemd/network/80-dhcp.network [Match] Name=en*

[systemd-devel] Unable to override systemd-udevd.service

2014-03-30 Thread Andrey Borzenkov
linux-qbc6:~ # systemctl show systemd-udevd.service -p FragmentPath FragmentPath=/usr/lib/systemd/system/systemd-udevd.service linux-qbc6:~ # cp /usr/lib/systemd/system/systemd-udevd.service /etc/systemd/system linux-qbc6:~ # systemctl daemon-reload linux-qbc6:~ # cp

Re: [systemd-devel] Requiring hardware device and escaping device names

2014-03-30 Thread Kai Hendry
On 26 March 2014 22:55, Jóhann B. Guðmundsson johan...@gmail.com wrote: SUBSYSTEM==input, ENV{ID_INPUT_KEYBOARD}==?*, ENV{.INPUT_CLASS}=kbd, TAG+=systemd, ENV{SYSTEMD_WANTS}+=shkd@%p.service Trying to teach myself how to fish here. How did you know it would match this particular device? $

Re: [systemd-devel] [212] systemd-networkd crashes with simple network config

2014-03-30 Thread Kai Krakow
Tom Gundersen t...@jklm.no schrieb: Starting it from command line shows: # /usr/lib/systemd/systemd-networkd enp4s0: link is up enp4s0: carrier on segmentation fault (core dumped) If you could reproduce this with debug symbols included, that would be very helpful (I cannot reproduce it

Re: [systemd-devel] [212] systemd-networkd crashes with simple network config

2014-03-30 Thread Kai Krakow
Tom Gundersen t...@jklm.no schrieb: Starting it from command line shows: # /usr/lib/systemd/systemd-networkd enp4s0: link is up enp4s0: carrier on segmentation fault (core dumped) If you could reproduce this with debug symbols included, that would be very helpful (I cannot reproduce it

Re: [systemd-devel] Requiring hardware device and escaping device names

2014-03-30 Thread Andrey Borzenkov
В Sun, 30 Mar 2014 23:48:11 +0800 Kai Hendry hen...@webconverger.com пишет: On 26 March 2014 22:55, Jóhann B. Guðmundsson johan...@gmail.com wrote: SUBSYSTEM==input, ENV{ID_INPUT_KEYBOARD}==?*, ENV{.INPUT_CLASS}=kbd, TAG+=systemd, ENV{SYSTEMD_WANTS}+=shkd@%p.service ... Trying to teach

[systemd-devel] [PATCH] sd-dhcp: check for udp packets

2014-03-30 Thread Umut Tezduyar Lindskog
Do not try to parse ICMP packets --- src/libsystemd-network/dhcp-packet.c |5 + 1 file changed, 5 insertions(+) diff --git a/src/libsystemd-network/dhcp-packet.c b/src/libsystemd-network/dhcp-packet.c index bed942f..f4a6227 100644 --- a/src/libsystemd-network/dhcp-packet.c +++

Re: [systemd-devel] [PATCH] sd-dhcp: check for udp packets

2014-03-30 Thread Tom Gundersen
On Sun, Mar 30, 2014 at 7:09 PM, Umut Tezduyar Lindskog umut.tezdu...@axis.com wrote: Do not try to parse ICMP packets --- src/libsystemd-network/dhcp-packet.c |5 + 1 file changed, 5 insertions(+) diff --git a/src/libsystemd-network/dhcp-packet.c

Re: [systemd-devel] [212] systemd-networkd crashes with simple network config

2014-03-30 Thread Tom Gundersen
On Sun, Mar 30, 2014 at 6:07 PM, Kai Krakow hurikha...@gmail.com wrote: Tom Gundersen t...@jklm.no schrieb: Starting it from command line shows: # /usr/lib/systemd/systemd-networkd enp4s0: link is up enp4s0: carrier on segmentation fault (core dumped) If you could reproduce this with

Re: [systemd-devel] [212] systemd-networkd crashes with simple network config

2014-03-30 Thread Tom Gundersen
On Sun, Mar 30, 2014 at 9:30 PM, Tom Gundersen t...@jklm.no wrote: On Sun, Mar 30, 2014 at 6:07 PM, Kai Krakow hurikha...@gmail.com wrote: Tom Gundersen t...@jklm.no schrieb: Starting it from command line shows: # /usr/lib/systemd/systemd-networkd enp4s0: link is up enp4s0: carrier on

Re: [systemd-devel] [212] systemd-networkd crashes with simple network config

2014-03-30 Thread Kai Krakow
Tom Gundersen t...@jklm.no schrieb: On Sun, Mar 30, 2014 at 9:30 PM, Tom Gundersen t...@jklm.no wrote: On Sun, Mar 30, 2014 at 6:07 PM, Kai Krakow hurikha...@gmail.com wrote: Tom Gundersen t...@jklm.no schrieb: Starting it from command line shows: # /usr/lib/systemd/systemd-networkd

Re: [systemd-devel] [212] systemd-networkd crashes with simple network config

2014-03-30 Thread Kai Krakow
Tom Gundersen t...@jklm.no schrieb: On Sun, Mar 30, 2014 at 6:07 PM, Kai Krakow hurikha...@gmail.com wrote: Tom Gundersen t...@jklm.no schrieb: Starting it from command line shows: # /usr/lib/systemd/systemd-networkd enp4s0: link is up enp4s0: carrier on segmentation fault (core dumped)

Re: [systemd-devel] [212] systemd-networkd crashes with simple network config

2014-03-30 Thread poma
On 30.03.2014 22:03, Kai Krakow wrote: Tom Gundersen t...@jklm.no schrieb: ... Hm, so the segfault happens in glibc... It is triggered by us calling calloc(1, 88), which I think is a supported thing to do ;) At least as far as I can tell this is not a bug on our side... Out of interest, what

Re: [systemd-devel] [212] systemd-networkd crashes with simple network config

2014-03-30 Thread Kai Krakow
poma pomidorabelis...@gmail.com schrieb: On 30.03.2014 22:03, Kai Krakow wrote: Tom Gundersen t...@jklm.no schrieb: ... Hm, so the segfault happens in glibc... It is triggered by us calling calloc(1, 88), which I think is a supported thing to do ;) At least as far as I can tell this is not

Re: [systemd-devel] [212] systemd-networkd crashes with simple network config

2014-03-30 Thread poma
On 30.03.2014 22:38, Kai Krakow wrote: poma pomidorabelis...@gmail.com schrieb: On 30.03.2014 22:03, Kai Krakow wrote: Tom Gundersen t...@jklm.no schrieb: ... Hm, so the segfault happens in glibc... It is triggered by us calling calloc(1, 88), which I think is a supported thing to do ;) At

[systemd-devel] [PATCH 1/4] connection: remove useless kdbus_str_hash() call

2014-03-30 Thread Djalal Harouni
The hash is calculated internally in kdbus_name_lookup(), so just remove this useless kdbus_str_hash() call. It is not used. Signed-off-by: Djalal Harouni tix...@opendz.org --- connection.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/connection.c b/connection.c index 753903b..c623720

[systemd-devel] [PATCH 2/4] endpoint: protect the idr tree on release

2014-03-30 Thread Djalal Harouni
Signed-off-by: Djalal Harouni tix...@opendz.org --- endpoint.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/endpoint.c b/endpoint.c index 66b4de5..f37b80a 100644 --- a/endpoint.c +++ b/endpoint.c @@ -104,7 +104,9 @@ void kdbus_ep_disconnect(struct kdbus_ep *ep) ep-dev =

[systemd-devel] [PATCH 3/4] handle: change return value from -EFAULT to -EPERM

2014-03-30 Thread Djalal Harouni
Return -EPERM if current does not have the appropriate privileges to create custom endpoints. Signed-off-by: Djalal Harouni tix...@opendz.org --- handle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/handle.c b/handle.c index 8082241..eda88c1 100644 --- a/handle.c +++

[systemd-devel] [PATCH 4/4] connection: unref ep and bus and free match_db on error path

2014-03-30 Thread Djalal Harouni
Signed-off-by: Djalal Harouni tix...@opendz.org --- connection.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/connection.c b/connection.c index c623720..e01e0ab 100644 --- a/connection.c +++ b/connection.c @@ -2062,7 +2062,7 @@ int kdbus_conn_new(struct kdbus_ep *ep,

[systemd-devel] [PATCH 2/2] kdbus: use kdbus_conn_find_peer() where appropriate

2014-03-30 Thread Djalal Harouni
Signed-off-by: Djalal Harouni tix...@opendz.org --- connection.c | 7 ++- match.c | 14 ++ names.c | 5 + 3 files changed, 5 insertions(+), 21 deletions(-) diff --git a/connection.c b/connection.c index 97fde97..f14cedc 100644 --- a/connection.c +++ b/connection.c

Re: [systemd-devel] Requiring hardware device and escaping device names

2014-03-30 Thread Kai Hendry
On 31 March 2014 01:00, Andrey Borzenkov arvidj...@gmail.com wrote: udevadm monitor --env would be more useful, it also shows device attributes after event is processed. Thank you Andrey! With %N and a reboot, the keyboard is working. However for interest sake, I un-plugged the USB device and

Re: [systemd-devel] [PATCH] sd-rtnl: fix off-by-one

2014-03-30 Thread Dave Reisner
On Sun, Mar 30, 2014 at 05:34:54PM -0700, Steven Siloti wrote: --- src/libsystemd/sd-rtnl/rtnl-message.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libsystemd/sd-rtnl/rtnl-message.c b/src/libsystemd/sd-rtnl/rtnl-message.c index 5265184..a31f6ba 100644 ---

[systemd-devel] [PATCH v2] sd-rtnl: fix off-by-one

2014-03-30 Thread Steven Siloti
Also fix type parameter passed to new0 --- src/libsystemd/sd-rtnl/rtnl-message.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libsystemd/sd-rtnl/rtnl-message.c b/src/libsystemd/sd-rtnl/rtnl-message.c index 5265184..4ace94c 100644 ---