Re: [systemd-devel] Restart of Target should restart all services that are wanted by that target and have StopWhenUnneeded=true

2014-06-27 Thread Andrey Borzenkov
On Fri, Jun 27, 2014 at 9:56 AM, Michael Seiwald michael.seiw...@ith-icoserve.com wrote: Hi, I have a target unit that acts as a collection unit for several service units. The service units all have a WantedBy directive pointing to the target unit as well as StopWhenUnneeded set to true.

Re: [systemd-devel] [RFC 7/8] HACK3: minimize the range of D-Cache flush in ioctl(CMD_MSG_RECV)

2014-06-27 Thread AKASHI Takahiro
On 06/27/2014 01:17 AM, Daniel Mack wrote: Hi, I now booted an ARM board and tried your change, but it doesn't work. On 06/25/2014 11:13 AM, AKASHI Takahiro wrote: void kdbus_pool_slice_flush(const struct kdbus_pool_slice *slice) { +#if KDBUS_HACK3 + flush_kernel_vmap_range((void

Re: [systemd-devel] [RFC 4/8] HACK0: allow meta information customizable

2014-06-27 Thread AKASHI Takahiro
On 06/27/2014 01:32 AM, Daniel Mack wrote: Hi, On 06/26/2014 12:33 PM, AKASHI Takahiro wrote: On 06/25/2014 06:56 PM, Daniel Mack wrote: On 06/25/2014 11:13 AM, AKASHI Takahiro wrote: Note that the kernel features of kdbus are defined by the kernel code, not by the convenience wrappers for

Re: [systemd-devel] [RFC 7/8] HACK3: minimize the range of D-Cache flush in ioctl(CMD_MSG_RECV)

2014-06-27 Thread Daniel Mack
On 06/27/2014 10:50 AM, AKASHI Takahiro wrote: On 06/27/2014 01:17 AM, Daniel Mack wrote: Your Pandaboard features an OMAP4430 MCU with VIPT/PIPT data cache that doesn't suffer from aliasing, and both cache_is_vivt() and cache_is_vipt_aliasing() will validate to false on your platform. Hence,

Re: [systemd-devel] Restart of Target should restart all services that are wanted by that target and have StopWhenUnneeded=true

2014-06-27 Thread Michael Seiwald
With PartOf it works perfectly. Thanks! -Ursprüngliche Nachricht- Von: Andrey Borzenkov [mailto:arvidj...@gmail.com] Gesendet: Freitag, 27. Juni 2014 10:32 An: Michael Seiwald Cc: systemd-devel@lists.freedesktop.org Betreff: Re: [systemd-devel] Restart of Target should restart all

Re: [systemd-devel] [RFC 4/8] HACK0: allow meta information customizable

2014-06-27 Thread Daniel Mack
On 06/27/2014 11:06 AM, AKASHI Takahiro wrote: On 06/27/2014 01:32 AM, Daniel Mack wrote: On 06/26/2014 12:33 PM, AKASHI Takahiro wrote: Assuming that attaching meta is necessary but its also expensive, it might be a good idea to have and check meta info not per message, but per connection.

Re: [systemd-devel] [RFC 4/8] HACK0: allow meta information customizable

2014-06-27 Thread Djalal Harouni
On Fri, Jun 27, 2014 at 11:24:48AM +0200, Daniel Mack wrote: On 06/27/2014 11:06 AM, AKASHI Takahiro wrote: On 06/27/2014 01:32 AM, Daniel Mack wrote: On 06/26/2014 12:33 PM, AKASHI Takahiro wrote: Assuming that attaching meta is necessary but its also expensive, it might be a good

Re: [systemd-devel] [RFC 4/8] HACK0: allow meta information customizable

2014-06-27 Thread Daniel Mack
On 06/27/2014 11:33 AM, Djalal Harouni wrote: On Fri, Jun 27, 2014 at 11:24:48AM +0200, Daniel Mack wrote: No, that's what I'm saying. We cannot cache anything as any information may change at any time. The rule here is simple: if you want metadata, you have to be aware that they come at a

Re: [systemd-devel] [RFC 4/8] HACK0: allow meta information customizable

2014-06-27 Thread Djalal Harouni
On Fri, Jun 27, 2014 at 11:44:06AM +0200, Daniel Mack wrote: On 06/27/2014 11:33 AM, Djalal Harouni wrote: On Fri, Jun 27, 2014 at 11:24:48AM +0200, Daniel Mack wrote: No, that's what I'm saying. We cannot cache anything as any information may change at any time. The rule here is simple:

[systemd-devel] [PATCH 0/4] kdbus: improve benchmark by using cached metadata

2014-06-27 Thread Djalal Harouni
Hi, First this is just to investigate things! and if it follows kdbus use cases. This is in the spirit of the late kdbus benchmark threads. Do not apply, just trying to investigate things and if it is really useful. I did benchmarks and the improvement is say ~50%, but did not post numbers,

[systemd-devel] [PATCH 1/4] kdbus: add KDBUS_HELLO_CACHE_META to use the cached metadata

2014-06-27 Thread Djalal Harouni
Collecting metadata for kdbus is a heavy operation, in the other hand it is very useful and part of kdbus design. To reduce calls to kdbus_meta_append() and the metadata collection overhead, introduce the KDBUS_HELLO_CACHE_META flag that will only be available to privileged bus users. This flag

[systemd-devel] [PATCH 2/4] metadata: add kdbus_meta_memdup() to dup a metadata object

2014-06-27 Thread Djalal Harouni
This is a preparation patch thats add kdbus_meta_memdup() to memdup a metadata object. This is useful to connections with a KDBUS_HELLO_CACHE_META flag. Signed-off-by: Djalal Harouni tix...@opendz.org --- metadata.c | 27 +++ metadata.h | 3 ++- 2 files changed, 29

[systemd-devel] [PATCH 3/4] connection: use the already cached metadata if KDBUS_HELLO_CACHE_META is set

2014-06-27 Thread Djalal Harouni
For connections with the KDBUS_HELLO_CACHE_META flag dup the metadata/credentials from handle or from the HELLO cmd, and use it to construct kdbus kmsg object, this improves benchmark by ~50% The KDBUS_HELLO_CACHE_META flag is only for privileged bus users, others will fail with -EPERM.

[systemd-devel] [PATCH 4/4] kdbus-benchmark: use KDBUS_HELLO_CACHE_META to improve benchmark

2014-06-27 Thread Djalal Harouni
Use the new KDBUS_HELLO_CACHE_META flag to improve benchmark by ~50% This reduces latency and allows sending metadata at the same time. Signed-off-by: Djalal Harouni tix...@opendz.org --- test/test-kdbus-benchmark.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [systemd-devel] [PATCH 3/4] connection: use the already cached metadata if KDBUS_HELLO_CACHE_META is set

2014-06-27 Thread Kay Sievers
On Fri, Jun 27, 2014 at 12:32 PM, Djalal Harouni tix...@opendz.org wrote: For connections with the KDBUS_HELLO_CACHE_META flag dup the metadata/credentials from handle or from the HELLO cmd, and use it to construct kdbus kmsg object, this improves benchmark by ~50% The KDBUS_HELLO_CACHE_META

[systemd-devel] kdbus performance regression by ~70% on 3.15 kernels ?

2014-06-27 Thread Djalal Harouni
Hi, Just to let you know that I did notice a regression by ~70% when running test-kdbus-benchmark on a kvm guest (that's what I've under hands now) I know sorry, but still a kdbus on kvm is a valid case, I don't know if this affects real machine or only kvm guests will be able to confirm it next

Re: [systemd-devel] [PATCH 3/4] connection: use the already cached metadata if KDBUS_HELLO_CACHE_META is set

2014-06-27 Thread Daniel Mack
On 06/27/2014 12:46 PM, Kay Sievers wrote: On Fri, Jun 27, 2014 at 12:32 PM, Djalal Harouni tix...@opendz.org wrote: For connections with the KDBUS_HELLO_CACHE_META flag dup the metadata/credentials from handle or from the HELLO cmd, and use it to construct kdbus kmsg object, this improves

Re: [systemd-devel] kdbus performance regression by ~70% on 3.15 kernels ?

2014-06-27 Thread Daniel Mack
On 06/27/2014 12:51 PM, Djalal Harouni wrote: Just to let you know that I did notice a regression by ~70% when running test-kdbus-benchmark on a kvm guest (that's what I've under hands now) I know sorry, but still a kdbus on kvm is a valid case, I don't know if this affects real machine or

Re: [systemd-devel] kdbus performance regression by ~70% on 3.15 kernels ?

2014-06-27 Thread Djalal Harouni
On Fri, Jun 27, 2014 at 01:04:00PM +0200, Daniel Mack wrote: On 06/27/2014 12:51 PM, Djalal Harouni wrote: Just to let you know that I did notice a regression by ~70% when running test-kdbus-benchmark on a kvm guest (that's what I've under hands now) I know sorry, but still a kdbus on

Re: [systemd-devel] Keyring service as a natural use-case for systemd?

2014-06-27 Thread Lennart Poettering
On Wed, 25.06.14 14:25, Anatol Pomozov (anatol.pomo...@gmail.com) wrote: Haya, One of the weirdest decisions made by ssh/gpg developers is using environment variables to pass information about agent processes. Why don't they use some well-known location for the socket file like any other

Re: [systemd-devel] [systemd-commits] 14 commits - configure.ac Makefile.am Makefile-man.am man/coredump.conf.xml src/core src/journal src/shared

2014-06-27 Thread Lennart Poettering
On Wed, 25.06.14 22:49, Zbigniew Jędrzejewski-Szmek (zbys...@kemper.freedesktop.org) wrote: + varlistentry +termvarnameCompression=/varname/term + +listitemparaControls the type of compression for external +storage. One of literalxz/literal or +

Re: [systemd-devel] [PATCH] timer: name the stamp file consistently

2014-06-27 Thread Lennart Poettering
On Thu, 26.06.14 13:23, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Thu, Jun 26, 2014 at 10:16:27AM +0200, Michał Bartoszkiewicz wrote: The stamp file for systemd --user timers was named stamp-foo.timer if XDG_DATA_HOME was unset, but foo.timer otherwise. ---

[systemd-devel] Locking current session programmatically

2014-06-27 Thread Ivan Shapovalov
I want to lock my current session using a command-line tool (or a D-Bus call). The only apparent way to do this is `loginctl lock-session $XDG_SESSION_ID`. However, this results in an Access denied reply, which is somewhat strange (I expect to be able to lock my own session). Is this by design

Re: [systemd-devel] [systemd-commits] 14 commits - configure.ac Makefile.am Makefile-man.am man/coredump.conf.xml src/core src/journal src/shared

2014-06-27 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jun 27, 2014 at 03:22:50PM +0200, Lennart Poettering wrote: On Wed, 25.06.14 22:49, Zbigniew Jędrzejewski-Szmek (zbys...@kemper.freedesktop.org) wrote: + varlistentry +termvarnameCompression=/varname/term + +listitemparaControls the type of compression for

Re: [systemd-devel] [PATCH] timer: name the stamp file consistently

2014-06-27 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jun 27, 2014 at 03:31:05PM +0200, Lennart Poettering wrote: On Thu, 26.06.14 13:23, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Thu, Jun 26, 2014 at 10:16:27AM +0200, Michał Bartoszkiewicz wrote: The stamp file for systemd --user timers was named stamp-foo.timer if

Re: [systemd-devel] Keyring service as a natural use-case for systemd?

2014-06-27 Thread Mantas Mikulėnas
I don't think the kernel keyring would work for ssh-agent or gpg-agent. The point of using an agent is *not* just providing dumb secret storage, but moving the actual crypto functions to the agent, so that the UIs (ssh, scp, gpg as of v2.1) won't *ever* deal with unlocked keys. (The agents

Re: [systemd-devel] Keyring service as a natural use-case for systemd?

2014-06-27 Thread Lennart Poettering
On Fri, 27.06.14 18:08, Mantas Mikulėnas (graw...@gmail.com) wrote: (The agents usually set themselves as undumpable and untraceable to avoid key extraction by the same user's other processes.) Honestly, playing these games with trying to protect a user processes from its own user, are snake

Re: [systemd-devel] Locking current session programmatically

2014-06-27 Thread Jan Alexander Steffens
Am 27.06.2014 15:45 schrieb Ivan Shapovalov intelfx...@gmail.com: I want to lock my current session using a command-line tool (or a D-Bus call). The only apparent way to do this is `loginctl lock-session $XDG_SESSION_ID`. However, this results in an Access denied reply, which is somewhat

Re: [systemd-devel] [systemd-commits] 14 commits - configure.ac Makefile.am Makefile-man.am man/coredump.conf.xml src/core src/journal src/shared

2014-06-27 Thread Uoti Urpala
On Fri, 2014-06-27 at 16:17 +0200, Zbigniew Jędrzejewski-Szmek wrote: Hm, I did some testing, and I'm not convinced that XZ is the right compressor for the job. First I generated a 1GB coredump of Python with random patterns. It takes 20 minutes (!) to compress with XZ 9, and 11.5 min with

Re: [systemd-devel] [systemd-commits] 14 commits - configure.ac Makefile.am Makefile-man.am man/coredump.conf.xml src/core src/journal src/shared

2014-06-27 Thread Lennart Poettering
On Fri, 27.06.14 16:17, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Fri, Jun 27, 2014 at 03:22:50PM +0200, Lennart Poettering wrote: On Wed, 25.06.14 22:49, Zbigniew Jędrzejewski-Szmek (zbys...@kemper.freedesktop.org) wrote: + varlistentry +

Re: [systemd-devel] [PATCH] [RFCv7] Optionally save core dumps as plain files

2014-06-27 Thread Lennart Poettering
On Tue, 24.06.14 15:21, Lennart Poettering (lenn...@poettering.net) wrote: On Mon, 23.06.14 14:29, Dave Reisner (d...@falconindy.com) wrote: Anyway, I hope this makes sense. With these changes coredumpctl actually is now really useful and just works. I have thus dropped the

Re: [systemd-devel] Locking current session programmatically

2014-06-27 Thread Lennart Poettering
On Fri, 27.06.14 17:45, Ivan Shapovalov (intelfx...@gmail.com) wrote: I want to lock my current session using a command-line tool (or a D-Bus call). The only apparent way to do this is `loginctl lock-session $XDG_SESSION_ID`. However, this results in an Access denied reply, which is somewhat

Re: [systemd-devel] [PATCH] journald: make MaxFileSec really default to 1month

2014-06-27 Thread Lennart Poettering
On Thu, 26.06.14 22:11, Michał Bartoszkiewicz (mbartoszkiew...@gmail.com) wrote: journald.conf(5) states that the default for MaxFileSec is one month, but the code didn't respect that. Makes sense, applied! Lennart -- Lennart Poettering, Red Hat

Re: [systemd-devel] Systemd stops

2014-06-27 Thread Lennart Poettering
On Wed, 25.06.14 10:54, Jay D Bhatt (jay.bh...@igate.com) wrote: Hi, Finally I was able to get the my systemd running for multi-user mode, so I got login , password and then I could login and get prompt. I removed few services which were hindering the progress and included

Re: [systemd-devel] [PATCH] rules: don't enable usb pm for Avocent devices

2014-06-27 Thread Kay Sievers
On Wed, Jun 25, 2014 at 1:57 PM, Tom Hirst tom.hi...@ipe-systems.co.uk wrote: The Avocent KVM over IP devices doesn't work correctly with USB power management enabled. --- rules/42-usb-hid-pm.rules | 4 1 file changed, 4 deletions(-) Applied. Thanks, Kay

Re: [systemd-devel] [PATCH] Add support for DHCP static route options in networkd

2014-06-27 Thread Marcel Holtmann
Hi Lennart, I am tempted to say that we should try to apply as much information from DHCP as we can by default, but make sure it doesn't become a security problem. i.e. we should probably use metrics or so so that manual routes always win, or routes to other interfaces. I think using

Re: [systemd-devel] [PATCH] core: Don't require cgroups xattr support

2014-06-27 Thread Cristian Rodríguez
El 26/06/14 01:58, Zbigniew Jędrzejewski-Szmek escribió: On Wed, Jun 25, 2014 at 11:45:45AM +, Tom Hirst wrote: Failure to mount cgroups with xattr should not be fatal --- src/core/mount-setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/mount-setup.c

Re: [systemd-devel] git requires now linux api userspace headers = 3.13 to build?

2014-06-27 Thread Lennart Poettering
On Fri, 30.05.14 12:05, Wulf C. Krueger (philant...@exherbo.org) wrote: On 31.03.2014 17:18, Tom Gundersen wrote: I remember reading a while back here = 3.7 being required and that being reworked to not require so new, but looks like something backfired there... Ah, my bad. I did the

Re: [systemd-devel] [PATCH] Add support for DHCP static route options in networkd

2014-06-27 Thread Lennart Poettering
On Thu, 26.06.14 12:49, Eugene Yakubovich (eyakubov...@gmail.com) wrote: On Thu, Jun 26, 2014 at 11:17 AM, Lennart Poettering lenn...@poettering.net wrote: I am tempted to say that we should try to apply as much information from DHCP as we can by default, but make sure it doesn't become

Re: [systemd-devel] [PATCH] timer: name the stamp file consistently

2014-06-27 Thread Simon Peeters
2014-06-27 19:49 GMT+02:00 Lennart Poettering lenn...@poettering.net: Hmm, are you saying the current logic is no stamp file, trigger immediately? And you say it should be no stamp file, pretend there was one with the current time? no, afaik what he is saying that the current logic is indeed,

Re: [systemd-devel] [PATCH] Add support for DHCP static route options in networkd

2014-06-27 Thread Eugene Yakubovich
On Fri, Jun 27, 2014 at 11:09 AM, Marcel Holtmann mar...@holtmann.org wrote: Hmm, something in the middle of the range, I figure, that is still nice to type and look at for whatever that is. pick something... Also I figure the default route added due to dhcp config should also use this same

Re: [systemd-devel] Keyring service as a natural use-case for systemd?

2014-06-27 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jun 27, 2014 at 05:47:01PM +0200, Lennart Poettering wrote: On Fri, 27.06.14 18:08, Mantas Mikulėnas (graw...@gmail.com) wrote: (The agents usually set themselves as undumpable and untraceable to avoid key extraction by the same user's other processes.) Honestly, playing these

Re: [systemd-devel] [PATCH] timer: name the stamp file consistently

2014-06-27 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jun 27, 2014 at 08:18:18PM +0200, Simon Peeters wrote: 2014-06-27 19:49 GMT+02:00 Lennart Poettering lenn...@poettering.net: Hmm, are you saying the current logic is no stamp file, trigger immediately? And you say it should be no stamp file, pretend there was one with the current

Re: [systemd-devel] kdbus performance regression by ~70% on 3.15 kernels ?

2014-06-27 Thread Djalal Harouni
On Fri, Jun 27, 2014 at 12:23:05PM +0100, Djalal Harouni wrote: On Fri, Jun 27, 2014 at 01:04:00PM +0200, Daniel Mack wrote: On 06/27/2014 12:51 PM, Djalal Harouni wrote: Just to let you know that I did notice a regression by ~70% when running test-kdbus-benchmark on a kvm guest (that's

Re: [systemd-devel] kdbus performance regression by ~70% on 3.15 kernels ?

2014-06-27 Thread Greg KH
On Fri, Jun 27, 2014 at 10:19:03PM +0100, Djalal Harouni wrote: On Fri, Jun 27, 2014 at 12:23:05PM +0100, Djalal Harouni wrote: On Fri, Jun 27, 2014 at 01:04:00PM +0200, Daniel Mack wrote: On 06/27/2014 12:51 PM, Djalal Harouni wrote: Just to let you know that I did notice a regression

Re: [systemd-devel] [PATCH resend] Add support for DHCP static route options in networkd

2014-06-27 Thread Eugene Yakubovich
On Thu, Jun 26, 2014 at 1:45 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: +r = sd_dhcp_lease_get_routes(link-dhcp_lease, static_routes, static_routes_size); +if (r = 0) { +for (i = 0; i static_routes_size; i++) { +

[systemd-devel] [PATCH v2] Add support for DHCP static route options

2014-06-27 Thread Eugene Yakubovich
This adds support for DHCP options 33 and 121: Static Route and Classless Static Route. To enable this feature, set UseRoutes=true in .network file. Returned routes are added to the routing table. --- man/systemd.network.xml | 7 ++

Re: [systemd-devel] kdbus performance regression by ~70% on 3.15 kernels ?

2014-06-27 Thread Djalal Harouni
On Fri, Jun 27, 2014 at 02:28:56PM -0700, Greg KH wrote: On Fri, Jun 27, 2014 at 10:19:03PM +0100, Djalal Harouni wrote: On Fri, Jun 27, 2014 at 12:23:05PM +0100, Djalal Harouni wrote: On Fri, Jun 27, 2014 at 01:04:00PM +0200, Daniel Mack wrote: On 06/27/2014 12:51 PM, Djalal Harouni

Re: [systemd-devel] kdbus performance regression by ~70% on 3.15 kernels ?

2014-06-27 Thread Djalal Harouni
On Fri, Jun 27, 2014 at 04:55:30PM -0700, Steven Noonan wrote: On Fri, Jun 27, 2014 at 3:14 PM, Djalal Harouni tix...@opendz.org wrote: On Fri, Jun 27, 2014 at 02:28:56PM -0700, Greg KH wrote: On Fri, Jun 27, 2014 at 10:19:03PM +0100, Djalal Harouni wrote: On Fri, Jun 27, 2014 at

[systemd-devel] [PATCH 3/3] doc: use expanded forms for written style

2014-06-27 Thread Jan Engelhardt
--- CODING_STYLE | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/CODING_STYLE b/CODING_STYLE index e192944..e22c1ed 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -23,14 +23,14 @@ more than one cause, it *really* should have int as return value

[systemd-devel] [PATCH 1/3] doc: grammatical corrections

2014-06-27 Thread Jan Engelhardt
--- CODING_STYLE| 24 ++--- NEWS| 46 - README | 8 +++ man/coredump.conf.xml | 2 +- man/coredumpctl.xml | 2 +- man/hostnamectl.xml

[systemd-devel] [PATCH 2/3] doc: typographical improvements and choice of words

2014-06-27 Thread Jan Engelhardt
--- CODING_STYLE| 10 +- NEWS| 4 ++-- man/sysctl.d.xml| 4 ++-- man/systemd.network.xml | 4 ++-- man/tmpfiles.d.xml | 2 +- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/CODING_STYLE b/CODING_STYLE index

[systemd-devel] The usual document updates

2014-06-27 Thread Jan Engelhardt
The following changes since commit 102bd40e1ed71c7ab980a90435a1c23d4c786c63: man: split systemd.network(5) and related into various sections for better readability (2014-06-27 20:50:08 +0200) are available in the git repository at: git://git.inai.de/systemd HEAD for you to fetch changes

[systemd-devel] networkd losing dhcp lease with dracut / nfs root

2014-06-27 Thread Rich Freeman
I'm running systemd-212 and dracut-037, on a diskless box with an nfs root and pxe boot. After a number of updates I noticed that the box would freeze up after 24h uptime - almost exactly. This behavior is the same whether I have systemd-networkd running or not (it is configured to set up any

[systemd-devel] [PATCH 1/3] Move x-systemd-device.timeout handling from core to fstab-generator

2014-06-27 Thread Zbigniew Jędrzejewski-Szmek
Instead of adjusting job timeouts in the core, let fstab-generator write out a dropin snippet with the appropriate JobTimeout. x-systemd-device.timeout option is removed from Options= line in the generated unit. The functions to write dropins are moved from core/unit.c to shared/dropin.c, to make

[systemd-devel] [PATCH 0/3] move timeout handling out of the core

2014-06-27 Thread Zbigniew Jędrzejewski-Szmek
Hi, this patch series continues the trend of moving stuff out of the core into generators. As a prerequisite for 3/3, it was necessary to move some code from core to shared. If comments are not counted, series is line-count-wise neutral, but I think it makes things cleaner and easier to

[systemd-devel] [PATCH 3/3] cryptsetup: allow x-systemd.device-timeout

2014-06-27 Thread Zbigniew Jędrzejewski-Szmek
https://bugs.freedesktop.org/show_bug.cgi?id=54210 --- src/core/unit.c | 4 ++-- src/cryptsetup/cryptsetup-generator.c | 25 - src/shared/dropin.c | 16 ++-- src/shared/dropin.h | 6 +++---

[systemd-devel] [PATCH 2/3] fstab-generator: allow x-systemd.device-timeout for swap units

2014-06-27 Thread Zbigniew Jędrzejewski-Szmek
--- src/fstab-generator/fstab-generator.c | 5 + src/shared/generator.c| 24 +++- 2 files changed, 20 insertions(+), 9 deletions(-) diff --git src/fstab-generator/fstab-generator.c src/fstab-generator/fstab-generator.c index 6f392dfd4d..1256a1ce53 100644

Re: [systemd-devel] The usual document updates

2014-06-27 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Jun 28, 2014 at 03:39:30AM +0200, Jan Engelhardt wrote: The following changes since commit 102bd40e1ed71c7ab980a90435a1c23d4c786c63: man: split systemd.network(5) and related into various sections for better readability (2014-06-27 20:50:08 +0200) Thanks, applied. Zbyszek

[systemd-devel] regression in a4a878d0 (units: introduce network-pre.target...)

2014-06-27 Thread Gerardo Exequiel Pozzi
Hello Looks like this commit also changes a unrelated file (units/local-fs.target) reverting the commit 40f862e3 (filesystem targets: disable default dependencies) The side effect, at least in my case is that the nofail option in both crypttab and fstab has partial effect does the default