[systemd-devel] [PATCH 2/2] bootchart: ask for --rel when failed to initialize graph start time

2014-07-31 Thread Karel Zak
We always read system uptime before log start time. So the uptime should be always smaller number, except it includes system suspend time. It seems better to ask for --rel and exit() than try to be smart and try to recovery from this situation or generate huge messy graphs. ---

[systemd-devel] [PATCH 1/2] bootchart: don't parse /proc/uptime, use CLOCK_BOOTTIME

2014-07-31 Thread Karel Zak
* systemd-bootchart always parses /proc/uptime, although the information is unnecessary when --rel specified * use /proc/uptime is overkill, since Linux 2.6.39 we have clock_gettime(CLOCK_BOOTTIME, ...). The backend on kernel side is get_monotonic_boottime() in both cases. * main() uses if

Re: [systemd-devel] Support for pre-restart check

2014-07-31 Thread Jóhann B. Guðmundsson
On 07/31/2014 12:41 AM, Michael Biebl wrote: 2014-07-30 14:34 GMT+02:00 Reindl Harald h.rei...@thelounge.net: ExecStopPre would be better suited as the pre-restart check because it would achieve the goal and also prevent stop a service until it's configuration is fixed - that catchs cases

Re: [systemd-devel] Support for pre-restart check

2014-07-31 Thread Reindl Harald
Am 31.07.2014 um 07:03 schrieb Jóhann B. Guðmundsson: On 07/31/2014 12:16 AM, Colin Guthrie wrote: I think the use case is pretty clear tho'. Config (or general machine state) has transitioned from working to broken in the time since the service was started and while it's really not a nice

Re: [systemd-devel] Support for pre-restart check

2014-07-31 Thread Reindl Harald
Am 31.07.2014 um 02:41 schrieb Michael Biebl: 2014-07-30 14:34 GMT+02:00 Reindl Harald h.rei...@thelounge.net: ExecStopPre would be better suited as the pre-restart check because it would achieve the goal and also prevent stop a service until it's configuration is fixed - that catchs cases

Re: [systemd-devel] Support for pre-restart check

2014-07-31 Thread Mantas Mikulėnas
On Jul 31, 2014 12:57 PM, Reindl Harald h.rei...@thelounge.net wrote: Am 31.07.2014 um 02:16 schrieb Colin Guthrie: Reindl Harald wrote on 30/07/14 13:34: *how* should that both help in calling apachectl -t *before* stop the service and in case of a error-repsonse keep it running? Note,

[systemd-devel] [PATCH] build-sys: check for intltool also when polkit is enabled

2014-07-31 Thread Robert Schiele
intltool is needed for nls _and_ polkit, thus the check needs to be changed to do the test whenever one of them is enables. Without this build fails when configured with --disable-nls --enable-polkit --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [systemd-devel] [PATCH] build-sys: check for intltool also when polkit is enabled

2014-07-31 Thread Samuli Suominen
On 31/07/14 15:18, Robert Schiele wrote: intltool is needed for nls _and_ polkit, thus the check needs to be changed to do the test whenever one of them is enables. Without this build fails when configured with --disable-nls --enable-polkit --- configure.ac | 2 +- 1 file changed, 1

[systemd-devel] Pairing udev's SYSTEMD_WANTS and systemd's templated units

2014-07-31 Thread Ivan Shapovalov
Hello all, I'm trying to start from an udev rule a templated systemd unit, whose instance should be a properly escaped device node path (so that %i.device would represent an existing unit). Which udev specifier should I use for this? Or, in more clear wording: given the rule: ACTION==add, ...,

Re: [systemd-devel] [PATCH] build-sys: check for intltool also when polkit is enabled

2014-07-31 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jul 31, 2014 at 03:37:40PM +0300, Samuli Suominen wrote: On 31/07/14 15:18, Robert Schiele wrote: intltool is needed for nls _and_ polkit, thus the check needs to be changed to do the test whenever one of them is enables. Without this build fails when configured with

Re: [systemd-devel] [PATCH 1/5] test: correctly set the 'ret' variable

2014-07-31 Thread Kay Sievers
On Wed, Jul 23, 2014 at 6:34 PM, Djalal Harouni tix...@opendz.org wrote: Signed-off-by: Djalal Harouni tix...@opendz.org --- test/test-kdbus-policy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Applied. Thanks, Kay ___ systemd-devel

Re: [systemd-devel] [PATCH 0/5] kdbus: allow multiple policies

2014-07-31 Thread Kay Sievers
On Wed, Jul 23, 2014 at 6:34 PM, Djalal Harouni tix...@opendz.org wrote: This series adds the infrastructure to test and upload multiple policies. The last #5 patch allows to upload multiple policies per connection What is the reason for this? A policy holding connection (which matches a

Re: [systemd-devel] [PATCH] allow systemd to manage loop device partitions

2014-07-31 Thread Kay Sievers
On Thu, Jul 31, 2014 at 4:00 AM, Kevin Wells wellsie1...@gmail.com wrote: SYSTEMD_READY is currently set to 0 for all loop devices (loop[0-9]*) that do not have a backing_file. Partitioned loop devices (ex. loop0p1), however, are matched by this rule and excluded by systemd even though they

Re: [systemd-devel] [PATCH 0/5] kdbus: allow multiple policies

2014-07-31 Thread Djalal Harouni
(Cc'ed Lennart) On Thu, Jul 31, 2014 at 05:40:53PM +0200, Kay Sievers wrote: On Wed, Jul 23, 2014 at 6:34 PM, Djalal Harouni tix...@opendz.org wrote: This series adds the infrastructure to test and upload multiple policies. The last #5 patch allows to upload multiple policies per

Re: [systemd-devel] [PATCH 0/5] kdbus: allow multiple policies

2014-07-31 Thread Kay Sievers
On Thu, Jul 31, 2014 at 8:57 PM, Djalal Harouni tix...@opendz.org wrote: (Cc'ed Lennart) On Thu, Jul 31, 2014 at 05:40:53PM +0200, Kay Sievers wrote: On Wed, Jul 23, 2014 at 6:34 PM, Djalal Harouni tix...@opendz.org wrote: This series adds the infrastructure to test and upload multiple

Re: [systemd-devel] Pairing udev's SYSTEMD_WANTS and systemd's templated units

2014-07-31 Thread Michael Biebl
I suggested something like this in [1] but in the end a systemd-escape utility was added [2]. Since you can't use ENV to set dynamic variables, you might do that via a RUN rule instead. HTH, Michael [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=747044#25 [2]