[systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Umut Tezduyar Lindskog
--- Makefile-man.am | 9 ++--- Makefile.am | 2 ++ configure.ac| 6 ++ 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/Makefile-man.am b/Makefile-man.am index 45b8238..c6506aa 100644 --- a/Makefile-man.am +++ b/Makefile-man.am @@ -14,7 +14,6 @@ MANPAGES += \

Re: [systemd-devel] mount failed because the mount point dir doesn't exist

2014-12-19 Thread Lennart Poettering
On Fri, 19.12.14 10:58, Baoquan He (b...@redhat.com) wrote: Hi, Now I encountered a prlblem. When I add an entry in /etc/fstab to mount a disk on a dir like below, mount can be done successfully though /aa/bb doesn't exist. _ _ _ _ _ /dev/disk/by-uuid/xxx-xxx /aa/bb xfs defaults 0 2

[systemd-devel] [PATCHv2] build: add option to disable hwdb

2014-12-19 Thread Umut Tezduyar Lindskog
Umut: I can't generate man list since I am cross compiling Please run make update-man-list and include changes on Makefile-man.am. I have updated the Makefile-man.am manually on v1, even though very first that file says DO NOT EDIT IT. --- Makefile.am | 2 ++ configure.ac | 6 ++ 2 files

[systemd-devel] [PATCH 1/4] path-lookup, systemctl: export lookup_paths_init_from_scope() from shared/install.c and use it

2014-12-19 Thread Ivan Shapovalov
--- src/shared/install.c | 16 src/shared/path-lookup.c | 16 src/shared/path-lookup.h | 4 src/systemctl/systemctl.c | 6 +- 4 files changed, 21 insertions(+), 21 deletions(-) diff --git a/src/shared/install.c b/src/shared/install.c index

[systemd-devel] [PATCH 4/4] systemctl: unit_find_paths(): unify error handling in two code pathes

2014-12-19 Thread Ivan Shapovalov
--- src/systemctl/systemctl.c | 63 ++- 1 file changed, 35 insertions(+), 28 deletions(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 20c367c..2a4e2a2 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c

[systemd-devel] [PATCH 2/4] systemctl: edit: improve error messages, report actual error for units which could not be loaded

2014-12-19 Thread Ivan Shapovalov
Not found condition in find_paths_to_edit() has been made non-fatal because the error message in edit() (Cannot find any units to edit) suggests that. Error messages in edit() themselves have been removed because - result of expand_names() is not checked anywhere else - an extra cannot find any

[systemd-devel] [PATCH 3/4] systemctl: edit: further reword error messages

2014-12-19 Thread Ivan Shapovalov
--- src/systemctl/systemctl.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 658793e..20c367c 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -4776,7 +4776,7 @@

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Michael Biebl
+if ENABLE_HWDB +MANPAGES += \ +man/hwdb.7 +man/systemd-hwdb.xml Shouldn't this rather be systemd-hwdb.8 ? I also don't see a reason to remove man/systemd-hwdb.xml from EXTRA_DIST. You want to include that file in the dist tarball always. 2014-12-19 13:25 GMT+01:00 Tom Gundersen

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Michael Biebl
That said, Makefile-man.am contains a comment, that this file shouldn't be edited directly but rather be updated via make update-man-list 2014-12-19 15:12 GMT+01:00 Michael Biebl mbi...@gmail.com: +if ENABLE_HWDB +MANPAGES += \ +man/hwdb.7 +man/systemd-hwdb.xml Shouldn't

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Umut Tezduyar Lindskog
:) See my second patch's comment Michael. On Fri, Dec 19, 2014 at 3:17 PM, Michael Biebl mbi...@gmail.com wrote: That said, Makefile-man.am contains a comment, that this file shouldn't be edited directly but rather be updated via make update-man-list 2014-12-19 15:12 GMT+01:00 Michael Biebl

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Michael Biebl
Here is an updated patch, using conditionals as suggested by Makefile-man.am and regenerating Makefile-man.am by running make update-man-list This also removed the HAVE_PYTHON section from Makefile-man.am. Why it did that is unclear to me. Maybe Zbigniew can chime in here. 2014-12-19 15:24

[systemd-devel] [PATCH udev v2] udev: Add program/rule to export touchscreen/tablet size as udev properties

2014-12-19 Thread Carlos Garnacho
This rule is only run on tablet/touchscreen devices, and extracts their size in millimeters, as it can be found out through their struct input_absinfo. This may be useful to separate policy and application at the time of mapping these devices to the available outputs in windowing environments

Re: [systemd-devel] [systemd-commits] src/journal

2014-12-19 Thread Filipe Brandenburger
Hi, This seems to have fixed test-journal-stream but test-journal-interleaving is still broken for me, it fails with: NUMBER=1 NUMBER=2 Assertion 'r == 1' failed at src/journal/test-journal-interleaving.c:101, function test_check_numbers_down(). Aborting. Aborted (core dumped) Can you please

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Filipe Brandenburger
On Fri, Dec 19, 2014 at 6:32 AM, Michael Biebl mbi...@gmail.com wrote: This also removed the HAVE_PYTHON section from Makefile-man.am. Why it did that is unclear to me. This happened to me before and when it did it was because ./configure didn't detect a working Python, so make update-man-list

Re: [systemd-devel] logind, su - sessions and initscripts compatibility

2014-12-19 Thread Dale R. Worley
Simon McVittie simon.mcvit...@collabora.co.uk writes: On 18/12/14 14:10, Dale R. Worley wrote: Simon McVittie simon.mcvit...@collabora.co.uk writes: On 18/12/14 08:05, Andrei Borzenkov wrote: Any initscript that is using su - would [cause badness] Don't do that then? Init scripts are fairly

Re: [systemd-devel] [dm-devel] multipath breaks with recent udev/systemd

2014-12-19 Thread Benjamin Marzinski
On Fri, Dec 19, 2014 at 08:21:57AM +0100, Hannes Reinecke wrote: On 12/18/2014 11:04 PM, Benjamin Marzinski wrote: On Wed, Dec 17, 2014 at 01:04:54PM +0100, Hannes Reinecke wrote: On 12/16/2014 11:18 PM, Benjamin Marzinski wrote: On Tue, Dec 16, 2014 at 04:10:44PM -0600, Benjamin Marzinski

Re: [systemd-devel] [PATCH udev v2] udev: Add program/rule to export touchscreen/tablet size as udev properties

2014-12-19 Thread Lennart Poettering
On Fri, 19.12.14 16:01, Carlos Garnacho (carl...@gnome.org) wrote: + +#include linux/input.h +#include udev.h + +/* Resolution is defined to be in units/mm for ABS_X/Y */ +#define ABS_SIZE_MM(absinfo) ((absinfo.maximum - absinfo.minimum) / absinfo.resolution) Just out of principle: can

Re: [systemd-devel] [systemd-commits] src/journal

2014-12-19 Thread Michal Schmidt
On 12/19/2014 04:49 PM, Filipe Brandenburger wrote: This seems to have fixed test-journal-stream but test-journal-interleaving is still broken for me, it fails with: NUMBER=1 NUMBER=2 Assertion 'r == 1' failed at src/journal/test-journal-interleaving.c:101, function

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Michael Biebl
2014-12-19 17:10 GMT+01:00 Filipe Brandenburger filbran...@google.com: On Fri, Dec 19, 2014 at 6:32 AM, Michael Biebl mbi...@gmail.com wrote: This also removed the HAVE_PYTHON section from Makefile-man.am. Why it did that is unclear to me. This happened to me before and when it did it was

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Filipe Brandenburger
On Fri, Dec 19, 2014 at 8:31 AM, Michael Biebl mbi...@gmail.com wrote: 2014-12-19 17:10 GMT+01:00 Filipe Brandenburger filbran...@google.com: On Fri, Dec 19, 2014 at 6:32 AM, Michael Biebl mbi...@gmail.com wrote: This also removed the HAVE_PYTHON section from Makefile-man.am. Why it did that

Re: [systemd-devel] [systemd-commits] src/journal

2014-12-19 Thread Filipe Brandenburger
On Fri, Dec 19, 2014 at 8:30 AM, Michal Schmidt mschm...@redhat.com wrote: On 12/19/2014 04:49 PM, Filipe Brandenburger wrote: This seems to have fixed test-journal-stream but test-journal-interleaving is still broken for me, it fails with: NUMBER=1 NUMBER=2 Assertion 'r == 1' failed at

Re: [systemd-devel] logind, su - sessions and initscripts compatibility

2014-12-19 Thread Andrei Borzenkov
В Fri, 19 Dec 2014 11:16:58 -0500 wor...@alum.mit.edu (Dale R. Worley) пишет: Simon McVittie simon.mcvit...@collabora.co.uk writes: On 18/12/14 14:10, Dale R. Worley wrote: Simon McVittie simon.mcvit...@collabora.co.uk writes: On 18/12/14 08:05, Andrei Borzenkov wrote: Any initscript

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Dec 19, 2014 at 08:42:13AM -0800, Filipe Brandenburger wrote: On Fri, Dec 19, 2014 at 8:31 AM, Michael Biebl mbi...@gmail.com wrote: 2014-12-19 17:10 GMT+01:00 Filipe Brandenburger filbran...@google.com: On Fri, Dec 19, 2014 at 6:32 AM, Michael Biebl mbi...@gmail.com wrote: This

Re: [systemd-devel] [PATCH udev v2] udev: Add program/rule to export touchscreen/tablet size as udev properties

2014-12-19 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Dec 19, 2014 at 04:01:11PM +0100, Carlos Garnacho wrote: This rule is only run on tablet/touchscreen devices, and extracts their size in millimeters, as it can be found out through their struct input_absinfo. This may be useful to separate policy and application at the time of mapping

Re: [systemd-devel] [PATCH udev v2] udev: Add program/rule to export touchscreen/tablet size as udev properties

2014-12-19 Thread Carlos Garnacho
Hey Lennart, On vie, 2014-12-19 at 17:20 +0100, Lennart Poettering wrote: On Fri, 19.12.14 16:01, Carlos Garnacho (carl...@gnome.org) wrote: + +#include linux/input.h +#include udev.h + +/* Resolution is defined to be in units/mm for ABS_X/Y */ +#define ABS_SIZE_MM(absinfo)

[systemd-devel] [PATCH udev v3] udev: Add builtin/rule to export touchscreen/tablet size as udev properties

2014-12-19 Thread Carlos Garnacho
This rule is only run on tablet/touchscreen devices, and extracts their size in millimeters, as it can be found out through their struct input_absinfo. This may be useful to separate policy and application at the time of mapping these devices to the available outputs in windowing environments

Re: [systemd-devel] [PATCH 1/2] networkd: Introduce Link Layer Discovery Protocol (LLDP)

2014-12-19 Thread Tom Gundersen
I have now mergede these patches, with some minor cleanups on top. Susant, please yell if I broke something when fixing the headers. Cheers, Tom On Sun, Nov 23, 2014 at 5:45 AM, Susant Sahani sus...@redhat.com wrote: This patch introduces LLDP support to networkd. it implements the receiver

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Tom Gundersen
On Fri, Dec 19, 2014 at 3:32 PM, Michael Biebl mbi...@gmail.com wrote: Here is an updated patch, using conditionals as suggested by Makefile-man.am and regenerating Makefile-man.am by running make update-man-list This also removed the HAVE_PYTHON section from Makefile-man.am. Why it did that

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Michael Biebl
2014-12-20 0:23 GMT+01:00 Tom Gundersen t...@jklm.no: On Fri, Dec 19, 2014 at 3:32 PM, Michael Biebl mbi...@gmail.com wrote: Here is an updated patch, using conditionals as suggested by Makefile-man.am and regenerating Makefile-man.am by running make update-man-list This also removed the

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Michael Biebl
2014-12-20 3:05 GMT+01:00 Michael Biebl mbi...@gmail.com: Basically you can take my patch and drop the junk which removes the Heh, this should be hunk, of course . Why is it that you spot the typo the second you press send :-) Michael -- Why is it that all of the instruments seeking

Re: [systemd-devel] [PATCH 1/2] networkd: Introduce Link Layer Discovery Protocol (LLDP)

2014-12-19 Thread Susant Sahani
Hi Tom, On Sat, 20 Dec 2014 04:40:17 +0530, Tom Gundersen t...@jklm.no wrote: I have now mergede these patches, with some minor cleanups on top. Susant, please yell if I broke something when fixing the headers. Tested and works fine. thanks ! Cheers, Tom On Sun, Nov 23, 2014 at 5:45 AM,