Re: [systemd-devel] [PATCH]fopen_temporary: close fd if fail

2015-07-09 Thread Daniel Mack
On 07/09/2015 01:52 AM, cee1 wrote: From 76a7f141d54428af3019732c0fce146f9a6f6394 Mon Sep 17 00:00:00 2001 From: cee1 fykc...@gmail.com Date: Thu, 9 Jul 2015 12:06:59 +0800 Subject: [PATCH] basic/util.c fopen_temporary(): close fd if failed --- src/basic/util.c | 1 + 1 file changed, 1

Re: [systemd-devel] About github repo and release tarball change

2015-07-09 Thread Daniel Mack
On 07/09/2015 09:28 AM, Armin K. wrote: On 09.07.2015 12:32, Andrei Borzenkov wrote: I clicked on release link and it downloaded file with name systemd-222.tar.gz. I see that there could be an issue with dumb cli clients not following redirections probably. I suppose it's a github issue

Re: [systemd-devel] About github repo and release tarball change

2015-07-09 Thread Daniel Mack
On 07/09/2015 06:32 AM, Andrei Borzenkov wrote: On Thu, Jul 9, 2015 at 12:43 PM, Armin K. kre...@email.com wrote: Now, this might be an issue with my limited git knowledge, but I don't think that's related to the web interface not showing the commits in the correct order between two release

Re: [systemd-devel] sd 221 regression: login - nonexistent sessions via lightdm

2015-07-09 Thread poma
On 09.07.2015 10:21, David Herrmann wrote: Hi On Wed, Jul 8, 2015 at 6:09 PM, poma pomidorabelis...@gmail.com wrote: On 08.07.2015 16:39, poma wrote: On 08.07.2015 13:54, David Herrmann wrote: diff --git a/src/login/logind-dbus.c b/src/login/logind-dbus.c index 82654ee..91cc67d 100644 ---

Re: [systemd-devel] difference in restart behavior between 219 and 220?

2015-07-09 Thread Andrei Borzenkov
В Thu, 9 Jul 2015 14:56:55 -0700 Vadim Berezniker va...@berezniker.com пишет: Hello, I have a scenario where a service restarts after a dependency failure in 219, but not in 220. I'm wondering if it's a systemd issue or a problem with my configuration. I've created a simple, but somewhat

Re: [systemd-devel] sd 221 regression: login - nonexistent sessions via lightdm

2015-07-09 Thread David Herrmann
Hi On Wed, Jul 8, 2015 at 6:09 PM, poma pomidorabelis...@gmail.com wrote: On 08.07.2015 16:39, poma wrote: On 08.07.2015 13:54, David Herrmann wrote: diff --git a/src/login/logind-dbus.c b/src/login/logind-dbus.c index 82654ee..91cc67d 100644 --- a/src/login/logind-dbus.c +++

Re: [systemd-devel] About github repo and release tarball change

2015-07-09 Thread Kay Sievers
On Thu, Jul 9, 2015 at 11:43 AM, Armin K. kre...@email.com wrote: I discovered a commit 2c8849add40805256156a36d7ef8c54cf019e29e by Kay Sievers which literally broke the make dist target. A lot of += were removed, making a target that appears more than once redefine itself each time instead

Re: [systemd-devel] About github repo and release tarball change

2015-07-09 Thread Armin K.
On 09.07.2015 13:44, Kay Sievers wrote: On Thu, Jul 9, 2015 at 11:43 AM, Armin K. kre...@email.com wrote: I discovered a commit 2c8849add40805256156a36d7ef8c54cf019e29e by Kay Sievers which literally broke the make dist target. A lot of += were removed, making a target that appears more

Re: [systemd-devel] About github repo and release tarball change

2015-07-09 Thread Armin K.
On 09.07.2015 14:17, Armin K. wrote: On 09.07.2015 13:44, Kay Sievers wrote: On Thu, Jul 9, 2015 at 11:43 AM, Armin K. kre...@email.com wrote: I discovered a commit 2c8849add40805256156a36d7ef8c54cf019e29e by Kay Sievers which literally broke the make dist target. A lot of += were removed,

[systemd-devel] About github repo and release tarball change

2015-07-09 Thread Armin K.
Hello, I have been systemd user since version 38 and have followed the development ever since then. But, since the move to github, it has become extremely difficult to track commits via the web interface between releases now that pull requests are preferred method of contributing. I guess main

Re: [systemd-devel] About github repo and release tarball change

2015-07-09 Thread Andrei Borzenkov
On Thu, Jul 9, 2015 at 12:43 PM, Armin K. kre...@email.com wrote: Now, this might be an issue with my limited git knowledge, but I don't think that's related to the web interface not showing the commits in the correct order between two release tags. Recently there was discussion about

Re: [systemd-devel] About github repo and release tarball change

2015-07-09 Thread Martin Pitt
Armin K. [2015-07-09 14:42 +0200]: Still, man pages and html docs issue exists. That's by design. They are built from the docbook sources. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)

Re: [systemd-devel] About github repo and release tarball change

2015-07-09 Thread Armin K.
On 09.07.2015 15:17, Martin Pitt wrote: Armin K. [2015-07-09 14:42 +0200]: Still, man pages and html docs issue exists. That's by design. They are built from the docbook sources. Martin Some new design? Previously, make dist would bundle the built sources into distribution tarball

Re: [systemd-devel] About github repo and release tarball change

2015-07-09 Thread Michael Biebl
Hi 2015-07-09 14:17 GMT+02:00 Armin K. kre...@email.com: a is systemd-221 from fd.o, b is systemd-222 generated by make dist. TL;DR - files used to build the compat libs are missing even though --enable-compat libs was specified on ./configure line before make dist was built. You need to

Re: [systemd-devel] About github repo and release tarball change

2015-07-09 Thread Armin K.
On 09.07.2015 12:32, Andrei Borzenkov wrote: On Thu, Jul 9, 2015 at 12:43 PM, Armin K. kre...@email.com wrote: So, my first question is: How do I get around this? Is there any sane way of me knowing which exactly commits happened between two release tags from the web interface? If not, is

[systemd-devel] difference in restart behavior between 219 and 220?

2015-07-09 Thread Vadim Berezniker
Hello, I have a scenario where a service restarts after a dependency failure in 219, but not in 220. I'm wondering if it's a systemd issue or a problem with my configuration. I've created a simple, but somewhat contrived repro. Service A fails on first attempt, gets restarted and succeeds.