Re: [systemd-devel] [RFC 0/6] A network proxy management daemon, systemd-proxy-discoveryd

2015-08-13 Thread Lucas De Marchi
update TODO What happened to this patch set? Are you going to send a new version? Lucas De Marchi ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-11 Thread Lucas De Marchi
then. Now when I'm reviewing pullrequests I never trust to review them directly in the browser but I rather pull all the pullrequests with a variant of your git pullnotes: alias.pullpr = fetch origin refs/pull/*:refs/pull/* -- Lucas De Marchi ___ systemd-devel

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-05 Thread Lucas De Marchi
On Fri, Jun 5, 2015 at 7:02 AM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Wed, Jun 3, 2015 at 7:48 PM, Lucas De Marchi lucas.de.mar...@gmail.com wrote: Of course this is a non-issue for several projects in github which don't have proper commit review. It's not the case of systemd

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-03 Thread Lucas De Marchi
-- Lucas De Marchi ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH] vconsole-setup: check error of child process

2015-03-13 Thread lucas . de . marchi
From: Lucas De Marchi lucas.demar...@intel.com If we don't check the error of the child process, systemd-vconsole-setup would exit with 0 even if it could not really setup the console. For a simple test, move loadkeys elsewhere and execute systemd-vconsole-setup: [root@localhost

[systemd-devel] [PATCH] vconsole-setup: check error of child process

2015-03-12 Thread lucas . de . marchi
From: Lucas De Marchi lucas.demar...@intel.com If we don't check the error of the child process, systemd-vconsole-setup would exit with 0 even if it could not really setup the console. For a simple test, move loadkeys elsewhere and execute systemd-vconsole-setup: [root@localhost

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-12 Thread Lucas De Marchi
On Thu, Mar 12, 2015 at 6:57 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Thu, Mar 12, 2015 at 11:00:55AM +0100, Kay Sievers wrote: On Thu, Mar 12, 2015 at 5:09 AM, Lucas De Marchi lucas.de.mar...@gmail.com wrote: On Tue, Mar 10, 2015 at 3:04 PM, Jeff Waugh j...@bethesignal.org

Re: [systemd-devel] [PATCH] vconsole-setup: check error of child process

2015-03-11 Thread Lucas De Marchi
On Wed, Mar 11, 2015 at 12:55 PM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Tue, Mar 10, 2015 at 8:56 PM, lucas.de.mar...@gmail.com wrote: From: Lucas De Marchi lucas.demar...@intel.com If we don't check the error of the child process, systemd-vconsole-setup would exit with 0 even

Re: [systemd-devel] [PATCH] vconsole-setup: check error of child process

2015-03-11 Thread Lucas De Marchi
. That is, don't return prematurely at all. ok... I'll send a v2 -- Lucas De Marchi ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] use dolt.m4 to speedup compilation

2015-03-05 Thread Lucas De Marchi
, dolt real1m58.653s user6m20.523s sys 0m28.920s -- Lucas De Marchi ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] use dolt.m4 to speedup compilation

2015-03-05 Thread Lucas De Marchi
On Thu, Mar 5, 2015 at 10:37 PM, j...@joshtriplett.org wrote: On Thu, Mar 05, 2015 at 10:33:19PM -0300, Lucas De Marchi wrote: On Thu, Mar 5, 2015 at 9:58 PM, j...@joshtriplett.org wrote: On Fri, Mar 06, 2015 at 12:55:38AM +0100, Michael Biebl wrote: 2015-03-05 11:58 GMT+01:00 har

[systemd-devel] [PATCH] build: export symbols to integrate mainloops

2015-01-21 Thread Lucas De Marchi
--- src/libsystemd/libsystemd.sym.m4 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libsystemd/libsystemd.sym.m4 b/src/libsystemd/libsystemd.sym.m4 index 19a49f4..41418b9 100644 --- a/src/libsystemd/libsystemd.sym.m4 +++ b/src/libsystemd/libsystemd.sym.m4 @@ -382,6 +382,9 @@ global:

Re: [systemd-devel] Improving module loading

2014-12-24 Thread Lucas De Marchi
by systemd during startup, but the module will only be loaded by the kernel when some one actually try to use them. $ ls /dev/loop-control /dev/loop-control $ lsmod | grep loop $ touch /dev/loop-control $ lsmod | grep loop loop 26560 0 -- Lucas De Marchi

Re: [systemd-devel] Improving module loading

2014-12-22 Thread Lucas De Marchi
load until it's needed I very much prefer the static nodes approach we have. Shouldn't this be used instead of filling modules-load-d with lots of entries? I really miss numbers here and more information on which modules are taking long because they are serialized. -- Lucas De Marchi

Re: [systemd-devel] [RFC PATCH 1/2] Replace mkostemp+unlink with open(O_TMPFILE)

2014-01-27 Thread Lucas De Marchi
De Marchi ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [RFC 02/12] ring: add basic ring-buffer helper

2013-11-27 Thread Lucas De Marchi
=3ba7f59e84857eb4dbe56a68fc7a3ffe8a650393 for a shorter and faster version of this. Lucas De Marchi ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] libudev: enumerate: fix NULL-deref for subsystem-matches

2013-08-30 Thread Lucas De Marchi
where the value between ? and : is inherited from the test itself... nice! this is an extension: http://gcc.gnu.org/onlinedocs/gcc/Conditionals.html As far as I know it's supported both by clang and gcc Lucas De Marchi ___ systemd-devel mailing list

[systemd-devel] [ANNOUNCE] kmod 15

2013-08-22 Thread Lucas De Marchi
to the library is kind of an workaround for people doing initrd needing their tools to be statically linked. As usual, shortlog is below. Cheers Lucas De Marchi --- Jan Engelhardt (1): depmod: add missing else clause Lucas De Marchi (15): tools: Do not link dynamically with libkmod Use

[systemd-devel] [ANNOUNCE] kmod 14

2013-07-03 Thread Lucas De Marchi
in this release. Shortlog is below. Cheers Lucas De Marchi --- Chengwei Yang (2): Several minor fixes for documentation Add document for exported enums Jan Luebbe (1): libkmod: Avoid calling syscall() with -1 Johannes Berg (1): modprobe: don't check refcount with remove command

Re: [systemd-devel] systemd fails to build with static kmod library

2013-06-03 Thread Lucas De Marchi
I think it could be acceptable upstream. Another option is... while building systemd, you could achieve something similar to (2) above without the trouble of modifying libkmod.a by passing -Wl,--exclude-libs,ALL in LDFLAGS (untested). Lucas De Marchi

Re: [systemd-devel] 2013 Plumber's CFP: Fastboot

2013-05-15 Thread Lucas De Marchi
proposed: http://wiki.linuxplumbersconf.org/2013:boot_and_core_os which sounds pretty close to fastboot? What if we merge the proposals? John, are you ok with proposing (some of) these topics in the Boot and Core OS track? I could help with the module-related part, too. Lucas De Marchi

Re: [systemd-devel] [PATCH v3] tools: add static-nodes tool

2013-04-16 Thread Lucas De Marchi
CAP_MKNOD from udev? Lucas De Marchi ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH v2] tools: add static-nodes tool

2013-04-15 Thread Lucas De Marchi
kmod_cmd kmod_cmd_static_nodes = { + .name = static-nodes, + .cmd = do_static_nodes, + .help = outputs the static-node information of the currently running kernel, +}; -- Lucas De Marchi ___ systemd-devel mailing list systemd-devel

Re: [systemd-devel] [RFC/PATCH] Use initalization instead of explicit zeroing

2013-04-05 Thread Lucas De Marchi
when you get used to it ;-) Lucas De Marchi ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] pyload.service

2012-11-05 Thread Lucas De Marchi
. I didn't really use it, though Lucas De Marchi ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] setting up to allow separate udev and systemd builds

2012-06-14 Thread Lucas De Marchi
Hi William, On Tue, Jun 12, 2012 at 2:52 PM, William Hubbs w.d.hu...@gmail.com wrote: All, on source-based distros like gentoo or lfs, and on distros that do not Don't you have the ability to split the built package in gentoo? Lucas De Marchi

[systemd-devel] [PATCH 1/2] util: introduce container_of() macro

2012-04-26 Thread Lucas De Marchi
This macro comes from kernel and it's useful for unwrapping structs inside another one. The generated code is actually the same to the one where this logic is used in udev, but using this macro is much cleaner and less error prone. --- src/shared/util.h | 11 +++ 1 file changed, 11

[systemd-devel] [PATCH 2/2] udev: use container_of() macro

2012-04-26 Thread Lucas De Marchi
--- src/libudev/libudev-list.c |8 ++-- src/udev/collect/collect.c |8 ++-- src/udev/udevd.c | 16 3 files changed, 8 insertions(+), 24 deletions(-) diff --git a/src/libudev/libudev-list.c b/src/libudev/libudev-list.c index 1fe46f3..aec334b 100644 ---

[systemd-devel] [PATCH 2/2] build-sys: separate ldflags from cflags

2012-03-19 Thread Lucas De Marchi
--- Makefile.am |1 + configure.ac |7 +-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 8f736d0..0829f06 100644 --- a/Makefile.am +++ b/Makefile.am @@ -107,6 +107,7 @@ AM_CPPFLAGS = \ -I $(top_srcdir)/src/systemd AM_CFLAGS

Re: [systemd-devel] [PATCH] man/daemon: Use pkg-config as default for --with-systemdsystemunitdir

2011-06-27 Thread Lucas De Marchi
, it will autodetect with pkg-config. Am I missing something? I don't see a reason to change this behavior and lots of packages already use this. E.g., packages may use --with-systemdsystemunitdir= in 'make distcheck' rule in order to not break dist. Lucas De Marchi

[systemd-devel] [PATCH] build-sys: make less noise when checking file

2011-01-26 Thread Lucas De Marchi
There's already a condition that gives a warning if user is cross-compiling an relying on files from the build system. AC_CHECK_FILE macro only tests for file in the build system. Hence use a simple 'test -f' that does the same job, without the warning. --- configure.ac | 14 +++--- 1

Re: [systemd-devel] [PATCH] Don't require vala if gtk is disabled

2010-11-16 Thread Lucas De Marchi
On Tue, Nov 16, 2010 at 8:04 PM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 16.11.10 11:47, Lucas De Marchi (lucas.demar...@profusion.mobi) wrote: Vala is actually not required for building the tarball, since the tarball includes generated code. However, we do require people who