Re: [systemd-devel] [RFC][PATCH] udev: net_id - support multi-function, multi-port enpo* device names

2015-07-15 Thread Michael Marineau
Found one of these fabaled multi-function network devices you dropped from the patch, an Intel I350 Gigabit device on a Supermicro X9DRI-LN4F+ motherboard. The 4 different network interfaces are all are fighting over the 'eno1' name and are functions 06:00.0, 06:00.1, 06:00.2, and 06:00.3. On Wed,

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-02 Thread Michael Marineau
On Tue, Jun 2, 2015 at 6:31 AM, Daniel Mack wrote: > On 06/02/2015 02:19 PM, Jason A. Donenfeld wrote: >> On Tue, Jun 2, 2015 at 1:06 PM, David Herrmann wrote: >>> Regarding the final github address: David Strauss kindly offered the >>> 'systemd' user to us. Hence, we hope to move the repository

Re: [systemd-devel] [PATCH] networkd: fix systemd-networkd-wait-online with multiple NICs

2015-05-20 Thread Michael Marineau
On May 20, 2015 9:48 AM, "Tom Gundersen" wrote: > > On Tue, Apr 21, 2015 at 11:59 PM, Nick Owens wrote: > > hello tom, > > > > On Mon, Apr 20, 2015 at 2:32 PM, Tom Gundersen wrote: > >> On Fri, Apr 3, 2015 at 12:48 AM, Michael Marineau > >>

Re: [systemd-devel] [PATCH v2] networkd: do not change kernel forwarding parameters when IPForwarding is unset

2015-05-15 Thread Michael Marineau
On Fri, May 15, 2015 at 1:49 PM, Tom Gundersen wrote: > On Fri, May 15, 2015 at 10:02 PM, Lennart Poettering > wrote: >> On Fri, 15.05.15 12:56, Michael Marineau (michael.marin...@coreos.com) wrote: >> >>> (build time option to ./configure that is) >> >>

Re: [systemd-devel] [PATCH v2] networkd: do not change kernel forwarding parameters when IPForwarding is unset

2015-05-15 Thread Michael Marineau
(build time option to ./configure that is) On Fri, May 15, 2015 at 12:55 PM, Michael Marineau wrote: > On Fri, May 15, 2015 at 12:52 PM, Lennart Poettering > wrote: >> On Fri, 15.05.15 12:42, Michael Marineau (michael.marin...@coreos.com) wrote: >> >>> On Fri, May 15

Re: [systemd-devel] [PATCH v2] networkd: do not change kernel forwarding parameters when IPForwarding is unset

2015-05-15 Thread Michael Marineau
On Fri, May 15, 2015 at 12:52 PM, Lennart Poettering wrote: > On Fri, 15.05.15 12:42, Michael Marineau (michael.marin...@coreos.com) wrote: > >> On Fri, May 15, 2015 at 12:18 PM, Lennart Poettering >> wrote: >> > On Fri, 15.05.15 12:08, Nick Owens (nick.ow...@coreo

Re: [systemd-devel] [PATCH v2] networkd: do not change kernel forwarding parameters when IPForwarding is unset

2015-05-15 Thread Michael Marineau
On Fri, May 15, 2015 at 12:18 PM, Lennart Poettering wrote: > On Fri, 15.05.15 12:08, Nick Owens (nick.ow...@coreos.com) wrote: > >> In 5a8bcb674f71a20e95df55319b34c556638378ce, IPForwarding was introduced >> to set forwarding flags on interfaces in .network files. networkd sets >> forwarding opti

Re: [systemd-devel] [PATCH] networkd: fix systemd-networkd-wait-online with multiple NICs

2015-04-02 Thread Michael Marineau
On Thu, Apr 2, 2015 at 3:08 PM, Nick Owens wrote: > hi, sorry for the delay. > > from > http://www.freedesktop.org/software/systemd/man/systemd-networkd-wait-online.service.html: > > "By default, it will wait for all links it is aware of and which are > managed by systemd-networkd.service(8) to b

[systemd-devel] Enabling timesyncd in virtual machines

2015-03-13 Thread Michael Marineau
Greetings, Currently systemd-timesyncd.service includes ConditionVirtualization=no, disabling it in both containers and virtual machines. Each VM platform tends to deal with or ignore the time problem in their own special ways, KVM/QEMU has the kernel time source kvm-clock, Xen has had different s

[systemd-devel] [PATCH] network: add UseNTP DHCP option

2015-03-13 Thread Michael Marineau
Despite having the internal logic in place to enable/disable using NTP servers provided by DHCP the network config didn't expose the option. --- man/systemd.network.xml | 8 src/network/networkd-network-gperf.gperf | 1 + 2 files changed, 9 insertions(+) diff --git a/man

Re: [systemd-devel] [PATCH 1/2] networkd: accept a trailing '.' on the end of domains

2015-01-28 Thread Michael Marineau
On Wed, Jan 28, 2015 at 8:49 AM, Lennart Poettering wrote: > On Thu, 15.01.15 13:24, Michael Marineau (michael.marin...@coreos.com) wrote: > >> While not common outside of BIND configs the implied top level '.' in >> domains is commonly accepted and crops up in ran

[systemd-devel] [PATCH 2/2] missing: add macros for OFD locks

2015-01-15 Thread Michael Marineau
--- src/shared/missing.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/shared/missing.h b/src/shared/missing.h index cdc38b2..d074405 100644 --- a/src/shared/missing.h +++ b/src/shared/missing.h @@ -79,6 +79,12 @@ #define F_SEAL_WRITE0x0008 /* prevent writes */ #endif +#if

[systemd-devel] [PATCH 1/2] networkd: accept a trailing '.' on the end of domains

2015-01-15 Thread Michael Marineau
While not common outside of BIND configs the implied top level '.' in domains is commonly accepted and crops up in random places. Starting with commit 784d9b9c networkd began validating domains as hostnames which rejects trailing dots, breaking short name resolution in some environments such as Goo

[systemd-devel] [PATCH v2] fstab-generator: Allow mount.usr without mount.usrflags, honor rw/ro

2014-12-08 Thread Michael Marineau
There is no need to require mount.usrflags. The original implementation assumed that a btrfs subvolume would always be needed but that is not applicable to systems that do not use btrfs for /usr. Similar to using rootflags= for the default of mount.usrflags=, append the classic 'ro' and 'rw' flags

Re: [systemd-devel] [PATCH] fstab-generator: Allow mount.usr without mount.usrflags, honor rw/ro

2014-12-08 Thread Michael Marineau
On Sun, Dec 7, 2014 at 4:51 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Sat, Dec 06, 2014 at 02:47:51PM -0800, Michael Marineau wrote: >> There is no need to require mount.usrflags. The original implementation >> assumed that a btrfs subvolume would always be needed but that is no

[systemd-devel] [PATCH] fstab-generator: Allow mount.usr without mount.usrflags, honor rw/ro

2014-12-06 Thread Michael Marineau
There is no need to require mount.usrflags. The original implementation assumed that a btrfs subvolume would always be needed but that is not applicable to systems that do not use btrfs for /usr. Similar to using rootflags= for the default of mount.usrflags=, append the classic 'ro' and 'rw' flags

Re: [systemd-devel] preset enables everything by default

2014-12-04 Thread Michael Marineau
On Thu, Dec 4, 2014 at 5:50 PM, Lennart Poettering wrote: > On Tue, 02.12.14 09:40, Michael Marineau (michael.marin...@coreos.com) wrote: > >> I didn't catch this behavior when it was first introduced since >> originally it was much harder to trigger systemd's "

[systemd-devel] preset enables everything by default

2014-12-02 Thread Michael Marineau
I didn't catch this behavior when it was first introduced since originally it was much harder to trigger systemd's "empty /etc" logic but now that it only requires /etc/machine-id to be missing it is quite easy, booting a new instance from an image for example. By default applying presets enables e

Re: [systemd-devel] [PATCH] Allow PID 1 systemd --user instances to exit

2014-11-06 Thread Michael Marineau
On Thu, Nov 6, 2014 at 6:02 PM, Lennart Poettering wrote: > On Thu, 06.11.14 17:48, Michael Marineau (michael.marin...@coreos.com) wrote: > >> > So, what's the real usecase for all of this? Can you elaborate on >> > that? >> >> The basic idea is to c

Re: [systemd-devel] [PATCH] Allow PID 1 systemd --user instances to exit

2014-11-06 Thread Michael Marineau
On Nov 6, 2014 5:17 PM, "Lennart Poettering" wrote: > > On Thu, 06.11.14 16:59, Vito Caputo (vito.cap...@coreos.com) wrote: > > > Because for all intents and purposes it's effectively still a user > > instance, just having its own PID namespace isn't cause --system behaviors > > like disabling sys

[systemd-devel] [PATCH] man: use the escape for "-" in example instead of space.

2014-09-15 Thread Michael Marineau
This sentence can be misread to mean that "\x20" is the escape code for "-" which is the only character explicitly mentioned. This lead to at least one user loosing hair over why a mount unit for "/foo/bar-baz" didn't work. The example escape is arbitrary so lets prevent hair loss. --- man/systemd

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-14 Thread Michael Marineau
On Aug 14, 2014 1:21 AM, "Lennart Poettering" wrote: > > On Mon, 04.08.14 10:05, Michael Marineau (michael.marin...@coreos.com) wrote: > > Patch looks pretty good, though I'd really prefer if we could do the > UseDomain= thing as discussed in the other mail, and

[systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-04 Thread Michael Marineau
When the code for generating resolv.conf was moved from networkd to resolved the DHCP domain name code was dropped. --- This is a refresh of the patch on recent master with a little bit of cleanup from the last. Regarding the robustness/correctness/etc of setting the "domain" resolv.conf attribute

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-07-29 Thread Michael Marineau
On Tue, Jul 29, 2014 at 3:37 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Jul 29, 2014 at 02:48:18PM -0700, Michael Marineau wrote: >> When the code for generating resolv.conf was moved from networkd to >> resolved the DHCP domain name code was dropped. >> --- >> &

[systemd-devel] [PATCH] nspawn: fix truncation of machine names in interface names

2014-07-29 Thread Michael Marineau
When deriving the network interface name from machine name strncpy was not properly null terminating the string and the maximum string size as returned by strlen() is actually IFNAMSIZ-1, not IFNAMSIZ. --- src/nspawn/nspawn.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sr

[systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-07-29 Thread Michael Marineau
When the code for generating resolv.conf was moved from networkd to resolved the DHCP domain name code was dropped. --- This is a resend, rebased since some recent changes changed how this patch needed to be implemented. src/network/networkd-link.c| 13 + src/network/sd-network.c

[systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-07-22 Thread Michael Marineau
When the code for generating resolv.conf was moved from networkd to resolved the DHCP domain name code was dropped. --- src/network/networkd-link.c| 2 ++ src/network/sd-network.c | 4 src/resolve/resolved-link.c| 31 +++ src/resolve/resolved-link.h

[systemd-devel] [PATCH] networkd: fix reporting errors from hostnamed

2014-07-21 Thread Michael Marineau
The return value may be -EINVAL or a positive errno from the dbus message. Check both ranges, otherwise most errors are silently ignored. --- src/network/networkd-link.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c

[systemd-devel] Persistent virtio device name removal

2014-07-03 Thread Michael Marineau
Working on bumping to 215 over here in CoreOS land, but I've got a question regarding the removal of persistent device names for virtio devices since changing the network device names creates a difficult upgrade path from 212. The commit was: http://cgit.freedesktop.org/systemd/systemd/commit/?id=

[systemd-devel] [PATCH] build-sys: require elfutils >= 158

2014-06-20 Thread Michael Marineau
The recently added stacktrace support in 8d4e028f uses functions added in elfutils 158. Check for one of the new functions to avoid attempting to build against older versions. --- configure.ac | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configur

Re: [systemd-devel] [PATCH 1/5] shared: rename path_strv_canonicalize_absolute functions

2014-06-19 Thread Michael Marineau
On Thu, Jun 19, 2014 at 9:14 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Jun 19, 2014 at 07:07:02PM -0700, Michael Marineau wrote: >> Since 12ed81d9 path_strv_canonicalize_absolute leaves the search list >> relative to the given root directory instead of resolving paths t

[systemd-devel] [PATCH 3/5] conf-files: include root in returned file paths

2014-06-19 Thread Michael Marineau
This restores the original root handling logic that was present prior to 112cfb18 when path expansion moved to path_strv_canonicalize_absolute. That behavior partially went away in 12ed81d9. Alternatively all users of conf_files_list* could be updated to concatenate the paths themselves as unit_fi

[systemd-devel] [PATCH 5/5] shared: fix search_and_fopen with alternate roots

2014-06-19 Thread Michael Marineau
Update for the current behavior of path_strv_resolve which now returns paths relative to the given root, not the full absolute paths. --- src/shared/util.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/shared/util.c b/src/shared/util.c index c1e1f9f..aaf109e 100644 --

[systemd-devel] [PATCH 4/5] test: ensure conf_files_list returns absolute paths

2014-06-19 Thread Michael Marineau
systemd. + + Copyright 2014 Michael Marineau + + systemd is free software; you can redistribute it and/or modify it + under the terms of the GNU Lesser General Public License as published by + the Free Software Foundation; either version 2.1 of the License, or + (at your option) any later version

[systemd-devel] [PATCH 2/5] test: unit test for using alternate roots with path_strv_resolve

2014-06-19 Thread Michael Marineau
--- src/test/test-path-util.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/test/test-path-util.c b/src/test/test-path-util.c index 9f8ae4d..4ee33a9 100644 --- a/src/test/test-path-util.c +++ b/src/test/test-path-util.c @@ -20,10 +20,12 @@ ***/ #inclu

[systemd-devel] [PATCH 1/5] shared: rename path_strv_canonicalize_absolute functions

2014-06-19 Thread Michael Marineau
Since 12ed81d9 path_strv_canonicalize_absolute leaves the search list relative to the given root directory instead of resolving paths to their true location as the name implies. To better reflect this behavior rename to the less strongly worded path_strv_resolve. --- src/shared/conf-files.c | 2 +

Re: [systemd-devel] new user/group population on bootup

2014-06-15 Thread Michael Marineau
On Sun, Jun 15, 2014 at 2:56 PM, Lennart Poettering wrote: > On Fri, 13.06.14 12:35, Michael Marineau (michael.marin...@coreos.com) wrote: > >> As a side note, regardless of whether an empty /etc is actually viable >> or not the more packages that support gracefully dealing wit

Re: [systemd-devel] new user/group population on bootup

2014-06-14 Thread Michael Marineau
On Jun 14, 2014 11:55 AM, "Colin Walters" wrote: > > On Fri, Jun 13, 2014, at 12:35 PM, Michael Marineau wrote: > > > > For what its worth, in my efforts to make CoreOS boot with a > > completely empty root filesystem I found that the changes required > &g

Re: [systemd-devel] new user/group population on bootup

2014-06-13 Thread Michael Marineau
On Fri, Jun 13, 2014 at 6:37 AM, Colin Walters wrote: > On Fri, Jun 13, 2014, at 05:36 AM, Colin Walters wrote: > >> My high level takeaway right now is that this looks OK for nspawn >> containers, but it's not clear to me it's viable or right for the host >> OS, at least for general purpose syste

[systemd-devel] [PATCH] shared: fix searching for configs in alternate roots

2014-06-11 Thread Michael Marineau
Commit 12ed81d9 changed path_strv_canonicalize_absolute's behavior to return a directory list without the root prefix if one was given but did not update other users of the function to the new behavior. This broke the --root option in systemd-tmpfiles, a regression in v213. To better reflect that

[systemd-devel] [PATCH] shared: fix searching for configs in alternate roots

2014-05-29 Thread Michael Marineau
Commit 12ed81d9 changed path_strv_canonicalize_absolute's behavior to return a directory list without the root prefix if one was given but did not update other users of the function to the new behavior. This broke the --root option in systemd-tmpfiles, a regression in v213. To better reflect that

Re: [systemd-devel] [PATCH] sd-dhcp-client: Sets broadcast flag to 1

2014-05-28 Thread Michael Marineau
On Wed, May 28, 2014 at 4:13 PM, Camilo Aguilar wrote: > Oh, never mind, there is no rush since we are already custom patching in > CoreOS for now. Hey, don't get ahead of yourself. I haven't merged your patch into CoreOS just yet ;-) I'm fine with the patch being a temporary fix as long as we ca

[systemd-devel] [PATCH] man: note that entire sections can now be ignored

2014-05-17 Thread Michael Marineau
Prefixing a section name with "X-" will cause it and all of its contents to be silently ignored as of commit 342aea19. --- man/systemd.unit.xml | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/man/systemd.unit.xml b/man/systemd.unit.xml index 157530b..e903156 100644 -

[systemd-devel] [PATCH] conf-parser: silently ignore sections starting with "X-"

2014-05-16 Thread Michael Marineau
This allows external tools to keep additional unit information in a separate section without scaring users with a big warning. --- src/shared/conf-parser.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/shared/conf-parser.c b/src/shared/conf-parser.c index d27b1b7

Re: [systemd-devel] [PATCH] device: Add stub serialization methods to enable job serialization.

2014-05-15 Thread Michael Marineau
On Thu, May 15, 2014 at 4:24 PM, Lennart Poettering wrote: > On Tue, 06.05.14 19:08, Michael Marineau (michael.marin...@coreos.com) wrote: > >> If a unit type doesn't provide its own serialization methods then >> none of the generic serialization will happen either. For dev

[systemd-devel] [PATCH] device: Add stub serialization methods to enable job serialization.

2014-05-06 Thread Michael Marineau
If a unit type doesn't provide its own serialization methods then none of the generic serialization will happen either. For devices this means jobs used for waiting on device dependencies are dropped during reloads, breaking dependency state that was relying on those jobs. --- src/core/device.c |

[systemd-devel] [PATCH] job: always add waiting jobs to run queue during coldplug.

2014-05-06 Thread Michael Marineau
commit 20a83d7bf was not equivalent to the original bug fix proposed by Michal Sekletar . The committed version only added the job to the run queue if the job had a timeout, which most jobs do not have. Just re-ordering the code gets us the intended functionality. --- src/core/job.c | 6 +++--- 1

[systemd-devel] [PATCH 2/3] tmpfiles: Add --root option to operate on an alternate fs tree.

2014-03-13 Thread Michael Marineau
This makes it possible to initialize or cleanup an arbitrary filesystem hierarchy in the same way that it would be during system boot. --- src/tmpfiles/tmpfiles.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles

[systemd-devel] [PATCH 3/3] tmpfiles: Add --root to the man page.

2014-03-13 Thread Michael Marineau
--- man/systemd-tmpfiles.xml | 8 1 file changed, 8 insertions(+) diff --git a/man/systemd-tmpfiles.xml b/man/systemd-tmpfiles.xml index 0b62640..193acb7 100644 --- a/man/systemd-tmpfiles.xml +++ b/man/systemd-tmpfiles.xml @@ -152,6 +152,14 @@ prefix. Thi

[systemd-devel] [PATCH 1/3] shared: add root argument to search_and_fopen

2014-03-13 Thread Michael Marineau
This adds the same root argument to search_and_fopen that conf_files_list already has. Tools that use those two functions as a pair can now be easily modified to load configuration files from an alternate root filesystem tree. --- src/binfmt/binfmt.c | 2 +- src/modules-load/modules-l

[systemd-devel] [PATCH] shared: include root when canonicalizing conf paths

2014-01-31 Thread Michael Marineau
The conf_files_list family accepts an alternate root path to prefix all directories in the list but path_strv_canonicalize_uniq doesn't use it. This results in the suspicious behavior of resolving directory symlinks based on the contents of / instead of the alternate root. This adds a prefix argum

[systemd-devel] [PATCH] tmpfiles: Add free that was missed in 5c795114

2014-01-30 Thread Michael Marineau
--- src/tmpfiles/tmpfiles.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c index bff9527..ae74af9 100644 --- a/src/tmpfiles/tmpfiles.c +++ b/src/tmpfiles/tmpfiles.c @@ -1509,6 +1509,7 @@ finish: hashmap_free(globs); strv_fr

Re: [systemd-devel] [PATCH resend] getty-generator: Enable getty on all active serial consoles.

2013-09-10 Thread Michael Marineau
On Sep 10, 2013 6:41 PM, "Jan Engelhardt" wrote: > > > On Tuesday 2013-09-10 17:41, Lennart Poettering wrote: > >On Wed, 28.08.13 13:12, Michael Marineau (michael.marin...@coreos.com) wrote: > > > >> This enables a getty on active kernel consoles even when

Re: [systemd-devel] [PATCH resend] getty-generator: Enable getty on all active serial consoles.

2013-09-10 Thread Michael Marineau
On Tue, Sep 10, 2013 at 8:41 AM, Lennart Poettering wrote: > On Wed, 28.08.13 13:12, Michael Marineau (michael.marin...@coreos.com) > wrote: > > > This enables a getty on active kernel consoles even when they are not > > the last one specified on the kernel command line a

[systemd-devel] [PATCH resend] getty-generator: Enable getty on all active serial consoles.

2013-08-28 Thread Michael Marineau
This enables a getty on active kernel consoles even when they are not the last one specified on the kernel command line and mapped to /dev/console. Now the order "console=ttyS0 console=tty0" works in addition to "console=tty0 console=ttyS0". --- src/getty-generator/getty-generator.c | 37 +

Re: [systemd-devel] [PATCH] getty-generator: Enable getty on all active serial consoles.

2013-08-22 Thread Michael Marineau
Greetings, sent this last week but didn't get any feedback. Is this change acceptable for systemd or is there a particular reason for not starting gettys on all active consoles? On Fri, Aug 16, 2013 at 8:28 PM, Michael Marineau < michael.marin...@coreos.com> wrote: > This enab

[systemd-devel] [PATCH] getty-generator: Enable getty on all active serial consoles.

2013-08-16 Thread Michael Marineau
This enables a getty on active kernel consoles even when they are not the last one specified on the kernel command line and mapped to /dev/console. Now the order "console=ttyS0 console=tty0" works in addition to "console=tty0 console=ttyS0". --- I'm not sure if there is a particular reason for the

[systemd-devel] [PATCH] build-sys: Add configure check for linux/btrfs.h

2013-08-16 Thread Michael Marineau
btrfs.h was added to uapi in Linux 3.9. To fix building with older header versions this adds a configure check for the header and re-adds btrfs definitions to missing.h which was removed in bed2e820 along with two other ioctls used by gpt-auto-generator. --- configure.ac

Re: [systemd-devel] [PATCH] travis: Add a travis.yml for doing CI after commits

2013-08-16 Thread Michael Marineau
On Wed, Aug 14, 2013 at 5:15 PM, <> wrote: > On Thu, Jul 18, 2013 at 7:40 AM, Holger Hans Peter Freyther > wrote: > > On Wed, Jul 17, 2013 at 05:08:46PM +0200, Kay Sievers wrote: > >> > >> I did something like that now. Let's see if it works ... > > > > Thank you, it did[1]. > > > > [1] https://t