Re: [systemd-devel] [PATCH] Fix: can not pass configure by default kmod build option

2014-01-15 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 15, 2014 at 01:28:26PM +0800, Chengwei Yang wrote: The situation is: by default, we get a auto value for kmod compiling option, so if we found required kmod files, then we build it with kmod enabled, otherwise, just build without kmod and do not complain to user. However,

Re: [systemd-devel] [PATCH] Fix: can not pass configure by default kmod build option

2014-01-15 Thread Yang Chengwei
On Thu, Jan 16, 2014 at 02:56:27AM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Jan 15, 2014 at 01:28:26PM +0800, Chengwei Yang wrote: The situation is: by default, we get a auto value for kmod compiling option, so if we found required kmod files, then we build it with kmod enabled,

Re: [systemd-devel] [PATCH] Fix: can not pass configure by default kmod build option

2014-01-15 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 16, 2014 at 10:05:23AM +0800, Yang Chengwei wrote: On Thu, Jan 16, 2014 at 02:56:27AM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Jan 15, 2014 at 01:28:26PM +0800, Chengwei Yang wrote: The situation is: by default, we get a auto value for kmod compiling option, so if we

Re: [systemd-devel] [PATCH] Fix: can not pass configure by default kmod build option

2014-01-15 Thread Yang Chengwei
On Thu, Jan 16, 2014 at 10:05:23AM +0800, Yang Chengwei wrote: On Thu, Jan 16, 2014 at 02:56:27AM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Jan 15, 2014 at 01:28:26PM +0800, Chengwei Yang wrote: The situation is: by default, we get a auto value for kmod compiling option, so if we

Re: [systemd-devel] [PATCH] Fix: can not pass configure by default kmod build option

2014-01-15 Thread Holger Schurig
Chengwai, given that kmod may not available in some distro version I'm on Debian and use my self-compiled systemd v208 with a self-made kmod_15.deb file. Packaging kmod is dead easy, it's a very straightforward package. Using the newest kmod doesn't hurt Debian Stable nor Debian SID. So the

Re: [systemd-devel] [PATCH] Fix: can not pass configure by default kmod build option

2014-01-15 Thread Kay Sievers
On Thu, Jan 16, 2014 at 8:27 AM, Holger Schurig holgerschu...@gmail.com wrote: If they think that it's not worth the hassle, then they could simply apply --disable-kmod. Both systemd and udev source code have the proper #ifdef HAVE_KMOD guarding. Keep in mind that machines with modular

[systemd-devel] [PATCH] Fix: can not pass configure by default kmod build option

2014-01-14 Thread Chengwei Yang
The situation is: by default, we get a auto value for kmod compiling option, so if we found required kmod files, then we build it with kmod enabled, otherwise, just build without kmod and do not complain to user. However, currently, if kmod version 15 available in machine, and build with default