Re: [systemd-devel] [PATCH] mount: use libmount to monitor mountinfo utab

2015-06-17 Thread Lennart Poettering
On Wed, 03.06.15 14:59, Karel Zak (k...@redhat.com) wrote: The current implementation directly monitor /proc/self/mountinfo and /run/mount/utab files. It's really not optimal because utab file is private libmount stuff without any official guaranteed semantic. The libmount since v2.26

[systemd-devel] [PATCH] mount: use libmount to monitor mountinfo utab

2015-06-03 Thread Karel Zak
The current implementation directly monitor /proc/self/mountinfo and /run/mount/utab files. It's really not optimal because utab file is private libmount stuff without any official guaranteed semantic. The libmount since v2.26 provides API to monitor mount kernel userspace changes. This patch

Re: [systemd-devel] [PATCH] mount: use libmount to monitor mountinfo utab

2015-06-03 Thread systemd github import bot
Patchset imported to github. To create a pull request, one of the main developers has to initiate one via: https://github.com/systemd/systemd/compare/master...systemd-mailing-devs:146366-7016-1-git-send-email-kzak%40redhat.com -- Generated by https://github.com/haraldh/mail2git

Re: [systemd-devel] [PATCH] mount: use libmount to monitor mountinfo utab

2015-06-02 Thread Karel Zak
On Mon, Jun 01, 2015 at 05:06:56PM +0200, Tom Gundersen wrote: -(void) sd_event_source_set_description(m-mount_utab_event_source, mount-utab-dispatch); +sd_event_source_set_description(m-mount_event_source, mount-monitor-dispatch); This should be

Re: [systemd-devel] [PATCH] mount: use libmount to monitor mountinfo utab

2015-06-02 Thread Marcos Mello
Karel Zak kzak at redhat.com writes: The current implementation directly monitor /proc/self/mountinfo and /run/mount/utab files. It's really not optimal because utab file is private libmount stuff without any official guaranteed semantic. [...] Please update libmount requirement in

Re: [systemd-devel] [PATCH] mount: use libmount to monitor mountinfo utab

2015-06-02 Thread Tom Gundersen
On Tue, Jun 2, 2015 at 1:53 PM, Karel Zak k...@redhat.com wrote: On Mon, Jun 01, 2015 at 05:06:56PM +0200, Tom Gundersen wrote: -(void) sd_event_source_set_description(m-mount_utab_event_source, mount-utab-dispatch); +

Re: [systemd-devel] [PATCH] mount: use libmount to monitor mountinfo utab

2015-06-01 Thread systemd github import bot
Patchset imported to github. Pull request: https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:1433160477-25478-1-git-send-email-kzak%40redhat.com -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing

[systemd-devel] [PATCH] mount: use libmount to monitor mountinfo utab

2015-06-01 Thread Karel Zak
The current implementation directly monitor /proc/self/mountinfo and /run/mount/utab files. It's really not optimal because utab file is private libmount stuff without any official guaranteed semantic. The libmount since v2.26 provides API to monitor mount kernel userspace changes. This patch

Re: [systemd-devel] [PATCH] mount: use libmount to monitor mountinfo utab

2015-06-01 Thread Tom Gundersen
Hi Karel, On Mon, Jun 1, 2015 at 2:07 PM, Karel Zak k...@redhat.com wrote: The current implementation directly monitor /proc/self/mountinfo and /run/mount/utab files. It's really not optimal because utab file is private libmount stuff without any official guaranteed semantic. The libmount