Re: [systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-25 Thread Lennart Poettering
On Tue, 24.06.14 23:21, Susant Sahani (sus...@redhat.com) wrote: This patch introduces tuntap support to networkd. Example conf file : tuntap.netdev [NetDev] Name=tuntap-test Kind=tuntap [TUNTAP] Hm, maybe call this TunTap instead? Mode=tap OneQueue=true MultiQueue=true

Re: [systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-25 Thread Susant Sahani
On 06/25/2014 02:21 PM, Lennart Poettering wrote: On Tue, 24.06.14 23:21, Susant Sahani (sus...@redhat.com) wrote: This patch introduces tuntap support to networkd. Example conf file : tuntap.netdev [NetDev] Name=tuntap-test Kind=tuntap [TUNTAP] Hm, maybe call this TunTap instead?

Re: [systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-25 Thread Susant Sahani
On 06/25/2014 02:51 PM, Susant Sahani wrote: On 06/25/2014 02:21 PM, Lennart Poettering wrote: On Tue, 24.06.14 23:21, Susant Sahani (sus...@redhat.com) wrote: This patch introduces tuntap support to networkd. Example conf file : tuntap.netdev [NetDev] Name=tuntap-test Kind=tuntap

Re: [systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-25 Thread Tom Gundersen
On Wed, Jun 25, 2014 at 11:38 AM, Susant Sahani sus...@redhat.com wrote: On 06/25/2014 02:51 PM, Susant Sahani wrote: On 06/25/2014 02:21 PM, Lennart Poettering wrote: On Tue, 24.06.14 23:21, Susant Sahani (sus...@redhat.com) wrote: This patch introduces tuntap support to networkd.

Re: [systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-25 Thread Susant Sahani
On 06/25/2014 03:28 PM, Tom Gundersen wrote: On Wed, Jun 25, 2014 at 11:38 AM, Susant Sahani sus...@redhat.com wrote: On 06/25/2014 02:51 PM, Susant Sahani wrote: On 06/25/2014 02:21 PM, Lennart Poettering wrote: On Tue, 24.06.14 23:21, Susant Sahani (sus...@redhat.com) wrote: This patch

[systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-24 Thread Susant Sahani
This patch introduces tuntap support to networkd. Example conf file : tuntap.netdev [NetDev] Name=tuntap-test Kind=tuntap [TUNTAP] Mode=tap OneQueue=true MultiQueue=true PacketInfo=true Added: 1. file networkd-tuntap.c 2. enum TunTapKind 3. NETDEV_KIND_TUNTAP 4. TUNTAP Section to

Re: [systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-24 Thread Ronny Chevalier
2014-06-24 18:25 GMT+02:00 Susant Sahani sus...@redhat.com: This patch introduces tuntap support to networkd. Example conf file : tuntap.netdev [NetDev] Name=tuntap-test Kind=tuntap [TUNTAP] Mode=tap OneQueue=true MultiQueue=true PacketInfo=true Added: 1. file networkd-tuntap.c

Re: [systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-24 Thread Tom Gundersen
Looks great, just minor comments below. On Tue, Jun 24, 2014 at 6:25 PM, Susant Sahani sus...@redhat.com wrote: This patch introduces tuntap support to networkd. Example conf file : tuntap.netdev [NetDev] Name=tuntap-test Kind=tuntap [TUNTAP] Hm, maybe call this TunTap instead?

Re: [systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-24 Thread Marcel Holtmann
Hi Tom, This patch introduces tuntap support to networkd. Example conf file : tuntap.netdev [NetDev] Name=tuntap-test Kind=tuntap [TUNTAP] Hm, maybe call this TunTap instead? Mode=tap OneQueue=true MultiQueue=true PacketInfo=true I wonder if it might be better separate in

Re: [systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-24 Thread Tom Gundersen
On Tue, Jun 24, 2014 at 7:09 PM, Marcel Holtmann mar...@holtmann.org wrote: Hi Tom, This patch introduces tuntap support to networkd. Example conf file : tuntap.netdev [NetDev] Name=tuntap-test Kind=tuntap [TUNTAP] Hm, maybe call this TunTap instead? Mode=tap OneQueue=true

Re: [systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-24 Thread Susant Sahani
On 06/24/2014 10:39 PM, Marcel Holtmann wrote: Hi Tom, This patch introduces tuntap support to networkd. Example conf file : tuntap.netdev [NetDev] Name=tuntap-test Kind=tuntap [TUNTAP] Hm, maybe call this TunTap instead? Mode=tap OneQueue=true MultiQueue=true PacketInfo=true I

Re: [systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-24 Thread Susant Sahani
On 06/24/2014 10:31 PM, Tom Gundersen wrote: Looks great, just minor comments below. On Tue, Jun 24, 2014 at 6:25 PM, Susant Sahani sus...@redhat.com wrote: This patch introduces tuntap support to networkd. Example conf file : tuntap.netdev [NetDev] Name=tuntap-test Kind=tuntap [TUNTAP]

Re: [systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-24 Thread Susant Sahani
On 06/24/2014 10:05 PM, Ronny Chevalier wrote: 2014-06-24 18:25 GMT+02:00 Susant Sahani sus...@redhat.com: This patch introduces tuntap support to networkd. Example conf file : tuntap.netdev [NetDev] Name=tuntap-test Kind=tuntap [TUNTAP] Mode=tap OneQueue=true MultiQueue=true