Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-10-24 Thread David Herrmann
Hi On Thu, Oct 9, 2014 at 3:31 PM, Susant Sahani sus...@redhat.com wrote: CID 1237543 (#1 of 1): Unchecked return value from library (CHECKED_RETURN) --- src/socket-proxy/socket-proxyd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/socket-proxy/socket-proxyd.c

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-10-10 Thread Lennart Poettering
On Fri, 10.10.14 05:57, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Thu, Oct 09, 2014 at 07:01:11PM +0530, Susant Sahani wrote: CID 1237543 (#1 of 1): Unchecked return value from library (CHECKED_RETURN) --- src/socket-proxy/socket-proxyd.c | 2 +- 1 file changed, 1

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-10-09 Thread Susant Sahani
On 10/03/2014 12:21 AM, Lennart Poettering wrote: On Fri, 19.09.14 13:27, Susant Sahani (sus...@redhat.com) wrote: CID 1237543 (#1 of 1): Unchecked return value from library (CHECKED_RETURN) --- src/socket-proxy/socket-proxyd.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

[systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-10-09 Thread Susant Sahani
CID 1237543 (#1 of 1): Unchecked return value from library (CHECKED_RETURN) --- src/socket-proxy/socket-proxyd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/socket-proxy/socket-proxyd.c b/src/socket-proxy/socket-proxyd.c index ff2b24f..3041903 100644 ---

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-10-09 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 09, 2014 at 07:01:11PM +0530, Susant Sahani wrote: CID 1237543 (#1 of 1): Unchecked return value from library (CHECKED_RETURN) --- src/socket-proxy/socket-proxyd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/socket-proxy/socket-proxyd.c

[systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread Susant Sahani
CID 1237543 (#1 of 1): Unchecked return value from library (CHECKED_RETURN) --- src/socket-proxy/socket-proxyd.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/socket-proxy/socket-proxyd.c b/src/socket-proxy/socket-proxyd.c index ff2b24f..7b0714d 100644 ---

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread David Herrmann
Hi On Fri, Sep 19, 2014 at 9:57 AM, Susant Sahani sus...@redhat.com wrote: CID 1237543 (#1 of 1): Unchecked return value from library (CHECKED_RETURN) --- src/socket-proxy/socket-proxyd.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread Susant Sahani
On 09/19/2014 01:35 PM, David Herrmann wrote: Hi Hi, On Fri, Sep 19, 2014 at 9:57 AM, Susant Sahani sus...@redhat.com wrote: CID 1237543 (#1 of 1): Unchecked return value from library (CHECKED_RETURN) --- src/socket-proxy/socket-proxyd.c | 6 +- 1 file changed, 5 insertions(+), 1

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread David Herrmann
Hi On Fri, Sep 19, 2014 at 10:28 AM, Susant Sahani sus...@redhat.com wrote: On 09/19/2014 01:35 PM, David Herrmann wrote: I don't think that's right. Ignoring the return value of that fcntl is just fine. We read the buffer-size afterwards, so if it failed, we still continue properly. See

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread Susant Sahani
On 09/19/2014 02:00 PM, David Herrmann wrote: Hi On Fri, Sep 19, 2014 at 10:28 AM, Susant Sahani sus...@redhat.com wrote: On 09/19/2014 01:35 PM, David Herrmann wrote: I don't think that's right. Ignoring the return value of that fcntl is just fine. We read the buffer-size afterwards, so if

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread Alexander E. Patrakov
19.09.2014 14:35, Susant Sahani wrote: On 09/19/2014 02:00 PM, David Herrmann wrote: Hi On Fri, Sep 19, 2014 at 10:28 AM, Susant Sahani sus...@redhat.com wrote: On 09/19/2014 01:35 PM, David Herrmann wrote: I don't think that's right. Ignoring the return value of that fcntl is just fine. We

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread David Herrmann
Hi On Fri, Sep 19, 2014 at 10:39 AM, Alexander E. Patrakov patra...@gmail.com wrote: 19.09.2014 14:35, Susant Sahani wrote: On 09/19/2014 02:00 PM, David Herrmann wrote: Hi On Fri, Sep 19, 2014 at 10:28 AM, Susant Sahani sus...@redhat.com wrote: On 09/19/2014 01:35 PM, David Herrmann

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread Susant Sahani
On 09/19/2014 02:11 PM, David Herrmann wrote: Hi On Fri, Sep 19, 2014 at 10:39 AM, Alexander E. Patrakov patra...@gmail.com wrote: 19.09.2014 14:35, Susant Sahani wrote: On 09/19/2014 02:00 PM, David Herrmann wrote: Hi On Fri, Sep 19, 2014 at 10:28 AM, Susant Sahani sus...@redhat.com

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread Simon McVittie
On 19/09/14 09:05, David Herrmann wrote: -fcntl(buffer[0], F_SETPIPE_SZ, BUFFER_SIZE); +r = fcntl(buffer[0], F_SETPIPE_SZ, BUFFER_SIZE); +if (r 0) { +log_error(Failed to set pipe buffer size: %m); +return -errno; +} I don't