Re: [systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-28 Thread Lennart Poettering
On Fri, 25.04.14 19:36, Tom Gundersen (t...@jklm.no) wrote: [sorry for breaking the quoting, hopefully it is clear who said what] I actually think this is the correct way to do it, as the addresses (which I assume is what Jóhann is objecting to?) are properties of the link (similar to mac

Re: [systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-28 Thread Tom Gundersen
On Mon, Apr 28, 2014 at 5:53 PM, Lennart Poettering lenn...@poettering.net wrote: This is solely about whether Local= and Remote= belong in .netdev? That's my take. I am pretty sure they do, after all this is a weird setup: a tunnel is something where the link level is actually the network

Re: [systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-25 Thread Tom Gundersen
On Fri, Apr 11, 2014 at 6:29 PM, Susant Sahani sus...@redhat.com wrote: On 04/08/2014 12:54 PM, Jóhann B. Guðmundsson wrote: On 04/08/2014 03:22 AM, Susant Sahani wrote: file: ipip.netdev -- [NetDev] Name=ipip-tun Kind=ipip [Tunnel] Local=192.168.8.102

Re: [systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-12 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Apr 08, 2014 at 08:52:51AM +0530, Susant Sahani wrote: This patch enables basic ipip tunnel support. It works with kernel module ipip Example configuration file: ipip.netdev -- [NetDev] Name=ipip-tun Kind=ipip [Tunnel] Local=192.168.8.102

Re: [systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-11 Thread Susant Sahani
On 04/09/2014 01:33 AM, Umut Tezduyar Lindskog wrote: Hi, Few minor suggestions, if you care. Hi sorry for replying late :) On Tue, Apr 8, 2014 at 5:22 AM, Susant Sahani sus...@redhat.com wrote: This patch enables basic ipip tunnel support. It works with kernel module ipip Example

Re: [systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-11 Thread Susant Sahani
On 04/08/2014 12:54 PM, Jóhann B. Guðmundsson wrote: On 04/08/2014 03:22 AM, Susant Sahani wrote: file: ipip.netdev -- [NetDev] Name=ipip-tun Kind=ipip [Tunnel] Local=192.168.8.102 Remote=10.4.4.4 TTL=64 MTUBytes=1480 file: ipip.network --

Re: [systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-08 Thread Jóhann B. Guðmundsson
On 04/08/2014 03:22 AM, Susant Sahani wrote: file: ipip.netdev -- [NetDev] Name=ipip-tun Kind=ipip [Tunnel] Local=192.168.8.102 Remote=10.4.4.4 TTL=64 MTUBytes=1480 file: ipip.network -- [Match] Name=eth0 [Network] Tunnel=ipip-tun I think

Re: [systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-08 Thread Umut Tezduyar Lindskog
Hi, Few minor suggestions, if you care. On Tue, Apr 8, 2014 at 5:22 AM, Susant Sahani sus...@redhat.com wrote: This patch enables basic ipip tunnel support. It works with kernel module ipip Example configuration file: ipip.netdev -- [NetDev] Name=ipip-tun

[systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-07 Thread Susant Sahani
This patch enables basic ipip tunnel support. It works with kernel module ipip Example configuration file: ipip.netdev [NetDev] Name=ipip-tun Kind=ipip [Tunnel] Local=192.168.8.102 Remote=10.4.4.4 TTL=64 MTUBytes=1480 file: ipip.network [Match] Name=eth0 [Network] Tunnel=ipip-tun ---

Re: [systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-07 Thread Tom Gundersen
On Mon, Apr 7, 2014 at 9:44 AM, Susant Sahani sus...@redhat.com wrote: This patch enables basic ipip tunnel support. It works with kernel module ipip Example configuration file: ipip.netdev [NetDev] Name=ipip-tun Kind=ipip [Tunnel] Local=192.168.8.102 Remote=10.4.4.4 TTL=64

Re: [systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-07 Thread Susant Sahani
On 04/07/2014 02:39 PM, Tom Gundersen wrote: On Mon, Apr 7, 2014 at 9:44 AM, Susant Sahani sus...@redhat.com wrote: This patch enables basic ipip tunnel support. It works with kernel module ipip Example configuration file: ipip.netdev [NetDev] Name=ipip-tun Kind=ipip [Tunnel]

Re: [systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-07 Thread Tom Gundersen
On Mon, Apr 7, 2014 at 12:28 PM, Susant Sahani sus...@redhat.com wrote: +r = manager_init_kmod_ctx(m); Maybe just do manager-kmod_ctx = kmod_ctx_new(NULL, NULL); if (!manager-kmod_ctx) { r = -ENOMEM; etc... } and drop the wrapping function (see above). Any

[systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-07 Thread Susant Sahani
This patch enables basic ipip tunnel support. It works with kernel module ipip Example configuration file: ipip.netdev -- [NetDev] Name=ipip-tun Kind=ipip [Tunnel] Local=192.168.8.102 Remote=10.4.4.4 TTL=64 MTUBytes=1480 file: ipip.network --