Re: [systemd-devel] [PATCH 1/3] zsh-completion: add missing completions for machinectl

2015-05-16 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 22, 2015 at 03:52:59PM -0700, Lukas Rusak wrote: +_available_machines() { +local -a _machines +_machines=(${(fo)$(__get_available_machines)}) +typeset -U _machines +if [[ -n $_machines ]]; then +_describe 'machines' _machines +else + _message 'no

Re: [systemd-devel] [PATCH 1/3] zsh-completion: add missing completions for machinectl

2015-05-16 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 22, 2015 at 03:52:59PM -0700, Lukas Rusak wrote: Appologies, I'm still getting used to this mailing list thing and using git send-email --- shell-completion/zsh/_machinectl | 84 +--- 1 file changed, 70 insertions(+), 14 deletions(-)

Re: [systemd-devel] [PATCH 1/3] zsh-completion: add missing completions for machinectl

2015-05-16 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Apr 27, 2015 at 12:09:47PM -0700, Lukas Rusak wrote: I feel like this is already accomplished. The completion function _sd_machines already lists the running containers. Otherwise currently _available_machines is only used for machinectl start. see,

Re: [systemd-devel] [PATCH 1/3] zsh-completion: add missing completions for machinectl

2015-04-27 Thread Lukas Rusak
I feel like this is already accomplished. The completion function _sd_machines already lists the running containers. Otherwise currently _available_machines is only used for machinectl start. see, list*|cancel-transfer|pull-tar|pull-raw|pull-dkr) msg=no options ;;

Re: [systemd-devel] [PATCH 1/3] zsh-completion: add missing completions for machinectl

2015-04-23 Thread Lennart Poettering
On Wed, 22.04.15 15:52, Lukas Rusak (loru...@gmail.com) wrote: Appologies, I'm still getting used to this mailing list thing and using git send-email --- shell-completion/zsh/_machinectl | 84 +--- 1 file changed, 70 insertions(+), 14 deletions(-)

Re: [systemd-devel] [PATCH 1/3] zsh-completion: add missing completions for machinectl

2015-04-23 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Apr 23, 2015 at 04:44:01PM +0200, Lennart Poettering wrote: On Thu, 23.04.15 13:06, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Wed, Apr 22, 2015 at 12:30:32PM -0700, Lukas Rusak wrote: Ah, completely missed images. So perhaps something like this would be better?

Re: [systemd-devel] [PATCH 1/3] zsh-completion: add missing completions for machinectl

2015-04-23 Thread Lennart Poettering
On Thu, 23.04.15 13:06, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Wed, Apr 22, 2015 at 12:30:32PM -0700, Lukas Rusak wrote: Ah, completely missed images. So perhaps something like this would be better? machinectl --full --no-legend --no-pager list-images | awk '{print

Re: [systemd-devel] [PATCH 1/3] zsh-completion: add missing completions for machinectl

2015-04-23 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 22, 2015 at 12:30:32PM -0700, Lukas Rusak wrote: Ah, completely missed images. So perhaps something like this would be better? machinectl --full --no-legend --no-pager list-images | awk '{print $1}' We usually try to avoid running external programs unless necessary. This can be

[systemd-devel] [PATCH 1/3] zsh-completion: add missing completions for machinectl

2015-04-22 Thread Lukas Rusak
--- shell-completion/zsh/_machinectl | 84 +--- 1 file changed, 70 insertions(+), 14 deletions(-) diff --git a/shell-completion/zsh/_machinectl b/shell-completion/zsh/_machinectl index c666b7e..2b1b7ed 100644 --- a/shell-completion/zsh/_machinectl +++

Re: [systemd-devel] [PATCH 1/3] zsh-completion: add missing completions for machinectl

2015-04-22 Thread Lennart Poettering
On Wed, 22.04.15 11:07, Lukas Rusak (loru...@gmail.com) wrote: --- shell-completion/zsh/_machinectl | 84 +--- 1 file changed, 70 insertions(+), 14 deletions(-) diff --git a/shell-completion/zsh/_machinectl b/shell-completion/zsh/_machinectl index

Re: [systemd-devel] [PATCH 1/3] zsh-completion: add missing completions for machinectl

2015-04-22 Thread Lukas Rusak
Ah, completely missed images. So perhaps something like this would be better? machinectl --full --no-legend --no-pager list-images | awk '{print $1}' as this lists fedora fedora-rawhide instead of fedora.raw fedora-rawhide However this will break if one has spaces in the container name. I

Re: [systemd-devel] [PATCH 1/3] zsh-completion: add missing completions for machinectl

2015-04-22 Thread Lennart Poettering
On Wed, 22.04.15 15:44, Lukas Rusak (loru...@gmail.com) wrote: Here is a rebase of the original patch to include the discussed changes Where? Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

Re: [systemd-devel] [PATCH 1/3] zsh-completion: add missing completions for machinectl

2015-04-22 Thread Lukas Rusak
Appologies, I'm still getting used to this mailing list thing and using git send-email --- shell-completion/zsh/_machinectl | 84 +--- 1 file changed, 70 insertions(+), 14 deletions(-) diff --git a/shell-completion/zsh/_machinectl

Re: [systemd-devel] [PATCH 1/3] zsh-completion: add missing completions for machinectl

2015-04-22 Thread Lukas Rusak
Here is a rebase of the original patch to include the discussed changes ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel