Re: [systemd-devel] [PATCH 1/5] build-sys: move common libraries to separate Makefile

2012-06-19 Thread Lennart Poettering
On Tue, 12.06.12 12:52, William Hubbs (w.d.hu...@gmail.com) wrote: heya, Sorry, not going to merge this. This patch is ugly, and I doubt you can fix it to make it less ugly. Split makefiles suck [1], and so do makefiles with even more ifdefs than we already have. Besides that it would probably

Re: [systemd-devel] [PATCH 1/5] build-sys: move common libraries to separate Makefile

2012-06-19 Thread Karel Zak
On Tue, Jun 19, 2012 at 10:31:30AM +0200, Lennart Poettering wrote: [1] I mean, seriously, we made the clear decision to have only a single makefile and avoid recursive make and now with splitting this stuff up you undo that half-way. Note that include Makefile-udev.am does not mean

Re: [systemd-devel] [PATCH 1/5] build-sys: move common libraries to separate Makefile

2012-06-19 Thread Lennart Poettering
On Tue, 19.06.12 10:45, Karel Zak (k...@redhat.com) wrote: On Tue, Jun 19, 2012 at 10:31:30AM +0200, Lennart Poettering wrote: [1] I mean, seriously, we made the clear decision to have only a single makefile and avoid recursive make and now with splitting this stuff up you undo that

[systemd-devel] [PATCH 1/5] build-sys: move common libraries to separate Makefile

2012-06-12 Thread William Hubbs
--- Makefile-shared.am | 117 Makefile.am| 99 +--- 2 files changed, 118 insertions(+), 98 deletions(-) create mode 100644 Makefile-shared.am diff --git a/Makefile-shared.am