Re: [systemd-devel] [PATCH v4 1/2] Move handling of sysv initscripts to a generator

2014-07-04 Thread Alexey Shabalin
2014-06-01 1:29 GMT+04:00 Thomas H.P. Andersen pho...@gmail.com: From: Thomas Hindoe Paaboel Andersen pho...@gmail.com Reuses logic from service.c and the rc-local generator. Note that this drops reading of chkconfig entirely. It also drops reading runlevels from the LSB headers. The

Re: [systemd-devel] [PATCH v4 1/2] Move handling of sysv initscripts to a generator

2014-07-04 Thread Colin Guthrie
'Twas brillig, and Alexey Shabalin at 04/07/14 10:50 did gyre and gimble: It would be good for me to skip generate unit files for exist native unit files or aliases. This was always our behaviour before, and I believe this is still the intended behaviour after Thomas' changes. Are you saying

Re: [systemd-devel] [PATCH v4 1/2] Move handling of sysv initscripts to a generator

2014-07-04 Thread Alexey Shabalin
2014-07-04 14:20 GMT+04:00 Colin Guthrie gm...@colin.guthr.ie: 'Twas brillig, and Alexey Shabalin at 04/07/14 10:50 did gyre and gimble: It would be good for me to skip generate unit files for exist native unit files or aliases. This was always our behaviour before, and I believe this is

Re: [systemd-devel] [PATCH v4 1/2] Move handling of sysv initscripts to a generator

2014-07-04 Thread Lennart Poettering
On Fri, 04.07.14 13:50, Alexey Shabalin (a.shaba...@gmail.com) wrote: 2014-06-01 1:29 GMT+04:00 Thomas H.P. Andersen pho...@gmail.com: From: Thomas Hindoe Paaboel Andersen pho...@gmail.com Reuses logic from service.c and the rc-local generator. Note that this drops reading of

Re: [systemd-devel] [PATCH v4 1/2] Move handling of sysv initscripts to a generator

2014-06-24 Thread Alexey Shabalin
2014-06-07 3:01 GMT+04:00 Thomas H.P. Andersen pho...@gmail.com: On Fri, Jun 6, 2014 at 4:09 PM, Lennart Poettering lenn...@poettering.net wrote: On Sat, 31.05.14 23:29, Thomas H.P. Andersen (pho...@gmail.com) wrote: + +if (s-sysv_start_priority 0) +fprintf(f,

Re: [systemd-devel] [PATCH v4 1/2] Move handling of sysv initscripts to a generator

2014-06-24 Thread Thomas H.P. Andersen
On Tue, Jun 24, 2014 at 7:56 PM, Alexey Shabalin a.shaba...@gmail.com wrote: 2014-06-07 3:01 GMT+04:00 Thomas H.P. Andersen pho...@gmail.com: On Fri, Jun 6, 2014 at 4:09 PM, Lennart Poettering lenn...@poettering.net wrote: On Sat, 31.05.14 23:29, Thomas H.P. Andersen (pho...@gmail.com) wrote:

Re: [systemd-devel] [PATCH v4 1/2] Move handling of sysv initscripts to a generator

2014-06-06 Thread Lennart Poettering
On Sat, 31.05.14 23:29, Thomas H.P. Andersen (pho...@gmail.com) wrote: Thanks! Awesome work! I am enjoying this! A few comments: + +static int generate_unit_file(SysvStub *s) { +char *unit; +char **p; +_cleanup_fclose_ FILE *f = NULL; +_cleanup_free_ char

Re: [systemd-devel] [PATCH v4 1/2] Move handling of sysv initscripts to a generator

2014-06-06 Thread Lennart Poettering
On Sat, 31.05.14 23:29, Thomas H.P. Andersen (pho...@gmail.com) wrote: +const char *arg_dest = /tmp; + +static LookupPaths lp; +static Hashmap *all_services; Small addendum: we try to avoid static vars. WOuld be great to pass the latter *both* through as params. We just try though, sometimes

Re: [systemd-devel] [PATCH v4 1/2] Move handling of sysv initscripts to a generator

2014-06-06 Thread Thomas H.P. Andersen
On Fri, Jun 6, 2014 at 4:09 PM, Lennart Poettering lenn...@poettering.net wrote: On Sat, 31.05.14 23:29, Thomas H.P. Andersen (pho...@gmail.com) wrote: Thanks! Awesome work! I am enjoying this! A few comments: + +static int generate_unit_file(SysvStub *s) { +char *unit; +

[systemd-devel] [PATCH v4 1/2] Move handling of sysv initscripts to a generator

2014-05-31 Thread Thomas H.P. Andersen
From: Thomas Hindoe Paaboel Andersen pho...@gmail.com Reuses logic from service.c and the rc-local generator. Note that this drops reading of chkconfig entirely. It also drops reading runlevels from the LSB headers. The runlevels were only used to check for runlevels outside of the normal 1-5