Re: [systemd-devel] [RFC 03/12] bus: add two new bus_*_map_*_properties() helpers

2013-12-10 Thread Lennart Poettering
On Thu, 28.11.13 09:21, David Herrmann (dh.herrm...@gmail.com) wrote: Hi On Wed, Nov 27, 2013 at 10:58 PM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 27.11.13 19:48, David Herrmann (dh.herrm...@gmail.com) wrote: +/* skip interface, but allow callers to do that

Re: [systemd-devel] [RFC 03/12] bus: add two new bus_*_map_*_properties() helpers

2013-11-28 Thread David Herrmann
Hi On Wed, Nov 27, 2013 at 10:58 PM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 27.11.13 19:48, David Herrmann (dh.herrm...@gmail.com) wrote: +/* skip interface, but allow callers to do that themselves */ +sd_bus_message_skip(m, s); This feels a bit like taping

[systemd-devel] [RFC 03/12] bus: add two new bus_*_map_*_properties() helpers

2013-11-27 Thread David Herrmann
This splits the core of bus_map_all_properties() out into a new helper called bus_message_map_all_properties(). Instead of sending a blocking dbus call, this helper takes the response message as argument and parses it. So the normal use-case is to send an async GetAll() request and once you get

Re: [systemd-devel] [RFC 03/12] bus: add two new bus_*_map_*_properties() helpers

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 19:48, David Herrmann (dh.herrm...@gmail.com) wrote: +/* skip interface, but allow callers to do that themselves */ +sd_bus_message_skip(m, s); This feels a bit like taping over bugs. I'd suggest adding an additional parameter const char **interface to the