On Sun, Jun 1, 2014 at 2:58 PM, Michael Biebl mbi...@gmail.com wrote:
I quickly looked at the patch and it seems ok.
While glancing over Makefile.am I noticed that e.g. libsystemd_network
links against $(KMOD_LIBS).
That looks wrong to me (faulty commit is
On 03/06/14 01:48, Tom Gundersen wrote:
On Sun, Jun 1, 2014 at 2:58 PM, Michael Biebl mbi...@gmail.com wrote:
I quickly looked at the patch and it seems ok.
While glancing over Makefile.am I noticed that e.g. libsystemd_network
links against $(KMOD_LIBS).
That looks wrong to me (faulty
On Tue, Jun 3, 2014 at 12:57 AM, Samuli Suominen ssuomi...@gentoo.org wrote:
On 03/06/14 01:48, Tom Gundersen wrote:
On Sun, Jun 1, 2014 at 2:58 PM, Michael Biebl mbi...@gmail.com wrote:
I quickly looked at the patch and it seems ok.
While glancing over Makefile.am I noticed that e.g.
On 1 Jun 2014 06:31, Lennart Poettering lenn...@poettering.net wrote:
On Sat, 31.05.14 19:43, Samuli Suominen (ssuomi...@gentoo.org) wrote:
On 31/05/14 17:10, Samuli Suominen wrote:
On 31/05/14 14:14, Samuli Suominen wrote:
1. libsystemd_network_la_SOURCES = in Makefile.am includes
On Sun, 01.06.14 08:04, Tom Gundersen (t...@jklm.no) wrote:
On 1 Jun 2014 06:31, Lennart Poettering lenn...@poettering.net wrote:
On Sat, 31.05.14 19:43, Samuli Suominen (ssuomi...@gentoo.org) wrote:
On 31/05/14 17:10, Samuli Suominen wrote:
On 31/05/14 14:14, Samuli Suominen
On 01/06/14 10:04, Tom Gundersen wrote:
On 1 Jun 2014 06:31, Lennart Poettering lenn...@poettering.net
mailto:lenn...@poettering.net wrote:
On Sat, 31.05.14 19:43, Samuli Suominen (ssuomi...@gentoo.org
mailto:ssuomi...@gentoo.org) wrote:
On 31/05/14 17:10, Samuli Suominen
On Sun, Jun 1, 2014 at 8:15 AM, Samuli Suominen ssuomi...@gentoo.org wrote:
On 01/06/14 10:04, Tom Gundersen wrote:
On 1 Jun 2014 06:31, Lennart Poettering lenn...@poettering.net
mailto:lenn...@poettering.net wrote:
On Sat, 31.05.14 19:43, Samuli Suominen (ssuomi...@gentoo.org
On Sun, Jun 1, 2014 at 8:15 AM, Lennart Poettering
lenn...@poettering.net wrote:
On Sun, 01.06.14 08:04, Tom Gundersen (t...@jklm.no) wrote:
On 1 Jun 2014 06:31, Lennart Poettering lenn...@poettering.net wrote:
On Sat, 31.05.14 19:43, Samuli Suominen (ssuomi...@gentoo.org) wrote:
Tom,
I quickly looked at the patch and it seems ok.
While glancing over Makefile.am I noticed that e.g. libsystemd_network
links against $(KMOD_LIBS).
That looks wrong to me (faulty commit is
679be2a74241a70028438217bace423a1a45faa6), only
libsystemd-networkd-core really requires kmod
1. libsystemd_network_la_SOURCES = in Makefile.am includes
src/libsystemd-network/network-internal.h
and there is no anykind of #ifdef -logic behind it
2. src/libsystemd-network/network-internal.h has #include libkmod.h
and there is no anykind of #ifdef
-logic behind it
so kmod is hardcoded
On 31/05/14 14:14, Samuli Suominen wrote:
1. libsystemd_network_la_SOURCES = in Makefile.am includes
src/libsystemd-network/network-internal.h
and there is no anykind of #ifdef -logic behind it
2. src/libsystemd-network/network-internal.h has #include libkmod.h
and there is no anykind of
On 31/05/14 17:10, Samuli Suominen wrote:
On 31/05/14 14:14, Samuli Suominen wrote:
1. libsystemd_network_la_SOURCES = in Makefile.am includes
src/libsystemd-network/network-internal.h
and there is no anykind of #ifdef -logic behind it
2. src/libsystemd-network/network-internal.h has
A proper git formatted patch for inclusion.
From 9be13cce871d1d7275acee8bcb106cd2f9e909b7 Mon Sep 17 00:00:00 2001
From: Mike Gilbert flop...@gentoo.org
Date: Sat, 31 May 2014 19:58:47 +0300
Subject: [PATCH] Fix building with --disable-kmod --disable-networkd when kmod
is not installed.
---
El 31/05/14 13:00, Samuli Suominen escribió:
A proper git formatted patch for inclusion.
IN my opinion, we should just make KMOD a mandatory dependency, drop all
ifdefs, error out if not found.
--
Cristian
I don't know the key to success, but the key to failure is trying to
please everybody.
On Sat, May 31, 2014 at 7:45 PM, Cristian Rodríguez
crrodrig...@opensuse.org wrote:
El 31/05/14 13:00, Samuli Suominen escribió:
A proper git formatted patch for inclusion.
IN my opinion, we should just make KMOD a mandatory dependency, drop all
ifdefs, error out if not found.
Sound fine to
On Sun, 01.06.14 06:23, Kay Sievers (k...@vrfy.org) wrote:
On Sat, May 31, 2014 at 7:45 PM, Cristian Rodríguez
crrodrig...@opensuse.org wrote:
El 31/05/14 13:00, Samuli Suominen escribió:
A proper git formatted patch for inclusion.
IN my opinion, we should just make KMOD a mandatory
On Sat, 31.05.14 19:43, Samuli Suominen (ssuomi...@gentoo.org) wrote:
On 31/05/14 17:10, Samuli Suominen wrote:
On 31/05/14 14:14, Samuli Suominen wrote:
1. libsystemd_network_la_SOURCES = in Makefile.am includes
src/libsystemd-network/network-internal.h
and there is no anykind of
17 matches
Mail list logo
