Re: [systemd-devel] [PATCH] Do not clear parent mount flags when setting up namespaces

2015-01-02 Thread Djalal Harouni
On Thu, Jan 01, 2015 at 06:41:17PM +, Topi Miettinen wrote: On 01/01/15 18:08, Dave Reisner wrote: On Thu, Jan 01, 2015 at 04:49:04PM +0200, Topi Miettinen wrote: Copy parent directory mount flags when setting up a namespace and don't accidentally clear mount flags later.

Re: [systemd-devel] [PATCH] Do not clear parent mount flags when setting up namespaces

2015-01-01 Thread Topi Miettinen
On 01/01/15 14:49, Topi Miettinen wrote: Copy parent directory mount flags when setting up a namespace and don't accidentally clear mount flags later. The problem here is that flags noexec, nosuid and nodev are cleared, so the mounts always have exec, suid, dev flags enabled. With the patch

Re: [systemd-devel] [PATCH] Do not clear parent mount flags when setting up namespaces

2015-01-01 Thread Dave Reisner
On Thu, Jan 01, 2015 at 04:49:04PM +0200, Topi Miettinen wrote: Copy parent directory mount flags when setting up a namespace and don't accidentally clear mount flags later. Signed-off-by: Topi Miettinen toiwo...@gmail.com --- src/core/namespace.c | 4 ++-- src/shared/util.c| 20

Re: [systemd-devel] [PATCH] Do not clear parent mount flags when setting up namespaces

2015-01-01 Thread Topi Miettinen
On 01/01/15 18:08, Dave Reisner wrote: On Thu, Jan 01, 2015 at 04:49:04PM +0200, Topi Miettinen wrote: Copy parent directory mount flags when setting up a namespace and don't accidentally clear mount flags later. Signed-off-by: Topi Miettinen toiwo...@gmail.com --- src/core/namespace.c |