Re: [systemd-devel] [PATCH 00/11] *** SUBJECT HERE ***

2013-12-21 Thread Djalal Harouni
On Fri, Dec 20, 2013 at 11:59:16AM -0800, Shawn Landden wrote: On Fri, Dec 20, 2013 at 11:50 AM, Colin Walters walt...@verbum.org wrote: On Thu, 2013-12-19 at 14:20 +0100, Florian Weimer wrote: readdir_r is rather broken on Linux because there are some directories it cannot read.

[systemd-devel] [PATCH] fstab-generator: Do not try to fsck non-devices

2013-12-21 Thread Thomas Bächler
This fixes a regression introduced in 64e70e4 where the mount fails when fstab is misconfigured with fs_passno 0 on a virtual file system like tmpfs. --- src/fstab-generator/fstab-generator.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [systemd-devel] [PATCH] fstab-generator: Do not try to fsck non-devices

2013-12-21 Thread Tom Gundersen
On Sat, Dec 21, 2013 at 11:22 AM, Thomas Bächler tho...@archlinux.org wrote: This fixes a regression introduced in 64e70e4 where the mount fails when fstab is misconfigured with fs_passno 0 on a virtual file system like tmpfs. --- src/fstab-generator/fstab-generator.c | 8 +--- 1 file

[systemd-devel] fstrim cron job

2013-12-21 Thread Bastien Nocera
Hey, I've seen that Ubuntu recently added transparent support for trimming filesystems on SSDs: https://blueprints.launchpad.net/ubuntu/+spec/core-1311-ssd-trimming and in the patch for util-linux: https://launchpadlibrarian.net/159909554/util-linux_2.20.1-5.1ubuntu11.diff.gz (looks for

Re: [systemd-devel] fstrim cron job

2013-12-21 Thread Kay Sievers
On Sat, Dec 21, 2013 at 2:25 PM, Bastien Nocera had...@hadess.net wrote: I've seen that Ubuntu recently added transparent support for trimming filesystems on SSDs: https://blueprints.launchpad.net/ubuntu/+spec/core-1311-ssd-trimming and in the patch for util-linux:

Re: [systemd-devel] fstrim cron job

2013-12-21 Thread Reindl Harald
Am 21.12.2013 14:44, schrieb Kay Sievers: Trimming should be the job of the filesystem, not for a nasty cron job. We do not want to support legacy filesystems with upstream shipped systemd units. doing it permanently on the fs-layer degrades all time performance doing it in a cron job

Re: [systemd-devel] fstrim cron job

2013-12-21 Thread Kay Sievers
On Sat, Dec 21, 2013 at 3:11 PM, Reindl Harald h.rei...@thelounge.net wrote: Am 21.12.2013 14:44, schrieb Kay Sievers: Trimming should be the job of the filesystem, not for a nasty cron job. We do not want to support legacy filesystems with upstream shipped systemd units. doing it

Re: [systemd-devel] fstrim cron job

2013-12-21 Thread Reindl Harald
Am 21.12.2013 15:23, schrieb Kay Sievers: On Sat, Dec 21, 2013 at 3:11 PM, Reindl Harald h.rei...@thelounge.net wrote: Am 21.12.2013 14:44, schrieb Kay Sievers: Trimming should be the job of the filesystem, not for a nasty cron job. We do not want to support legacy filesystems with upstream

Re: [systemd-devel] fstrim cron job

2013-12-21 Thread Marcos Mello
Bastien Nocera hadess at hadess.net writes: Hey, I've seen that Ubuntu recently added transparent support for trimming filesystems on SSDs: https://blueprints.launchpad.net/ubuntu/+spec/core-1311-ssd-trimming and in the patch for util-linux:

[systemd-devel] [PATCH] loginctl: corretly show session IDs on session-status

2013-12-21 Thread Djalal Harouni
Commit f8f14b3654bcd introduced a regression that makes loginctl session-status to not show the correct session ID(s) In print_session_status_info() the map[] array, element Seat receives the offset of the id in SessionStatusInfo struct instead of the offset of the seat member. This will cause

Re: [systemd-devel] [PATCH] fstab-generator: Do not try to fsck non-devices

2013-12-21 Thread Dave Reisner
On Sat, Dec 21, 2013 at 12:49:07PM +0100, Tom Gundersen wrote: On Sat, Dec 21, 2013 at 11:22 AM, Thomas Bächler tho...@archlinux.org wrote: This fixes a regression introduced in 64e70e4 where the mount fails when fstab is misconfigured with fs_passno 0 on a virtual file system like tmpfs.

Re: [systemd-devel] [PATCH] fstab-generator: Do not try to fsck non-devices

2013-12-21 Thread Kay Sievers
On Sat, Dec 21, 2013 at 5:33 PM, Dave Reisner d...@falconindy.com wrote: On Sat, Dec 21, 2013 at 12:49:07PM +0100, Tom Gundersen wrote: On Sat, Dec 21, 2013 at 11:22 AM, Thomas Bächler tho...@archlinux.org wrote: This fixes a regression introduced in 64e70e4 where the mount fails when

Re: [systemd-devel] [PATCH] fstab-generator: Do not try to fsck non-devices

2013-12-21 Thread Tom Gundersen
On Sat, Dec 21, 2013 at 5:42 PM, Kay Sievers k...@vrfy.org wrote: On Sat, Dec 21, 2013 at 5:33 PM, Dave Reisner d...@falconindy.com wrote: On Sat, Dec 21, 2013 at 12:49:07PM +0100, Tom Gundersen wrote: On Sat, Dec 21, 2013 at 11:22 AM, Thomas Bächler tho...@archlinux.org wrote: This fixes a

Re: [systemd-devel] fstrim cron job

2013-12-21 Thread Chris Murphy
On Dec 21, 2013, at 6:25 AM, Bastien Nocera had...@hadess.net wrote: I wanted to integrate that in Fedora, through a systemd daily unit. I was wondering whether this sort of integration (I'd intend to port the fstrim-all code to C) should be in systemd itself, or whether it should be a unit

Re: [systemd-devel] [PATCH] loginctl: corretly show session IDs on session-status

2013-12-21 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Dec 21, 2013 at 03:49:46PM +0100, Djalal Harouni wrote: Commit f8f14b3654bcd introduced a regression that makes loginctl session-status to not show the correct session ID(s) Applied. Zbyszek ___ systemd-devel mailing list

Re: [systemd-devel] [PATCH 00/11] *** SUBJECT HERE ***

2013-12-21 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Dec 19, 2013 at 02:20:10PM +0100, Florian Weimer wrote: This patch series removes all uses of readdir_r. The changes are not entirely mechanical, some of the patches fix bugs in error handling. readdir_r is rather broken on Linux because there are some directories it cannot read. I

Re: [systemd-devel] [PATCH] fstab-generator: Do not try to fsck non-devices

2013-12-21 Thread Thomas Bächler
Am 21.12.2013 12:49, schrieb Tom Gundersen: -r = add_fsck(f, what, where, type, passno); -if (r 0) -return r; +if(is_device_path(what)) { +r = add_fsck(f, what, where, type, passno); +if (r 0) +

[systemd-devel] [PATCH] libsystemd-login: add sd_session_get_remote_{host, user}

2013-12-21 Thread Mantas Mikulėnas
--- Makefile-man.am| 15 + man/sd_session_is_active.xml | 50 +++--- src/login/libsystemd-login.sym | 7 ++ src/login/sd-login.c | 28 +++ src/login/test-login.c | 14 +++-

[systemd-devel] [PATCH] loginctl: fix output of type with class

2013-12-21 Thread Mantas Mikulėnas
--- src/login/loginctl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/login/loginctl.c b/src/login/loginctl.c index 36c65bc..5f57f62 100644 --- a/src/login/loginctl.c +++ b/src/login/loginctl.c @@ -364,10 +364,12 @@ static void

Re: [systemd-devel] [PATCH] loginctl: fix output of type with class

2013-12-21 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Dec 22, 2013 at 02:54:05AM +0200, Mantas Mikulėnas wrote: --- src/login/loginctl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/login/loginctl.c b/src/login/loginctl.c index 36c65bc..5f57f62 100644 --- a/src/login/loginctl.c +++ b/src/login/loginctl.c

Re: [systemd-devel] [systemd-commits] 5 commits - TODO src/core src/libsystemd-bus src/login src/machine src/systemd

2013-12-21 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Dec 21, 2013 at 06:54:53PM -0800, Lennart Poettering wrote: TODO | 12 + src/core/automount.c |1 src/core/busname.c |1 src/core/dbus-automount.c|9 -

Re: [systemd-devel] [PATCH] libsystemd-login: add sd_session_get_remote_{host, user}

2013-12-21 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Dec 22, 2013 at 02:48:46AM +0200, Mantas Mikulėnas wrote: --- Makefile-man.am| 15 + man/sd_session_is_active.xml | 50 +++--- src/login/libsystemd-login.sym | 7 ++ src/login/sd-login.c | 28

Re: [systemd-devel] [PATCH] fstab-generator: Do not try to fsck non-devices

2013-12-21 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Dec 21, 2013 at 05:49:19PM +0100, Tom Gundersen wrote: On Sat, Dec 21, 2013 at 5:42 PM, Kay Sievers k...@vrfy.org wrote: On Sat, Dec 21, 2013 at 5:33 PM, Dave Reisner d...@falconindy.com wrote: On Sat, Dec 21, 2013 at 12:49:07PM +0100, Tom Gundersen wrote: On Sat, Dec 21, 2013 at

Re: [systemd-devel] [PATCH] loginctl: fix output of type with class

2013-12-21 Thread Mantas Mikulėnas
On Sun, Dec 22, 2013 at 4:00 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Sun, Dec 22, 2013 at 02:54:05AM +0200, Mantas Mikulėnas wrote: --- src/login/loginctl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/login/loginctl.c b/src/login/loginctl.c

[systemd-devel] [PATCH v2] loginctl: fix output of type with class

2013-12-21 Thread Mantas Mikulėnas
--- src/login/loginctl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/login/loginctl.c b/src/login/loginctl.c index 914f316..6900253 100644 --- a/src/login/loginctl.c +++ b/src/login/loginctl.c @@ -453,10 +453,12 @@ static int print_session_status_info(sd_bus *bus,