[systemd-devel] how to handle filesystems that do not support d_type in readdirs dirent?

2011-03-03 Thread Marius Tolzmann
hello.. we are currently using reiserfs on our root-partition.. since reiserfs always sets d_type to DT_UNKNOWN in dirent entries some tools like systemd-tmpfiles do not work as expected. in src/util.c:3905 DT_UNKNOWN is already included when checking file for type DT_REG or DT_LNK.

Re: [systemd-devel] how to handle filesystems that do not support d_type in readdirs dirent?

2011-03-03 Thread Marius Tolzmann
hi.. On 03/03/11 13:52, Andrey Borzenkov wrote: since reiserfs always sets d_type to DT_UNKNOWN in dirent entries some tools like systemd-tmpfiles do not work as expected. Hmm .. this could be the reason for my problem with utmp: it started with a missing utmp and i tracked it down to

Re: [systemd-devel] [PATCH] correctly mark system reboot

2011-03-03 Thread Lennart Poettering
On Thu, 03.03.11 09:14, Andrey Borzenkov (arvidj...@gmail.com) wrote: On Thu, Mar 3, 2011 at 7:51 AM, Andrey Borzenkov arvidj...@gmail.com wrote: On Thu, Mar 3, 2011 at 12:31 AM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 02.03.11 11:41, Andrey Borzenkov

Re: [systemd-devel] [PATCH] correctly mark system reboot

2011-03-03 Thread Lennart Poettering
On Thu, 03.03.11 07:51, Andrey Borzenkov (arvidj...@gmail.com) wrote: On Thu, Mar 3, 2011 at 12:31 AM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 02.03.11 11:41, Andrey Borzenkov (arvidj...@gmail.com) wrote: It is expected that system will put reboot in wtmp to mark when

Re: [systemd-devel] how to handle filesystems that do not support d_type in readdirs dirent?

2011-03-03 Thread Andrey Borzenkov
On Thu, Mar 3, 2011 at 5:48 PM, Marius Tolzmann tolzm...@molgen.mpg.de wrote: hi.. On 03/03/11 13:52, Andrey Borzenkov wrote: since reiserfs always sets d_type to DT_UNKNOWN in dirent entries some tools like systemd-tmpfiles do not work as expected. Hmm .. this could be the reason for my

Re: [systemd-devel] [PATCH] correctly mark system reboot

2011-03-03 Thread Andrey Borzenkov
On Thu, Mar 3, 2011 at 6:20 PM, Lennart Poettering lenn...@poettering.net wrote: On Thu, 03.03.11 09:14, Andrey Borzenkov (arvidj...@gmail.com) wrote: On Thu, Mar 3, 2011 at 7:51 AM, Andrey Borzenkov arvidj...@gmail.com wrote: On Thu, Mar 3, 2011 at 12:31 AM, Lennart Poettering

[systemd-devel] [PATCH] add extra check for DT_UNKNOWN files in directory scan

2011-03-03 Thread Andrey Borzenkov
Some file systems (at least, reiserfs) return DT_UNKNOWN for every directory entry in readdir(). So far in several places systemd filtered on DT_REG/DT_LNK and so skipped any file on such filesystems. It affected systemd-update-utmp, systemd-modules-load and systemd-tty-ask-password-agent. This

Re: [systemd-devel] how to handle filesystems that do not support d_type in readdirs dirent?

2011-03-03 Thread Lennart Poettering
On Thu, 03.03.11 13:05, Marius Tolzmann (tolzm...@molgen.mpg.de) wrote: hello.. we are currently using reiserfs on our root-partition.. Urks, people still use that cruft? since reiserfs always sets d_type to DT_UNKNOWN in dirent entries some tools like systemd-tmpfiles do not work as

Re: [systemd-devel] [PATCH] add extra check for DT_UNKNOWN files in directory scan

2011-03-03 Thread Lennart Poettering
On Thu, 03.03.11 18:27, Andrey Borzenkov (arvidj...@gmail.com) wrote: Some file systems (at least, reiserfs) return DT_UNKNOWN for every directory entry in readdir(). So far in several places systemd filtered on DT_REG/DT_LNK and so skipped any file on such filesystems. It affected

Re: [systemd-devel] [PATCH] add extra check for DT_UNKNOWN files in directory scan

2011-03-03 Thread Marius Tolzmann
Hello.. this looks fine.. and is better than just adding DT_UNKOWN 8) i additionally patched the cgroup-util.c (see attachment) thx for the patch.. m. On 03/03/11 16:27, Andrey Borzenkov wrote: Some file systems (at least, reiserfs) return DT_UNKNOWN for every directory entry in readdir().

Re: [systemd-devel] [PATCH] add extra check for DT_UNKNOWN files in directory scan

2011-03-03 Thread Marius Tolzmann
oops.. sorry.. wrong patch sent... this won't compile.. but since lennart also fixed it it seems to be obsolete anyway... 8) m. On 03/03/11 16:36, Marius Tolzmann wrote: Hello.. this looks fine.. and is better than just adding DT_UNKOWN 8) i additionally patched the cgroup-util.c (see

Re: [systemd-devel] how to handle filesystems that do not support d_type in readdirs dirent?

2011-03-03 Thread Marius Tolzmann
hi On 03/03/11 16:30, Lennart Poettering wrote: On Thu, 03.03.11 13:05, Marius Tolzmann (tolzm...@molgen.mpg.de) wrote: hello.. we are currently using reiserfs on our root-partition.. Urks, people still use that cruft? at least we do.. .. how is this supposed to be handled? if the

Re: [systemd-devel] /usr on separate file system

2011-03-03 Thread Tollef Fog Heen
]] Lennart Poettering Hi, | But it's a promise you are making there that you cannot keep. If you | want to support /usr on a separate partition then you'd need to do all | the work and move the PCI and USB databases to /, move libatasmart, | fix udisks, fix D-Bus and so on. I leave that to

Re: [systemd-devel] /usr on separate file system

2011-03-03 Thread Tomasz Torcz
On Thu, Mar 03, 2011 at 06:45:21PM +0100, Lennart Poettering wrote: On Thu, 03.03.11 17:58, Tollef Fog Heen (tfh...@err.no) wrote: ]] Lennart Poettering | To boot a system, enough must be present on the root partition to | mount other filesystems. This includes utilities,

Re: [systemd-devel] /usr on separate file system

2011-03-03 Thread Lennart Poettering
On Thu, 03.03.11 19:42, Tollef Fog Heen (tfh...@err.no) wrote: ]] Tomasz Torcz | I don't get it. What during the boot (before /usr is mounted) require pci.db, | usb ids, why udisks would be started? udev rules that reference the name rather than the USB/PCI vendor or product ID is

Re: [systemd-devel] /usr on separate file system

2011-03-03 Thread Lennart Poettering
On Thu, 03.03.11 19:21, Tomasz Torcz (to...@pipebreaker.pl) wrote: But it's a promise you are making there that you cannot keep. If you want to support /usr on a separate partition then you'd need to do all the work and move the PCI and USB databases to /, move libatasmart, fix udisks,

Re: [systemd-devel] /usr on separate file system

2011-03-03 Thread Tomasz Torcz
On Thu, Mar 03, 2011 at 05:39:03PM -0300, Pablo Hess wrote: Not supporting a separate /usr would be a major setback for systemd, IMO. Separate /usr has nothing to do with systemd. It just the way current distribution work. Systemd is just a messenger, don't shot it because of friendly

Re: [systemd-devel] /usr on separate file system

2011-03-03 Thread Lennart Poettering
On Thu, 03.03.11 17:39, Pablo Hess (natunobi...@gentoobr.org) wrote: Would it work better if /usr was an automounted target? That would probably blow up in your face, since a lot of programs used during early boot end up accessing /usr and would stay stuck Aren't /usr/bin and

Re: [systemd-devel] /usr on separate file system

2011-03-03 Thread Matthew Miller
On Thu, Mar 03, 2011 at 09:51:52PM +0100, Lennart Poettering wrote: Why? systemd just warns you. systemd itself works fine with sperate /usr. It's just a statement on the general ecosystem, a statement of fact on the status quo. systemd is just the messenger. Don't shoot the messenger. If