[systemd-devel] [PATCH] test: Make testing work on systems without or old systemd

2013-07-18 Thread Holger Hans Peter Freyther
From: Holger Hans Peter Freyther hol...@moiji-mobile.com * Introduce a macro to conditionally execute tests. This avoids skipping the entire test if some parts require systemd * Skip the journal tests when no /etc/machine-id is present * Change test-catalog to load the catalog from the source

[systemd-devel] [PATCH] make: Automake is complaining about .PRECIOUS being redefined

2013-07-18 Thread Holger Hans Peter Freyther
From: Holger Hans Peter Freyther hol...@moiji-mobile.com Yesterday I added test-suite.log as dependency to the .PRECIOUS target. Automake is warning about this target being redefined and from what I see there is no way I can stop the warning but I can add the %MAKEFILE% as dependency. automake

Re: [systemd-devel] [PATCH] makefile:put macros file to the correct place

2013-07-18 Thread Vaclav Pavlin
- Original Message - From: Kay Sievers k...@redhat.com To: Václav Pavlín vpav...@redhat.com Cc: Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl, Fedora systemd team systemd-ma...@redhat.com, systemd-devel@lists.freedesktop.org Sent: Friday, June 28, 2013 11:25:49 AM Subject: Re:

[systemd-devel] Has systemd booted up command

2013-07-18 Thread Umut Tezduyar
Hi, This is in reference to https://bugs.freedesktop.org/show_bug.cgi?id=66926 request. I have been polling systemd with systemctl is-active default.target to detect if boot up has been completed or not. I have noticed that this is not enough though. It seems like starting a service that is

[systemd-devel] [PATCH] journalctl: add ”short-iso” output format with verbose ISO8601 timestamps

2013-07-18 Thread Tomasz Torcz
Example: 2013-07-18T10:10:01+0200 sandworm CROND[20957]: (root) CMD (/usr/lib64/sa/sa1 1 1) --- man/journalctl.xml | 12 src/journal/journalctl.c | 2 +- src/shared/logs-show.c | 10 +- src/shared/output-mode.h | 1 + 4 files changed, 23 insertions(+), 2

Re: [systemd-devel] [PATCH] journalctl: add --iso-dates for long timestamps

2013-07-18 Thread Thomas Bächler
Am 17.07.2013 17:58, schrieb Zbigniew Jędrzejewski-Szmek: So, now we have -o short, -o short-monotonic, and --iso-dates. I'm sure we'll add a relative timestamp mode like the excellent one in dmesg --human output in recent util-linux. So I'd say that it makes sense to deprecate short-monotonic

[systemd-devel] [PATCHv4] systemctl, man: option to list units by state

2013-07-18 Thread Maciej Wereski
This allows to show only units with specified LOAD or SUB or ACTIVE state. Signed-off-by: Maciej Wereski m.were...@partner.samsung.com --- man/systemctl.xml | 15 +-- src/systemctl/systemctl.c | 34 -- 2 files changed, 41 insertions(+), 8

[systemd-devel] /etc/systemd/system/darkice.service

2013-07-18 Thread Kai Hendry
Hi guys, http://sprunge.us/SLSF is the service file I have currently. I'm running http://archlinuxarm.org/ on a Rpi with systemd 204-3. I'm having issues creating a service file for darkice a audio streamer that depends on: * a network connection * a microphone

Re: [systemd-devel] runtime directories for services vs. tmpfiles

2013-07-18 Thread Kay Sievers
On Thu, Jul 18, 2013 at 4:50 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Thu, Jul 18, 2013 at 02:51:09AM +0200, Lennart Poettering wrote: [snip repoquery magic] This means: ~81% of the packages have been converted from sysv to systemd. And ~10% of the converted packages make

Re: [systemd-devel] [PATCH v5] journalctl: Add support for showing messages from a previous boot

2013-07-18 Thread Jan Janssen
On 07/18/2013 06:10 AM, Zbigniew Jędrzejewski-Szmek wrote: On Tue, Jul 16, 2013 at 05:46:04PM +0200, Lennart Poettering wrote: On Tue, 16.07.13 17:42, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Tue, Jul 16, 2013 at 05:39:54PM +0200, Lennart Poettering wrote: On Fri, 28.06.13

[systemd-devel] [PATCHv5] systemctl, man: option to list units by state

2013-07-18 Thread Maciej Wereski
This allows to show only units with specified LOAD or SUB or ACTIVE state. Signed-off-by: Maciej Wereski m.were...@partner.samsung.com --- changes since v4: * removed help information about deprecated behaviour Sorry, that I've forgot about this in previous patch! regards, Maciej ---

Re: [systemd-devel] [PATCH v5] journalctl: Add support for showing messages from a previous boot

2013-07-18 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jul 18, 2013 at 01:05:25PM +0200, Jan Janssen wrote: On 07/18/2013 06:10 AM, Zbigniew Jędrzejewski-Szmek wrote: On Tue, Jul 16, 2013 at 05:46:04PM +0200, Lennart Poettering wrote: On Tue, 16.07.13 17:42, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Tue, Jul 16, 2013

Re: [systemd-devel] /etc/systemd/system/darkice.service

2013-07-18 Thread Lennart Poettering
On Thu, 18.07.13 18:01, Kai Hendry (hen...@iki.fi) wrote: Hi guys, http://sprunge.us/SLSF is the service file I have currently. I'm running http://archlinuxarm.org/ on a Rpi with systemd 204-3. I'm having issues creating a service file for darkice a audio streamer that depends on: * a

Re: [systemd-devel] runtime directories for services vs. tmpfiles

2013-07-18 Thread Jóhann B. Guðmundsson
On 07/18/2013 12:51 AM, Lennart Poettering wrote: Fedora is not completely converted, but here are some stats. $ repoquery --whatprovides '/etc/rc.d/init.d/*' --qf %{name} | sort -u | egrep -v '(-sysvinit|-initscript|-sysv)$' | wc -l 139 Well even that number is not accurate

Re: [systemd-devel] /etc/systemd/system/darkice.service

2013-07-18 Thread Tom Gundersen
On Thu, Jul 18, 2013 at 2:27 PM, Lennart Poettering lenn...@poettering.net wrote: On Thu, 18.07.13 18:01, Kai Hendry (hen...@iki.fi) wrote: [root@pihsg ~]# systemctl status darkice.service darkice.service - DarkIce audio forwarder Loaded: loaded (/etc/systemd/system/darkice.service;

Re: [systemd-devel] /etc/systemd/system/darkice.service

2013-07-18 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jul 18, 2013 at 02:27:09PM +0200, Lennart Poettering wrote: On Thu, 18.07.13 18:01, Kai Hendry (hen...@iki.fi) wrote: Second scenario, microphone plugged in: [root@pihsg ~]# systemctl status darkice.service darkice.service - DarkIce audio forwarder Loaded: loaded

[systemd-devel] [PATCH] journal: Leave server_dispatch_message early when Storage is none

2013-07-18 Thread Holger Hans Peter Freyther
From: Holger Hans Peter Freyther hol...@moiji-mobile.com When using Storage=none there is no point in collecting all the information just to throw them away. After this change journald consumes a lot less CPU time when only forwarding messages. --- src/journal/journald-server.c | 5 + 1 file

Re: [systemd-devel] [PATCH] Log failing start conditions

2013-07-18 Thread Lennart Poettering
On Thu, 18.07.13 05:52, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: I'd prefer if we'd solve this without the journal. Instead, I think struct Condition should be extended to store the most recent test result in a tri-state, i.e. negative for untested, zero for failed, positive

Re: [systemd-devel] /etc/systemd/system/darkice.service

2013-07-18 Thread Kai Hendry
On 18 July 2013 20:27, Lennart Poettering lenn...@poettering.net wrote: You need an After= here for the device, too. Thanks this fixes the first scenario: http://sprunge.us/LiQF I must say needing After BindsTo is a bit confusing. I also don't see the need for different sections. Never quite

Re: [systemd-devel] [PATCHv2] core: notify triggered by socket of a service

2013-07-18 Thread Umut Tezduyar
On Thu, Jul 18, 2013 at 3:27 AM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 17.07.13 09:46, Umut Tezduyar (u...@tezduyar.com) wrote: +static void socket_trigger_notify(Unit *u, Unit *other) { +Socket *s = SOCKET(u); +Service *se = SERVICE(other); + +

[systemd-devel] [PATCHv3] core: notify triggered by socket of a service

2013-07-18 Thread Umut Tezduyar
Refer to: http://lists.freedesktop.org/archives/systemd-devel/2013-June/011532.html --- TODO |3 --- src/core/service.c | 31 --- src/core/socket.c | 34 +- src/core/socket.h |3 --- 4 files changed, 33

Re: [systemd-devel] /etc/systemd/system/darkice.service

2013-07-18 Thread Lennart Poettering
On Thu, 18.07.13 14:34, Tom Gundersen (t...@jklm.no) wrote: On Thu, Jul 18, 2013 at 2:27 PM, Lennart Poettering lenn...@poettering.net wrote: On Thu, 18.07.13 18:01, Kai Hendry (hen...@iki.fi) wrote: [root@pihsg ~]# systemctl status darkice.service darkice.service - DarkIce audio

Re: [systemd-devel] [PATCH] Log failing start conditions

2013-07-18 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jul 18, 2013 at 02:47:56PM +0200, Lennart Poettering wrote: On Thu, 18.07.13 05:52, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: I'd prefer if we'd solve this without the journal. Instead, I think struct Condition should be extended to store the most recent test

Re: [systemd-devel] [PATCH] journalctl: add ”short-iso” output format with verbose ISO8601 timestamps

2013-07-18 Thread Lennart Poettering
On Thu, 18.07.13 10:21, Tomasz Torcz (to...@pipebreaker.pl) wrote: Example: 2013-07-18T10:10:01+0200 sandworm CROND[20957]: (root) CMD (/usr/lib64/sa/sa1 1 1) Applied! Thanks! (Made some minor changes though: dropped tabs, and removed a gcc warning by changing the strftime() invocation to

[systemd-devel] [PATCH] core: get rid the start job when transitioning to deactivating

2013-07-18 Thread Michal Sekletar
When dependency unit is configured with StopWhenUnneeded=yes and activation of main unit fails, e.g. start timeout occurs, then dependencies are never stopped. This happens because start job for the main unit is still around. --- src/core/unit.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [systemd-devel] [PATCH v2, ping?] tmpfiles, man: Add xattr support to tmpfiles

2013-07-18 Thread Maciej Wereski
Hello, 16.07.2013 at 00:31 Lennart Poettering lenn...@poettering.net wrote: +STRV_FOREACH(x, i-xattrs) { +value = *x; +name = strsep(value, =); I'd really prefer if we didn't corrupt the string here. Maybe use strv_split_quoted() here? That handles all

Re: [systemd-devel] [PATCH] journalctl: add --iso-dates for long timestamps

2013-07-18 Thread Lennart Poettering
On Thu, 18.07.13 10:45, Thomas Bächler (tho...@archlinux.org) wrote: Am 17.07.2013 17:58, schrieb Zbigniew Jędrzejewski-Szmek: So, now we have -o short, -o short-monotonic, and --iso-dates. I'm sure we'll add a relative timestamp mode like the excellent one in dmesg --human output in

Re: [systemd-devel] [PATCH] journalctl: add --iso-dates for long timestamps

2013-07-18 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jul 18, 2013 at 06:55:47PM +0200, Lennart Poettering wrote: On Thu, 18.07.13 10:45, Thomas Bächler (tho...@archlinux.org) wrote: Am 17.07.2013 17:58, schrieb Zbigniew Jędrzejewski-Szmek: So, now we have -o short, -o short-monotonic, and --iso-dates. I'm sure we'll add a relative

Re: [systemd-devel] Has systemd booted up command

2013-07-18 Thread Lennart Poettering
On Thu, 18.07.13 10:08, Umut Tezduyar (u...@tezduyar.com) wrote: Hi, This is in reference to https://bugs.freedesktop.org/show_bug.cgi?id=66926 request. I have been polling systemd with systemctl is-active default.target to detect if boot up has been completed or not. I have noticed

Re: [systemd-devel] [PATCH] Log failing start conditions

2013-07-18 Thread Lennart Poettering
On Thu, 18.07.13 15:47, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: Now, in both cases the externally visible type is actually a bool, even if we internally distuingish three different states. For the condition stuff it is necessary to *actually* distuingish three states on the

Re: [systemd-devel] /etc/systemd/system/darkice.service

2013-07-18 Thread Lennart Poettering
On Thu, 18.07.13 21:11, Kai Hendry (hen...@iki.fi) wrote: On 18 July 2013 20:27, Lennart Poettering lenn...@poettering.net wrote: You need an After= here for the device, too. Thanks this fixes the first scenario: http://sprunge.us/LiQF I must say needing After BindsTo is a bit

Re: [systemd-devel] [PATCHv5] systemctl, man: option to list units by state

2013-07-18 Thread Lennart Poettering
On Thu, 18.07.13 13:24, Maciej Wereski (m.were...@partner.samsung.com) wrote: This allows to show only units with specified LOAD or SUB or ACTIVE state. Thanks! Applied (with some changes, got rid of the arg_load_states strv which is kinda unnecessary if we have arg_states now). Lennart --

Re: [systemd-devel] [PATCH] journal: Leave server_dispatch_message early when Storage is none

2013-07-18 Thread Lennart Poettering
On Thu, 18.07.13 14:45, Holger Hans Peter Freyther (hol...@freyther.de) wrote: From: Holger Hans Peter Freyther hol...@moiji-mobile.com When using Storage=none there is no point in collecting all the information just to throw them away. After this change journald consumes a lot less CPU

Re: [systemd-devel] [PATCH] core: get rid the start job when transitioning to deactivating

2013-07-18 Thread Lennart Poettering
On Thu, 18.07.13 17:04, Michal Sekletar (msekl...@redhat.com) wrote: When dependency unit is configured with StopWhenUnneeded=yes and activation of main unit fails, e.g. start timeout occurs, then dependencies are never stopped. This happens because start job for the main unit is still

Re: [systemd-devel] [PATCHv3] core: notify triggered by socket of a service

2013-07-18 Thread Lennart Poettering
On Thu, 18.07.13 15:27, Umut Tezduyar (u...@tezduyar.com) wrote: +static void socket_trigger_notify(Unit *u, Unit *other) { +Socket *s = SOCKET(u); +Service *se = SERVICE(other); + +assert(u); +assert(other); + +if (other-load_state != UNIT_LOADED

Re: [systemd-devel] [PATCH v2, ping?] tmpfiles, man: Add xattr support to tmpfiles

2013-07-18 Thread Lennart Poettering
On Thu, 18.07.13 17:09, Maciej Wereski (m.were...@partner.samsung.com) wrote: Hello, 16.07.2013 at 00:31 Lennart Poettering lenn...@poettering.net wrote: +STRV_FOREACH(x, i-xattrs) { +value = *x; +name = strsep(value, =); I'd really prefer if

Re: [systemd-devel] [PATCH 1/2] RFC: journald: Allow to cache the cg_get_root_path

2013-07-18 Thread Karol Lewandowski
On 07/16/2013 03:26 AM, Lennart Poettering wrote: On Mon, 08.07.13 18:39, Karol Lewandowski (k.lewando...@samsung.com) wrote: According to my analysis /proc access is costly and it would be best to cache the result for later use. Difficulty comes from trying to keep cache up to date, though.

Re: [systemd-devel] Has systemd booted up command

2013-07-18 Thread Umut Tezduyar
On Thu, Jul 18, 2013 at 7:06 PM, Lennart Poettering lenn...@poettering.net wrote: On Thu, 18.07.13 10:08, Umut Tezduyar (u...@tezduyar.com) wrote: Hi, This is in reference to https://bugs.freedesktop.org/show_bug.cgi?id=66926 request. I have been polling systemd with systemctl is-active

Re: [systemd-devel] [PATCH 1/2] RFC: journald: Allow to cache the cg_get_root_path

2013-07-18 Thread Holger Hans Peter Freyther
On Thu, Jul 18, 2013 at 08:32:18PM +0200, Karol Lewandowski wrote: Agreed, this is why I have been naively thinking that caching wouldn't be that bad... However, sending all the required information in message itself is clearly the best solution to this problem. It is nice to avoid the race

Re: [systemd-devel] [systemd-commits] What is a criterion to differentiate sysinit.target from basic.target?

2013-07-18 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jul 18, 2013 at 07:54:37PM +0900, Tony Seo wrote: Hello. I'm Tonyseo in south of Korea. As I'm a new stater, I try to study systemd. When I had studied bootup procedue in systemd, I found that there are two important targets which are sysinit.target and basic.target. I wonder

Re: [systemd-devel] [systemd-commits] What is a criterion to differentiate sysinit.target from basic.target?

2013-07-18 Thread Lennart Poettering
On Thu, 18.07.13 21:07, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Thu, Jul 18, 2013 at 07:54:37PM +0900, Tony Seo wrote: Hello. I'm Tonyseo in south of Korea. As I'm a new stater, I try to study systemd. When I had studied bootup procedue in systemd, I found

Re: [systemd-devel] Has systemd booted up command

2013-07-18 Thread Hoyer, Marko (ADITG/SW2)
-Original Message- From: systemd-devel-bounces+mhoyer=de.adit-jv@lists.freedesktop.org [mailto:systemd-devel-bounces+mhoyer=de.adit-jv@lists.freedesktop.org] On Behalf Of Umut Tezduyar Sent: Thursday, July 18, 2013 8:38 PM To: Lennart Poettering Cc: Mailing-List systemd