Re: [systemd-devel] [PATCH] systemd-run: extend bash completion

2014-03-11 Thread Thomas H.P. Andersen
On Tue, Mar 11, 2014 at 4:52 AM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 05.03.14 23:48, Thomas H.P. Andersen (pho...@gmail.com) wrote: From: Thomas Hindoe Paaboel Andersen pho...@gmail.com --system -H --host -M --machine --service-type (options: simple forking oneshot

Re: [systemd-devel] [PATCH] systemd: powerd initctl support

2014-03-11 Thread Michael Biebl
2014-03-11 4:30 GMT+01:00 Lennart Poettering lenn...@poettering.net: On Fri, 07.03.14 14:32, Hannes Reinecke (h...@suse.de) wrote: + THE POWER IS FAILED! SYSTEM GOING DOWN! PLEASE LOG OFF NOW!); Hmm, this is incorrect english, isn't it? it should be The power

Re: [systemd-devel] [systemd][cgroup in container] problem with cgroup hierarchy in container

2014-03-11 Thread Dariusz Michaluk
On 10.03.2014 22:50, Lennart Poettering wrote: Which version of systemd is this? any chance you can reproduce this with systemctl compiled fresh from current git? Or could you run gdbus introspect --system --dest org.freedesktop.systemd1 --object-path /org/freedesktop/systemd1 and see if any of

Re: [systemd-devel] [PATCH] service: don't create extra cgroup for control process when reloading SysV service

2014-03-11 Thread Jóhann B. Guðmundsson
On 03/11/2014 09:05 AM, Michael Biebl wrote: 2014-03-10 15:25 GMT+01:00 Lukas Nykryn lnyk...@redhat.com: Unfortunately common practice in initscripts is to have reload as an alias for restart (https://fedoraproject.org/wiki/Packaging:SysVInitScript). In that case the newly started process will

Re: [systemd-devel] [PATCH] udev: properly detect reference to unexisting part of PROGRAM's result

2014-03-11 Thread Kay Sievers
On Mon, Feb 24, 2014 at 5:06 PM, Lukas Nykryn lnyk...@redhat.com wrote: --- src/udev/udev-event.c | 2 ++ 1 file changed, 2 insertions(+) Applied. Thanks, Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

[systemd-devel] kernel panic

2014-03-11 Thread Vasiliy Tolstov
I have strange kernel panic Kernel 3.13.3 vanilla root is mounted via 9p virtfs (readonly). virsh --version 1.2.1 qemu --version QEMU emulator version 1.7.0, Copyright (c) 2003-2008 Fabrice Bellard systemd version 210 Domain config: domain type='kvm' namebuild/name

Re: [systemd-devel] Suspending access to opened/active /dev/nodes during application runtime

2014-03-11 Thread David Herrmann
Hi On Fri, Mar 7, 2014 at 7:45 PM, Lukasz Pawelczyk hav...@gmail.com wrote: Problem: Has anyone thought about a mechanism to limit/remove an access to a device during an application runtime? Meaning we have an application that has an open file descriptor to some /dev/node and depending on

Re: [systemd-devel] [PATCH] systemd-run: extend bash completion

2014-03-11 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Mar 11, 2014 at 08:05:48AM +0100, Thomas H.P. Andersen wrote: On Tue, Mar 11, 2014 at 4:52 AM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 05.03.14 23:48, Thomas H.P. Andersen (pho...@gmail.com) wrote: From: Thomas Hindoe Paaboel Andersen pho...@gmail.com --system

Re: [systemd-devel] kernel panic

2014-03-11 Thread Cristian Rodríguez
El 11/03/14 09:24, Vasiliy Tolstov escribió: I have strange kernel panic Kernel 3.13.3 vanilla root is mounted via 9p virtfs (readonly). virsh --version 1.2.1 qemu --version QEMU emulator version 1.7.0, Copyright (c) 2003-2008 Fabrice Bellard systemd version 210 [ 14.640174] Kernel panic

Re: [systemd-devel] kernel panic

2014-03-11 Thread Vasiliy Tolstov
2014-03-11 17:13 GMT+04:00 Cristian Rodríguez crrodrig...@opensuse.org: This is quite obviously not a systemd/udev problem, post your problem in the kernel mailing list instead. Thanks! -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru jabber: v...@selfip.ru

Re: [systemd-devel] [PATCH] systemd-run: extend bash completion

2014-03-11 Thread Lennart Poettering
On Tue, 11.03.14 08:05, Thomas H.P. Andersen (pho...@gmail.com) wrote: On Tue, Mar 11, 2014 at 4:52 AM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 05.03.14 23:48, Thomas H.P. Andersen (pho...@gmail.com) wrote: From: Thomas Hindoe Paaboel Andersen pho...@gmail.com

Re: [systemd-devel] [PATCH 3/3] hostnamectl: read pretty_name and cpe_name from remote

2014-03-11 Thread Djalal Harouni
On Tue, Mar 11, 2014 at 05:01:33AM +0100, Lennart Poettering wrote: On Tue, 04.03.14 23:01, Djalal Harouni (tix...@opendz.org) wrote: The other two patches look fine (well, this one needs updating, if the prop names change as proposed in the other mail...) Please rebase, and repost, will

[systemd-devel] [PATCH v2 1/3] hostnamed: minor improvements in context_write_data_other()

2014-03-11 Thread Djalal Harouni
Prepare context_write_data_other() and rename it to context_write_data_machine_info() --- src/hostname/hostnamed.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/hostname/hostnamed.c b/src/hostname/hostnamed.c index 6aa08ca..fab0601 100644 ---

[systemd-devel] [PATCH v2 2/3] hostnamed: expose OperatingSystemPrettyName and OperatingSystemCPEName on the bus

2014-03-11 Thread Djalal Harouni
--- src/hostname/hostnamed.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/hostname/hostnamed.c b/src/hostname/hostnamed.c index fab0601..3b19d43 100644 --- a/src/hostname/hostnamed.c +++ b/src/hostname/hostnamed.c @@ -40,6 +40,8 @@ enum { PROP_PRETTY_HOSTNAME,

[systemd-devel] [PATCH v2 3/3] hostnamectl: read OS pretty_name and cpe_name from remote

2014-03-11 Thread Djalal Harouni
--- src/hostname/hostnamectl.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/src/hostname/hostnamectl.c b/src/hostname/hostnamectl.c index 94b4243..326f371 100644 --- a/src/hostname/hostnamectl.c +++ b/src/hostname/hostnamectl.c @@ -67,6 +67,8 @@

[systemd-devel] [PATCH] nspawn: fix argv[0] for getent

2014-03-11 Thread Mantas Mikulėnas
--- src/nspawn/nspawn.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/nspawn/nspawn.c b/src/nspawn/nspawn.c index cd31bd4..489dbde 100644 --- a/src/nspawn/nspawn.c +++ b/src/nspawn/nspawn.c @@ -2264,8 +2264,8 @@ static int spawn_getent(const char *database, const

Re: [systemd-devel] [PATCH] nspawn: fix argv[0] for getent

2014-03-11 Thread Lennart Poettering
On Tue, 11.03.14 18:00, Mantas Mikulėnas (graw...@gmail.com) wrote: Applied! Thanks! --- src/nspawn/nspawn.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/nspawn/nspawn.c b/src/nspawn/nspawn.c index cd31bd4..489dbde 100644 --- a/src/nspawn/nspawn.c +++

Re: [systemd-devel] StartTransientService problems

2014-03-11 Thread Lennart Poettering
On Wed, 05.03.14 09:55, Barry Scott (barry.sc...@onelan.co.uk) wrote: On Wed 05 Mar 2014 04:47:13 Lennart Poettering wrote: On Tue, 25.02.14 17:59, Barry Scott (barry.sc...@onelan.co.uk) wrote: Which should make them available via the bus for transient units. If you need other props

Re: [systemd-devel] [RFC] bus: add sd_bus_emit_object_{added, removed}()

2014-03-11 Thread Lennart Poettering
On Tue, 18.02.14 00:02, David Herrmann (dh.herrm...@gmail.com) wrote: Sorry for the late review! However, on object_removed() I cannot do that as node_vtable_get_userdata() is very likely to return 0 for all these objects. So there is no way to figure out which interfaces actually existed on

Re: [systemd-devel] [RFC] bus: add sd_bus_emit_object_{added, removed}()

2014-03-11 Thread David Herrmann
Hi On Tue, Mar 11, 2014 at 7:27 PM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 18.02.14 00:02, David Herrmann (dh.herrm...@gmail.com) wrote: Sorry for the late review! However, on object_removed() I cannot do that as node_vtable_get_userdata() is very likely to return 0 for

Re: [systemd-devel] [PATCH] Fix systemd-stdio-bridge symlink

2014-03-11 Thread Umut Tezduyar Lindskog
Hi, From: systemd-devel-boun...@lists.freedesktop.org [systemd-devel-boun...@lists.freedesktop.org] On Behalf Of Lennart Poettering [lenn...@poettering.net] Sent: Tuesday, March 04, 2014 2:38 PM To: Umut Tezduyar Cc: systemd Mailing List Subject: Re:

[systemd-devel] [PATCH] build-sys: Fix move-to-rootlibdir

2014-03-11 Thread Mike Gilbert
Since we now use ln -s --relative, using this sed statement is redundant and causes broken symlinks to be installed. --- Makefile.am | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 182eca6..bd78f44 100644 --- a/Makefile.am +++ b/Makefile.am @@

Re: [systemd-devel] [PATCH] build-sys: Fix move-to-rootlibdir

2014-03-11 Thread Mike Gilbert
On Tue, Mar 11, 2014 at 6:14 PM, Mike Gilbert flop...@gentoo.org wrote: Since we now use ln -s --relative, using this sed statement is redundant and causes broken symlinks to be installed. Actually, I think the the symlinks are not broken under normal circumstances (rootlibdir = /lib). However,

Re: [systemd-devel] [PATCH] Fix systemd-stdio-bridge symlink

2014-03-11 Thread Lennart Poettering
On Tue, 11.03.14 22:04, Umut Tezduyar Lindskog (umut.tezdu...@axis.com) wrote: Is this something you would be interested: http://lists.openembedded.org/pipermail/openembedded-core/2014-March/090162.html Well, this is implemented in python, and we don't want a python dependency for the build

Re: [systemd-devel] [PATCH] build-sys: Fix move-to-rootlibdir

2014-03-11 Thread Lennart Poettering
On Tue, 11.03.14 18:14, Mike Gilbert (flop...@gentoo.org) wrote: Since we now use ln -s --relative, using this sed statement is redundant and causes broken symlinks to be installed. Hmm, wouldn't it be nicer to just drop the --relative here? Quite honestly, I don't grok the code, neither the

Re: [systemd-devel] [PATCH] build-sys: Fix move-to-rootlibdir

2014-03-11 Thread Mike Gilbert
On Tue, Mar 11, 2014 at 6:42 PM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 11.03.14 18:14, Mike Gilbert (flop...@gentoo.org) wrote: Since we now use ln -s --relative, using this sed statement is redundant and causes broken symlinks to be installed. Hmm, wouldn't it be nicer to

Re: [systemd-devel] [PATCH] build-sys: Fix move-to-rootlibdir

2014-03-11 Thread Mike Gilbert
On Tue, Mar 11, 2014 at 6:53 PM, Mike Gilbert flop...@gentoo.org wrote: On Tue, Mar 11, 2014 at 6:42 PM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 11.03.14 18:14, Mike Gilbert (flop...@gentoo.org) wrote: Since we now use ln -s --relative, using this sed statement is redundant

Re: [systemd-devel] [PATCH] build-sys: Fix move-to-rootlibdir

2014-03-11 Thread Kay Sievers
On Tue, Mar 11, 2014 at 11:42 PM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 11.03.14 18:14, Mike Gilbert (flop...@gentoo.org) wrote: Since we now use ln -s --relative, using this sed statement is redundant and causes broken symlinks to be installed. Hmm, wouldn't it be nicer

Re: [systemd-devel] [PATCH] util: Rewrite in_charset to use strspn

2014-03-11 Thread Josh Triplett
On Wed, Mar 12, 2014 at 12:49:08AM +0100, Lennart Poettering wrote: Can you turn this into an inline function please? If it's that simple it sounds better to just make it an inline function in the .h file, instead of the .c file... Sure. Mind if I do that as a two-patch series? I prefer to

Re: [systemd-devel] [PATCH] util: Rewrite in_charset to use strspn

2014-03-11 Thread Lennart Poettering
On Tue, 11.03.14 18:33, Josh Triplett (j...@joshtriplett.org) wrote: On Wed, Mar 12, 2014 at 12:49:08AM +0100, Lennart Poettering wrote: Can you turn this into an inline function please? If it's that simple it sounds better to just make it an inline function in the .h file, instead of

Re: [systemd-devel] [PATCH] util: Rewrite in_charset to use strspn

2014-03-11 Thread Lennart Poettering
On Tue, 11.03.14 16:45, Josh Triplett (j...@joshtriplett.org) wrote: Can you turn this into an inline function please? If it's that simple it sounds better to just make it an inline function in the .h file, instead of the .c file... This simplifies in_charset down to a one-liner, and allows for

[systemd-devel] [PATCH] util: Make in_charset a static inline in util.h

2014-03-11 Thread Josh Triplett
With in_charset now reduced to a one-liner (plus asserts), make it a static inline. --- This applies on top of the previous patch simplifying in_charset. src/shared/util.c | 6 -- src/shared/util.h | 6 +- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/shared/util.c

[systemd-devel] [ANNOUNCE] systemd 211

2014-03-11 Thread Lennart Poettering
Heya! Many bugfixes, and a number of new features: http://www.freedesktop.org/software/systemd/systemd-211.tar.xz As before

[systemd-devel] [PATCH 1/2] backlight: Fix copy/paste error printing an unrelated error code

2014-03-11 Thread Josh Triplett
udev_device_get_sysattr_value returns NULL on failure, but doesn't provide an error code; thus, when printing an error from it, don't print an unrelated error code from a previous call. --- src/backlight/backlight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[systemd-devel] [PATCH 2/2] backlight: Avoid restoring brightness to an unreadably dim level

2014-03-11 Thread Josh Triplett
Some systems turn the backlight all the way off at the lowest levels. Clamp saved brightness to at least 1 or 5% of max_brightness. This avoids preserving an unreadably dim screen, which would otherwise force the user to disable state restoration. --- src/backlight/backlight.c | 39

[systemd-devel] systemd 211 journal getting created with different permissions

2014-03-11 Thread Greg KH
Hi all, With systemd 211, a new journal file is getting created with permissions of root:root instead of root:systemd-journal like previously (210 and prior). I looked at the git log and can't see anything obvious that would have caused this. Is this intentional? Or something on my end with my

[systemd-devel] [PATCH] util: Rewrite in_charset to use strspn

2014-03-11 Thread Josh Triplett
This simplifies in_charset down to a one-liner, and allows for possible optimizations of strspn in libc. --- src/shared/util.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/shared/util.c b/src/shared/util.c index d28caae..82326df 100644 --- a/src/shared/util.c

Re: [systemd-devel] systemd 211 journal getting created with different permissions

2014-03-11 Thread Mantas Mikulėnas
On Wed, Mar 12, 2014 at 3:46 AM, Greg KH gre...@linuxfoundation.org wrote: Hi all, With systemd 211, a new journal file is getting created with permissions of root:root instead of root:systemd-journal like previously (210 and prior). I looked at the git log and can't see anything obvious

Re: [systemd-devel] [PATCH 2/2] backlight: Avoid restoring brightness to an unreadably dim level

2014-03-11 Thread Lennart Poettering
On Tue, 11.03.14 18:55, Josh Triplett (j...@joshtriplett.org) wrote: +/* Some systems turn the backlight all the way off at the + * lowest levels. Clamp saved brightness to at least 1 or 5% + * of max_brightness. This avoids preserving an

Re: [systemd-devel] systemd 211 journal getting created with different permissions

2014-03-11 Thread Greg KH
On Wed, Mar 12, 2014 at 04:21:55AM +0200, Mantas Mikulėnas wrote: On Wed, Mar 12, 2014 at 3:46 AM, Greg KH gre...@linuxfoundation.org wrote: Hi all, With systemd 211, a new journal file is getting created with permissions of root:root instead of root:systemd-journal like previously (210

Re: [systemd-devel] [PATCH 2/2] backlight: Avoid restoring brightness to an unreadably dim level

2014-03-11 Thread Josh Triplett
On Wed, Mar 12, 2014 at 03:32:47AM +0100, Lennart Poettering wrote: On Tue, 11.03.14 18:55, Josh Triplett (j...@joshtriplett.org) wrote: +/* Some systems turn the backlight all the way off at the + * lowest levels. Clamp saved brightness to at least 1 or

[systemd-devel] [PATCHv2 1/2] backlight: Fix copy/paste error printing an unrelated error code

2014-03-11 Thread Josh Triplett
udev_device_get_sysattr_value returns NULL on failure, but doesn't provide an error code; thus, when printing an error from it, don't print an unrelated error code from a previous call. --- v2: Patch 1/2 unchanged from v1. src/backlight/backlight.c | 2 +- 1 file changed, 1 insertion(+), 1

[systemd-devel] [PATCH 2/2] backlight: Avoid restoring brightness to an unreadably dim level

2014-03-11 Thread Josh Triplett
Some systems turn the backlight all the way off at the lowest levels. Clamp saved brightness to at least 1 or 5% of max_brightness. This avoids preserving an unreadably dim screen, which would otherwise force the user to disable state restoration. --- v2: Send the right patch this time. Factor

Re: [systemd-devel] systemd 211 journal getting created with different permissions

2014-03-11 Thread Greg KH
On Tue, Mar 11, 2014 at 08:38:58PM -0700, Greg KH wrote: On Wed, Mar 12, 2014 at 04:21:55AM +0200, Mantas Mikulėnas wrote: On Wed, Mar 12, 2014 at 3:46 AM, Greg KH gre...@linuxfoundation.org wrote: Hi all, With systemd 211, a new journal file is getting created with permissions of

Re: [systemd-devel] systemd 211 journal getting created with different permissions

2014-03-11 Thread Greg KH
On Tue, Mar 11, 2014 at 09:41:50PM -0700, Greg KH wrote: On Tue, Mar 11, 2014 at 08:38:58PM -0700, Greg KH wrote: On Wed, Mar 12, 2014 at 04:21:55AM +0200, Mantas Mikulėnas wrote: On Wed, Mar 12, 2014 at 3:46 AM, Greg KH gre...@linuxfoundation.org wrote: Hi all, With systemd