Re: [systemd-devel] [PATCH] Handle Unix domain socket connections from outside our namespace

2014-04-19 Thread Kay Sievers
On Thu, Apr 17, 2014 at 4:24 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Wed, Apr 16, 2014 at 06:39:07PM +0200, Eelco Dolstra wrote: NixOS uses Unix domain sockets for certain host - container interaction; i.e. the host connects to a socket visible in the container's directory

Re: [systemd-devel] Masking .network files

2014-04-19 Thread Tom Gundersen
On Fri, Apr 11, 2014 at 2:56 AM, Lennart Poettering lenn...@poettering.net wrote: On Sat, 05.04.14 11:26, Tom Gundersen (t...@jklm.no) wrote: On Sat, Apr 5, 2014 at 12:43 AM, Leonid Isaev lis...@umail.iu.edu wrote: I seem to have a strange issue with the way networkd processes its

[systemd-devel] [PATCH 2/2] implement a union to pad out file_handle

2014-04-19 Thread Dave Reisner
Cases where name_to_handle_at is used allocated the full struct to be MAX_HANDLE_SZ, and assigned this size to handle_bytes. This is wrong since handle_bytes should describe the length of the flexible array member and not the whole struct. Define a union type which includes sufficient padding to

Re: [systemd-devel] [PATCH] Handle Unix domain socket connections from outside our namespace

2014-04-19 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 19, 2014 at 01:58:03PM +0200, Kay Sievers wrote: On Thu, Apr 17, 2014 at 4:24 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Wed, Apr 16, 2014 at 06:39:07PM +0200, Eelco Dolstra wrote: NixOS uses Unix domain sockets for certain host - container interaction; i.e.

[systemd-devel] [PATCH] cryptsetup: copy value, not key for (rd.)luks.key

2014-04-19 Thread Matthew Monaco
--- Semi-shameless bump, but new email address would be preferred src/cryptsetup/cryptsetup-generator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cryptsetup/cryptsetup-generator.c b/src/cryptsetup/cryptsetup-generator.c index 75d56dd..f4eeb2a 100644 ---

Re: [systemd-devel] [PATCH] Handle Unix domain socket connections from outside our namespace

2014-04-19 Thread Eelco Dolstra
Hi Zbigniew, On 19/04/14 20:30, Zbigniew Jędrzejewski-Szmek wrote: PID1 crashes with this code, I have reverted the commit for now. Please have a look. systemd[1]: Code should not be reached 'Unhandled socket type.' at src/core/socket.c:684, function

[systemd-devel] Cache passphrase for cryptsetup?

2014-04-19 Thread Nikolaus Rath
Hello, I have several LUKS encrypted volumes that use the same passphrase. Before switching to systemd, I have used the decrypt_keyctl keyscript to cache the passphrase, so that I have to enter it only once. As far as I can tell, the systemd cryptsetup generator is ignoring the keyscript option

Re: [systemd-devel] [PATCH] Handle Unix domain socket connections from outside our namespace

2014-04-19 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 19, 2014 at 10:16:41PM +0200, Eelco Dolstra wrote: Hi Zbigniew, On 19/04/14 20:30, Zbigniew Jędrzejewski-Szmek wrote: PID1 crashes with this code, I have reverted the commit for now. Please have a look. systemd[1]: Code should not be reached 'Unhandled socket type.'

[systemd-devel] [PATCH] libudev: replace name_to_handle_at with normal sscanf

2014-04-19 Thread Zbigniew Jędrzejewski-Szmek
This has the advantage that we use the same sscanf pattern as in other places where /proc/self/mountinfo is parsed, and we avoid bugreports from people who are confused about missing CONFIG_FHANDLE. An alternate solution would be to warn when (at runtime) name_to_handle_at is detected to be

Re: [systemd-devel] [PATCH] cryptsetup: copy value, not key for (rd.)luks.key

2014-04-19 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 19, 2014 at 12:56:45PM -0600, Matthew Monaco wrote: --- Applied, thanks for the reminder. Semi-shameless bump, but new email address would be preferred Really? No one has used this? Either that, or their password starts with luks.key= or rd.luks.key=. Zbyszek

Re: [systemd-devel] [PATCH] Handle Unix domain socket connections from outside our namespace

2014-04-19 Thread Kay Sievers
On Sun, Apr 20, 2014 at 5:30 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: PID1 crashes with this code, I have reverted the commit for now. Please have a look. systemd[1]: Code should not be reached 'Unhandled socket type.' at src/core/socket.c:684, function