[systemd-devel] [PATCH] machine: fix uninitialized variable

2014-07-06 Thread Ronny Chevalier
--- src/machine/machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/machine/machine.c b/src/machine/machine.c index c0fa1b2..7e90d61 100644 --- a/src/machine/machine.c +++ b/src/machine/machine.c @@ -353,7 +353,7 @@ int machine_start(Machine *m, sd_bus_message

[systemd-devel] [PATCH] sysusers: fix uninitialized warning

2014-07-06 Thread Ronny Chevalier
--- src/sysusers/sysusers.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/sysusers/sysusers.c b/src/sysusers/sysusers.c index 1209a5a..c0af693 100644 --- a/src/sysusers/sysusers.c +++ b/src/sysusers/sysusers.c @@ -1312,6 +1312,8 @@ static int parse_line(const char *fname, unsigned

Re: [systemd-devel] [PATCH] sysusers: fix uninitialized warning

2014-07-06 Thread Tom Gundersen
On Sun, Jul 6, 2014 at 1:33 PM, Ronny Chevalier chevalier.ro...@gmail.com wrote: --- src/sysusers/sysusers.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/sysusers/sysusers.c b/src/sysusers/sysusers.c index 1209a5a..c0af693 100644 --- a/src/sysusers/sysusers.c +++

Re: [systemd-devel] [PATCH] machine: fix uninitialized variable

2014-07-06 Thread Tom Gundersen
Thanks for the report. I pushed a slightly different fix. We generally prefer to just return directly the value rather than assigning it to r first (when possible). -t On Sun, Jul 6, 2014 at 1:33 PM, Ronny Chevalier chevalier.ro...@gmail.com wrote: --- src/machine/machine.c | 2 +- 1 file

Re: [systemd-devel] [PATCH] sysusers: fix uninitialized warning

2014-07-06 Thread Ronny Chevalier
2014-07-06 14:06 GMT+02:00 Tom Gundersen t...@jklm.no: On Sun, Jul 6, 2014 at 1:33 PM, Ronny Chevalier chevalier.ro...@gmail.com wrote: --- src/sysusers/sysusers.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/sysusers/sysusers.c b/src/sysusers/sysusers.c index 1209a5a..c0af693

Re: [systemd-devel] [PATCH] sysusers: fix uninitialized warning

2014-07-06 Thread Tom Gundersen
On Sun, Jul 6, 2014 at 2:14 PM, Ronny Chevalier chevalier.ro...@gmail.com wrote: 2014-07-06 14:06 GMT+02:00 Tom Gundersen t...@jklm.no: On Sun, Jul 6, 2014 at 1:33 PM, Ronny Chevalier chevalier.ro...@gmail.com wrote: --- src/sysusers/sysusers.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [systemd-devel] [PATCH 1/2] journal: add LZ4 as optional compressor

2014-07-06 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jul 06, 2014 at 01:05:29PM +0200, Ronny Chevalier wrote: 2014-07-05 20:56 GMT+02:00 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl: +if (src_size 9) +return -ENOSPC; Also, I am not sure that ENOSPC is appropriate here (and everywhere) ? Why not ENOMEM (since

Re: [systemd-devel] [PATCH 1/2] journal: add LZ4 as optional compressor

2014-07-06 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jul 06, 2014 at 02:57:17PM +0200, Zbigniew Jędrzejewski-Szmek wrote: On Sun, Jul 06, 2014 at 01:05:29PM +0200, Ronny Chevalier wrote: 2014-07-05 20:56 GMT+02:00 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl: +if (src_size 9) +return -ENOSPC; Also, I am

[systemd-devel] systemctl escaping of unit names

2014-07-06 Thread Gero Treuner
Hello everybody, I join this mailing list because I want to discuss extending systemctl with a method to escape unit names. Currently systemd and systemctl deal with escaped unit names but there are many potential name sources which doesn't have out-of-the-box escaping methods. The issue is a

Re: [systemd-devel] Misleading udev error messages regarding virtual interfaces

2014-07-06 Thread Leonid Isaev
Hi, Sorry for a delayed reply. On Thu, Jul 03, 2014 at 01:46:53PM +0200, Lennart Poettering wrote: it would be good to know what the precise error output is you get now with this new change... With systemd-215 udevd still complains (and segfaults) about the virtual interface: -- $

[systemd-devel] Is there a reason to forcefully create /etc/mtab?

2014-07-06 Thread Leonid Isaev
Hi, I have a read-only / filesystem and /etc/mtab points to /proc/self/mounts as it should. So, in systemd-215 tmpfile.d fails to create a symbolic link /etc/mtab because /usr/lib/tmpfiles.d/etc.conf contains is a line L+ /etc/mtab - - - - ../proc/self/mounts. Is this

Re: [systemd-devel] Is there a reason to forcefully create /etc/mtab?

2014-07-06 Thread Ivan Shapovalov
On Sunday 06 July 2014 at 13:01:22, Leonid Isaev wrote: Hi, I have a read-only / filesystem and /etc/mtab points to /proc/self/mounts as it should. So, in systemd-215 tmpfile.d fails to create a symbolic link /etc/mtab because /usr/lib/tmpfiles.d/etc.conf contains is a line L+

Re: [systemd-devel] Is there a reason to forcefully create /etc/mtab?

2014-07-06 Thread Mike Gilbert
On Sun, Jul 6, 2014 at 1:08 PM, Ivan Shapovalov intelfx...@gmail.com wrote: On Sunday 06 July 2014 at 13:01:22, Leonid Isaev wrote: Hi, I have a read-only / filesystem and /etc/mtab points to /proc/self/mounts as it should. So, in systemd-215 tmpfile.d fails to create a symbolic

Re: [systemd-devel] Is there a reason to forcefully create /etc/mtab?

2014-07-06 Thread Ivan Shapovalov
On Sunday 06 July 2014 at 13:13:55, Mike Gilbert wrote: On Sun, Jul 6, 2014 at 1:08 PM, Ivan Shapovalov intelfx...@gmail.com wrote: On Sunday 06 July 2014 at 13:01:22, Leonid Isaev wrote: Hi, I have a read-only / filesystem and /etc/mtab points to /proc/self/mounts as it should.

[systemd-devel] systemd-networkd fails to get DHCPv4 lease with disabled IPv6

2014-07-06 Thread Leonid Isaev
Hi, With systemd-215 networkd fails to set up the DHCPv4 on WAN interface: -- $ journalctl -u systemd-networkd.service | grep wlp1s0 Jul 06 12:21:07 hermes systemd-networkd[355]: wlp1s0 : link configured Jul 06 12:21:08 hermes systemd-networkd[355]: wlp1s0 : gained

Re: [systemd-devel] systemctl escaping of unit names

2014-07-06 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jul 06, 2014 at 04:01:52PM +0200, Gero Treuner wrote: Hello everybody, I join this mailing list because I want to discuss extending systemctl with a method to escape unit names. Currently systemd and systemctl deal with escaped unit names but there are many potential name sources

Re: [systemd-devel] Is there a reason to forcefully create /etc/mtab?

2014-07-06 Thread Leonid Isaev
On Sun, Jul 06, 2014 at 09:15:28PM +0400, Ivan Shapovalov wrote: On Sunday 06 July 2014 at 13:13:55, Mike Gilbert wrote: On Sun, Jul 6, 2014 at 1:08 PM, Ivan Shapovalov intelfx...@gmail.com wrote: On Sunday 06 July 2014 at 13:01:22, Leonid Isaev wrote: Hi, I have a

Re: [systemd-devel] Is there a reason to forcefully create /etc/mtab?

2014-07-06 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jul 06, 2014 at 01:44:05PM -0400, Leonid Isaev wrote: On Sun, Jul 06, 2014 at 09:15:28PM +0400, Ivan Shapovalov wrote: On Sunday 06 July 2014 at 13:13:55, Mike Gilbert wrote: On Sun, Jul 6, 2014 at 1:08 PM, Ivan Shapovalov intelfx...@gmail.com wrote: On Sunday 06 July

Re: [systemd-devel] systemd-networkd fails to get DHCPv4 lease with disabled IPv6

2014-07-06 Thread Tom Gundersen
On Sun, Jul 6, 2014 at 7:17 PM, Leonid Isaev lis...@umail.iu.edu wrote: Hi, With systemd-215 networkd fails to set up the DHCPv4 on WAN interface: -- $ journalctl -u systemd-networkd.service | grep wlp1s0 Jul 06 12:21:07 hermes systemd-networkd[355]: wlp1s0 : link

Re: [systemd-devel] Is there a reason to forcefully create /etc/mtab?

2014-07-06 Thread Leonid Isaev
Hi, On Sun, Jul 06, 2014 at 08:13:56PM +0200, Zbigniew Jędrzejewski-Szmek wrote: On Sun, Jul 06, 2014 at 01:44:05PM -0400, Leonid Isaev wrote: So... the solution would be for distro packages to ship mtab as a symlink to ../proc instead of /proc? No, the latter is fine, or even better.

Re: [systemd-devel] Is there a reason to forcefully create /etc/mtab?

2014-07-06 Thread Lennart Poettering
On Sun, 06.07.14 13:01, Leonid Isaev (lis...@umail.iu.edu) wrote: Hi, I have a read-only / filesystem and /etc/mtab points to /proc/self/mounts as it should. So, in systemd-215 tmpfile.d fails to create a symbolic link /etc/mtab because /usr/lib/tmpfiles.d/etc.conf contains is

Re: [systemd-devel] Is there a reason to forcefully create /etc/mtab?

2014-07-06 Thread Lennart Poettering
On Sun, 06.07.14 13:44, Leonid Isaev (lis...@umail.iu.edu) wrote: I think the path matching is a little naive; Using a simple string comparison, /proc/self/mounts != ../proc/self/mounts even though both paths refer to the same object. No, they aren't referring to the same object.

Re: [systemd-devel] Is there a reason to forcefully create /etc/mtab?

2014-07-06 Thread Lennart Poettering
On Sun, 06.07.14 20:13, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: I think the path matching is a little naive; Using a simple string comparison, /proc/self/mounts != ../proc/self/mounts even though both paths refer to the same object. No, they aren't referring to

Re: [systemd-devel] [PATCH] arch: add crisv32

2014-07-06 Thread Lennart Poettering
On Fri, 04.07.14 20:30, Simon McVittie (simon.mcvit...@collabora.co.uk) wrote: On 03/07/14 14:27, Lennart Poettering wrote: BTW, to clarify what this is about I will now rename the tupel macro from ARCH_TUPLE to LIB_ARCH_TUPLE or so, since this is about locations for shared libraries,

Re: [systemd-devel] [PATCH 1/2] journal: add LZ4 as optional compressor

2014-07-06 Thread Lennart Poettering
On Sat, 05.07.14 20:56, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: -bool uncompress_blob(const void *src, uint64_t src_size, - void **dst, uint64_t *dst_alloc_size, uint64_t* dst_size, uint64_t dst_max) { +int compress_blob_lz4(const void *src, uint64_t

Re: [systemd-devel] systemctl escaping of unit names

2014-07-06 Thread Lennart Poettering
On Sun, 06.07.14 16:01, Gero Treuner (gt_18_lists.freedesktop@innocircle.com) wrote: 1. Extend systemctl unit name interpretation with a syntax to escape in controlled manner, preferably capable of escaping only parts of a given name to support compound names with verbatim content

Re: [systemd-devel] systemctl escaping of unit names

2014-07-06 Thread Michael Biebl
2014-07-06 22:12 GMT+02:00 Lennart Poettering lenn...@poettering.net: (And I think I would prefer this as seperate tool from systemctl -- and not just as new verbs), since this appears to not be directly related to what systemctl otherwise does which is control the system...) I ended up with

Re: [systemd-devel] systemctl escaping of unit names

2014-07-06 Thread Michael Biebl
2014-07-06 22:28 GMT+02:00 Michael Biebl mbi...@gmail.com: If there is consensus, I'll just move it from rootlibexec_PROGRAMS to rootbin_PROGRAMS And moving it to $PATH probably means adding a short man page -- Why is it that all of the instruments seeking intelligent life in the universe

Re: [systemd-devel] systemctl escaping of unit names

2014-07-06 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jul 06, 2014 at 10:28:55PM +0200, Michael Biebl wrote: +#include stdio.h +#include stdlib.h + +#include log.h +#include unit-name.h + +int main(int argc, char *argv[]) { +char *escaped_name = NULL; + +if (argc != 2) { +log_error(This program

Re: [systemd-devel] systemctl escaping of unit names

2014-07-06 Thread Michael Biebl
2014-07-06 23:22 GMT+02:00 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl: On Sun, Jul 06, 2014 at 10:28:55PM +0200, Michael Biebl wrote: +#include stdio.h +#include stdlib.h + +#include log.h +#include unit-name.h + +int main(int argc, char *argv[]) { +char *escaped_name = NULL;

Re: [systemd-devel] [PATCH 1/2] journal: add LZ4 as optional compressor

2014-07-06 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jul 06, 2014 at 09:47:02PM +0200, Lennart Poettering wrote: On Sat, 05.07.14 20:56, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: -bool uncompress_blob(const void *src, uint64_t src_size, - void **dst, uint64_t *dst_alloc_size, uint64_t* dst_size,

Re: [systemd-devel] systemd-networkd fails to get DHCPv4 lease with disabled IPv6

2014-07-06 Thread Leonid Isaev
On Sun, Jul 06, 2014 at 08:43:01PM +0200, Tom Gundersen wrote: On Sun, Jul 6, 2014 at 7:17 PM, Leonid Isaev lis...@umail.iu.edu wrote: Hi, With systemd-215 networkd fails to set up the DHCPv4 on WAN interface: -- $ journalctl -u systemd-networkd.service | grep wlp1s0

Re: [systemd-devel] systemd-networkd fails to get DHCPv4 lease with disabled IPv6

2014-07-06 Thread Tom Gundersen
On Sun, Jul 6, 2014 at 11:52 PM, Leonid Isaev lis...@umail.iu.edu wrote: On Sun, Jul 06, 2014 at 08:43:01PM +0200, Tom Gundersen wrote: On Sun, Jul 6, 2014 at 7:17 PM, Leonid Isaev lis...@umail.iu.edu wrote: Hi, With systemd-215 networkd fails to set up the DHCPv4 on WAN

[systemd-devel] systemd-sysusers and gshadow

2014-07-06 Thread Leonid Isaev
Hi, Shouldn't systemd-sysusers update /etc/gshadow when adding 'basic' groups? From sysusers.c I don't see that gshadow (and shadow) is updated, and this seems to cause problems on package updates. Consider the following scenario: 1. A package is updated, so timestamp of /usr gets ahead

Re: [systemd-devel] [PATCH 1/2] journal: add LZ4 as optional compressor

2014-07-06 Thread Zbigniew Jędrzejewski-Szmek
Looks good otheriwse. BTW, have you checked whether reuseing the XZ context might make the XZ more competitive? No, I haven't. But I seriously doubt how it could improve things enough to make a difference ( 2 orders). I generated some coredumps, fixed some messages, and things seem to

Re: [systemd-devel] using /dev/root in fstab

2014-07-06 Thread Mantas Mikulėnas
On Mon, Jul 7, 2014 at 7:29 AM, microcai micro...@fedoraproject.org wrote: a long ago, /dev/root is an symblic to real root device. no matter it is on NFS or HDD, we can use /dev/root / auto defaults 0 0 in fstab to mount / as readwrite. Is it any better than just using 'rw' in the