[systemd-devel] [PATCH] fix uninitialized access to var in error path

--- src/libsystemd/sd-bus/bus-objects.c | 2 +- src/libsystemd/sd-bus/sd-bus.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libsystemd/sd-bus/bus-objects.c b/src/libsystemd/sd-bus/bus-objects.c index 51d4a62..dbb04e5 100644 ---

[systemd-devel] [PATCH] tests: do not use systemctl status --failed

since v212 calling systemctl status without arguments will show a overall system state --- test/TEST-01-BASIC/test.sh | 2 +- test/TEST-02-CRYPTSETUP/test.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/TEST-01-BASIC/test.sh b/test/TEST-01-BASIC/test.sh index

[systemd-devel] [PATCH] log: honour the kernel's quiet cmdline argument

It was forgotten in b1e90ec515408aec2702522f6f68c4920b56375b See https://bugs.freedesktop.org/show_bug.cgi?id=79582 --- src/shared/log.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/shared/log.c b/src/shared/log.c index 9039db3..6f17705 100644 --- a/src/shared/log.c +++

[systemd-devel] [PATCH] tests: add missing XDG_RUNTIME_DIR env variable

Otherwise the test fails because specifier_runtime() returns -ENOTSUP when XDG_RUNTIME_DIR is not set. --- src/test/test-unit-name.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/test-unit-name.c b/src/test/test-unit-name.c index fff3e16..bff4319 100644 ---

[systemd-devel] [PATCH 1/2] tests: add test-socket-util

index 000..716efd8 --- /dev/null +++ b/src/test/test-socket-util.c @@ -0,0 +1,145 @@ +/*** + This file is part of systemd + + Copyright 2014 Ronny Chevalier + + systemd is free software; you can redistribute it and/or modify it + under the terms of the GNU Lesser General Public License

[systemd-devel] [PATCH 2/2] tests: add test-fdset

/test-fdset.c @@ -0,0 +1,114 @@ +/*** + This file is part of systemd + + Copyright 2014 Ronny Chevalier + + systemd is free software; you can redistribute it and/or modify it + under the terms of the GNU Lesser General Public License as published by + the Free Software Foundation; either

[systemd-devel] [PATCH] tests: add tests to test-hashmap

add tests for: - hashmap_remove_and_put - hashmap_first_key - hashmap_last - hashmap_steal_first_key - hashmap_clear_free_free --- src/test/test-hashmap.c | 88 + 1 file changed, 88 insertions(+) diff --git a/src/test/test-hashmap.c

[systemd-devel] [PATCH] tests: unlink temp file used in test

--- src/test/test-util.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/test/test-util.c b/src/test/test-util.c index 2b46699..35dd63f 100644 --- a/src/test/test-util.c +++ b/src/test/test-util.c @@ -654,6 +654,8 @@ static void test_writing_tmpfile(void) { assert(r == 0);

[systemd-devel] [PATCH] build-sys: add missing backslash

--- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 0213c38..e428141 100644 --- a/Makefile.am +++ b/Makefile.am @@ -3537,7 +3537,7 @@ libsystemd_journal_internal_la_SOURCES = \ src/journal/mmap-cache.h # using _CFLAGS = in

[systemd-devel] [PATCH] man: fix typo

--- man/systemd.special.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/systemd.special.xml b/man/systemd.special.xml index f29cc23..2ff64c9 100644 --- a/man/systemd.special.xml +++ b/man/systemd.special.xml @@ -1137,7 +1137,7 @@ varlistentry

[systemd-devel] [PATCH] tests: fix test-icmp6-rs

Don't close the fd given to sd-icmp6-nd, since it will be aynschonously closed by sd_icmp6_nd_unref --- src/libsystemd-network/test-icmp6-rs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libsystemd-network/test-icmp6-rs.c b/src/libsystemd-network/test-icmp6-rs.c index 86e02cc..cd5c476

[systemd-devel] [PATCH] sd-icmp6-nd: fix uninitialized fd

--- src/libsystemd-network/sd-icmp6-nd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libsystemd-network/sd-icmp6-nd.c b/src/libsystemd-network/sd-icmp6-nd.c index f820a9c..10c5e5e 100644 --- a/src/libsystemd-network/sd-icmp6-nd.c +++ b/src/libsystemd-network/sd-icmp6-nd.c @@ -171,6

[systemd-devel] [PATCH] sd-dhcp6-client: fix uninitialized variables

--- src/libsystemd-network/sd-dhcp6-client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libsystemd-network/sd-dhcp6-client.c b/src/libsystemd-network/sd-dhcp6-client.c index ef5fb44..97a2ba7 100644 --- a/src/libsystemd-network/sd-dhcp6-client.c +++

[systemd-devel] [PATCH] tests: add tests for strv_extendf

--- src/test/test-strv.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index c8c5fc9..24ed681 100644 --- a/src/test/test-strv.c +++ b/src/test/test-strv.c @@ -323,6 +323,20 @@ static void test_strv_extend(void) {

[systemd-devel] [PATCH] tests: add tests to test-util

add tests for: - filename_is_safe - ascii_strlower - files_same - is_valid_documentation_url - file_in_same_dir - endswith - close_nointr - unlink_noerrno - readlink_and_make_absolute - read_one_char - ignore_signals - strshorten --- src/test/test-util.c | 202

[systemd-devel] [PATCH] tests: add missing return

--- src/test/test-fdset.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/test/test-fdset.c b/src/test/test-fdset.c index ed83ee1..7f52748 100644 --- a/src/test/test-fdset.c +++ b/src/test/test-fdset.c @@ -111,4 +111,6 @@ int main(int argc, char *argv[]) { test_fdset_put_dup();

[systemd-devel] [PATCH 4/4] tests: add test_fdset_remove

--- src/test/test-fdset.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/test/test-fdset.c b/src/test/test-fdset.c index 7f52748..3b77415 100644 --- a/src/test/test-fdset.c +++ b/src/test/test-fdset.c @@ -106,11 +106,32 @@ static void test_fdset_close_others(void)

[systemd-devel] [PATCH 3/4] tests: add test-async

file mode 100644 index 000..c1c535b --- /dev/null +++ b/src/test/test-async.c @@ -0,0 +1,50 @@ +/*** + This file is part of systemd + + Copyright 2014 Ronny Chevalier + + systemd is free software; you can redistribute it and/or modify it + under the terms of the GNU Lesser General Public

[systemd-devel] [PATCH 1/4] build-sys: add -pthread flag for libsystemd-shared

src/shared/async.c uses pthread so it will fail at link time if we link only to libsystemd-shared and use async --- Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index c7653ea..00db82d 100644 --- a/Makefile.am +++ b/Makefile.am @@

[systemd-devel] [PATCH 2/4] tests: add test-capability

/test/test-capability.c b/src/test/test-capability.c new file mode 100644 index 000..a362fc6 --- /dev/null +++ b/src/test/test-capability.c @@ -0,0 +1,161 @@ +/*** + This file is part of systemd + + Copyright 2014 Ronny Chevalier + + systemd is free software; you can redistribute it and/or modify

[systemd-devel] [PATCH] update .gitignore

--- Hi, Sorry I forgot to update the .gitignore with the last commits. Ronny .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 979ab45..e42fbcb 100644 --- a/.gitignore +++ b/.gitignore @@ -116,6 +116,7 @@ /systemd-vconsole-setup /tags

Re: [systemd-devel] [PATCH] log: honour the kernel's quiet cmdline argument

2014-06-23 16:49 GMT+02:00 Lennart Poettering lenn...@poettering.net: On Tue, 10.06.14 19:17, Kay Sievers (k...@vrfy.org) wrote: On Tue, Jun 3, 2014 at 7:44 PM, Ronny Chevalier chevalier.ro...@gmail.com wrote: It was forgotten in b1e90ec515408aec2702522f6f68c4920b56375b See https

[systemd-devel] [PATCH 2/3] tests: add test-ratelimit

--- /dev/null +++ b/src/test/test-ratelimit.c @@ -0,0 +1,49 @@ +/*** + This file is part of systemd + + Copyright 2014 Ronny Chevalier + + systemd is free software; you can redistribute it and/or modify it + under the terms of the GNU Lesser General Public License as published by + the Free

[systemd-devel] [PATCH 3/3] build-sys: do not run coverage if build failed

--- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 0e4edf7..37a164e 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1635,7 +1635,7 @@ test_conf_files_LDADD = \ .PHONY: coverage lcov-run lcov-report coverage-sync # run lcov from

[systemd-devel] [PATCH 1/3] tests: add tests to test-unit-name

+ Copyright 2014 Ronny Chevalier systemd is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by @@ -193,9 +194,135 @@ static int test_unit_printf(void) { return 0; } +static void test_unit_instance_is_valid(void

Re: [systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-24 18:25 GMT+02:00 Susant Sahani sus...@redhat.com: This patch introduces tuntap support to networkd. Example conf file : tuntap.netdev [NetDev] Name=tuntap-test Kind=tuntap [TUNTAP] Mode=tap OneQueue=true MultiQueue=true PacketInfo=true Added: 1. file networkd-tuntap.c

[systemd-devel] [PATCH] sd-dhcp6-client: use %m instead of strerror(errno)

--- src/libsystemd-network/sd-dhcp6-client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libsystemd-network/sd-dhcp6-client.c b/src/libsystemd-network/sd-dhcp6-client.c index 97a2ba7..ab4d9e8 100644 --- a/src/libsystemd-network/sd-dhcp6-client.c +++

[systemd-devel] [PATCH] use more _cleanup_ macro

--- src/core/automount.c| 3 +-- src/core/execute.c | 20 ++-- src/core/killall.c | 4 +--- src/core/umount.c | 16 src/shared/conf-files.c | 5 + src/shared/fdset.c | 4 +--- src/shared/path-util.c | 4 +--- src/shared/util.c

[systemd-devel] [PATCH] tests: add test-compress

/systemd/sd-messages.h \ diff --git a/src/journal/test-compress.c b/src/journal/test-compress.c new file mode 100644 index 000..15b3f9a --- /dev/null +++ b/src/journal/test-compress.c @@ -0,0 +1,76 @@ +/*** + This file is part of systemd + + Copyright 2014 Ronny Chevalier + + systemd is free

[systemd-devel] [PATCH] machine: fix uninitialized variable

--- src/machine/machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/machine/machine.c b/src/machine/machine.c index c0fa1b2..7e90d61 100644 --- a/src/machine/machine.c +++ b/src/machine/machine.c @@ -353,7 +353,7 @@ int machine_start(Machine *m, sd_bus_message

[systemd-devel] [PATCH] sysusers: fix uninitialized warning

--- src/sysusers/sysusers.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/sysusers/sysusers.c b/src/sysusers/sysusers.c index 1209a5a..c0af693 100644 --- a/src/sysusers/sysusers.c +++ b/src/sysusers/sysusers.c @@ -1312,6 +1312,8 @@ static int parse_line(const char *fname, unsigned

Re: [systemd-devel] [PATCH] sysusers: fix uninitialized warning

2014-07-06 14:06 GMT+02:00 Tom Gundersen t...@jklm.no: On Sun, Jul 6, 2014 at 1:33 PM, Ronny Chevalier chevalier.ro...@gmail.com wrote: --- src/sysusers/sysusers.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/sysusers/sysusers.c b/src/sysusers/sysusers.c index 1209a5a..c0af693

[systemd-devel] [PATCH] update .gitignore

--- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 822f5a6..cafcec0 100644 --- a/.gitignore +++ b/.gitignore @@ -13,6 +13,8 @@ .deps/ .dirstamp .libs/ +/*.gcda +/*.gcno /*.tar.bz2 /*.tar.gz /*.tar.xz -- 2.0.1

[systemd-devel] [PATCH] journal: fix LZ4 and XZ decompression

LZ4 was not always properly supported and a typo would have made the build failed --- src/journal/journal-def.h| 2 +- src/journal/journal-file.c | 2 +- src/journal/journal-verify.c | 6 +++--- src/journal/sd-journal.c | 21 +++-- src/journal/test-compress.c | 2

Re: [systemd-devel] [PATCH 1/2] bootchart: don't parse /proc/uptime, use CLOCK_BOOTTIME

2014-07-31 10:15 GMT+02:00 Karel Zak k...@redhat.com: Hi, * systemd-bootchart always parses /proc/uptime, although the information is unnecessary when --rel specified * use /proc/uptime is overkill, since Linux 2.6.39 we have clock_gettime(CLOCK_BOOTTIME, ...). The backend on kernel side

[systemd-devel] [PATCH 8/8] tests: add missing entry to test-tables

--- src/test/test-tables.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/test-tables.c b/src/test/test-tables.c index cb9185e..88e7d10 100644 --- a/src/test/test-tables.c +++ b/src/test/test-tables.c @@ -86,6 +86,7 @@ int main(int argc, char **argv) {

[systemd-devel] [PATCH 4/8] tests: add test for fdset_iterate

--- src/test/test-fdset.c | 29 + 1 file changed, 29 insertions(+) diff --git a/src/test/test-fdset.c b/src/test/test-fdset.c index 3b77415..91df7eb 100644 --- a/src/test/test-fdset.c +++ b/src/test/test-fdset.c @@ -126,12 +126,41 @@ static void

[systemd-devel] [PATCH 3/8] tests: add tests for fileio.c

add tests for: - write_string_stream - write_string_file - sendfile_full --- src/test/test-fileio.c | 69 ++ 1 file changed, 69 insertions(+) diff --git a/src/test/test-fileio.c b/src/test/test-fileio.c index 1de59fa..e69706c 100644 ---

[systemd-devel] [PATCH 7/8] tests: add tests for time-util.c

add tests for: - timezone_is_valid - get_timezones --- src/test/test-time.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/test/test-time.c b/src/test/test-time.c index 7c29f96..87e7ae7 100644 --- a/src/test/test-time.c +++ b/src/test/test-time.c @@ -20,6 +20,7

[systemd-devel] [PATCH 5/8] tests: add tests for util.c

add tests for: - is_symlink - pid_is_unwaited - pid_is_alive - search_and_fopen - search_and_fopen_nulstr - glob_exists - execute_directory --- src/test/test-util.c | 165 +++ 1 file changed, 165 insertions(+) diff --git a/src/test/test-util.c

[systemd-devel] [PATCH 6/8] tests: add test-condition-util

a/src/test/test-condition-util.c b/src/test/test-condition-util.c new file mode 100644 index 000..4ee5600 --- /dev/null +++ b/src/test/test-condition-util.c @@ -0,0 +1,107 @@ +/*** + This file is part of systemd + + Copyright 2014 Ronny Chevalier + + systemd is free software; you can

[systemd-devel] [PATCH 2/8] tests: add missing unlink

--- src/test/test-async.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/test/test-async.c b/src/test/test-async.c index c1c535b..401e685 100644 --- a/src/test/test-async.c +++ b/src/test/test-async.c @@ -46,5 +46,7 @@ int main(int argc, char *argv[]) { assert_se(fcntl(fd,

[systemd-devel] [PATCH 1/8] tests: add tests for socket-util.c

add tests for: - socket_address_is - socket_address_is_netlink - sockaddr_equal --- src/test/test-socket-util.c | 50 + 1 file changed, 50 insertions(+) diff --git a/src/test/test-socket-util.c b/src/test/test-socket-util.c index 4e90590..17180db

[systemd-devel] [PATCH] bootchart: use NSEC_PER_SEC

--- src/bootchart/store.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/bootchart/store.c b/src/bootchart/store.c index cedcba8..d838a53 100644 --- a/src/bootchart/store.c +++ b/src/bootchart/store.c @@ -34,6 +34,7 @@ #include time.h #include util.h +#include

[systemd-devel] [PATCH] man: fix typo

--- man/systemd-firstboot.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/systemd-firstboot.xml b/man/systemd-firstboot.xml index 42fd753..c3fe0ed 100644 --- a/man/systemd-firstboot.xml +++ b/man/systemd-firstboot.xml @@ -249,7 +249,7 @@

[systemd-devel] [PATCH] condition-util: do not validate condition if paramater is garbage

To follow the same behavior that src/core/condition.c do --- src/shared/condition-util.c| 2 +- src/test/test-condition-util.c | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/shared/condition-util.c b/src/shared/condition-util.c index ff4a8ec..f21786f 100644 ---

[systemd-devel] [PATCH] util: do not execute files without exec permission

--- src/shared/util.c | 4 1 file changed, 4 insertions(+) diff --git a/src/shared/util.c b/src/shared/util.c index 18d40f3..3a03470 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@ -3921,6 +3921,10 @@ void execute_directory(const char *directory, DIR *d, usec_t timeout, char

Re: [systemd-devel] Make journalctl start at the end of the journal by default

2014-08-18 13:46 GMT+02:00 Philippe De Swert philippedesw...@gmail.com: Hi, Hi, Having to often use journalctl it has slowly driven me insane with the default options not matching common use cases. Attached is already a patch to start the journal at the end. Usually people check the logs

Re: [systemd-devel] [PATCH] condition-util: do not validate condition if paramater is garbage

2014-08-18 18:34 GMT+02:00 Lennart Poettering lenn...@poettering.net: On Sat, 16.08.14 14:24, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: To follow the same behavior that src/core/condition.c do --- src/shared/condition-util.c| 2 +- src/test/test-condition-util.c | 4 2

Re: [systemd-devel] [PATCH] util: do not execute files without exec permission

2014-08-18 15:51 GMT+02:00 Lennart Poettering lenn...@poettering.net: On Sat, 16.08.14 14:24, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: What's the rationale here? I think it makes a lot of sense to output an error if people drop non-executable files in such a directory... Yeah

[systemd-devel] [PATCH v2] bootchart: use NSEC_PER_SEC

--- src/bootchart/store.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/bootchart/store.c b/src/bootchart/store.c index cedcba8..2d2ea42 100644 --- a/src/bootchart/store.c +++ b/src/bootchart/store.c @@ -34,6 +34,7 @@ #include time.h #include util.h +#include

[systemd-devel] [PATCH] man: fix typo

--- man/systemd.exec.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/systemd.exec.xml b/man/systemd.exec.xml index cfcf996..af103ff 100644 --- a/man/systemd.exec.xml +++ b/man/systemd.exec.xml @@ -1013,7 +1013,7 @@ made inaccessible and

Re: [systemd-devel] [PATCH] util: do not execute files without exec permission

2014-08-18 21:10 GMT+02:00 Lennart Poettering lenn...@poettering.net: On Mon, 18.08.14 20:47, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: 2014-08-18 15:51 GMT+02:00 Lennart Poettering lenn...@poettering.net: On Sat, 16.08.14 14:24, Ronny Chevalier (chevalier.ro...@gmail.com) wrote

Re: [systemd-devel] [PATCH] journalctl: add -t --identifier=STRING option

2014-08-19 12:12 GMT+02:00 har...@redhat.com: From: Harald Hoyer har...@redhat.com This turns journalctl to the counterpart of systemd-cat. Messages sent with systemd-cat --identifier foo --prioritiy debug can now be shown with journalctl --identifier foo --prioritiy debug

[systemd-devel] [PATCH] man: fix typos

--- man/journalctl.xml| 6 +++--- man/systemctl.xml | 2 +- man/systemd-firstboot.xml | 4 ++-- man/systemd.network.xml | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/man/journalctl.xml b/man/journalctl.xml index bf18756..e10918a 100644 ---

[systemd-devel] [PATCH] dbus: use _cleanup_free_ instead of freeing ourself

--- src/core/dbus-execute.c | 3 +-- src/core/dbus-job.c | 11 ++- src/core/dbus-manager.c | 14 +++--- src/core/unit.c | 48 ++-- 4 files changed, 28 insertions(+), 48 deletions(-) diff --git a/src/core/dbus-execute.c

[systemd-devel] [PATCH] unit: fix unit_stop

If we don't add the unit to the cleanup queue after it has been stopped, no UnitRemoved will be sent. Since this signal is only sent when we free a unit. So we need to add it to the cleanup queue if we manage to stop it. --- src/core/unit.c | 7 ++- 1 file changed, 6 insertions(+), 1

[systemd-devel] [PATCH] zsh-completion: add systemd-run

--- Makefile.am | 1 + TODO | 2 -- shell-completion/zsh/_systemd-run | 31 +++ 3 files changed, 32 insertions(+), 2 deletions(-) create mode 100644 shell-completion/zsh/_systemd-run diff --git a/Makefile.am

[systemd-devel] [PATCH] zsh-completion: add missing options for systemd-run

--- shell-completion/zsh/_systemd-run | 2 ++ 1 file changed, 2 insertions(+) diff --git a/shell-completion/zsh/_systemd-run b/shell-completion/zsh/_systemd-run index 0c81c54..d550f22 100644 --- a/shell-completion/zsh/_systemd-run +++ b/shell-completion/zsh/_systemd-run @@ -22,6 +22,8 @@

[systemd-devel] [PATCH v2] zsh-completion: add missing options for systemd-run

--- shell-completion/zsh/_systemd-run | 17 + 1 file changed, 17 insertions(+) diff --git a/shell-completion/zsh/_systemd-run b/shell-completion/zsh/_systemd-run index 0c81c54..4bfbd19 100644 --- a/shell-completion/zsh/_systemd-run +++ b/shell-completion/zsh/_systemd-run @@

Re: [systemd-devel] [PATCH v2] zsh-completion: add missing options for systemd-run

2013/10/31 William Giokas 1007...@gmail.com: On Thu, Oct 31, 2013 at 08:46:29PM +0100, Ronny Chevalier wrote: --- shell-completion/zsh/_systemd-run | 17 + 1 file changed, 17 insertions(+) diff --git a/shell-completion/zsh/_systemd-run b/shell-completion/zsh/_systemd-run

Re: [systemd-devel] [PATCH] fix compiler warnings

2013/10/31 David Strauss da...@davidstrauss.net: Committed. Did you happen to be on 32-bit? I didn't see any warnings on my own builds (64-bit Fedora 19). Yes, 32 bit Archlinux ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

Re: [systemd-devel] [PATCH] fix compiler warnings

Oh sorry my bad, I missed the fact that some of them were unsigned. And yes it works. 2013/10/31 David Strauss da...@davidstrauss.net: I did a quick follow-up to make some of them %zu where they're actually unsigned. Can you let me know if that still works for you?

Re: [systemd-devel] [PATCH] fix compiler warnings

Yes, already fixed by David 2013/11/1 Markus Mayer lotharl...@gmx.de: On 10/31/2013 07:26 PM, Ronny Chevalier wrote: multiple warnings like src/socket-proxy/socket-proxyd.c: In function ‘transfer_data_cb’: src/socket-proxy/socket-proxyd.c:237:25: warning: format ‘%ld’ expects argument

[systemd-devel] [PATCH] man: fix typo

--- man/systemd-run.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/systemd-run.xml b/man/systemd-run.xml index 0881561..cc8a68a 100644 --- a/man/systemd-run.xml +++ b/man/systemd-run.xml @@ -60,7 +60,7 @@ along with systemd; If not, see http://www.gnu.org/licenses/.

Re: [systemd-devel] [PATCH] zsh-completion: Move machine listing to autoload

a single file to change the way machinectl and systemd-run completion for machines. --- An extension of the previous zsh completion patch from Ronny Chevalier. shell-completion/zsh/_machinectl | 7 +-- shell-completion/zsh/_sd_machines | 13 + shell-completion/zsh/_systemd

Re: [systemd-devel] French translation for systemd

Hi, Instead of : - Il est nécessaire de s'authentifier [...] why not Authentification requise [...] for Authentification required ? - inhiber why not empêcher for inhibit: For example, Permet aux applications d'empêcher l'arrêt du système - bouton d'alimentation, maybe bouton (de mise en

Re: [systemd-devel] French translation for systemd

2013/11/14 Sylvain Plantefeve sylvain.plantef...@gmail.com: Hi, 2013/11/14 Ronny Chevalier chevalier.ro...@gmail.com Hi, Instead of : - Il est nécessaire de s'authentifier [...] why not Authentification requise [...] for Authentification required ? Why not, indeed. - inhiber why

Re: [systemd-devel] French translation for systemd

2013/11/17 Sylvain Plantefeve sylvain.plantef...@gmail.com: Thanks a lot! Sorry for the line-wraps thing, I'm new to contributing patches, and did not expect gmail to do that... You can use git format-patch then git send-mail to send patches, and avoid such issues. If you are also

[systemd-devel] [PATCH] test: add run-qemu script

from Alexander Graf's script: http://www.spinics.net/lists/kvm/msg72389.html --- Hi, It adds a little script which try to find a QEMU binary on the system and enable kvm if it's available. This script is used when running QEMU in the tests. (We can also specify a different kernel and initramfs)

[systemd-devel] [PATCH] test: rework run_qemu

It tries to find a suitable QEMU binary and will use KVM if present. We can now configure QEMU from outside with 4 variables : - $QEMU_BIN : path to QEMU's binary - $KERNEL_APPEND : arguments appended to kernel cmdline - $KERNEL_BIN : path to a kernel Default /boot/vmlinuz-$KERNEL_VER

[systemd-devel] [PATCH] test: fix TEST-02-CRYPTSETUP

missing generate_module_dependencies call which prevents dm_mod and dm_crypt modules to be loaded --- test/TEST-02-CRYPTSETUP/test.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/test/TEST-02-CRYPTSETUP/test.sh b/test/TEST-02-CRYPTSETUP/test.sh index d7e8776..b243254 100755 ---

Re: [systemd-devel] [PATCH] test: rework run_qemu

Do we really want to add a compat for several distributions ? Because why not Archlinux, Ubuntu,... too ? I used Fedora's path by default because it was in the previous script. 2013/12/8 Shawn Landden sh...@churchofgit.com: On Sat, Dec 7, 2013 at 3:01 PM, Ronny Chevalier chevalier.ro

[systemd-devel] [PATCH 2/2] syscallfilter: port to libseccomp

--- Hi, This patch ports the syscall filter to libseccomp. It can be disable with --disable-seccomp and is enabled by default if libseccomp is present. Maybe I should add a warning when parsing SyscallFilter in a .service if seccomp has been disabled ? Now the SyscallFilter property is a

[systemd-devel] [PATCH 1/2] test: add basic seccomp tests

--- test/TEST-04-SECCOMP/Makefile | 1 + test/TEST-04-SECCOMP/test-seccomp.sh| 11 test/TEST-04-SECCOMP/test.sh| 79 + test/TEST-04-SECCOMP/will-fail.service | 6 +++ test/TEST-04-SECCOMP/will-not-fail.service | 6 +++

Re: [systemd-devel] [PATCH 2/2] syscallfilter: port to libseccomp

2014/1/24 Lennart Poettering lenn...@poettering.net: On Thu, 23.01.14 01:34, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: --- Hi, This patch ports the syscall filter to libseccomp. It can be disable with --disable-seccomp and is enabled by default if libseccomp is present. Maybe I

Re: [systemd-devel] [PATCH 2/2] syscallfilter: port to libseccomp

2014-01-27 Lennart Poettering lenn...@poettering.net: On Sat, 25.01.14 18:06, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: Doesn't libseccomp provide a way to enumerate the contents of the defined filter again? I'd really prefer if we could find a way that specifiying a filter

[systemd-devel] [PATCH v2 2/2] syscallfilter: port to libseccomp

--- Makefile.am| 30 ++--- README | 1 + TODO | 1 - configure.ac | 14 ++ man/systemd.exec.xml | 18 +++- src/core/build.h | 8 +++- src/core/dbus-execute.c|

Re: [systemd-devel] [PATCH 2/2] syscallfilter: port to libseccomp

2014-02-04 Lennart Poettering lenn...@poettering.net: So yeah, I figure we should continue with this logic, and of course probably document it... So I sent the new patch, it works the same way. But I did not use an integer array like you said. I used a set to store the syscalls number and a

Re: [systemd-devel] [PATCH 2/2] syscallfilter: port to libseccomp

2014-02-11 23:14 GMT+01:00 Ronny Chevalier chevalier.ro...@gmail.com: 2014-02-04 Lennart Poettering lenn...@poettering.net: So yeah, I figure we should continue with this logic, and of course probably document it... So I sent the new patch, it works the same way. But I did not use an integer

[systemd-devel] [PATCH v3 2/2] syscallfilter: port to libseccomp

--- Ok so I found the problem. I forgot a condition in SET_FOREACH that if e is 0, it will stop the foreach (and read have the id 0) Here is the new patch fixing this. Sorry again Makefile.am| 30 ++--- README | 1 + TODO

[systemd-devel] [PATCH v2 1/2] test: add basic seccomp tests

--- test/TEST-04-SECCOMP/Makefile | 1 + test/TEST-04-SECCOMP/test-seccomp.sh| 13 + test/TEST-04-SECCOMP/test.sh| 79 + test/TEST-04-SECCOMP/will-fail.service | 8 +++ test/TEST-04-SECCOMP/will-fail2.service | 6

Re: [systemd-devel] [PATCH 1/2] test: add basic seccomp tests

2014-02-13 3:34 GMT+01:00 Dave Reisner d...@falconindy.com: On Thu, Jan 23, 2014 at 01:34:57AM +0100, Ronny Chevalier wrote: --- test/TEST-04-SECCOMP/Makefile | 1 + test/TEST-04-SECCOMP/test-seccomp.sh| 11 test/TEST-04-SECCOMP/test.sh| 79

Re: [systemd-devel] [PATCH 1/2] test: add basic seccomp tests

2014-02-13 16:25 GMT+01:00 Dave Reisner d...@falconindy.com: On Thu, Feb 13, 2014 at 09:58:53AM +0100, Ronny Chevalier wrote: 2014-02-13 3:34 GMT+01:00 Dave Reisner d...@falconindy.com: On Thu, Jan 23, 2014 at 01:34:57AM +0100, Ronny Chevalier wrote: --- test/TEST-04-SECCOMP/Makefile

[systemd-devel] [PATCH v3 1/2] test: add basic seccomp tests

--- test/TEST-04-SECCOMP/Makefile | 1 + test/TEST-04-SECCOMP/test-seccomp.sh| 13 + test/TEST-04-SECCOMP/test.sh| 79 + test/TEST-04-SECCOMP/will-fail.service | 8 +++ test/TEST-04-SECCOMP/will-fail2.service | 6

[systemd-devel] [PATCH] dbus-manager: fix variable type introspection

--- Hi, When I used instrospection with systemd --user, there was a warning from DBus, the signature was s but in reality it was t. Regards, Ronny --- src/core/dbus-manager.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/dbus-manager.c

[systemd-devel] [PATCH] dbus-execute: fix introspection

Hi, Add missing property and remove duplicate properties already in src/core/dbus-kill.h Best regards, Ronny. --- src/core/dbus-execute.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/core/dbus-execute.h b/src/core/dbus-execute.h index eaa1b73..b9cc13c 100644 ---

[systemd-devel] [PATCH] logind: fix typo

--- src/login/logind-session-dbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/login/logind-session-dbus.c b/src/login/logind-session-dbus.c index 7d81500..58836fc 100644 --- a/src/login/logind-session-dbus.c +++ b/src/login/logind-session-dbus.c @@ -249,7 +249,7 @@

[systemd-devel] [PATCH] tests: fix resource mem leaks

--- src/test/test-condition-util.c | 2 +- src/test/test-fileio.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/test/test-condition-util.c b/src/test/test-condition-util.c index 4ee5600..35ee916 100644 --- a/src/test/test-condition-util.c +++

Re: [systemd-devel] [PATCH] fstab-generator: Honor usr=, usrfstype= and usrflags=

Hi, 2014-09-30 21:18 GMT+02:00 Tobias Hunger tobias.hun...@gmail.com: Any feedback at all? Please? Am I doing something wrong in posting my patch here? No you just need to wait that someone review your patch. It rarely takes more than 2 weeks. Best Regards, Tobias On Sat, Sep 27, 2014 at

[systemd-devel] [PATCH] systemctl: add edit verb

It helps editing units by either creating a drop-in file, like /etc/systemd/system/my.service.d/amendments.conf, or by copying the original unit from /usr/lib/systemd/ to /etc/systemd/ if the --full option is specified. Then it invokes the $SYSTEMD_EDITOR or $EDITOR or vim to the related files and

[systemd-devel] [PATCH] shared: remove unused functions

- mkdir_p_prefix: It has never been used - mkdir_parents_prefix_label: Unused since 1434ae6fd49f8377b0ddbd4c675736e0d3226ea6 --- src/shared/mkdir-label.c | 4 src/shared/mkdir.c | 4 src/shared/mkdir.h | 2 -- 3 files changed, 10 deletions(-) diff --git

[systemd-devel] [PATCH] avoid duplication of TIME_T_MAX

--- src/core/manager.c | 3 +-- src/shared/time-util.h | 2 ++ src/timesync/timesyncd-manager.c | 3 +-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/core/manager.c b/src/core/manager.c index e0c1cd1..dfd8cda 100644 --- a/src/core/manager.c +++

[systemd-devel] [PATCH 3/4] man: use example instead of multiple refsect1 for examples

--- man/systemd-activate.xml | 19 ++-- man/systemd-nspawn.xml | 75 2 files changed, 47 insertions(+), 47 deletions(-) diff --git a/man/systemd-activate.xml b/man/systemd-activate.xml index 717f5c0..cde4263 100644 ---

[systemd-devel] [PATCH 2/4] man: add missing commas

--- man/sd_journal_get_catalog.xml | 2 +- man/sysctl.d.xml| 2 +- man/systemd-bus-pro...@.service.xml | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/man/sd_journal_get_catalog.xml b/man/sd_journal_get_catalog.xml index 485bbba..c38a645 100644

[systemd-devel] [PATCH 1/4] man: add examples for coredumpctl

Add examples to clarify how to use coredumpctl See https://bugs.freedesktop.org/show_bug.cgi?id=83437 --- man/coredumpctl.xml | 28 1 file changed, 28 insertions(+) diff --git a/man/coredumpctl.xml b/man/coredumpctl.xml index a7b8793..03552b7 100644 ---

[systemd-devel] [PATCH 4/4] man: fix project reference for archlinux

--- man/systemd-nspawn.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/man/systemd-nspawn.xml b/man/systemd-nspawn.xml index 22f2df4..c02aa88 100644 --- a/man/systemd-nspawn.xml +++ b/man/systemd-nspawn.xml @@ -106,7 +106,7 @@ citerefentry

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-13 16:13 GMT+02:00 Simon McVittie simon.mcvit...@collabora.co.uk: On 13/10/14 14:38, Dale R. Worley wrote: My general understanding is that the traditional behavior when you need an editor but the user hasn't specified one is to use vi, and so people who don't want vi *always* set

Re: [systemd-devel] [PATCH, REVIEW, v2] find_symlinks: adds a cache of enabled unit symbolic link state

Hi, 2014-10-18 1:34 GMT+02:00 Ken Sedgwick ksedg...@bonsai.com: The current find_symlinks_fd code traverses the config directories duplicatively. This is a performance problem if 1000s of units are being controlled. This patch adds a hashmap cache of symbolic link state which is filled in one

[systemd-devel] [PATCH v2] systemctl: add edit verb

It helps editing units by either creating a drop-in file, like /etc/systemd/system/my.service.d/amendments.conf, or by copying the original unit from /usr/lib/systemd/ to /etc/systemd/ if the --full option is specified. Then it invokes an editor to the related files and daemon-reload is invoked

  1   2   >