Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-16 Thread Michal Sekletár
On Sat, Mar 16, 2013 at 4:11 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Thu, Mar 14, 2013 at 06:12:27PM +0100, Michal Sekletar wrote: All Execs within the service, will get mounted the same /tmp and /var/tmp directories, if service is configured with PrivateTmp=yes. Temporary

Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Mar 14, 2013 at 06:12:27PM +0100, Michal Sekletar wrote: All Execs within the service, will get mounted the same /tmp and /var/tmp directories, if service is configured with PrivateTmp=yes. Temporary directories are cleaned up by service itself in addition to systemd-tmpfiles.

Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-14 Thread Michal Sekletár
On Thu, Mar 14, 2013 at 3:33 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: Hi, Colin Walters wrote install-directories-hook: $(MKDIR_P) $(addprefix $(DESTDIR),$(INSTALL_DIRS)) + $(MKDIR_P) -m 000 $(addprefix $(DESTDIR),$(INACCESSIBLE_DIR)) Ugh. Can you make this

Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-14 Thread Kay Sievers
On Thu, Mar 14, 2013 at 2:07 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Thu, Mar 14, 2013 at 11:43:32AM +0100, Michal Sekletár wrote: Do you prefer to have it /run or in /tmp? It seems to be without much difference, but I'd go for /run, since this way there'll be less chance

[systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-14 Thread Michal Sekletar
All Execs within the service, will get mounted the same /tmp and /var/tmp directories, if service is configured with PrivateTmp=yes. Temporary directories are cleaned up by service itself in addition to systemd-tmpfiles. Directory which is mounted as inaccessible is created at runtime in

Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-14 Thread Michal Sekletar
Hi Zbyszek, - Original Message - Maybe just stick it in mount_setup()? Thank you for this suggestion! It seems to be without much difference, but I'd go for /run, since this way there'll be less chance that somebody deletes it by mistake. I first tried /tmp and I had issue that

Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-13 Thread Zbigniew Jędrzejewski-Szmek
Hi, Colin Walters wrote install-directories-hook: $(MKDIR_P) $(addprefix $(DESTDIR),$(INSTALL_DIRS)) + $(MKDIR_P) -m 000 $(addprefix $(DESTDIR),$(INACCESSIBLE_DIR)) Ugh. Can you make this /run/systemd/inaccessible or something, and have systemd do this at runtime? Having

[systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-12 Thread Michal Sekletar
All Execs within the service, will get mounted the same /tmp and /var/tmp directories, if service is configured with PrivateTmp=yes. Temporary directories are cleaned up by service itself, rather than relying on systemd-tmpfiles. Directory which is mounted as inaccessible is shared, created at

Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-12 Thread Michal Sekletar
Thank you for the review! It is very appreciated. Michal ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-12 Thread Colin Walters
On Tue, 2013-03-12 at 15:14 +0100, Michal Sekletar wrote: install-directories-hook: $(MKDIR_P) $(addprefix $(DESTDIR),$(INSTALL_DIRS)) + $(MKDIR_P) -m 000 $(addprefix $(DESTDIR),$(INACCESSIBLE_DIR)) Ugh. Can you make this /run/systemd/inaccessible or something, and have systemd do

Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-04 Thread Lennart Poettering
On Sat, 02.03.13 15:00, Michal Sekletar (sekleta...@gmail.com) wrote: On Mar 1, 2013, at 3:16 PM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 20.02.13 14:50, Michal Sekletar (msekl...@redhat.com) wrote: All Execs within the service, will get mounted the same /tmp and

Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-02 Thread Michal Sekletar
On Mar 1, 2013, at 3:16 PM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 20.02.13 14:50, Michal Sekletar (msekl...@redhat.com) wrote: All Execs within the service, will get mounted the same /tmp and /var/tmp directories, if service is configured with PrivateTmp=yes. Temporary

Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-01 Thread Lennart Poettering
On Wed, 20.02.13 14:50, Michal Sekletar (msekl...@redhat.com) wrote: All Execs within the service, will get mounted the same /tmp and /var/tmp directories, if service is configured with PrivateTmp=yes. Temporary directories are cleaned up by service itself, rather than relying on

[systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-02-20 Thread Michal Sekletar
All Execs within the service, will get mounted the same /tmp and /var/tmp directories, if service is configured with PrivateTmp=yes. Temporary directories are cleaned up by service itself, rather than relying on systemd-tmpfiles. Same logic applies also to inaccessible directories. ---

[systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-02-13 Thread Michal Sekletar
All Execs within the service, will get mounted the same /tmp and /var/tmp directories, if service is configured with PrivateTmp=yes. Temporary directories are cleaned up by service itself, rather than relying on systemd-tmpfiles. Same logic applies also to inaccessible directories. ---

Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-02-13 Thread Tom Gundersen
On Wed, Feb 13, 2013 at 2:45 PM, Michal Sekletar msekl...@redhat.com wrote: All Execs within the service, will get mounted the same /tmp and /var/tmp directories, if service is configured with PrivateTmp=yes. Temporary directories are cleaned up by service itself, rather than relying on

Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-02-13 Thread Lennart Poettering
On Wed, 13.02.13 14:45, Michal Sekletar (msekl...@redhat.com) wrote: Heya! Looks good in principle. +if (context-private_tmp) { +if (!context-tmp_dir) { +d = mktemp(tmp_dir); mktemp() is never OK. Also see BUGS section in the man page about