[systemd-devel] [PATCH] systemctl: fix variable initialization

2013-03-12 Thread Michal Sekletar
--- src/systemctl/systemctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 4a55c56..db12255 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -1454,7 +1454,7 @@ static int start_unit_one(

Re: [systemd-devel] [PATCH] systemctl: fix variable initialization

2013-03-12 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Mar 12, 2013 at 03:34:26PM +0100, Michal Sekletar wrote: --- src/systemctl/systemctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 4a55c56..db12255 100644 --- a/src/systemctl/systemctl.c +++

Re: [systemd-devel] [PATCH] systemctl: fix variable initialization

2013-03-12 Thread Michal Sekletar
Hi Zbyszek, Hi, that's not necessary, it's initialized right below the assert statements. I know it is initialized right after asserts, however we tend to initialize vars witch are marked for auto-cleanup with NULL. So I thought it would be good to do it here too, since it doesn't hurt