Re: [systemd-devel] [PATCH] util: don't consider trailing whitespaces as an empty string in split_quoted

2013-11-28 Thread Tom Gundersen
On Wed, Nov 27, 2013 at 7:12 PM, Dave Reisner d...@falconindy.com wrote: On Wed, Nov 27, 2013 at 06:45:06PM +0100, Tom Gundersen wrote: On Wed, Nov 27, 2013 at 6:00 PM, Lukas Nykryn lnyk...@redhat.com wrote: --- src/shared/util.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[systemd-devel] [PATCH] util: don't consider trailing whitespaces as an empty string in split_quoted

2013-11-27 Thread Lukas Nykryn
--- src/shared/util.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/shared/util.c b/src/shared/util.c index 3a4d196..c68ab09 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@ -383,7 +383,9 @@ char *split_quoted(const char *c, size_t *l, char **state) {

Re: [systemd-devel] [PATCH] util: don't consider trailing whitespaces as an empty string in split_quoted

2013-11-27 Thread Tom Gundersen
On Wed, Nov 27, 2013 at 6:00 PM, Lukas Nykryn lnyk...@redhat.com wrote: --- src/shared/util.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/shared/util.c b/src/shared/util.c index 3a4d196..c68ab09 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@

Re: [systemd-devel] [PATCH] util: don't consider trailing whitespaces as an empty string in split_quoted

2013-11-27 Thread Dave Reisner
On Wed, Nov 27, 2013 at 06:45:06PM +0100, Tom Gundersen wrote: On Wed, Nov 27, 2013 at 6:00 PM, Lukas Nykryn lnyk...@redhat.com wrote: --- src/shared/util.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/shared/util.c b/src/shared/util.c index

Re: [systemd-devel] [PATCH] util: don't consider trailing whitespaces as an empty string in split_quoted

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 18:00, Lukas Nykryn (lnyk...@redhat.com) wrote: I merged a different patch that simply moves the earlier NUL byte check after the jumping over whitespace, so that we don't need two checks. I also added a test case for this, so that this doesn't break again. (That sad, the whole