[systemd-devel] [PATCH 1/5] backlight: don't hardcode path in binary

2014-02-24 Thread Michal Sekletar
Not that we are going to move things around but it is nicer to have paths configurable rather than hardcoded in the source. --- Makefile.am | 2 ++ src/backlight/backlight.c | 6 +++--- units/systemd-backli...@.service.in | 2 +- 3 files changed, 6 insertions(+),

[systemd-devel] [PATCH 2/5] hostnamed: watch for transient hostname changes

2014-02-24 Thread Michal Sekletar
hostnamed parses its state information at the startup time and doesn't update it. This might lead to the situation when we are presenting administrator with inaccurate information. We should watch for changes in the system and update our state information accordingly. --- src/hostname/hostnamed.c

[systemd-devel] [PATCH 5/5] hostnamed: don't check against our cached data when setting new static hostname

2014-02-24 Thread Michal Sekletar
We don't change static hostname in case it is the same as the one we currently know about. This is not ideal, because it might have been changed in the meantime and we just don't know about the change. So allow user the set whatever he desires and don't check, before doing so, against our cached

[systemd-devel] [PATCH 3/5] hostnamed: correct error message

2014-02-24 Thread Michal Sekletar
We are not parsing timezone data. --- src/hostname/hostnamed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hostname/hostnamed.c b/src/hostname/hostnamed.c index 045f24d..064d9d2 100644 --- a/src/hostname/hostnamed.c +++ b/src/hostname/hostnamed.c @@ -719,7 +719,7 @@

Re: [systemd-devel] [PATCH 4/5] everywhere: stop using strerror()

2014-02-24 Thread Michal Sekletar
On Mon, Feb 24, 2014 at 04:05:36PM +0100, Lennart Poettering wrote: On Mon, 24.02.14 15:59, Michal Sekletar (msekl...@redhat.com) wrote: --- src/hostname/hostnamed.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/hostname

[systemd-devel] [PATCH] backlight: don't hardcode path in binary

2014-02-24 Thread Michal Sekletar
Not that we are going to move things around but it is nicer to have paths configurable rather than hardcoded in the source. --- Added trailing slash. Thanks! Makefile.am | 2 ++ src/backlight/backlight.c | 6 +++--- units/systemd-backli...@.service.in | 2 +- 3

Re: [systemd-devel] [PATCH 2/5] hostnamed: watch for transient hostname changes

2014-02-24 Thread Michal Sekletar
On Mon, Feb 24, 2014 at 04:32:46PM +0100, Lennart Poettering wrote: On Mon, 24.02.14 15:59, Michal Sekletar (msekl...@redhat.com) wrote: hostnamed parses its state information at the startup time and doesn't update it. This might lead to the situation when we are presenting administrator

Re: [systemd-devel] [PATCH] job: always add waiting jobs to run queue during coldplug.

2014-05-07 Thread Michal Sekletar
On Tue, May 06, 2014 at 12:36:44PM -0700, Michael Marineau wrote: commit 20a83d7bf was not equivalent to the original bug fix proposed by Michal Sekletar msekl...@redhat.com. The committed version only added the job to the run queue if the job had a timeout, which most jobs do not have. Just

Re: [systemd-devel] [PATCH] job: always add waiting jobs to run queue during coldplug.

2014-05-12 Thread Michal Sekletar
On Tue, May 06, 2014 at 12:36:44PM -0700, Michael Marineau wrote: commit 20a83d7bf was not equivalent to the original bug fix proposed by Michal Sekletar msekl...@redhat.com. The committed version only added the job to the run queue if the job had a timeout, which most jobs do not have. Just

Re: [systemd-devel] Failed to mark scope session-20.scope as abandoned

2014-05-12 Thread Michal Sekletar
On Sat, May 10, 2014 at 05:12:21PM -0400, Garry T. Williams wrote: This recently stated showing up in the journal on Fedora F20 here: May 10 17:01:01 vfr systemd[1]: Starting Session 20 of user root. May 10 17:01:01 vfr systemd[1]: Started Session 20 of user root. May 10 17:01:01

Re: [systemd-devel] Failed to mark scope session-20.scope as abandoned

2014-05-13 Thread Michal Sekletar
On Tue, May 13, 2014 at 11:54:49PM -0400, Garry T. Williams wrote: On 5-12-14 15:11:46 Michal Sekletar wrote: On Sat, May 10, 2014 at 05:12:21PM -0400, Garry T. Williams wrote: This recently stated showing up in the journal on Fedora F20 here: May 10 17:01:01 vfr systemd[1

Re: [systemd-devel] [RFC][PATCH] core: sysvcompat - $network should be equivalent to network-online, rather than network target

2014-05-14 Thread Michal Sekletar
. This means {systemd-networkd,NetworkManager}-wait-online.service, can be enabled by default as part of network-online.target, and only delay boot when some service actively pulls it in. See: https://bugzilla.gnome.org/show_bug.cgi?id=728965 Cc: Pavel Šimerda psime...@redhat.com Cc: Michal

Re: [systemd-devel] Failed to mark scope session-20.scope as abandoned

2014-05-14 Thread Michal Sekletar
On Wed, May 14, 2014 at 07:51:01AM +0200, Michal Sekletar wrote: On Tue, May 13, 2014 at 11:54:49PM -0400, Garry T. Williams wrote: On 5-12-14 15:11:46 Michal Sekletar wrote: On Sat, May 10, 2014 at 05:12:21PM -0400, Garry T. Williams wrote: This recently stated showing up in the journal

Re: [systemd-devel] [PATCH 1/2] man: Document server sockets in use by journald

2014-05-30 Thread Michal Sekletar
On Wed, May 28, 2014 at 10:30:56PM +0200, Lubomir Rintel wrote: --- man/systemd-journald.service.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/man/systemd-journald.service.xml b/man/systemd-journald.service.xml index f0ce7aa..715 100644 ---

Re: [systemd-devel] [PATCH] journald: collect process data from socket data

2014-05-30 Thread Michal Sekletar
On Fri, May 30, 2014 at 12:45:21PM +0200, Piotr Wilczek wrote: This patch adds posibility for journal to get process data from socket data (if available) instead of from procfs. Additionally a new procinfo structure is added to store all process data in single place. This data include

[systemd-devel] [PATCH] localed: consider an unset model as a wildcard

2014-05-30 Thread Michal Sekletar
--- src/locale/localed.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/locale/localed.c b/src/locale/localed.c index e3061c8..358f6c2 100644 --- a/src/locale/localed.c +++ b/src/locale/localed.c @@ -712,15 +712,16 @@ static int find_legacy_keymap(Context

[systemd-devel] [PATCH] localed: search locale settings on kernel cmdline first

2014-06-02 Thread Michal Sekletar
systemd spawns services with locale settings taken from kernel cmdline. If it doesn't find anything there, then it proceeds with parsing settings from /etc/locale.conf. localed should do the same and look at kernel cmdline first. --- src/locale/localed.c | 80

[systemd-devel] [PATCH] fileio: make parse_env_file() return number of parsed items

2014-06-02 Thread Michal Sekletar
This should make logic in locale_setup() work as intended, hence don't parse /etc/locale.conf if admin passed to us explicit locale settings on kernel cmdline. --- src/shared/fileio.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git

[systemd-devel] [RFC] Split keymap conversion functions to separate library

2014-06-03 Thread Michal Sekletar
Hello, Currently systemd-localed does conversions from X11 keymap to VConsole keymap and vice-versa. There was a request coming from Anaconda installer team at Red Hat which was about splitting this functionality to separate library. I am curious if other people would be interested in such

Re: [systemd-devel] [RFC] Split keymap conversion functions to separate library

2014-06-03 Thread Michal Sekletar
On Tue, Jun 03, 2014 at 11:05:53AM +0200, Kay Sievers wrote: On Tue, Jun 3, 2014 at 10:58 AM, Michal Sekletar msekl...@redhat.com wrote: Currently systemd-localed does conversions from X11 keymap to VConsole keymap and vice-versa. There was a request coming from Anaconda installer team

Re: [systemd-devel] [PATCH] localed: consider an unset model as a wildcard

2014-06-19 Thread Michal Sekletar
On Fri, May 30, 2014 at 06:20:16PM +0200, Michal Sekletar wrote: ping? --- src/locale/localed.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/locale/localed.c b/src/locale/localed.c index e3061c8..358f6c2 100644 --- a/src/locale/localed.c +++ b

Re: [systemd-devel] [PATCH] fileio: make parse_env_file() return number of parsed items

2014-06-19 Thread Michal Sekletar
On Mon, Jun 02, 2014 at 06:03:27PM +0200, Michal Sekletar wrote: This should make logic in locale_setup() work as intended, hence don't parse /etc/locale.conf if admin passed to us explicit locale settings on kernel cmdline. --- src/shared/fileio.c | 28 ++-- 1 file

[systemd-devel] [PATCH 1/2] dhcp-network: add check for DHCP.chaddr

2014-06-19 Thread Michal Sekletar
Check that received DHCP packets actually include our MAC address in chaddr field. BPF interpreter has 32 bit wide registers but MAC address is 48 bits long so we have to do check in two steps. --- src/libsystemd-network/dhcp-internal.h| 3 ++- src/libsystemd-network/dhcp-network.c | 15

[systemd-devel] [PATCH 2/2] dhcp-network: don't bother with IP fragments

2014-06-19 Thread Michal Sekletar
--- src/libsystemd-network/dhcp-network.c | 4 1 file changed, 4 insertions(+) diff --git a/src/libsystemd-network/dhcp-network.c b/src/libsystemd-network/dhcp-network.c index e5fd6a8..f500bff 100644 --- a/src/libsystemd-network/dhcp-network.c +++ b/src/libsystemd-network/dhcp-network.c @@

Re: [systemd-devel] [PATCH 1/2] dhcp-network: add check for DHCP.chaddr

2014-06-19 Thread Michal Sekletar
On Thu, Jun 19, 2014 at 12:02:39PM -0500, Dan Williams wrote: On Thu, 2014-06-19 at 18:59 +0200, Michal Sekletar wrote: Check that received DHCP packets actually include our MAC address in chaddr field. BPF interpreter has 32 bit wide registers but MAC address is 48 bits long so we have

Re: [systemd-devel] systemd-networkd: no network connectivity with 214/master due to 63a070415db09f5b5bcc5c

2014-06-20 Thread Michal Sekletar
On Wed, Jun 18, 2014 at 09:51:02PM +0200, Friedrich Kröner wrote: Hello, when trying systemd-networkd with =214 and the following config: [Match] Name=eth* [Network] DHCP=yes Address=2001:db8::1234:5678/64 DNS=8.8.8.8 DNS=2001:db8:1::ab9:C0A8:102 I get lots of DHCP DISCOVER

[systemd-devel] [PATCH] systemctl: don't return success if we refused to execute user's request

2014-06-23 Thread Michal Sekletar
--- src/systemctl/systemctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 727be58..2dac67c 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -6644,7 +6644,7 @@ found: } else {

Re: [systemd-devel] [PATCH] systemctl: don't return success if we refused to execute user's request

2014-06-23 Thread Michal Sekletar
On Mon, Jun 23, 2014 at 02:46:42PM +0200, Lennart Poettering wrote: On Mon, 23.06.14 13:34, Michal Sekletar (msekl...@redhat.com) wrote: What's the rationale? This came up while discussing the issue when some script saved list of actions it took and same script could be called to undo those

Re: [systemd-devel] [PATCH 1/2] dhcp-network: add check for DHCP.chaddr

2014-06-24 Thread Michal Sekletar
On Thu, Jun 19, 2014 at 12:02:39PM -0500, Dan Williams wrote: On Thu, 2014-06-19 at 18:59 +0200, Michal Sekletar wrote: Check that received DHCP packets actually include our MAC address in chaddr field. BPF interpreter has 32 bit wide registers but MAC address is 48 bits long so we have

Re: [systemd-devel] [PATCH] localed: search locale settings on kernel cmdline first

2014-07-02 Thread Michal Sekletar
On Wed, Jul 02, 2014 at 03:05:36AM +0200, Zbigniew Jędrzejewski-Szmek wrote: On Tue, Jul 01, 2014 at 04:36:47PM +0200, Lennart Poettering wrote: On Tue, 01.07.14 16:47, microcai (micro...@fedoraproject.org) wrote: Maybe another option is to improve localectl on the client side to

Re: [systemd-devel] [PATCH 1/2] dhcp-network: add check for DHCP.chaddr

2014-07-07 Thread Michal Sekletar
On Tue, Jun 24, 2014 at 03:54:54PM +0200, Tom Gundersen wrote: On Tue, Jun 24, 2014 at 12:58 PM, Michal Sekletar msekl...@redhat.com wrote: On Thu, Jun 19, 2014 at 12:02:39PM -0500, Dan Williams wrote: On Thu, 2014-06-19 at 18:59 +0200, Michal Sekletar wrote: Check that received DHCP

[systemd-devel] [PATCH] dhcp-network: ignore IP packets with More Fragments (MF) flag set

2014-07-07 Thread Michal Sekletar
We already ignore IP fragments, because we expect that Fragment offset (FO) field is not set. However first fragment in a fragmented IP flow will have all zeroes in FO field. We should ignore such packet as well, thus we need to look at MF flag in the IP header. Checking MF flag will filter out

[systemd-devel] [PATCH] units: make ExecStopPost action part of ExecStart

2014-07-08 Thread Michal Sekletar
Currently after exiting rescue shell we isolate default target. User might want to isolate to some other target than default one. However issuing systemctl isolate command to desired target would bring system to default target as a consequence of running ExecStopPost action. Having common

Re: [systemd-devel] [PATCH] units: make ExecStopPost action part of ExecStart

2014-07-09 Thread Michal Sekletar
If there are no further objections I will push the patch as is. Michal ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH] journald: fix syslog facility for messages coming from kmsg

2014-07-25 Thread Michal Sekletar
--- src/journal/journald-kmsg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/journal/journald-kmsg.c b/src/journal/journald-kmsg.c index 12992e7..8d24344 100644 --- a/src/journal/journald-kmsg.c +++ b/src/journal/journald-kmsg.c @@ -274,6 +274,9 @@ static void

Re: [systemd-devel] [PATCH] journald: fix syslog facility for messages coming from kmsg

2014-07-27 Thread Michal Sekletar
SYSLOG_FACILITY field confuses some tools, most notably rsyslog, thus rsyslog filters like kern.* /var/log/kernel.log doesn't work and rsyslog don't output kernel log messages to /var/log/kernel.log. Michal Zbyszek On Fri, Jul 25, 2014 at 03:04:44PM +0200, Michal Sekletar wrote: --- src

Re: [systemd-devel] [PATCH] journald: fix syslog facility for messages coming from kmsg

2014-07-28 Thread Michal Sekletar
On Sun, Jul 27, 2014 at 07:57:47PM +0200, Zbigniew Jędrzejewski-Szmek wrote: On Sun, Jul 27, 2014 at 01:11:07PM +0200, Michal Sekletar wrote: On Sat, Jul 26, 2014 at 09:11:47PM +0200, Zbigniew Jędrzejewski-Szmek wrote: Hm, what was wrong with the facility before? I think that we should

Re: [systemd-devel] Support for pre-restart check

2014-07-30 Thread Michal Sekletar
On Wed, Jul 30, 2014 at 11:26:38AM +, Jóhann B. Guðmundsson wrote: On 07/30/2014 10:22 AM, Ansgar Burchardt wrote: Hi, while looking at how to convert sysvinit scripts to service files in Debian, I noticed that some scripts do an additional sanity check during the restart action. That

[systemd-devel] [PATCH] socket: introduce SELinuxLabeledNet option

2014-08-05 Thread Michal Sekletar
This makes possible to spawn service instances triggered by socket with MLS/MCS SELinux labels which are created based on information provided by connected peer. Implementation of label_get_socket_label derived from xinetd. --- man/systemd.socket.xml| 11 ++

Re: [systemd-devel] Condition* options linked by AND if stated more than once

2014-08-07 Thread Michal Sekletar
On Thu, Aug 07, 2014 at 01:23:34PM +0200, Peter Mattern wrote: If one of these options gets stated more than once the different instances seem to be linked by a logical AND, too. This prevents overwriting these options via snippets in /etc, e. g. systemd-timesyncd.service still won't run in

Re: [systemd-devel] [PATCH] socket: introduce SELinuxLabeledNet option

2014-08-20 Thread Michal Sekletar
On Wed, Aug 13, 2014 at 09:42:14PM +0200, Lennart Poettering wrote: On Tue, 05.08.14 13:46, Michal Sekletar (msekl...@redhat.com) wrote: This makes possible to spawn service instances triggered by socket with MLS/MCS SELinux labels which are created based on information provided

Re: [systemd-devel] [PATCH] socket: introduce SELinuxLabeledNet option

2014-08-20 Thread Michal Sekletar
On Wed, Aug 20, 2014 at 03:29:37PM +0200, Lennart Poettering wrote: On Wed, 20.08.14 12:01, Michal Sekletar (msekl...@redhat.com) wrote: +if (context-selinux_labeled_net use_selinux()) { +_cleanup_free_ char *label = NULL

Re: [systemd-devel] [PATCH] socket: introduce SELinuxLabeledNet option

2014-08-20 Thread Michal Sekletar
On Wed, Aug 13, 2014 at 09:42:14PM +0200, Lennart Poettering wrote: snip @@ -1773,6 +1782,9 @@ static void socket_enter_running(Socket *s, int cfd) { cfd = -1; s-n_connections ++; +if (s-selinux_labeled_net) +

[systemd-devel] [PATCH v2] socket: introduce SELinuxContextViaNet option

2014-08-20 Thread Michal Sekletar
This makes possible to spawn service instances triggered by socket with MLS/MCS SELinux labels which are created based on information provided by connected peer. Implementation of label_get_child_label derived from xinetd. Reviewed-by: Paul Moore pmo...@redhat.com --- Changes in v2: *

Re: [systemd-devel] [PATCH] missing: add BPF_XOR

2014-08-21 Thread Michal Sekletar
On Thu, Aug 21, 2014 at 12:38:08PM +0200, Michael Olbrich wrote: BPF_XOR was introduced in kernel 3.7 --- This fixes compiling systemd for me. I'm not sure about the implications of this. I'm not sure what happens if the code using it is executed on a linux kernel 3.7 I don't think that

[systemd-devel] [PATCH 2/2 v3] socket: introduce SELinuxContextFromNet option

2014-08-25 Thread Michal Sekletar
This makes possible to spawn service instances triggered by socket with MLS/MCS SELinux labels which are created based on information provided by connected peer. Implementation of label_get_child_mls_label derived from xinetd. Reviewed-by: Paul Moore pmo...@redhat.com --- Changes in v3:

[systemd-devel] [PATCH 1/2] everywhere: don't use uprefixed word context in struct and function names

2014-08-25 Thread Michal Sekletar
We use libselinux which exports context_free function. To prevent name clashes rename our internal APIs and don't use context_* but rather appropriately prefixed names. --- src/hostname/hostnamed.c | 72 +-- src/journal/mmap-cache.c | 102

[systemd-devel] [PATCH] core: get rid the start job when transitioning to deactivating

2013-07-18 Thread Michal Sekletar
When dependency unit is configured with StopWhenUnneeded=yes and activation of main unit fails, e.g. start timeout occurs, then dependencies are never stopped. This happens because start job for the main unit is still around. --- src/core/unit.c | 2 +- 1 file changed, 1 insertion(+), 1

[systemd-devel] [PATCH 2/3] install: don't allow to enable/disable templates

2013-08-08 Thread Michal Sekletar
Calling enable on template units doesn't make sense since it is possible to enable instances directly and users are not forced to use Alias= trickery anymore. --- src/shared/install.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/shared/install.c

[systemd-devel] [PATCH 1/3] systemctl: check for triggering units before calling StopUnit

2013-08-08 Thread Michal Sekletar
Rearranging the code in a way that we always check for triggers before we issue StopUnit D-Bus call will make behavior consistent, thus triggers are always checked. https://bugzilla.redhat.com/show_bug.cgi?id=908690 --- src/systemctl/systemctl.c | 20 ++-- 1 file changed, 10

[systemd-devel] [PATCH 3/3] TODO: don't allow to enable/disable template

2013-08-08 Thread Michal Sekletar
--- TODO | 5 - 1 file changed, 5 deletions(-) diff --git a/TODO b/TODO index ead699c..884acd6 100644 --- a/TODO +++ b/TODO @@ -2,11 +2,6 @@ Bugfixes: * the running hwdb seems not to pick up updated database files without an explicit: udevadm control --reload -* enabling an instance

Re: [systemd-devel] [PATCH 1/3] systemctl: check for triggering units before calling StopUnit

2013-08-08 Thread Michal Sekletar
On Thu, Aug 08, 2013 at 03:57:20PM +0200, Václav Pavlín wrote: Michal Sekletar píše v Čt 08. 08. 2013 v 15:19 +0200: Rearranging the code in a way that we always check for triggers before we issue StopUnit D-Bus call will make behavior consistent, thus triggers are always checked

Re: [systemd-devel] [PATCH 2/3] install: don't allow to enable/disable templates

2013-08-09 Thread Michal Sekletar
On Thu, Aug 08, 2013 at 03:35:24PM +0200, Tom Gundersen wrote: Hi Michal, Hello Tom, On Thu, Aug 8, 2013 at 3:19 PM, Michal Sekletar msekl...@redhat.com wrote: Calling enable on template units doesn't make sense since it is possible to enable instances directly and users are not forced

[systemd-devel] [PATCH] systemctl: process only signals for jobs we really wait for

2013-09-12 Thread Michal Sekletar
wait_filter() callback shouldn't process JobRemove signals for arbitrary jobs. It should only deal with signals for jobs which are included in set of jobs we wait for. --- src/systemctl/systemctl.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git

Re: [systemd-devel] [PATCH 1/3] systemctl: check for triggering units before calling StopUnit

2013-09-12 Thread Michal Sekletar
Hi everyone, I am wondering if there is something else wrong or it is merge ready? Please let me know. Michal ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] core: get rid the start job when transitioning to deactivating

2013-09-13 Thread Michal Sekletar
On Thu, Sep 12, 2013 at 06:51:49PM +0200, Lennart Poettering wrote: On Fri, 19.07.13 09:17, Lukáš Nykrýn (lnyk...@redhat.com) wrote: Hi, when service has StopWhenUnneeded=yes and it is requested by forking service, which fails during initialization, the first unit is not stopped. Hi

Re: [systemd-devel] [PATCH 1/3] systemctl: check for triggering units before calling StopUnit

2013-09-13 Thread Michal Sekletar
On Wed, Sep 11, 2013 at 08:04:38PM +0200, Lennart Poettering wrote: On Fri, 09.08.13 16:00, Michal Sekletar (msekl...@redhat.com) wrote: Heya, Hi Lennart, Hmm, so what I don't really like about this patch is that the stop might have caused the triggering units also to go away via some

[systemd-devel] [PATCH 2/3] net-util: call ioctl() only if necessary

2013-11-06 Thread Michal Sekletar
In case when update of current values is not necessary we still might end up calling ioctl(), because need_update variable is not explicitly initialized. --- src/udev/net/ethtool-util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/udev/net/ethtool-util.c

[systemd-devel] [PATCH 3/3] systemctl: return r instead of always returning 0

2013-11-06 Thread Michal Sekletar
--- src/systemctl/systemctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 9f5e273..0c1588c 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -1362,7 +1362,7 @@ static int

[systemd-devel] [PATCH 1/3] tmpfiles: skip the path entirely if configured as type x

2013-11-06 Thread Michal Sekletar
Type x in tmpfiles configuration accepts shell style globs instead of normal paths. If user uses normal path he might expect that the path will be left untouched. However this is not the case for directories and content of the directory will be cleaned according to the Age parameter, we should

Re: [systemd-devel] [PATCH 1/3] tmpfiles: skip the path entirely if configured as type x

2013-11-08 Thread Michal Sekletar
On Thu, Nov 07, 2013 at 10:39:19PM +0100, Lennart Poettering wrote: On Wed, 06.11.13 11:18, Michal Sekletar (msekl...@redhat.com) wrote: Type x in tmpfiles configuration accepts shell style globs instead of normal paths. If user uses normal path he might expect that the path will be left

Re: [systemd-devel] [PATCH 1/3] tmpfiles: skip the path entirely if configured as type x

2013-11-08 Thread Michal Sekletar
On Thu, Nov 07, 2013 at 10:39:19PM +0100, Lennart Poettering wrote: On Wed, 06.11.13 11:18, Michal Sekletar (msekl...@redhat.com) wrote: Type x in tmpfiles configuration accepts shell style globs instead of normal paths. If user uses normal path he might expect that the path will be left

Re: [systemd-devel] [PATCH 1/3] tmpfiles: skip the path entirely if configured as type x

2013-11-11 Thread Michal Sekletar
On Sun, Nov 10, 2013 at 11:13:57PM +0100, Lennart Poettering wrote: On Fri, 08.11.13 14:36, Michal Sekletar (msekl...@redhat.com) wrote: On Thu, Nov 07, 2013 at 10:39:19PM +0100, Lennart Poettering wrote: On Wed, 06.11.13 11:18, Michal Sekletar (msekl...@redhat.com) wrote: Type

Re: [systemd-devel] [PATCH] selinux: fix selinux check for transient units

2013-11-18 Thread Michal Sekletar
On Mon, Nov 18, 2013 at 04:19:20PM -0500, Daniel J Walsh wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/16/2013 08:10 AM, Lennart Poettering wrote: On Thu, 14.11.13 15:43, Daniel J Walsh (dwa...@redhat.com) wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On

Re: [systemd-devel] [PATCH] selinux: fix selinux check for transient units

2013-11-19 Thread Michal Sekletar
On Tue, Nov 19, 2013 at 08:54:41AM -0500, Daniel J Walsh wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/18/2013 05:45 PM, Michal Sekletar wrote: On Mon, Nov 18, 2013 at 04:19:20PM -0500, Daniel J Walsh wrote: On 11/16/2013 08:10 AM, Lennart Poettering wrote: On Thu, 14.11.13

[systemd-devel] [PATCH] systemd: introduced new timeout types

2012-08-07 Thread Michal Sekletar
Makes possible to specify separate timeout for start and stop of the service. --- man/systemd.service.xml | 25 - src/core/dbus-service.c | 4 +++- src/core/load-fragment-gperf.gperf.m4 | 4 +++- src/core/load-fragment.c | 12

Re: [systemd-devel] [PATCH] systemd: introduced new timeout types

2012-08-07 Thread Michal Sekletar
Hello, it should be fixed and behavior should be the same as Michal has described, however patch is not based on current origin/master HEAD since I am unable to pull today. If it does not apply cleanly please let me know. Thank you. Regards, Michal

[systemd-devel] [PATCH] systemctl: fix misleading warning message

2012-09-21 Thread Michal Sekletar
From: Michal Sekletar sekleta...@gmail.com When stopping multiple units at once do not print warning about triggering units when they are stopped by the same command. --- src/systemctl/systemctl.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/systemctl

[systemd-devel] [PATCH 2/6] localectl: fix memleak, call set_free before return

2012-10-25 Thread Michal Sekletar
--- src/locale/localectl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/locale/localectl.c b/src/locale/localectl.c index c05eba0..16700fe 100644 --- a/src/locale/localectl.c +++ b/src/locale/localectl.c @@ -354,6 +354,7 @@ static int list_locales(DBusConnection *bus, char **args,

[systemd-devel] [PATCH 4/6] util: fix possible integer overflows

2012-10-25 Thread Michal Sekletar
--- src/shared/util.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/shared/util.c b/src/shared/util.c index 2f0aba8..8da2314 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@ -148,6 +148,9 @@ usec_t timespec_load(const struct timespec *ts) { ts-tv_nsec ==

[systemd-devel] [PATCH 5/6] coredumpctl: null check before dereferencing

2012-10-25 Thread Michal Sekletar
--- src/journal/coredumpctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/journal/coredumpctl.c b/src/journal/coredumpctl.c index d15a31e..1a4d78f 100644 --- a/src/journal/coredumpctl.c +++ b/src/journal/coredumpctl.c @@ -222,6 +222,7 @@ static int retrieve(sd_journal *j, const char

[systemd-devel] [PATCH 6/6] sysctl: parse all keys in a config file

2012-10-25 Thread Michal Sekletar
https://bugzilla.redhat.com/show_bug.cgi?id=869779 --- src/sysctl/sysctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sysctl/sysctl.c b/src/sysctl/sysctl.c index a68d67f..035e0ec 100644 --- a/src/sysctl/sysctl.c +++ b/src/sysctl/sysctl.c @@ -178,7 +178,7 @@ static int

[systemd-devel] [PATCH 3/6] localectl: fix memleak, use _cleanup_strv_free_

2012-10-25 Thread Michal Sekletar
l might contain zero strings, however there is still memory allocated for NULL terminator, use _cleanup_strv_free_ instead to prevent tiny leak in such case. --- src/locale/localectl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/locale/localectl.c

Re: [systemd-devel] [PATCH 5/6] coredumpctl: null check before dereferencing

2012-10-25 Thread Michal Sekletar
On Thu, 2012-10-25 at 17:12 +0200, Michal Schmidt wrote: On 10/25/2012 04:16 PM, Michal Sekletar wrote: --- src/journal/coredumpctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/journal/coredumpctl.c b/src/journal/coredumpctl.c index d15a31e..1a4d78f 100644 --- a/src

[systemd-devel] [PATCH 1/5] journal: fix memleak, call set_free before return

2012-10-26 Thread Michal Sekletar
--- src/journal/coredumpctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/journal/coredumpctl.c b/src/journal/coredumpctl.c index 5c442ff..aa946ae 100644 --- a/src/journal/coredumpctl.c +++ b/src/journal/coredumpctl.c @@ -57,7 +57,7 @@ static Set *new_matches(void)

[systemd-devel] [PATCH 2/5] localectl: fix memleak, jump to finish before returning

2012-10-26 Thread Michal Sekletar
--- src/locale/localectl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/locale/localectl.c b/src/locale/localectl.c index c05eba0..84feb25 100644 --- a/src/locale/localectl.c +++ b/src/locale/localectl.c @@ -354,7 +354,8 @@ static int list_locales(DBusConnection *bus,

[systemd-devel] [PATCH 3/5] localectl: fix memleak, use _cleanup_strv_free_

2012-10-26 Thread Michal Sekletar
l might contain zero strings, however there is still memory allocated for NULL terminator, use _cleanup_strv_free_ instead to prevent tiny leak in such case. --- src/locale/localectl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/locale/localectl.c

[systemd-devel] [PATCH 5/5] coredumpctl: null check before dereferencing

2012-10-26 Thread Michal Sekletar
--- src/journal/coredumpctl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/journal/coredumpctl.c b/src/journal/coredumpctl.c index aa946ae..800e43f 100644 --- a/src/journal/coredumpctl.c +++ b/src/journal/coredumpctl.c @@ -220,9 +220,10 @@ static int

[systemd-devel] [PATCH 1/2] path-util: set pointer to null after calling free()

2012-12-13 Thread Michal Sekletar
In cases where path_strv_canonicalize() returns NULL, strv_free() is called afterwards and it will call free() on pointers which were freed already in path_strv_canonicalize() --- src/shared/path-util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/shared/path-util.c

[systemd-devel] [PATCH 2/2] socket-util: added check of return value

2012-12-13 Thread Michal Sekletar
--- src/shared/socket-util.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/shared/socket-util.c b/src/shared/socket-util.c index 49ea758..42ea545 100644 --- a/src/shared/socket-util.c +++ b/src/shared/socket-util.c @@ -369,6 +369,8 @@ int socket_address_print(const SocketAddress *a,

[systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-02-13 Thread Michal Sekletar
All Execs within the service, will get mounted the same /tmp and /var/tmp directories, if service is configured with PrivateTmp=yes. Temporary directories are cleaned up by service itself, rather than relying on systemd-tmpfiles. Same logic applies also to inaccessible directories. ---

[systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-02-20 Thread Michal Sekletar
All Execs within the service, will get mounted the same /tmp and /var/tmp directories, if service is configured with PrivateTmp=yes. Temporary directories are cleaned up by service itself, rather than relying on systemd-tmpfiles. Same logic applies also to inaccessible directories. ---

Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-02 Thread Michal Sekletar
On Mar 1, 2013, at 3:16 PM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 20.02.13 14:50, Michal Sekletar (msekl...@redhat.com) wrote: All Execs within the service, will get mounted the same /tmp and /var/tmp directories, if service is configured with PrivateTmp=yes. Temporary

Re: [systemd-devel] [PATCH 3/5] tpmfiles: add missing parenthesis

2013-03-02 Thread Michal Sekletar
On Mar 1, 2013, at 10:35 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: Hi Zbigniew, On Fri, Mar 01, 2013 at 06:29:59PM +0100, Lukas Nykryn wrote: --- src/tmpfiles/tmpfiles.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tmpfiles/tmpfiles.c

Re: [systemd-devel] [PATCH 3/5] tpmfiles: add missing parenthesis

2013-03-02 Thread Michal Sekletar
Hi Carlos, I shouldn't use word Agreed, because it seems that it caused some confusion. On Mar 2, 2013, at 3:55 PM, Carlos Silva r3...@r3pek.org wrote: On Sat, Mar 2, 2013 at 1:46 PM, Michal Sekletar sekleta...@gmail.com wrote: -if (!i-type == IGNORE_DIRECTORY_PATH

Re: [systemd-devel] [PATCH 3/5] tpmfiles: add missing parenthesis

2013-03-03 Thread Michal Sekletar
Hi Zbigniew, you are right. I overlooked the fact that negation has higher precedence than equal operator. Thank you! Would you be so kind and commit the patch? Michal. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

[systemd-devel] [PATCH] core: fix getting information about mount unit

2013-03-08 Thread Michal Sekletar
We should not try to get information about mount unit from fragment if the unit was created because of /proc/self/mountinfo event. --- src/core/mount.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/core/mount.c b/src/core/mount.c index 419cf27..df9 100644 ---

Re: [systemd-devel] [PATCH] core: fix getting information about mount unit

2013-03-08 Thread Michal Sekletar
Hi everyone, I haven't tested the patch, so suggestions and testing are very appreciated. Regards, Michal ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-12 Thread Michal Sekletar
All Execs within the service, will get mounted the same /tmp and /var/tmp directories, if service is configured with PrivateTmp=yes. Temporary directories are cleaned up by service itself, rather than relying on systemd-tmpfiles. Directory which is mounted as inaccessible is shared, created at

[systemd-devel] [PATCH] systemctl: fix variable initialization

2013-03-12 Thread Michal Sekletar
--- src/systemctl/systemctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 4a55c56..db12255 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -1454,7 +1454,7 @@ static int start_unit_one(

Re: [systemd-devel] [PATCH] systemctl: fix variable initialization

2013-03-12 Thread Michal Sekletar
Hi Zbyszek, Hi, that's not necessary, it's initialized right below the assert statements. I know it is initialized right after asserts, however we tend to initialize vars witch are marked for auto-cleanup with NULL. So I thought it would be good to do it here too, since it doesn't hurt

Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-12 Thread Michal Sekletar
Thank you for the review! It is very appreciated. Michal ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH] shutdown: move attribute packed to the end of the declaration, so it is not ignored

2013-03-12 Thread Michal Sekletar
--- src/systemd/sd-shutdown.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/systemd/sd-shutdown.h b/src/systemd/sd-shutdown.h index cee4350..b8f6a48 100644 --- a/src/systemd/sd-shutdown.h +++ b/src/systemd/sd-shutdown.h @@ -37,7 +37,7 @@ typedef enum sd_shutdown_mode

[systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-14 Thread Michal Sekletar
All Execs within the service, will get mounted the same /tmp and /var/tmp directories, if service is configured with PrivateTmp=yes. Temporary directories are cleaned up by service itself in addition to systemd-tmpfiles. Directory which is mounted as inaccessible is created at runtime in

Re: [systemd-devel] [PATCH] core: reuse the same /tmp, /var/tmp and inaccessible dir

2013-03-14 Thread Michal Sekletar
Hi Zbyszek, - Original Message - Maybe just stick it in mount_setup()? Thank you for this suggestion! It seems to be without much difference, but I'd go for /run, since this way there'll be less chance that somebody deletes it by mistake. I first tried /tmp and I had issue that

[systemd-devel] [PATCH] systemd: return error when asked to stop unknown unit

2012-06-19 Thread Michal Sekletar
Command systemctl stop foo.service, will print error message, when foo.service is unknown to systemd, i.e. there is no unit file loaded for this service. https://bugzilla.redhat.com/show_bug.cgi?id=732874 --- src/core/dbus-manager.c |5 + 1 file changed, 5 insertions(+) diff --git

[systemd-devel] systemd and templates

2012-06-25 Thread Michal Sekletar
on this matter. [1] It is possible to use Alias= in [Install] section of template, but we consider this as a workaround rather than solution. -- Lukas Nykryn and Michal Sekletar Red Hat, BaseOS Engineering, Brno Czech Republic ___ systemd-devel mailing

[systemd-devel] [PATCH 1/2] systemd: added new dependency StoppedBy

2012-07-03 Thread Michal Sekletar
This should address TODO item new dependency type to group services in a target. Semantic of new dependency is as follows. Once configured it creates dependency which will cause that all dependent units get stopped if unit they all depend on is stopped or restarted. Usual use case would be

[systemd-devel] [PATCH 2/2] systemd: enabling/disabling template units

2012-07-03 Thread Michal Sekletar
Makes possible to enable/disable instance of units and should resolve BZ 752774. --- src/shared/install.c | 81 +--- src/shared/unit-name.c | 11 +++ src/shared/unit-name.h |1 + 3 files changed, 81 insertions(+), 12 deletions(-) diff

[systemd-devel] [PATCH] systemd: added new dependency StoppedBy

2012-07-04 Thread Michal Sekletar
This should address TODO item new dependency type to group services in a target. Semantic of new dependency is as follows. Once configured it creates dependency which will cause that all dependent units get stopped if unit they all depend on is stopped or restarted. Usual use case would be

  1   2   >