[systemd-devel] [PATCH 1/1] sd-rtnl: Introduce container parsing

2014-03-22 Thread Susant Sahani
Introducing generic container parsing . Now supported for type FLA_INFO_KIND and IFLA_VLAN_ID which can be extended to other container parsing which is based on table based look up. --- src/libsystemd/sd-rtnl/rtnl-internal.h | 20 + src/libsystemd/sd-rtnl/rtnl-message.c | 79

Re: [systemd-devel] [PATCH 1/1] sd-rtnl: add support for tunnel attributes

2014-03-23 Thread Susant Sahani
On 03/23/2014 09:34 PM, Tom Gundersen wrote: On Sun, Mar 23, 2014 at 4:14 PM, Susant Sahani sus...@redhat.com wrote: Added support for tunneling netlink attrributes (ipip, gre, sit). These works with kernel module ipip, gre and sit . The test cases are commented out because they requirs super

Re: [systemd-devel] [PATCH 1/1] sd-rtnl: add support for tunnel attributes

2014-03-23 Thread Susant Sahani
On 03/23/2014 10:00 PM, Zbigniew Jędrzejewski-Szmek wrote: On Sun, Mar 23, 2014 at 08:44:09PM +0530, Susant Sahani wrote: Added support for tunneling netlink attrributes (ipip, gre, sit). These works with kernel module ipip, gre and sit . The test cases are commented out because they requirs

Re: [systemd-devel] [PATCH 1/1] sd-rtnl: Introduce container parsing

2014-03-24 Thread Susant Sahani
On 03/24/2014 09:58 PM, Tom Gundersen wrote: On Sat, Mar 22, 2014 at 5:13 PM, Susant Sahani sus...@redhat.com wrote: Introducing generic container parsing . Now supported for type FLA_INFO_KIND and IFLA_VLAN_ID which can be extended to other container parsing which is based on table based look

[systemd-devel] [PATCH 1/1] sd-rtnl: add support for tunnel attributes

2014-03-25 Thread Susant Sahani
@@ +/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/ + +/*** + This file is part of systemd. + + Copyright 2014 Susant Sahani + + systemd is free software; you can redistribute it and/or modify it + under the terms of the GNU Lesser General Public License as published by + the Free

[systemd-devel] sd-rtnl: broken test cases

2014-04-03 Thread Susant Sahani
51e8b0a3d18f892c2e0bb86ca86fab99562700b8 Mon Sep 17 00:00:00 2001 From: Susant Sahani sus...@redhat.com Date: Thu, 3 Apr 2014 13:35:56 +0530 Subject: [PATCH] sd-rtnl: fix broken test cases and add support for tunnel This patch fixes the broken test-cases for sd-rtnl and add support for ipip and sit tunnel --- src/libsystemd/sd

[systemd-devel] [PATCH] networkd: Introduce ipip tunnel

2014-04-04 Thread Susant Sahani
This patch enables basic ipip tunnel support. It works with kernel module ipip Example configuration File : ipip.netdev [NetDev] Name=ipip-tun Kind=tunnel [Tunnel] Kind=ipip Local=192.168.8.102 Remote=10.4.4.4 Dev=em1 Ttl=64 Mtu=1480 --- Makefile.am |

Re: [systemd-devel] [PATCH] networkd: Introduce ipip tunnel

2014-04-06 Thread Susant Sahani
at 11:25 AM, Susant Sahani sus...@redhat.com wrote: This patch enables basic ipip tunnel support. It works with kernel module ipip Example configuration File : ipip.netdev [NetDev] Name=ipip-tun Kind=tunnel [Tunnel] Kind=ipip Maybe we should simply have [NetDev] Kind=ipip We can

Re: [systemd-devel] [PATCH] networkd: Introduce ipip tunnel

2014-04-06 Thread Susant Sahani
On 04/07/2014 10:05 AM, Susant Sahani wrote: On 04/04/2014 10:00 PM, Tom Gundersen wrote: Hi Susant, Hi Tom, + log_error_netdev(netdev, + Could not append IFLA_IPTUN_LINK attribute: %s, + strerror(-r)); +return

[systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-07 Thread Susant Sahani
This patch enables basic ipip tunnel support. It works with kernel module ipip Example configuration file: ipip.netdev [NetDev] Name=ipip-tun Kind=ipip [Tunnel] Local=192.168.8.102 Remote=10.4.4.4 TTL=64 MTUBytes=1480 file: ipip.network [Match] Name=eth0 [Network] Tunnel=ipip-tun ---

Re: [systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-07 Thread Susant Sahani
On 04/07/2014 02:39 PM, Tom Gundersen wrote: On Mon, Apr 7, 2014 at 9:44 AM, Susant Sahani sus...@redhat.com wrote: This patch enables basic ipip tunnel support. It works with kernel module ipip Example configuration file: ipip.netdev [NetDev] Name=ipip-tun Kind=ipip [Tunnel] Local

Re: [systemd-devel] [PATCH] networkd: Introduce ipip tunnel

2014-04-07 Thread Susant Sahani
On 04/07/2014 03:13 PM, Jóhann B. Guðmundsson wrote: On 04/07/2014 04:35 AM, Susant Sahani wrote: This will be much nicer if we simply use ipip as the kind, rather than tunnel. Done ! Hmm... I think it got right the first place from a usability perspective as in kind=tunnel then we need

[systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-07 Thread Susant Sahani
This patch enables basic ipip tunnel support. It works with kernel module ipip Example configuration file: ipip.netdev -- [NetDev] Name=ipip-tun Kind=ipip [Tunnel] Local=192.168.8.102 Remote=10.4.4.4 TTL=64 MTUBytes=1480 file: ipip.network --

Re: [systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-11 Thread Susant Sahani
On 04/09/2014 01:33 AM, Umut Tezduyar Lindskog wrote: Hi, Few minor suggestions, if you care. Hi sorry for replying late :) On Tue, Apr 8, 2014 at 5:22 AM, Susant Sahani sus...@redhat.com wrote: This patch enables basic ipip tunnel support. It works with kernel module ipip Example

Re: [systemd-devel] [PATCH 1/1] networkd: Introduce ipip tunnel

2014-04-11 Thread Susant Sahani
On 04/08/2014 12:54 PM, Jóhann B. Guðmundsson wrote: On 04/08/2014 03:22 AM, Susant Sahani wrote: file: ipip.netdev -- [NetDev] Name=ipip-tun Kind=ipip [Tunnel] Local=192.168.8.102 Remote=10.4.4.4 TTL=64 MTUBytes=1480 file: ipip.network

[systemd-devel] [PATCH 2/2] sd-rtnl: fix test cases for rtnl tunnel attr

2014-04-13 Thread Susant Sahani
This patch fix the test cases for tunneling type safe address rtnl attributes and enhances module loading support . --- src/test/test-rtnl-manual.c | 49 + 1 file changed, 36 insertions(+), 13 deletions(-) diff --git a/src/test/test-rtnl-manual.c

[systemd-devel] [PATCH 1/2] networkd: ipip tunell add address support

2014-04-13 Thread Susant Sahani
This patch extends supports to configure address for ipip tunnel patch. File: ipip.network [Match] Name=em1 [Network] Tunnel=ipip-tun Address=192.168.10.24 --- src/network/networkd-address.c | 8 +++- src/network/networkd-link.c| 1 + 2 files changed, 8 insertions(+), 1 deletion(-)

Re: [systemd-devel] [PATCH 1/2] networkd: ipip tunell add address support

2014-04-14 Thread Susant Sahani
On 04/14/2014 03:50 PM, Jóhann B. Guðmundsson wrote: On 04/14/2014 04:06 AM, Susant Sahani wrote: This patch extends supports to configure address for ipip tunnel patch. File: ipip.network [Match] Name=em1 [Network] Tunnel=ipip-tun Address=192.168.10.24 You might want to skip tun from ipip

Re: [systemd-devel] [PATCH 1/2] networkd: ipip tunell add address support

2014-04-14 Thread Susant Sahani
On 04/14/2014 04:04 PM, Jóhann B. Guðmundsson wrote: On 04/14/2014 10:31 AM, Susant Sahani wrote: It's a name not tunnel type. Tunnel type configured in .netdev . you can put anything here . Should match the .netdev Name='XYZ' The Kind is mode which you can replace with ipip/sit/gre

[systemd-devel] [PATCH 1/1] networkd: sit-tunnel add support for pmtudisc

2014-05-20 Thread Susant Sahani
This patch adds path of mtu discovery for sit tunnel. To enable/disable DiscoverPathMTU is introduced. Example configuration file: sit.netdev [NetDev] Name=sit-tun Kind=sit MTUBytes=1480 [Tunnel] DiscoverPathMTU=1 Local=X.X.X.X Remote=X.X.X.X By default pmtudisc is turned on , if

Re: [systemd-devel] [PATCH 1/1] networkd: sit-tunnel add support for pmtudisc

2014-05-20 Thread Susant Sahani
Hi Lennart , Thanks for reviewing . static int netdev_fill_sit_rtnl_message(Link *link, sd_rtnl_message *m) { NetDev *netdev; +uint8_t pmtudisc; Hmm, you never initialized the variable if mtu disc is off, no? oops ! yes This should be uint8_t pmtudisc = 1 . with

[systemd-devel] [PATCH 1/1] networkd: sit-tunnel add support for pmtudisc

2014-05-21 Thread Susant Sahani
V2 fixed the uninitialized variable pmtudisc. This patch adds path of mtu discovery for sit tunnel. To enable/disable DiscoverPathMTU is introduced. Example configuration file: sit.netdev [NetDev] Name=sit-tun Kind=sit MTUBytes=1480 [Tunnel] DiscoverPathMTU=1 Local=X.X.X.X Remote=X.X.X.X By

Re: [systemd-devel] [PATCH 1/1] networkd: sit-tunnel add support for pmtudisc

2014-05-21 Thread Susant Sahani
+netdev-tunnel_pmtudisc = 1; Should be true, not 1. If something is of type bool we should use true for setting it and false for unsetting it. And this is of type bool. Ok . static int netdev_fill_sit_rtnl_message(Link *link, sd_rtnl_message *m) { NetDev *netdev; +

Re: [systemd-devel] [PATCH 1/1] networkd: sit-tunnel add support for pmtudisc

2014-05-21 Thread Susant Sahani
On 05/22/2014 08:32 AM, Susant Sahani wrote: static int netdev_fill_sit_rtnl_message(Link *link, sd_rtnl_message *m) { NetDev *netdev; +uint8_t pmtudisc = 1; int r; assert(link); @@ -207,6 +208,17 @@ static int netdev_fill_sit_rtnl_message(Link *link

Re: [systemd-devel] SIT tunnel does not work

2014-06-21 Thread Susant Sahani
On 06/21/2014 02:47 PM, Tomasz Torcz wrote: Hi, I've tried to establish SIT tunnel to Hurricane Electric, using systemd v214. It does not work, device do not appear. I'm concerned about networkd discarding part of netlink messages, see below. Original instruction is provided by HE, rest is

[systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-24 Thread Susant Sahani
-tuntap.c b/src/network/networkd-tuntap.c new file mode 100644 index 000..f138b8a --- /dev/null +++ b/src/network/networkd-tuntap.c @@ -0,0 +1,106 @@ +/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/ + +/*** +This file is part of systemd. + +Copyright 2014 Susant Sahani sus

Re: [systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-24 Thread Susant Sahani
On 06/24/2014 10:39 PM, Marcel Holtmann wrote: Hi Tom, This patch introduces tuntap support to networkd. Example conf file : tuntap.netdev [NetDev] Name=tuntap-test Kind=tuntap [TUNTAP] Hm, maybe call this TunTap instead? Mode=tap OneQueue=true MultiQueue=true PacketInfo=true I

Re: [systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-24 Thread Susant Sahani
On 06/24/2014 10:31 PM, Tom Gundersen wrote: Looks great, just minor comments below. On Tue, Jun 24, 2014 at 6:25 PM, Susant Sahani sus...@redhat.com wrote: This patch introduces tuntap support to networkd. Example conf file : tuntap.netdev [NetDev] Name=tuntap-test Kind=tuntap [TUNTAP

Re: [systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-24 Thread Susant Sahani
On 06/24/2014 10:05 PM, Ronny Chevalier wrote: 2014-06-24 18:25 GMT+02:00 Susant Sahani sus...@redhat.com: This patch introduces tuntap support to networkd. Example conf file : tuntap.netdev [NetDev] Name=tuntap-test Kind=tuntap [TUNTAP] Mode=tap OneQueue=true MultiQueue=true PacketInfo

Re: [systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-25 Thread Susant Sahani
On 06/25/2014 02:21 PM, Lennart Poettering wrote: On Tue, 24.06.14 23:21, Susant Sahani (sus...@redhat.com) wrote: This patch introduces tuntap support to networkd. Example conf file : tuntap.netdev [NetDev] Name=tuntap-test Kind=tuntap [TUNTAP] Hm, maybe call this TunTap instead? Mode

Re: [systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-25 Thread Susant Sahani
On 06/25/2014 02:51 PM, Susant Sahani wrote: On 06/25/2014 02:21 PM, Lennart Poettering wrote: On Tue, 24.06.14 23:21, Susant Sahani (sus...@redhat.com) wrote: This patch introduces tuntap support to networkd. Example conf file : tuntap.netdev [NetDev] Name=tuntap-test Kind=tuntap [TUNTAP

Re: [systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-25 Thread Susant Sahani
On 06/25/2014 03:28 PM, Tom Gundersen wrote: On Wed, Jun 25, 2014 at 11:38 AM, Susant Sahani sus...@redhat.com wrote: On 06/25/2014 02:51 PM, Susant Sahani wrote: On 06/25/2014 02:21 PM, Lennart Poettering wrote: On Tue, 24.06.14 23:21, Susant Sahani (sus...@redhat.com) wrote: This patch

[systemd-devel] [PATCH] networkd: Introduce tun/tap device

2014-06-25 Thread Susant Sahani
/networkd-tuntap.c @@ -0,0 +1,101 @@ +/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/ + +/*** +This file is part of systemd. + +Copyright 2014 Susant Sahani sus...@redhat.com + +systemd is free software; you can redistribute it and/or modify it +under the terms of the GNU

Re: [systemd-devel] SIT tunnel does not work

2014-06-25 Thread Susant Sahani
On 06/25/2014 04:50 PM, Tomasz Torcz wrote: On Sat, Jun 21, 2014 at 04:36:45PM +0530, Susant Sahani wrote: On 06/21/2014 02:47 PM, Tomasz Torcz wrote: Hi, I've tried to establish SIT tunnel to Hurricane Electric, using systemd v214. It does not work, device do not appear. I'm concerned

[systemd-devel] [PATCH] networkd: Introduce tun/tap device

2014-06-30 Thread Susant Sahani
/network/networkd-tuntap.c @@ -0,0 +1,101 @@ +/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/ + +/*** +This file is part of systemd. + +Copyright 2014 Susant Sahani sus...@redhat.com + +systemd is free software; you can redistribute it and/or modify it +under the terms

Re: [systemd-devel] [PATCH] networkd: Introduce tun/tap device

2014-06-30 Thread Susant Sahani
100644 index 000..7c1840c --- /dev/null +++ b/src/network/networkd-tuntap.c @@ -0,0 +1,101 @@ +/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/ + +/*** +This file is part of systemd. + +Copyright 2014 Susant Sahani sus...@redhat.com + +systemd is free software; you can

Re: [systemd-devel] [PATCH] networkd: Introduce tun/tap device

2014-06-30 Thread Susant Sahani
On 06/30/2014 11:03 PM, Lennart Poettering wrote: On Mon, 30.06.14 22:23, Susant Sahani (sus...@redhat.com) wrote: This patch introduces TUN/TAP device creation support to networkd. Please always also include the updates to the respective man pages that document these settings

Re: [systemd-devel] [PATCH] conf parser: introduce milisecond parsing

2014-07-16 Thread Susant Sahani
On 07/16/2014 01:07 PM, Susant Sahani wrote: Add millisecord parsing support to conf parser. Immediate usage of this function is to parse bond options such as MIIMonitor, UpDelayMSec, DownDelayMSec which is represented in milli seconds. Dropped the idea . Please ignore the patch. Susant

[systemd-devel] [PATCH 2/2] socket: Introduce SCTP support

2014-07-28 Thread Susant Sahani
This patch adds SCTP protcol support for socket activation. SCTP socket can be configured via the conf parameter 'ListenStreamControlTrans' which is kind of too long. --- man/systemd.socket.xml| 3 ++- src/core/load-fragment-gperf.gperf.m4 | 1 + src/core/load-fragment.c

[systemd-devel] [PATCH 1/2] socket: add support for tcp nagle

2014-07-28 Thread Susant Sahani
This patch adds support for TCP TCP_NODELAY socket option. This can be configured via NoDelay conf parameter.TCP Nagle's algorithm works by combining a number of small outgoing messages, and sending them all at once. This controls the TCP_NODELAY socket option --- man/systemd.socket.xml

[systemd-devel] [PATCH 3/3] socket: Add support for TCP defer accept

2014-07-29 Thread Susant Sahani
TCP_DEFER_ACCEPT Allow a listener to be awakened only when data arrives on the socket. If TCP_DEFER_ACCEPT set on a server-side listening socket, the TCP/IP stack will not to wait for the final ACK packet and not to initiate the process until the first packet of real data has arrived. After

[systemd-devel] [PATCH 1/3] socket: Add Support for TCP keep alive variables

2014-07-29 Thread Susant Sahani
The tcp keep alive variables now can be configured via conf parameter. Follwing variables are now supported by this patch. tcp_keepalive_intvl: The number of seconds between TCP keep-alive probes tcp_keepalive_probes: The maximum number of TCP keep-alive probes to send before giving up and

Re: [systemd-devel] [PATCH 2/2] socket: Introduce SCTP support

2014-08-04 Thread Susant Sahani
On 08/04/2014 06:26 PM, Lennart Poettering wrote: On Mon, 28.07.14 12:18, Susant Sahani (sus...@redhat.com) wrote: This patch adds SCTP protcol support for socket activation. SCTP socket can be configured via the conf parameter 'ListenStreamControlTrans' which is kind of too long. Hmm

[systemd-devel] [PATCH] socket: add support for TCP fast Open

2014-08-14 Thread Susant Sahani
TCP Fast Open (TFO) speeds up the opening of successiveTCP) connections between two endpoints.It works by using a TFO cookie in the initial SYN packet to authenticate a previously connected client. It starts sending data to the client before the receipt of the final ACK packet of the three way

Re: [systemd-devel] [PATCH 2/3] socket: Add support for TCP Fast Open

2014-08-14 Thread Susant Sahani
Hi Lennart, On 08/14/2014 06:16 AM, Lennart Poettering wrote: On Tue, 29.07.14 23:10, Susant Sahani (sus...@redhat.com) wrote: Looks good. Wanted to apply. But this requires your previous patch, so please rebase on a new version of that! Thanks! Since this patch does not depend on the other

Re: [systemd-devel] [PATCH 1/3] socket: Add Support for TCP keep alive variables

2014-08-14 Thread Susant Sahani
On 08/14/2014 06:13 AM, Lennart Poettering wrote: On Tue, 29.07.14 23:10, Susant Sahani (sus...@redhat.com) wrote: tcp_keepalive_time: The number of seconds a connection needs to be idle before TCP begins sending out keep-alive probes. Looks pretty OK

[systemd-devel] [PATCH 1/3] socket: Add Support for TCP keep alive variables

2014-08-14 Thread Susant Sahani
The tcp keep alive variables now can be configured via conf parameter. Follwing variables are now supported by this patch. tcp_keepalive_intvl: The number of seconds between TCP keep-alive probes tcp_keepalive_probes: The maximum number of TCP keep-alive probes to send before giving up and

[systemd-devel] [PATCH 2/3] socket: Add support for TCP defer accept

2014-08-14 Thread Susant Sahani
TCP_DEFER_ACCEPT Allow a listener to be awakened only when data arrives on the socket. If TCP_DEFER_ACCEPT set on a server-side listening socket, the TCP/IP stack will not to wait for the final ACK packet and not to initiate the process until the first packet of real data has arrived. After

[systemd-devel] [PATCH 3/3] socket: add bus property for bus property NoDelay

2014-08-14 Thread Susant Sahani
Missed to add the SD_BUS_PROPERTY for no_delay. --- src/core/dbus-socket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/core/dbus-socket.c b/src/core/dbus-socket.c index cc55b8d..e9e2430 100644 --- a/src/core/dbus-socket.c +++ b/src/core/dbus-socket.c @@ -101,6 +101,7 @@ const

[systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread Susant Sahani
CID 1237543 (#1 of 1): Unchecked return value from library (CHECKED_RETURN) --- src/socket-proxy/socket-proxyd.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/socket-proxy/socket-proxyd.c b/src/socket-proxy/socket-proxyd.c index ff2b24f..7b0714d 100644 ---

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread Susant Sahani
On 09/19/2014 01:35 PM, David Herrmann wrote: Hi Hi, On Fri, Sep 19, 2014 at 9:57 AM, Susant Sahani sus...@redhat.com wrote: CID 1237543 (#1 of 1): Unchecked return value from library (CHECKED_RETURN) --- src/socket-proxy/socket-proxyd.c | 6 +- 1 file changed, 5 insertions(+), 1

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread Susant Sahani
On 09/19/2014 02:00 PM, David Herrmann wrote: Hi On Fri, Sep 19, 2014 at 10:28 AM, Susant Sahani sus...@redhat.com wrote: On 09/19/2014 01:35 PM, David Herrmann wrote: I don't think that's right. Ignoring the return value of that fcntl is just fine. We read the buffer-size afterwards, so

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread Susant Sahani
On 09/19/2014 02:11 PM, David Herrmann wrote: Hi On Fri, Sep 19, 2014 at 10:39 AM, Alexander E. Patrakov patra...@gmail.com wrote: 19.09.2014 14:35, Susant Sahani wrote: On 09/19/2014 02:00 PM, David Herrmann wrote: Hi On Fri, Sep 19, 2014 at 10:28 AM, Susant Sahani sus...@redhat.com

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-10-09 Thread Susant Sahani
On 10/03/2014 12:21 AM, Lennart Poettering wrote: On Fri, 19.09.14 13:27, Susant Sahani (sus...@redhat.com) wrote: CID 1237543 (#1 of 1): Unchecked return value from library (CHECKED_RETURN) --- src/socket-proxy/socket-proxyd.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion

[systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-10-09 Thread Susant Sahani
CID 1237543 (#1 of 1): Unchecked return value from library (CHECKED_RETURN) --- src/socket-proxy/socket-proxyd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/socket-proxy/socket-proxyd.c b/src/socket-proxy/socket-proxyd.c index ff2b24f..3041903 100644 ---

[systemd-devel] [PATCH 2/3] resolved: fix CID 1237549 Unchecked return value

2014-11-11 Thread Susant Sahani
--- src/resolve/resolved-dns-scope.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/resolve/resolved-dns-scope.c b/src/resolve/resolved-dns-scope.c index 1664b13..25e0d9e 100644 --- a/src/resolve/resolved-dns-scope.c +++ b/src/resolve/resolved-dns-scope.c @@ -386,7

[systemd-devel] [PATCH 1/3] log: 1237557 Unchecked return value from library

2014-11-11 Thread Susant Sahani
fix 1237557 Unchecked return value from library --- src/shared/log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/log.c b/src/shared/log.c index 1c589ac..e7237ba 100644 --- a/src/shared/log.c +++ b/src/shared/log.c @@ -122,7 +122,7 @@ static int

[systemd-devel] [PATCH 3/3] bus-socket: fix CID 996290 Unchecked return value

2014-11-11 Thread Susant Sahani
--- src/libsystemd/sd-bus/bus-socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libsystemd/sd-bus/bus-socket.c b/src/libsystemd/sd-bus/bus-socket.c index d124d9a..662bf1c 100644 --- a/src/libsystemd/sd-bus/bus-socket.c +++ b/src/libsystemd/sd-bus/bus-socket.c

[systemd-devel] [PATCH 1/2] namespace:Unchecked return value from library

2014-11-11 Thread Susant Sahani
fix: CID 1237553 (#1 of 6): Unchecked return value from library (CHECKED_RETURN CID 1237553 (#3 of 6): Unchecked return value from library (CHECKED_RETURN) CID 1237553 (#4 of 6): Unchecked return value from library (CHECKED_RETURN) CID 1237553 (#5 of 6): Unchecked return value from library

[systemd-devel] [PATCH 2/2] tty-ask-password-agent: fix CID 996261

2014-11-11 Thread Susant Sahani
Unchecked return value from library --- src/tty-ask-password-agent/tty-ask-password-agent.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/tty-ask-password-agent/tty-ask-password-agent.c b/src/tty-ask-password-agent/tty-ask-password-agent.c index e6dc84b..c4cd387

[systemd-devel] [PATCH] networkd: Support VXlan parameters

2014-11-13 Thread Susant Sahani
Add vxlan paramertes to config. --- man/systemd.netdev.xml | 30 + src/network/networkd-netdev-gperf.gperf | 7 ++- src/network/networkd-netdev-vxlan.c | 75 + src/network/networkd-netdev-vxlan.h | 8

[systemd-devel] [PATCH] networkd: Support VXlan parameters

2014-11-14 Thread Susant Sahani
Add vxlan paramertes to config. --- man/systemd.netdev.xml | 30 + src/network/networkd-netdev-gperf.gperf | 7 ++- src/network/networkd-netdev-vxlan.c | 75 + src/network/networkd-netdev-vxlan.h | 8

Re: [systemd-devel] [PATCH] networkd: Support VXlan parameters

2014-11-14 Thread Susant Sahani
On 11/14/2014 01:48 PM, Ronny Chevalier wrote: 2014-11-14 8:44 GMT+01:00 Susant Sahani sus...@redhat.com: Hi, Hi, Add vxlan paramertes to config. --- +r = sd_rtnl_message_append_u32(m, IFLA_VXLAN_AGEING, v-fdb_ageing / USEC_PER_MSEC); s/USEC_PER_MSEC/USEC_PER_SEC

[systemd-devel] [PATCH] networkd: Support VXlan parameters

2014-11-14 Thread Susant Sahani
V3: fix copy paste error Add vxlan paramertes to config. --- man/systemd.netdev.xml | 30 src/network/networkd-netdev-gperf.gperf | 7 ++- src/network/networkd-netdev-vxlan.c | 81 + src/network/networkd-netdev-vxlan.h | 10

Re: [systemd-devel] [PATCH v2] localed: validate set-x11-keymap input

2014-11-14 Thread Susant Sahani
On 11/14/2014 05:12 PM, Jan Synacek wrote: +int xkb_validate_keymaps(const char *model, + const char *layouts_arg, + const char *variants_arg, + const char *options_arg, + char **error) +{ '{'

Re: [systemd-devel] [PATCH v2] localed: validate set-x11-keymap input

2014-11-14 Thread Susant Sahani
On 11/14/2014 05:12 PM, Jan Synacek wrote: +int xkb_keymap_get_components(X11Keymap *keymap) { +_cleanup_strv_free_ char **models = NULL, **options = NULL; +_cleanup_fclose_ FILE *f; +char line[LINE_MAX]; +enum KeymapComponent state = NONE; +size_t m = 0,

[systemd-devel] [PATCH] networkd: support vxlan parameters

2014-11-14 Thread Susant Sahani
V3: fix copy paste error V4: Make manual and config more readable Add vxlan paramertes to config. --- man/systemd.netdev.xml | 30 src/network/networkd-netdev-gperf.gperf | 83 + src/network/networkd-netdev-vxlan.c | 81

Re: [systemd-devel] [PATCH] networkd: Support VXlan parameters

2014-11-14 Thread Susant Sahani
+VXLAN.RouteShortCircuit On Fri, Nov 14, 2014 at 10:33 AM, Susant Sahani sus...@redhat.com wrote: V3: fix copy paste error Add vxlan paramertes to config. Susant ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman

[systemd-devel] [PATCH] networkd: Add bridge port path cost

2014-11-14 Thread Susant Sahani
This patch add support to specify path cost of the bridge port to be configured via conf file. Exampe: conf file: br.netdev [NetDev] Name=br-test Kind=bridge file: br.network [Match] Name=em1 [Network] Bridge=br-test [BridgePort] Cost=332 bridge link 2: em1 state UP :

Re: [systemd-devel] [PATCH 1/2] namespace:Unchecked return value from library

2014-11-17 Thread Susant Sahani
On 11/17/2014 03:35 PM, David Herrmann wrote: Hi Hi, On Tue, Nov 11, 2014 at 11:33 AM, Susant Sahani sus...@redhat.com wrote: fix: CID 1237553 (#1 of 6): Unchecked return value from library (CHECKED_RETURN CID 1237553 (#3 of 6): Unchecked return value from library (CHECKED_RETURN) CID

[systemd-devel] [PATCH 1/2] namespace:Unchecked return value from library

2014-11-17 Thread Susant Sahani
fix: CID 1237553 (#1 of 6): Unchecked return value from library (CHECKED_RETURN CID 1237553 (#3 of 6): Unchecked return value from library (CHECKED_RETURN) CID 1237553 (#4 of 6): Unchecked return value from library (CHECKED_RETURN) CID 1237553 (#5 of 6): Unchecked return value from library

[systemd-devel] [PATCH 1/2] namespace:Unchecked return value from library

2014-11-17 Thread Susant Sahani
fix: CID 1237553 (#1 of 6): Unchecked return value from library (CHECKED_RETURN CID 1237553 (#3 of 6): Unchecked return value from library (CHECKED_RETURN) CID 1237553 (#4 of 6): Unchecked return value from library (CHECKED_RETURN) CID 1237553 (#5 of 6): Unchecked return value from library

[systemd-devel] [PATCH 2/2] tty-ask-password-agent: fix CID 996261

2014-11-17 Thread Susant Sahani
--- src/tty-ask-password-agent/tty-ask-password-agent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tty-ask-password-agent/tty-ask-password-agent.c b/src/tty-ask-password-agent/tty-ask-password-agent.c index e6dc84b..1fc792b 100644 ---

Re: [systemd-devel] [PATCH 2/2] tty-ask-password-agent: fix CID 996261

2014-11-17 Thread Susant Sahani
On 11/17/2014 10:26 PM, Greg KH wrote: On Mon, Nov 17, 2014 at 04:28:58PM +0530, Susant Sahani wrote: --- src/tty-ask-password-agent/tty-ask-password-agent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tty-ask-password-agent/tty-ask-password-agent.c b/src/tty-ask

Re: [systemd-devel] [PATCH 2/2] tty-ask-password-agent: fix CID 996261

2014-11-17 Thread Susant Sahani
On 11/17/2014 10:39 PM, Greg KH wrote: On Mon, Nov 17, 2014 at 10:36:53PM +0530, Susant Sahani wrote: On 11/17/2014 10:26 PM, Greg KH wrote: On Mon, Nov 17, 2014 at 04:28:58PM +0530, Susant Sahani wrote: --- src/tty-ask-password-agent/tty-ask-password-agent.c | 2 +- 1 file changed, 1

Re: [systemd-devel] [PATCH 2/2] tty-ask-password-agent: fix CID 996261

2014-11-17 Thread Susant Sahani
On 11/17/2014 10:39 PM, Greg KH wrote: On Mon, Nov 17, 2014 at 10:36:53PM +0530, Susant Sahani wrote: On 11/17/2014 10:26 PM, Greg KH wrote: On Mon, Nov 17, 2014 at 04:28:58PM +0530, Susant Sahani wrote: --- src/tty-ask-password-agent/tty-ask-password-agent.c | 2 +- 1 file changed, 1

Re: [systemd-devel] [PATCH 2/2] tty-ask-password-agent: fix CID 996261

2014-11-17 Thread Susant Sahani
On 11/18/2014 12:06 AM, Greg KH wrote: On Mon, Nov 17, 2014 at 06:47:33PM +0100, Ronny Chevalier wrote: 2014-11-17 18:31 GMT+01:00 Greg KH gre...@linuxfoundation.org: On Mon, Nov 17, 2014 at 10:44:14PM +0530, Susant Sahani wrote: On 11/17/2014 10:39 PM, Greg KH wrote: On Mon, Nov 17, 2014

[systemd-devel] [PATCH 2/2] networkd: integrate LLDP

2014-11-22 Thread Susant Sahani
This patch integrates LLDP with networkd. Example conf: file : lldp.network [Match] Name=em1 [Network] LLDP=yes --- man/systemd.network.xml | 7 + src/network/networkd-link.c | 45 src/network/networkd-link.h | 2

[systemd-devel] [PATCH 1/2] networkd: Introduce Link Layer Discovery Protocol (LLDP)

2014-11-22 Thread Susant Sahani
@@ -0,0 +1,421 @@ +/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/ + +/*** + This file is part of systemd. + + Copyright (C) 2014 Tom Gundersen + Copyright (C) 2014 Susant Sahani + + systemd is free software; you can redistribute it and/or modify it + under the terms of the GNU Lesser

Re: [systemd-devel] [PATCH 1/2] networkd: Introduce Link Layer Discovery Protocol (LLDP)

2014-12-19 Thread Susant Sahani
, Susant Sahani sus...@redhat.com wrote: This patch introduces LLDP support to networkd. it implements the receiver side of the protocol. The Link Layer Discovery Protocol (LLDP) is an industry-standard, vendor-neutral method to allow networked devices to advertise capabilities, identity, and other

[systemd-devel] [PATCH] fix spell

2014-12-30 Thread Susant Sahani
--- man/sd_event_add_child.xml | 2 +- man/sd_event_add_signal.xml | 2 +- man/systemctl.xml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/man/sd_event_add_child.xml b/man/sd_event_add_child.xml index 9d943f8..7a84fce 100644 --- a/man/sd_event_add_child.xml +++

[systemd-devel] [PATCH] man: Fix spelling

2014-12-30 Thread Susant Sahani
--- man/sd_event_add_child.xml | 2 +- man/sd_event_add_signal.xml | 2 +- man/systemctl.xml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/man/sd_event_add_child.xml b/man/sd_event_add_child.xml index 9d943f8..7a84fce 100644 --- a/man/sd_event_add_child.xml +++

Re: [systemd-devel] [PATCH] fix spell

2014-12-30 Thread Susant Sahani
On Tue, 30 Dec 2014 21:12:51 +0530, Paul Menzel paulepan...@users.sourceforge.net wrote: man: Fix spelling Sure Thanks ! -- Susant ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

Re: [systemd-devel] [PATCH] man: Fix spelling

2014-12-30 Thread Susant Sahani
On Wed, 31 Dec 2014 02:35:00 +0530, Martin Pitt martin.p...@ubuntu.com wrote: Hey Susant, Hi Martin, Applied, thanks! Thanks ! Martin -- Susant ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

[systemd-devel] [PATCH] LLDP: Support locally assigned port subtype

2015-01-14 Thread Susant Sahani
The Zyxel switch sends port subtype as Locally assigned (7). Add LLDP_PORT_SUBTYPE_LOCALLY_ASSIGNED as supported type reported by Mantas Mikulėnas graw...@gmail.com --- src/libsystemd-network/lldp-internal.c | 1 + 1 file changed, 1 insertion(+) diff --git

[systemd-devel] [PATCH] journald: Introduce RFC 5424 syslog

2015-02-18 Thread Susant Sahani
-tabs-mode: nil -*-*/ + +/*** + This file is part of systemd. + + Copyright 2015 Susant Sahani + + systemd is free software; you can redistribute it and/or modify it + under the terms of the GNU Lesser General Public License as published by + the Free Software Foundation; either version 2.1

Re: [systemd-devel] [PATCH] journald: Introduce RFC 5424 syslog

2015-02-19 Thread Susant Sahani
On Thu, 19 Feb 2015 13:53:42 +0530, Umut Tezduyar Lindskog u...@tezduyar.com wrote: Hi Susant, Hi Umut, Thanks for reviewing. On Thu, Feb 19, 2015 at 8:58 AM, Susant Sahani sus...@redhat.com wrote: This patch adds support for RFC 5424 syslog format to journald. Journald can now

Re: [systemd-devel] [PATCH] journald: Introduce RFC 5424 syslog

2015-02-19 Thread Susant Sahani
Hi Lennart, On Thu, 19 Feb 2015 16:40:04 +0530, Lennart Poettering lenn...@poettering.net wrote: On Thu, 19.02.15 13:28, Susant Sahani (sus...@redhat.com) wrote: This patch adds support for RFC 5424 syslog format to journald. Journald can now forward logs to a multicast UDP group. RFC

Re: [systemd-devel] LLDP from Zyxel – Operation not supported

2015-01-12 Thread Susant Sahani
On Mon, 12 Jan 2015 13:23:40 +0530, Mantas Mikulėnas graw...@gmail.com wrote: I enabled LLDP receive for eth* in networkd. It recognizes outgoing packets sent by lldpd (on the computer itself) and by ladvd (on pfSense), but chokes on incoming packets sent by a Zyxel switch: LLDP: Receive

Re: [systemd-devel] [PATCH] journal: Introduce journal-network

2015-03-15 Thread Susant Sahani
Hi Zbigniew, Thanks for the review. On 03/16/2015 07:47 AM, Zbigniew Jędrzejewski-Szmek wrote: On Fri, Mar 13, 2015 at 10:55:42PM +0530, Susant Sahani wrote: This tiny daemon enables to pull journal entries and push to a UDP multicast address in syslog RFC 5424 format. journal

[systemd-devel] [PATCH] journal: Introduce journal-network

2015-03-13 Thread Susant Sahani
://www.oasis-open.org/docbook/xml/4.2/docbookx.dtd; + +!-- +This file is part of systemd. + +Copyright 2015 Susant Sahani + +systemd is free software; you can redistribute it and/or modify it +under the terms of the GNU Lesser General Public License as published by +the Free Software Foundation; either

[systemd-devel] [PATCH] networkd: Add support for bond option.

2015-03-09 Thread Susant Sahani
This patch adds configurational support for bond option. Test conf: bond.netdev --- [NetDev] Name=bond1 Kind=bond [Bond] ArpAllTargets=all PrimaryReselect=better ArpIntervalSec=10s ArpIpTargets= 192.168.8.102 192.168.8.101 192.168.8.102 --- $cat /proc/net/bonding/bond1 Ethernet Channel

[systemd-devel] [PATCH] networkd vxlan: Add support for enabling UDP checksums

2015-03-05 Thread Susant Sahani
Add UDPCheckSum option to enable transmitting UDP checksums when doing VXLAN/IPv4. Add UDP6ZeroChecksumRx, and UDP6ZeroChecksumTx options to enable sending zero checksums and receiving zero checksums in VXLAN/IPv6 V2: rename Udp to UDP --- man/systemd.netdev.xml | 20

Re: [systemd-devel] [PATCH] networkd vxlan: Add support for enabling UDP checksums

2015-03-05 Thread Susant Sahani
On Thu, 05 Mar 2015 16:51:37 +0530, Lennart Poettering lenn...@poettering.net wrote: On Thu, 05.03.15 14:05, Susant Sahani (sus...@redhat.com) wrote: Add UdpCheckSum option to enable transmitting UDP checksums when doing VXLAN/IPv4. Add Udp6ZeroChecksumRx, and Udp6ZeroChecksumTx options

Re: [systemd-devel] systemd-networkd and bonding config

2015-03-05 Thread Susant Sahani
On Thu, 05 Mar 2015 21:01:53 +0530, Michał Bartoszkiewicz mbartoszkiew...@gmail.com wrote: On Thu, Mar 5, 2015 at 3:47 PM, Tom Gundersen t...@jklm.no wrote: The kernel creates bond0 itself. This is confusing and we should probably request the kernel to stop doing that (patch needed). You

[systemd-devel] [PATCH] networkd vxlan: Add support for enabling UDP checksums

2015-03-05 Thread Susant Sahani
Add UdpCheckSum option to enable transmitting UDP checksums when doing VXLAN/IPv4. Add Udp6ZeroChecksumRx, and Udp6ZeroChecksumTx options to enable sending zero checksums and receiving zero checksums in VXLAN/IPv6 --- man/systemd.netdev.xml | 24 +++-

Re: [systemd-devel] [PATCH] journald: Introduce RFC 5424 syslog

2015-02-20 Thread Susant Sahani
On Fri, 20 Feb 2015 22:14:20 +0530, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Thu, Feb 19, 2015 at 12:10:04PM +0100, Lennart Poettering wrote: On Thu, 19.02.15 13:28, Susant Sahani (sus...@redhat.com) wrote: This patch adds support for RFC 5424 syslog format to journald

[systemd-devel] [PATCH] journal: Introduce journal-syslogd

2015-03-17 Thread Susant Sahani
Susant Sahani + + systemd is free software; you can redistribute it and/or modify it + under the terms of the GNU Lesser General Public License as published by + the Free Software Foundation; either version 2.1 of the License, or + (at your option) any later version. + + systemd is distributed

[systemd-devel] [PATCH] networkd man: fix man and config name.

2015-04-21 Thread Susant Sahani
Rename bond confs and man as well. --- man/systemd.netdev.xml | 28 src/network/networkd-netdev-gperf.gperf | 124 2 files changed, 76 insertions(+), 76 deletions(-) diff --git a/man/systemd.netdev.xml b/man/systemd.netdev.xml index

[systemd-devel] [PATCH] journal: Introduce journal-netlogd

2015-04-20 Thread Susant Sahani
..186178c --- /dev/null +++ b/man/journal-netlogd.conf.xml @@ -0,0 +1,115 @@ +?xml version='1.0'? !--*-nxml-*-- +!DOCTYPE refentry PUBLIC -//OASIS//DTD DocBook XML V4.2//EN + http://www.oasis-open.org/docbook/xml/4.2/docbookx.dtd; + +!-- + This file is part of systemd. + + Copyright 2015 Susant Sahani

  1   2   >