Re: [systemd-devel] [PATCH] networkd: Introduce ipip tunnel

2014-04-07 Thread Tom Gundersen
On Mon, Apr 7, 2014 at 6:35 AM, Susant Sahani sus...@redhat.com wrote: I have addressed all your comments. Cool. However I have some queries Please find below. Hm, we can probably reuse some of the existing address parsing functions don't you think? And we should also check the address

Re: [systemd-devel] [PATCH] networkd: Introduce ipip tunnel

2014-04-07 Thread Jóhann B. Guðmundsson
On 04/07/2014 04:35 AM, Susant Sahani wrote: This will be much nicer if we simply use ipip as the kind, rather than tunnel. Done ! Hmm... I think it got right the first place from a usability perspective as in kind=tunnel then we need to introduce mode= in the associated network file as

Re: [systemd-devel] [PATCH] networkd: Introduce ipip tunnel

2014-04-07 Thread Susant Sahani
On 04/07/2014 03:13 PM, Jóhann B. Guðmundsson wrote: On 04/07/2014 04:35 AM, Susant Sahani wrote: This will be much nicer if we simply use ipip as the kind, rather than tunnel. Done ! Hmm... I think it got right the first place from a usability perspective as in kind=tunnel then we need

Re: [systemd-devel] [PATCH] networkd: Introduce ipip tunnel

2014-04-07 Thread Jóhann B. Guðmundsson
On 04/07/2014 11:09 AM, Susant Sahani wrote: On 04/07/2014 03:13 PM, Jóhann B. Guðmundsson wrote: On 04/07/2014 04:35 AM, Susant Sahani wrote: This will be much nicer if we simply use ipip as the kind, rather than tunnel. Done ! Hmm... I think it got right the first place from a

Re: [systemd-devel] [PATCH] networkd: Introduce ipip tunnel

2014-04-06 Thread Susant Sahani
On 04/04/2014 10:00 PM, Tom Gundersen wrote: Hi Susant, Hi Tom, Thanks for reviewing . Thanks for this, looking forward getting this merged! I have some comments below though. I have addressed all your comments. However I have some queries Please find below. On Fri, Apr 4, 2014 at

Re: [systemd-devel] [PATCH] networkd: Introduce ipip tunnel

2014-04-06 Thread Susant Sahani
On 04/07/2014 10:05 AM, Susant Sahani wrote: On 04/04/2014 10:00 PM, Tom Gundersen wrote: Hi Susant, Hi Tom, + log_error_netdev(netdev, + Could not append IFLA_IPTUN_LINK attribute: %s, + strerror(-r)); +return

Re: [systemd-devel] [PATCH] networkd: Introduce ipip tunnel

2014-04-04 Thread Tom Gundersen
Hi Susant, Thanks for this, looking forward getting this merged! I have some comments below though. On Fri, Apr 4, 2014 at 11:25 AM, Susant Sahani sus...@redhat.com wrote: This patch enables basic ipip tunnel support. It works with kernel module ipip Example configuration File :