Re: Small fixes for if_oerrors in vlan(4), mpe(4) and pppx

2011-08-20 Thread Ryan McBride
committed, thanks! On Sat, Aug 20, 2011 at 02:46:30AM -0300, Christiano F. Haesbaert wrote: Hi, vlan_start() was increasing packet counts before checking if the packet was successfully enqueued. I made a hunt for similar errors. Index: net/if_mpe.c

Re: TOS option to tcpbench ala pf.conf

2011-08-20 Thread Christiano F. Haesbaert
On Fri, Aug 19, 2011 at 11:25:23PM +1000, Damien Miller wrote: Thanks, I like this. Could you add IPV6_TCLASS for IF_INET6 too? So here is the version with IPV6_TCLASS and -T instead of -t, since only traceroute uses -t, while ping and nc uses -T. I did some basic tests but my knowledge of

Re: ifconfig old wpapsk entry and cleanup.

2011-08-20 Thread Christiano F. Haesbaert
keeping this up. On Wed, Aug 17, 2011 at 12:42:02AM -0300, Christiano F. Haesbaert wrote: Hi Remove the old wpapsk cmd entry, remove unnecessary casts in malloc/calloc, use timerclear macro plus minor style(9): Index: ifconfig.c

Re: Fix tcpbench libevent segfault

2011-08-20 Thread Stuart Henderson
On 2011/08/20 03:37, Christiano F. Haesbaert wrote: Hi there, this fixes a segfault seen by sthen@ which I could only reproduce yesterday. I had fogotten to event_del() a persistent event. Ah yes that makes sense, and it fixes my problem. Thanks! OK to commit it? Index: tcpbench.c

Re: allow ospfd -v to set verbose logging in ospfe/rde

2011-08-20 Thread Stuart Henderson
On 2011/08/17 22:29, Claudio Jeker wrote: I don't like it and the diff is wrong -- the parent process will still not log verbose. I think the problem should be fixed at the source and change the way log_init() and log_verbose() work. Currently the second log_init() call in ospfd.c will

Re: allow ospfd -v to set verbose logging in ospfe/rde

2011-08-20 Thread Claudio Jeker
On Sat, Aug 20, 2011 at 10:32:54AM +0100, Stuart Henderson wrote: On 2011/08/20 10:07, Stuart Henderson wrote: On 2011/08/17 22:29, Claudio Jeker wrote: I don't like it and the diff is wrong -- the parent process will still not log verbose. I think the problem should be fixed at the

kill old stuff in pkg tools

2011-08-20 Thread Marc Espie
INSTALL and DEINSTALL were deprecated in June 2007, and removed from pkg_create in January 2010. I think it's time to remove all traces of +MTREE_DIRS, +REQ, +INSTALL, +DEINSTALL from all commands. Index: pkg_add.1 === RCS file:

Re: Fix tcpbench libevent segfault

2011-08-20 Thread Claudio Jeker
On Sat, Aug 20, 2011 at 09:14:30AM +0100, Stuart Henderson wrote: On 2011/08/20 03:37, Christiano F. Haesbaert wrote: Hi there, this fixes a segfault seen by sthen@ which I could only reproduce yesterday. I had fogotten to event_del() a persistent event. Ah yes that makes sense, and it

Re: allow ospfd -v to set verbose logging in ospfe/rde

2011-08-20 Thread Stuart Henderson
same diff for the other daemons which have log_verbose() and don't already handle this case:- bgpd dvmrpd ospf6d iscsid ldpd ripd. iscsid currently only supports increasing log level via iscsictl, so I've added the -v flag there (including usage/manual). I haven't looked at these yet, they don't