systrace: modify calloc() size argument

2014-11-16 Thread Nicolas Bedos
In the same vein as yesterday's diff for 'locate', I (well, Clang static analyzer and me) found in bin/systrace/alias.c that the variable 'reverse' is defined as a pointer to struct systrace_revalias but is initialized as follows reverse = calloc(1, sizeof(struct systrace_alias)); On amd64 :

Posix RealTime Extensions.

2014-11-16 Thread David Carlier
Hi all, sorry I m far to be an OpenBSD expert but I was wondering why it lacks some functions like sigqueue and such ... Is there any plan to add them in the future and if not what is the reasoning behind it ? Thanks in advance.

siphash for ffs inode hash

2014-11-16 Thread David Gwynne
im in two minds about this. on the one hand, its not like this can be attacked remotely. on the other hand, maybe someone would create a metric buttload of files and open all the ones with inodes whose values are 4096 apart. discussion? tests? ok? part of me thinks we shoudl apply siphash to

ressl blocking semantics

2014-11-16 Thread Dirk Engling
dear ressl fellows, when trying to properly reimplement a curses client (i.e. handling stdin with select) with a tls connection using ressl (i.e. handling a server socket with select), I stumbled upon conflicting recommendations in man pages regarding whether to use blocking sockets in BIOs. The

Re: siphash for ffs inode hash

2014-11-16 Thread Theo de Raadt
part of me thinks we shoudl apply siphash to all the kernel hashes as a matter of course rather than waste the effort trying to figure out if they are attackable or not. Almost replied to tell you that, then I finished reading your email. :) i agree also.

patch: check patch file size

2014-11-16 Thread Tobias Stoeckmann
Hi, p_filesize is of type long, but we assign an off_t. Before assignment, check if it will fit. Also, check if fstat was successful or not. Tobias Index: pch.c === RCS file: /cvs/src/usr.bin/patch/pch.c,v retrieving revision

Re: patch: check patch file size

2014-11-16 Thread Alexander Bluhm
On Sun, Nov 16, 2014 at 09:23:49PM +0100, Tobias Stoeckmann wrote: p_filesize is of type long, but we assign an off_t. Before assignment, check if it will fit. Can we change p_filesize type to off_t instead? bluhm

Re: patch: check patch file size

2014-11-16 Thread Tobias Stoeckmann
On Sun, Nov 16, 2014 at 09:39:32PM +0100, Alexander Bluhm wrote: Can we change p_filesize type to off_t instead? Definitely, but it takes closer looks for a review. Diff exists, I was just not sure if it's worth to support patch files which are larger than 2 GB on 32 bit systems. Tobias

Re: Posix RealTime Extensions.

2014-11-16 Thread Philip Guenther
On Sun, Nov 16, 2014 at 1:25 AM, David Carlier dcarl...@afilias.info wrote: sorry I m far to be an OpenBSD expert but I was wondering why it lacks some functions like sigqueue and such ... Is there any plan to add them in the future and if not what is the reasoning behind it ? It lacks them

Re: systrace: modify calloc() size argument

2014-11-16 Thread Philip Guenther
On Sun, Nov 16, 2014 at 4:13 AM, Nicolas Bedos nicolas.be...@gmail.com wrote: In the same vein as yesterday's diff for 'locate', I (well, Clang static analyzer and me) found in bin/systrace/alias.c that the variable 'reverse' is defined as a pointer to struct systrace_revalias but is

siphash for ufs disk quota hash

2014-11-16 Thread David Gwynne
can someone test this? and eyeball the use of a pointer as data to get mixed into the hash? Index: ufs_quota.c === RCS file: /cvs/src/sys/ufs/ufs/ufs_quota.c,v retrieving revision 1.35 diff -u -p -r1.35 ufs_quota.c --- ufs_quota.c 13

ufs_ihash.c double handles LIST entry invalidation

2014-11-16 Thread David Gwynne
src/sys/queue.h invalidates pointers in lists if DIAGNOSTIC is enabled, so ufs_ihash.c doesnt have to. ok? Index: ufs_ihash.c === RCS file: /cvs/src/sys/ufs/ufs/ufs_ihash.c,v retrieving revision 1.20 diff -u -p -r1.20 ufs_ihash.c