Re: iwm: fix handling of large firmware commands

2015-10-15 Thread Stefan Sperling
Any objections to putting this in soon? Any OKs? I'd like to move forward with iwm(4) (less fixing bugs, more adding new features...) On Sun, Oct 11, 2015 at 04:55:29PM +0200, Stefan Sperling wrote: > The iwm(4) driver pre-allocates fw command payload buffers of 320 bytes. > > For some firmware

nlist(3): out of boundary access

2015-10-15 Thread Tobias Stoeckmann
The library function nlist(3) does not properly validate parsed ELF binary files, which can lead to out of boundary accesses. Also, nlist will return -1 for stripped binary files, because eventually it will try to mmap 0 bytes. Instead of returning the amount of symbols we tried to look up, -1

Oct 15 OpenBSD errata and LibreSSL releases

2015-10-15 Thread Ted Unangst
The OBJ_obj2txt function in libcrypto contains a one byte buffer overrun and memory leak, as reported by Qualys Security. This can be abused by an attacker to cause a denial of service in some cases. Patches are now available for OpenBSD as well as new releases of LibreSSL portable. 5.6, 5.7, and

Re: nsd 4.1.6rc1

2015-10-15 Thread Ted Unangst
Stuart Henderson wrote: > It does not build as-is, there's an issue with "c_get_text" (a renamed > yyget_text) with our version of flex. I have two possible workarounds > so far but neither is particularly nice; > > - add a configlexer.c file generated with newer flex to the tree (e.g. > the one

Re: Another lock(1) pledge tweak

2015-10-15 Thread trondd
Whoops. I meant lock(1) in the subject. I guess making a patch put the word patch into my head. On Thu, October 15, 2015 9:25 pm, trondd wrote: > Is it safer to drop the recently added proc and exec pledges if the > arguments are not chosen which need them? > > Index: lock.c >

Another patch(1) pledge tweak

2015-10-15 Thread trondd
Is it safer to drop the recently added proc and exec pledges if the arguments are not chosen which need them? Index: lock.c === RCS file: /cvs/src/usr.bin/lock/lock.c,v retrieving revision 1.32 diff -u -p -r1.32 lock.c --- lock.c

remove unused variables in netcat.c

2015-10-15 Thread Rob Pierce
It looks like the subject and issuer variables are no longer used in report_tls() since the recent libtls api change. Also a few whitespace mods. Regards, Index: netcat.c === RCS file: /cvs/src/usr.bin/nc/netcat.c,v retrieving

Re: ctags.1: stop misusing Nm

2015-10-15 Thread Ingo Schwarze
Hi Michael, Michael Reed wrote on Wed, Oct 14, 2015 at 04:18:04PM -0400: > If the author wanted to emphasize these terms then they should have > used Sy or Em, but I wasn't convinced that the terms below > needed emphasis so I just removed the Nm usage altogether. Committed, thanks. Ingo >

Re: nsd 4.1.6rc1

2015-10-15 Thread Todd C. Miller
On Thu, 15 Oct 2015 22:22:17 -0400, "Ted Unangst" wrote: > Secondary question: what's involved in updating lex? I didn't realize we had > fallen behind as it were, but should we switch too? At one point it required GNU m4'isms we didn't support (the -P flag). We've had that for some time so I

cast struct sockaddr_dl

2015-10-15 Thread Alexander Bluhm
Hi, Inspired by the satosin() functions, I think it is better to have inline functions than casts to convert between sockaddrs. They check if the incoming object has the expected type. So introduce satosdl() and sdltosa() to the kernel. ok? bluhm Index: net/if.c

Re: nlist(3): out of boundary access

2015-10-15 Thread Tobias Stoeckmann
On Thu, Oct 15, 2015 at 11:28:07AM -0600, Todd C. Miller wrote: > Those checks all look good. The only thing I had a question > about is the: > > len = strlen(sym); > > Would it be better to use memchr to search for the NUL terminator > to avoid going past the end? E.g. > > if

two bge(4) bugfixes

2015-10-15 Thread Miod Vallat
The following diff attempts to fix two small bge(4) bugs: - the first chunk fixes what seems to be a logic error on BCM 5720, where the code attemps to preserve the state of four bits, but these have actually already been set in the local variable by the call to bge_dma_swap_options()

Re: nlist(3): out of boundary access

2015-10-15 Thread Todd C. Miller
Those checks all look good. The only thing I had a question about is the: len = strlen(sym); Would it be better to use memchr to search for the NUL terminator to avoid going past the end? E.g. if (memchr(sym, 0, left) == NULL) continue; - todd

Re: typo in OPENBSD-RELAYD-MIB.txt

2015-10-15 Thread Stuart Henderson
On 2015/10/14 09:53, Rob Pierce wrote: > > How is this? I played with the DESCRIPTION so it would all fit on one > line and match the current style, etc. > > Thanks! Thanks Rob, I've committed this.