Re: [patch] kern/exec_script: avoid invalid free() in a case of error

> On Sun, Dec 13, 2015 at 9:45 PM, Maxim Pugachev wrote: > > Hi, > > > > In exec_script_makecmds function, when EXEC_HASFD flag was set, but > > copystr/copyinstr returns an error, we need to set *tmpsap to NULL to > > terminate a loop (under "fail" label) correctly. I

Re: [patch] kern/exec_script: avoid invalid free() in a case of error

Michael McConville wrote: > > On Sun, Dec 13, 2015 at 9:45 PM, Maxim Pugachev > > wrote: > > > Hi, > > > > > > In exec_script_makecmds function, when EXEC_HASFD flag was set, but > > > copystr/copyinstr returns an error, we need to set *tmpsap to NULL to > > > terminate a

Re: Fix size hints for x11-ssh-askpass

On Mon, Dec 28, 2015 at 08:10:49AM +0100, Matthieu Herrb wrote: > On Sun, Dec 27, 2015 at 08:28:36PM +0100, Alexander Hall wrote: > > Hi, > > > > Recently, my window manager (i3) started making the ssh-askpass windows > > too small to be really usable. The problem seems to be that the size > >

mpsafe tx for re(4)

this builds on jmatthew@'s last commit and adds mpsafe tx. ive beat on it pretty hard, but more eyes/tests are appreciated. ok? Index: re.c === RCS file: /cvs/src/sys/dev/ic/re.c,v retrieving revision 1.188 diff -u -p -r1.188 re.c

Re: Fix size hints for x11-ssh-askpass

On Mon, Dec 28, 2015 at 11:42:00AM +0100, Alexander Hall wrote: > On Mon, Dec 28, 2015 at 08:10:49AM +0100, Matthieu Herrb wrote: > > On Sun, Dec 27, 2015 at 08:28:36PM +0100, Alexander Hall wrote: > > > Hi, > > > > > > Recently, my window manager (i3) started making the ssh-askpass windows > >

Re: bugs in printf(3)

On Fri, 25 Dec 2015 00:30:29 +0100, Ingo Schwarze wrote: > Besides, i don't see the point in messing with FILE flags at all > in case of encoding errors. As opposed to fgetwc(3) and fputwc(3), > the manual doesn't document this fiddling, and POSIX doesn't ask > for it. No other conversions in

Re: bug in fputwc(3) error reporting

OK millert@. I believe there are also instances of the same problem in the non-wide code. In fact, we don't even document that the error indicator is set in putc(3)! Someone else may wish to tackle that one :-) - todd

Re: [st...@openbsd.org: vlc, ld.so sigsegv/sigbus: _dl_cache_grpsym_list]

On 2015/12/27 20:36, Philip Guenther wrote: > On Sun, Dec 27, 2015 at 9:13 AM, Stuart Henderson wrote: > > Widening the audience to tech in case anyone with an idea missed it > > on ports: it seems some people are having a lot more trouble than just > > needing to restart build

mpsafe tx for bge(4)

this tweaks the bge tx code and marks it mpsafe. ok? Index: if_bge.c === RCS file: /cvs/src/sys/dev/pci/if_bge.c,v retrieving revision 1.380 diff -u -p -r1.380 if_bge.c --- if_bge.c29 Nov 2015 20:19:35 - 1.380 +++

Re: [PATCH] vi remove custom perr from cl_main

End there's also this monstrosity that removes localization support from vi, in contrast to nvi2, which switched from custom db2 functions to catgets(3): http://marc.info/?l=openbsd-tech=144908525123080=2 On 12/28/15 20:37, Michael McConville wrote: Todd C. Miller wrote: On Sun, 27 Dec 2015

Re: [PATCH] vi remove custom perr from cl_main

On Sun, 27 Dec 2015 10:12:23 +0100, Martijn van Duren wrote: > This patch has been accepted by the nvi2 project.[1] > There are more patches, but I'm waiting till these have been reviewed by > nvi2. Committed, thanks. - todd

Re: Circular queues are gone

On Sun, 27 Dec 2015 02:05:53 -0800, Chris Hettrick wrote: > Circular queues are gone, so remove remaining references to them. Thanks. I've committed this and added a short bit about XOR simple queues. Those are currently not documented (hint hint tedu@). - todd

Re: [PATCH] vi remove custom perr from cl_main

Todd C. Miller wrote: > On Sun, 27 Dec 2015 10:12:23 +0100, Martijn van Duren wrote: > > > This patch has been accepted by the nvi2 project.[1] There are more > > patches, but I'm waiting till these have been reviewed by nvi2. > > Committed, thanks. Thanks for taking care of this. There's a

ferror in ntpd (Re: bugs in printf(3))

Todd C. Miller(todd.mil...@courtesan.com) on 2015.12.28 10:46:08 -0700: > On Fri, 25 Dec 2015 00:30:29 +0100, Ingo Schwarze wrote: > > > Besides, i don't see the point in messing with FILE flags at all > > in case of encoding errors. As opposed to fgetwc(3) and fputwc(3), > > the manual doesn't

Re: [patch] nlist(3): out of bounds read

Serguey Parkhomovsky wrote: > Ping? This is the same sanity check that's done in nm(1)'s ELF handling. Make sense to me. Tentative ok mmcc@ Alternatively, this check could be added to __elf_is_ok__, which is called right above where you added it. However, the definition of the function would

Re: [patch] nlist(3): out of bounds read

Michael McConville wrote: > Serguey Parkhomovsky wrote: > > Ping? This is the same sanity check that's done in nm(1)'s ELF handling. > > Make sense to me. Tentative ok mmcc@ > > Alternatively, this check could be added to __elf_is_ok__, which is > called right above where you added it. However,

Re: Fix support for early SATA drives on ahci(4)

On Tue, Dec 29, 2015 at 12:43:43AM +0100, Mark Kettenis wrote: > I have an old Maxtor 7Y250M0 SATA drive that didn't quite work when > attached to an Intel AHCI controller. The drive was properly > detected, but any attempt to read from the drive failed. It worked > fine if I switched the SATA

Fix support for early SATA drives on ahci(4)

I have an old Maxtor 7Y250M0 SATA drive that didn't quite work when attached to an Intel AHCI controller. The drive was properly detected, but any attempt to read from the drive failed. It worked fine if I switched the SATA controller into IDE mode in the BIOS, so the drive was fine. Turns out

Re: ksh.1: Remove $ERRNO reference

Michael Reed wrote: > It's had the ``Not implemented'' notice since ksh.1's initial import > 19 years ago [1], so it's probably not going to be implemented. > > [1]: > http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/bin/ksh/ksh.1?rev=1.1=text/x-cvsweb-markup Committed. Thanks! bin/ksh/NOTES